[net-next] net: iavf: Use the ARRAY_SIZE macro for aq_to_posix

2020-09-09 Thread Wei Xu
Use the ARRAY_SIZE macro to calculate the size of an array. This code was detected with the help of Coccinelle. Signed-off-by: Wei Xu --- drivers/net/ethernet/intel/iavf/iavf_adminq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf

[net-next] net: i40e: Use the ARRAY_SIZE macro for aq_to_posix

2020-09-09 Thread Wei Xu
Use the ARRAY_SIZE macro to calculate the size of an array. This code was detected with the help of Coccinelle. Signed-off-by: Wei Xu --- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e

[net-next] net: smsc911x: Remove unused variables

2020-09-07 Thread Wei Xu
‘smsc911x_eeprom_write_location’: drivers/net/ethernet/smsc/smsc911x.c:2058:6: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable] Signed-off-by: Wei Xu --- drivers/net/ethernet/smsc/smsc911x.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH] net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

2020-09-03 Thread Wei Xu
Hi All, Sorry for the noise and please ignore it! I found a nearly same patch has been sent out 2 days before. Best Regards, Wei On 2020/9/3 19:45, Wei Xu wrote: > Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params > is invoked in a spinlock context. > This

[PATCH] net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

2020-09-03 Thread Wei Xu
Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params is invoked in a spinlock context. This code was detected with the help of Coccinelle. Signed-off-by: Wei Xu --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [RFC V4 PATCH 7/8] vhost: packed ring support

2018-05-23 Thread Wei Xu
On Wed, May 23, 2018 at 09:39:28AM +0800, Jason Wang wrote: > > > On 2018年05月23日 00:54, Wei Xu wrote: > >On Wed, May 16, 2018 at 08:32:20PM +0800, Jason Wang wrote: > >>Signed-off-by: Jason Wang > >>--- > >> drivers/vhost/net.c

Re: [RFC V4 PATCH 7/8] vhost: packed ring support

2018-05-22 Thread Wei Xu
On Wed, May 16, 2018 at 08:32:20PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 3 +- > drivers/vhost/vhost.c | 539 > ++ > drivers/vhost/vhost.h | 8 +- > 3 files changed, 513 insertions(+), 37 deletions

Re: [RFC V4 PATCH 0/8] Packed ring layout for vhost

2018-05-21 Thread Wei Xu
On Mon, May 21, 2018 at 10:33:30AM +0800, Jason Wang wrote: > > > On 2018年05月21日 00:25, Wei Xu wrote: > >On Wed, May 16, 2018 at 08:32:13PM +0800, Jason Wang wrote: > >>Hi all: > >> > >>This RFC implement packed ring layout. The code were tested with

Re: [RFC V4 PATCH 0/8] Packed ring layout for vhost

2018-05-20 Thread Wei Xu
On Wed, May 16, 2018 at 08:32:13PM +0800, Jason Wang wrote: > Hi all: > > This RFC implement packed ring layout. The code were tested with > Tiwei's RFC V3 ahttps://lkml.org/lkml/2018/4/25/34. Some fixups and > tweaks were needed on top of Tiwei's code to make it run for event > index. Could you

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

2017-11-30 Thread Wei Xu
On Thu, Nov 30, 2017 at 10:46:17AM +0800, Jason Wang wrote: > > > On 2017年11月29日 23:31, Michael S. Tsirkin wrote: > > On Wed, Nov 29, 2017 at 09:23:24AM -0500,w...@redhat.com wrote: > > > From: Wei Xu > > > > > > Matthew found a roughly 40% tcp throug

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

2017-11-29 Thread Wei Xu
On Wed, Nov 29, 2017 at 10:43:33PM +0800, Jason Wang wrote: > > > On 2017年11月29日 22:23, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing from skb array)

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Tue, Nov 28, 2017 at 07:53:33PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 28, 2017 at 12:17:16PM -0500, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing f

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Tue, Nov 28, 2017 at 07:50:58PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 28, 2017 at 12:17:16PM -0500, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing f

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Wed, Nov 29, 2017 at 01:06:28PM +0800, Jason Wang wrote: > > > On 2017年11月29日 09:53, Jason Wang wrote: > > > > > > On 2017å¹´11月29æ—¥ 01:17, w...@redhat.com wrote: > > > From: Wei Xu > > > > > > Matthew found a roughly 40% tcp thro

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-28 Thread Wei Xu
On Mon, Nov 27, 2017 at 09:44:07PM -0500, Matthew Rosato wrote: > On 11/27/2017 08:36 PM, Jason Wang wrote: > > > > > > On 2017年11月28日 00:21, Wei Xu wrote: > >> On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: > >>> On 11/14/2017 03:11

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-27 Thread Wei Xu
On Tue, Nov 28, 2017 at 09:36:37AM +0800, Jason Wang wrote: > > > On 2017年11月28日 00:21, Wei Xu wrote: > > On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: > > > On 11/14/2017 03:11 PM, Matthew Rosato wrote: > > > > On 11/12/2017 01:34 PM, We

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-27 Thread Wei Xu
On Mon, Nov 20, 2017 at 02:25:17PM -0500, Matthew Rosato wrote: > On 11/14/2017 03:11 PM, Matthew Rosato wrote: > > On 11/12/2017 01:34 PM, Wei Xu wrote: > >> On Sat, Nov 11, 2017 at 03:59:54PM -0500, Matthew Rosato wrote: > >>>>> This case should be q

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-12 Thread Wei Xu
On Sat, Nov 11, 2017 at 03:59:54PM -0500, Matthew Rosato wrote: > >> This case should be quite similar with pkgten, if you got improvement with > >> pktgen, usually it was also the same for UDP, could you please try to > >> disable > >> tso, gso, gro, ufo on all host tap devices and guest virtio-n

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-12 Thread Wei Xu
On Tue, Nov 07, 2017 at 08:02:48PM -0500, Matthew Rosato wrote: > On 11/04/2017 07:35 PM, Wei Xu wrote: > > On Fri, Nov 03, 2017 at 12:30:12AM -0400, Matthew Rosato wrote: > >> On 10/31/2017 03:07 AM, Wei Xu wrote: > >>> On Thu, Oct 26, 2017 at 01:53:12

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-04 Thread Wei Xu
On Fri, Nov 03, 2017 at 12:30:12AM -0400, Matthew Rosato wrote: > On 10/31/2017 03:07 AM, Wei Xu wrote: > > On Thu, Oct 26, 2017 at 01:53:12PM -0400, Matthew Rosato wrote: > >> > >>> > >>> Are you using the same binding as mentioned in previous mail sent

Re: Regression in throughput between kvm guests over virtual bridge

2017-10-30 Thread Wei Xu
On Thu, Oct 26, 2017 at 01:53:12PM -0400, Matthew Rosato wrote: > > > > > Are you using the same binding as mentioned in previous mail sent by you? it > > might be caused by cpu convention between pktgen and vhost, could you please > > try to run pktgen from another idle cpu by adjusting the bind

Re: Regression in throughput between kvm guests over virtual bridge

2017-10-26 Thread Wei Xu
On Wed, Oct 25, 2017 at 04:21:26PM -0400, Matthew Rosato wrote: > On 10/22/2017 10:06 PM, Jason Wang wrote: > > > > > > On 2017年10月19日 04:17, Matthew Rosato wrote: > >>> 2. It might be useful to short the traffic path as a reference, What > >>> I am running > >>> is briefly like: > >>> pktge

Re: Regression in throughput between kvm guests over virtual bridge

2017-10-23 Thread Wei Xu
On Wed, Oct 18, 2017 at 04:17:51PM -0400, Matthew Rosato wrote: > On 10/12/2017 02:31 PM, Wei Xu wrote: > > On Thu, Oct 05, 2017 at 04:07:45PM -0400, Matthew Rosato wrote: > >> > >> Ping... Jason, any other ideas or suggestions? > > > > Hi Matthew, > >

Re: Regression in throughput between kvm guests over virtual bridge

2017-10-12 Thread Wei Xu
On Thu, Oct 05, 2017 at 04:07:45PM -0400, Matthew Rosato wrote: > > Ping... Jason, any other ideas or suggestions? Hi Matthew, Recently I am doing similar test on x86 for this patch, here are some, differences between our testbeds. 1. It is nice you have got improvement with 50+ instances(or co

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-13 Thread Wei Xu
On 2016年12月14日 03:44, Theodore Ts'o wrote: Jason's patch fixed the issue, so I think we have the proper fix, but to answer your questions: On Wed, Dec 14, 2016 at 01:46:44AM +0800, Wei Xu wrote: Q1: Which distribution are you using for the GCE instance? The test appliance is based

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

2016-12-13 Thread Wei Xu
On 2016年12月13日 07:33, Theodore Ts'o wrote: Hi, I was doing a last minute regression test of the ext4 tree before sending a pull request to Linus, which I do using gce-xfstests[1], and I found that using networking was broken on GCE on linux-next. I was using next-20161209, and after bisecting

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

2015-10-08 Thread Wei Xu
On 10/8/2015 10:18 AM, Jiri Pirko wrote: > Thu, Oct 08, 2015 at 11:04:48AM CEST, l...@intel.com wrote: >> Hi Vivien, >> >> [auto build test ERROR on net-next/master -- if it's inappropriate base, >> please ignore] >> >> config: arm64-allyesconfig (attached as .config) >> reproduce: >>wge