On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote:
Thanks a lot!
Could you retest Xuan Zhuo original patch
Which one? I thought Darren already did so?
-Siwei
just to make sure it does
not fix the issue?
On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
For the record, I got a c
6. If net.core.high_order_alloc_disable=0, only
the first buffer of the frag is affected.
Fixes: f9dac92ba908 ("virtio_ring: enable premapped mode whatever use_dma_api")
Reported-by: "Si-Wei Liu"
Closes:
http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com
Signed-off-by: X
On 8/20/2024 1:09 PM, Michael S. Tsirkin wrote:
On Tue, Aug 20, 2024 at 12:44:46PM -0700, Si-Wei Liu wrote:
On 8/20/2024 12:19 AM, Xuan Zhuo wrote:
leads to regression on VM with the sysctl value of:
- net.core.high_order_alloc_disable=1
which could see reliable crashes or scp failure
net.core.high_order_alloc_disable=1, the maximum
buffer size is 4096 - 16. If net.core.high_order_alloc_disable=0, only
the first buffer of the frag is affected.
Fixes: f9dac92ba908 ("virtio_ring: enable premapped mode whatever use_dma_api")
Reported-by: "Si-Wei Liu"
Closes:
http://lore.ker
Hi,
May I know if this is really an intended fix to post officially, or just
a workaround/probe to make the offset in page_frag happy when
net_high_order_alloc_disable is true? In case it's the former, even
though this could fix the issue, I would assume clamping to a smaller
page_frag than a
Hi Michael,
I'll look for someone else from Oracle to help you on this, as the
relevant team already did verify internally that reverting all 4 patches
from this series could help address the regression. Just reverting one
single commit won't help.
9719f039d328 virtio_net: remove the misle
Turning out this below commit to unconditionally enable premapped
virtio-net:
commit f9dac92ba9081062a6477ee015bd3b8c5914efc4
Author: Xuan Zhuo
Date: Sat May 11 11:14:01 2024 +0800
leads to regression on VM with no ACCESS_PLATFORM, and with the sysctl
value of:
- net.core.high_order_al
On Wed, Apr 07, 2021 at 02:34:01PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Wei Liu
> > Sent: Wednesday, April 7, 2021 9:17 AM
> > To: Dexuan Cui
> > Cc: da...@davemloft.net; k...@kernel.org; KY Srinivasan
> > ; H
On Tue, Apr 06, 2021 at 04:23:21PM -0700, Dexuan Cui wrote:
[...]
> +config MICROSOFT_MANA
> + tristate "Microsoft Azure Network Adapter (MANA) support"
> + default m
> + depends on PCI_MSI
> + select PCI_HYPERV
OOI which part of the code requires PCI_HYPERV?
Asking because I can'
On Wed, Apr 07, 2021 at 08:08:59AM +, Dexuan Cui wrote:
> > From: kernel test robot
> > Sent: Tuesday, April 6, 2021 6:31 PM
> > ...
> > Hi Dexuan,
> > I love your patch! Perhaps something to improve:
> >
> > All warnings (new ones prefixed by >>):
> >
> >drivers/pci/controller/pci-hype
> Signed-off-by: Thomas Gleixner
Acked-by: Wei Liu
On 2/28/2021 1:27 PM, Michael S. Tsirkin wrote:
On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote:
Hi Michael,
Are you okay to live without this ioctl for now? I think QEMU is the one
that needs to be fixed and will have to be made legacy guest aware. I think
the kernel can just
;s fine, I would proceed to reverting commit fe36cbe067 and related
code in question from the kernel.
Thanks,
-Siwei
On 2/24/2021 10:24 AM, Si-Wei Liu wrote:
Detecting it isn't enough though, we will need a new ioctl to notify
the kernel that it's a legacy guest. Ugh :(
Well, althou
On 2/23/2021 9:04 PM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 11:35:57AM -0800, Si-Wei Liu wrote:
On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote:
On 2021/2/23 9:12 上午, Si-Wei Liu wrote:
On 2/21/2021 11:34 PM, Michael S
On 2/23/2021 5:26 AM, Michael S. Tsirkin wrote:
On Tue, Feb 23, 2021 at 10:03:57AM +0800, Jason Wang wrote:
On 2021/2/23 9:12 上午, Si-Wei Liu wrote:
On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote:
On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei
On 2/21/2021 11:34 PM, Michael S. Tsirkin wrote:
On Mon, Feb 22, 2021 at 12:14:17PM +0800, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
for legacy") made an exception for legacy guests to reset
features
On 2/21/2021 8:14 PM, Jason Wang wrote:
On 2021/2/19 7:54 下午, Si-Wei Liu wrote:
Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
for legacy") made an exception for legacy guests to reset
features to 0, when config space is accessed before features
are set. We should r
On 2/19/2021 6:38 PM, Jason Wang wrote:
Right now the value is exposed to userspace via GET_VRING_BASE, so
only last_avail_idx is synced. If we need sync last_used_idx, we
should also sync pending indices which requires more thoughts.
Technically it doesn't sound right - crossing the bound
On 2/17/2021 11:42 AM, Si-Wei Liu wrote:
On 2/16/2021 8:20 AM, Eli Cohen wrote:
When we suspend the VM, the VDPA interface will be reset. When the VM is
resumed again, clear_virtqueues() will clear the available and used
indices resulting in hardware virqtqueue objects becoming out of sync
On 2/18/2021 7:10 PM, Jason Wang wrote:
On 2021/2/18 8:43 下午, Si-Wei Liu wrote:
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote
o 0
prematurely causes correct MTU and link status unable to load
for the very first config space access, rendering issues like
guest showing inaccurate MTU value, or failure to reject
out-of-range MTU.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by:
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800
On 2/16/2021 7:21 AM, Eli Cohen wrote:
On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote:
On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from d
On 2/17/2021 1:20 PM, Michael S. Tsirkin wrote:
On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote:
On 2/16/2021 8:20 AM, Eli Cohen wrote:
When we suspend the VM, the VDPA interface will be reset. When the VM is
resumed again, clear_virtqueues() will clear the available and used
set_vq_state(). In get_vq_state() we return the value of hardware
used index.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Eli Cohen
Acked-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 -
1 file changed, 4 inserti
On 2/10/2021 7:45 AM, Eli Cohen wrote:
On Wed, Feb 10, 2021 at 12:59:03AM -0800, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20
On Fri, Feb 12, 2021 at 05:50:50PM +0100, Andrea Parri wrote:
> Hi all,
[...]
> 2) IIUC a8c3209998afb5 could be dropped (after rebase) without further modi-
>fications to hyperv-next.
I've reverted the said patch from hyperv-next.
Wei.
e a event being spurious if no rx OR no tx requests are
> pending.
>
> Fix that plus using local variables for rx/tx pending indicators in
> order to split function calls and if condition.
>
> Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding")
> Signed-off-by: Juergen Gross
Reviewed-by: Wei Liu
e Ethernet header up to the FCS altogether.
Fix the MTU so packets won't get dropped silently.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Si-Wei Liu
Acked-by: Jason Wang
Acked-by: Eli Cohen
---
drivers/vdpa/mlx5/core/mlx5_vdpa.
to be started,
i.e. until VIRTIO_CONFIG_S_DRIVER_OK is set again in
set_status().
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change
map")
Signed-off-by: Si-Wei Liu
Acked-by: Jason Wang
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion
--
v1->v2: move feature capability query to probing (Eli)
Si-Wei Liu (3):
vdpa/mlx5: should exclude header length and fcs from mtu
vdpa/mlx5: fix feature negotiation across device reset
vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 4
driv
wire.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 25 +++--
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/driver
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/9 下午2:12, Eli Cohen wrote:
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote:
On 2021/2/8 下午6:04, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 05:04
, 2021 at 12:27:18PM +0800, Jason Wang wrote:
On 2021/2/6 上午7:07, Si-Wei Liu wrote:
On 2/3/2021 11:36 PM, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are
destroyed
and then re-created again with the new memory map. In such
case, we need
to restore the hardware
On 2/8/2021 7:37 PM, Jason Wang wrote:
On 2021/2/6 下午8:29, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restate the virtq once device is st
aces to take the pointer to the xenbus device as a
> parameter instead of the domain id of the other side.
>
> While at it remove the stale prototype of bind_evtchn_to_irq_lateeoi().
>
> Signed-off-by: Juergen Gross
Reviewed-by: Wei Liu
On 2/7/2021 9:48 PM, Eli Cohen wrote:
On Sat, Feb 06, 2021 at 04:29:24AM -0800, Si-Wei Liu wrote:
While virtq is stopped, get_vq_state() is supposed to
be called to get sync'ed with the latest internal
avail_index from device. The saved avail_index is used
to restate the virtq
On 2/7/2021 9:35 PM, Eli Cohen wrote:
On Sat, Feb 06, 2021 at 04:29:23AM -0800, Si-Wei Liu wrote:
The mlx_features denotes the capability for which
set of virtio features is supported by device. In
principle, this field needs not be cleared during
virtio device reset, as this capability is
e Ethernet header up to the FCS altogether.
Fix the MTU so packets won't get dropped silently.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/core/mlx5_vdpa.h | 4
drivers/vdpa/mlx5/net/mlx5_vnet.c | 15 ++-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git
wire.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index b8416c4..aa6f8cd 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_v
to be started,
i.e. until VIRTIO_CONFIG_S_DRIVER_OK is set again in
set_status().
Fixes: b35ccebe3ef7 ("vdpa/mlx5: Restore the hardware used index after change
map")
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
On 2/3/2021 11:36 PM, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are destroyed
and then re-created again with the new memory map. In such case, we need
to restore the hardware available and used indices. The driver failed to
restore the used index which is adde
On Tue, Feb 2, 2021 at 9:16 PM Jason Wang wrote:
>
>
> On 2021/2/3 上午1:54, Si-Wei Liu wrote:
> > On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote:
> >> On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote:
> >>> Thanks Eli and Jason for clarifications. S
On Tue, Feb 2, 2021 at 10:48 PM Eli Cohen wrote:
>
> On Tue, Feb 02, 2021 at 09:14:02AM -0800, Si-Wei Liu wrote:
> > On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote:
> > >
> > > When a change of memory map occurs, the hardware resources are destroyed
> > >
On Tue, Feb 2, 2021 at 1:23 AM Eli Cohen wrote:
>
> On Tue, Feb 02, 2021 at 12:38:51AM -0800, Si-Wei Liu wrote:
> > Thanks Eli and Jason for clarifications. See inline.
> >
> > On Mon, Feb 1, 2021 at 11:06 PM Eli Cohen wrote:
> > >
> > > On Tue, Feb 02,
On Tue, Feb 2, 2021 at 6:34 AM Eli Cohen wrote:
>
> When a change of memory map occurs, the hardware resources are destroyed
> and then re-created again with the new memory map. In such case, we need
> to restore the hardware available and used indices. The driver failed to
> restore the used inde
> associated queue held.
>
> Reported-by: Igor Druzhinin
> Fixes: 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Juergen Gross
Acked-by: Wei Liu
Thanks Eli and Jason for clarifications. See inline.
On Mon, Feb 1, 2021 at 11:06 PM Eli Cohen wrote:
>
> On Tue, Feb 02, 2021 at 02:02:25PM +0800, Jason Wang wrote:
> >
> > On 2021/2/2 下午12:15, Si-Wei Liu wrote:
> > > On Mon, Feb 1, 2021 at 7:13 PM Jason Wang wrote:
On Mon, Feb 1, 2021 at 7:13 PM Jason Wang wrote:
>
>
> On 2021/2/2 上午3:17, Si-Wei Liu wrote:
> > On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote:
> >> On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote:
> >>> suspend_vq should only suspend the VQ on not sa
On Mon, Feb 1, 2021 at 10:51 AM Si-Wei Liu wrote:
>
> On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote:
> >
> > suspend_vq should only suspend the VQ on not save the current available
> > index. This is done when a change of map occurs when the driver calls
> >
On Thu, Jan 28, 2021 at 5:46 AM Eli Cohen wrote:
>
> suspend_vq should only suspend the VQ on not save the current available
> index. This is done when a change of map occurs when the driver calls
> save_channel_info().
Hmmm, suspend_vq() is also called by teardown_vq(), the latter of
which doesn
On Mon, Feb 01, 2021 at 03:48:10PM +0100, Andrea Parri (Microsoft) wrote:
> Andrea Parri (Microsoft) (4):
> x86/hyperv: Load/save the Isolation Configuration leaf
> Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests
> Drivers: hv: vmbus: Enforce 'VMBus version >= 5.2' on isolated g
On Sat, Jan 16, 2021 at 02:02:01PM +0100, Andrea Parri wrote:
> On Fri, Jan 15, 2021 at 08:30:22PM -0800, Jakub Kicinski wrote:
> > On Thu, 14 Jan 2021 21:26:28 +0100 Andrea Parri (Microsoft) wrote:
> > > For additional robustness in the face of Hyper-V errors or malicious
> > > behavior, validate
On Tue, Dec 22, 2020 at 01:59:34PM +, Michael Kelley wrote:
> From: Andrea Parri (Microsoft) Sent: Monday,
> December 7, 2020 8:53 PM
> >
> > From: Andres Beltran
> >
> > Pointers to ring-buffer packets sent by Hyper-V are used within the
> > guest VM. Hyper-V can send packets with erroneo
On Wed, Nov 18, 2020 at 05:37:15PM -0800, Jakub Kicinski wrote:
> On Wed, 18 Nov 2020 16:33:10 +0100 Andrea Parri (Microsoft) wrote:
> > Lack of validation could lead to out-of-bound reads and information
> > leaks (cf. usage of nvdev->chan_table[]). Check that the number of
> > allocated sub-chan
On Tue, Nov 17, 2020 at 09:23:08PM +0100, Enrico Weigelt, metux IT consult
wrote:
> Make it possible to opt-out from hyperv support.
>
"Hyper-V support".
Have you tested this patch? If so, how?
> Signed-off-by: Enrico Weigelt, metux IT consult
> ---
> arch/x86/Kconfig | 7 +++
On Mon, Nov 09, 2020 at 11:03:59AM +0100, Andrea Parri (Microsoft) wrote:
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised Hyper-V, avoid exposing
> guest memo
rea Parri (Microsoft)
> Reviewed-by: Michael Kelley
> Acked-by: Jakub Kicinski
> Cc: "David S. Miller"
> Cc: Jakub Kicinski
> Cc: netdev@vger.kernel.org
Reviewed-by: Wei Liu
n-netback/xenbus.c:1001: warning: Function parameter or member
> 'id' not described in 'netback_probe'
>
> Cc: Wei Liu
If this is ever needed:
Acked-by: Wei Liu
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the pinning leakage first and do the
possible optimization on top (which is still questionable to me).
OK
On 10/9/2020 7:27 PM, Jason Wang wrote:
On 2020/10/3 下午1:02, Si-Wei Liu wrote:
Pinned pages are not properly accounted particularly when
mapping error occurs on IOTLB update. Clean up dangling
pinned pages for the error path. As the inflight pinned
pages, specifically for memory region that
885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
Changes in v3:
- Factor out vhost_vdpa_map() change to a separate patch
Changes in v2:
- Fix incorrect target SHA1 referenced
drivers/vhost/vdpa.c | 119 ++-
1 f
t_vdpa_map() failure
This patchset attempts to address the above issues.
Changes in v3:
- Factor out changes in vhost_vdpa_map() and the fix for
page pinning leak to separate patches (Jason)
---
Si-Wei Liu (2):
vhost-vdpa: fix vhost_vdpa_map() on error condition
vhost-vdpa: fix page pinning
vhost_vdpa_map() should remove the iotlb entry just added
if the corresponding mapping fails to set up properly.
Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
drivers/vhost/vdpa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dri
+ Eli.
On Thu, Oct 1, 2020 at 2:02 PM Si-Wei Liu wrote:
>
> A VM with mlx5 vDPA has below warnings while being reset:
>
> vhost VQ 0 ring restore failed: -1: Resource temporarily unavailable (11)
> vhost VQ 1 ring restore failed: -1: Resource temporarily unavailable (11)
>
885f6 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
Changes in v2:
- Fix incorrect target SHA1 referenced
drivers/vhost/vdpa.c | 121 +++
1 file changed, 73 insertions(+), 48 deletions(-)
diff --git a/drivers/vhost/v
5fb06 ("vhost: introduce vDPA-based backend")
Signed-off-by: Si-Wei Liu
---
drivers/vhost/vdpa.c | 121 +++
1 file changed, 73 insertions(+), 48 deletions(-)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 796fe97..abc4aa2 10064
index, regardless of vDPA device
status. Save the index that was last seen when virtq was
stopped, so that userspace doesn't complain.
Signed-off-by: Si-Wei Liu
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/dr
On Wed, Sep 16, 2020 at 11:48:06AM +0800, Boqun Feng wrote:
> This patchset add the necessary changes to support guests whose page
> size is larger than 4K. And the main architecture which we develop this
> for is ARM64 (also it's the architecture that I use to test this
> feature).
>
> Previous v
On Mon, Sep 14, 2020 at 04:46:00PM +0800, Boqun Feng wrote:
> On Thu, Sep 10, 2020 at 10:34:52PM +0800, Boqun Feng wrote:
> > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> > least 2 * PAGE_SIZE: one page for the header and at least one page of
> > the data part (because
two patches to make it easy to review.
>
> Signed-off-by: Boqun Feng
Reviewed-by: Wei Liu
On Tue, Jul 21, 2020 at 09:41:25AM +0800, Boqun Feng wrote:
> Since the hypervisor always uses 4K as its page size, the size of PFNs
> used for gpadl should be HV_HYP_PAGE_SIZE rather than PAGE_SIZE, so
> adjust this accordingly as the preparation for supporting 16K/64K page
> size guests.
It may
Hi Chi
Thanks for your patch. A few things need to be fixed before it can be
accepted upstream.
On Fri, Jul 17, 2020 at 06:04:31AM +, Chi Song wrote:
> The network is observed with low performance, if TX indirection table
> is imbalance. But the table is in memory and set in runtime, it's
>
On Mon, Jun 29, 2020 at 09:33:15PM +, Haiyang Zhang wrote:
>
>
> > -Original Message-
> > From: Andres Beltran
> > Sent: Monday, June 29, 2020 4:02 PM
> > To: KY Srinivasan ; Haiyang Zhang
> > ; Stephen Hemminger ;
> > wei@kernel.org
> > Cc: linux-hyp...@vger.kernel.org; linux-ke
On Fri, Jun 26, 2020 at 04:48:17PM +0200, Andrea Parri wrote:
> On Fri, Jun 26, 2020 at 01:42:27PM +0000, Wei Liu wrote:
> > On Thu, Jun 25, 2020 at 11:37:20AM -0400, Andres Beltran wrote:
> > > From: Andres Beltran (Microsoft)
> > >
> > > Currently, VMbus dr
On Thu, Jun 25, 2020 at 11:37:20AM -0400, Andres Beltran wrote:
> From: Andres Beltran (Microsoft)
>
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised Hyper-V
David
Do you want this to go through net tree? I can submit it via hyperv tree
if that's preferred.
Wei.
On Tue, Apr 28, 2020 at 10:54:56AM -0700, Nathan Chancellor wrote:
> netvsc_start_xmit is used as a callback function for the ndo_start_xmit
> function pointer. ndo_start_xmit's return type i
On Mon, Apr 27, 2020 at 08:30:43PM -0700, Nathan Chancellor wrote:
> netvsc_start_xmit is used as a callback function for the ndo_start_xmit
> function pointer. ndo_start_xmit's return type is netdev_tx_t but
> netvsc_start_xmit's return type is int.
>
> This causes a failure with Control Flow Int
On Fri, 13 Sep 2019 at 16:28, Wei Liu wrote:
>
> On Fri, 13 Sep 2019 at 13:47, Paul Durrant wrote:
> >
> > My Citrix email address will expire shortly.
> >
> > Signed-off-by: Paul Durrant
>
> Acked-by: Wei Liu
Or rather:
Acked-by: Wei Liu
On Fri, 13 Sep 2019 at 13:47, Paul Durrant wrote:
>
> My Citrix email address will expire shortly.
>
> Signed-off-by: Paul Durrant
Acked-by: Wei Liu
On Sat, Aug 10, 2019 at 12:31:08PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Wei Liu
> Cc:
Signed-off-by: Wei Liu
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0c55b0fedbe2..e212c6a42ddf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17295,7 +17295,7 @@ F: Documentation/ABI/stable/sysfs-hypervisor-xen
F
On 4/9/2019 9:13 AM, Michael S. Tsirkin wrote:
On Mon, Apr 08, 2019 at 07:45:27PM -0400, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there&#
On 3/6/2019 8:13 PM, Samudrala, Sridhar wrote:
On 3/6/2019 7:08 PM, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there's a race
es should be changed to operate on failover master instead, as the
failover slave is dynamic in nature which may come and go at any point.
The goal is to make the role of failover slaves less relevant, and
all userspace should only deal with master in the long run.
Fixes: 30c8bd5aa8b2 ("net: I
On 3/5/2019 11:23 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:15:06PM -0800, si-wei liu wrote:
On 3/5/2019 10:43 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:51:00PM -0800, si-wei liu wrote:
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at
On 3/5/2019 10:43 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:51:00PM -0800, si-wei liu wrote:
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11
On 3/5/2019 4:36 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 04:20:50PM -0800, si-wei liu wrote:
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32
On 3/5/2019 4:06 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:35:50AM -0800, si-wei liu wrote:
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu wrote:
I have a vague idea: would it work to *not* set
IFF_UP on slave devices at all
On 3/5/2019 12:28 PM, Michael S. Tsirkin wrote:
On Tue, Mar 05, 2019 at 11:19:32AM -0800, si-wei liu wrote:
On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote:
On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
On 3/5/2019 11:24 AM, Stephen Hemminger wrote:
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu wrote:
I have a vague idea: would it work to *not* set
IFF_UP on slave devices at all?
Hmm, I ever thought about this option, and it appears this solution is
more invasive than required to convert
On 3/4/2019 6:33 PM, Michael S. Tsirkin wrote:
On Mon, Mar 04, 2019 at 07:50:59PM -0500, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there&#
Sorry for multiple sends. The patch is exactly same. I added a few
people who were missing int the cc lines in the first attemt. And
corrected the subject line in the second attempt.
-Siwei
On 3/4/2019 6:04 PM, David Miller wrote:
Why did you send this three times?
What's different in each
Please disregard patch emails previously sent with similar subject. The
patch target is set to net rather than net-next. Any discussion or
comment around this patch should go after this email.
-Siwei
On 3/4/2019 4:53 PM, Si-Wei Liu wrote:
When a netdev appears through hot plug then gets
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there's a race that userspace
(udev) may fail to rename the slave if the kernel (net_failover)
opens the slave earlier tha
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there's a race that userspace
(udev) may fail to rename the slave if the kernel (net_failover)
opens the slave earlier tha
When a netdev appears through hot plug then gets enslaved by a failover
master that is already up and running, the slave will be opened
right away after getting enslaved. Today there's a race that userspace
(udev) may fail to rename the slave if the kernel (net_failover)
opens the slave earlier tha
On 3/1/2019 5:27 AM, Michael S. Tsirkin wrote:
On Thu, Feb 28, 2019 at 05:30:56PM -0800, si-wei liu wrote:
On 2/28/2019 6:26 AM, Michael S. Tsirkin wrote:
On Thu, Feb 28, 2019 at 01:32:12AM -0800, si-wei liu wrote:
Will the
change break userspace further?
-Siwei
Didn't you
1 - 100 of 228 matches
Mail list logo
