Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-05-02 Thread Wang Shanker
Thanks a lot. I feel it excited to contribute to the development of kernel. I’ll do better next time. > 在 2016年5月3日,06:19,Stephen Hemminger 写道: > > On Thu, 28 Apr 2016 15:50:47 +0100 > James Chapman wrote: > >> Yes, that looks like the problem. >> >> The comments in l2tp.h which indicate th

[Question] Should `CAP_NET_ADMIN` be needed when opening `/dev/ppp`?

2016-05-01 Thread Wang Shanker
Hi, all. I’ve recently met some problems when trying to create a pppoe network link inside a unprivileged container. There is a uid namespace which maps root inside to a normal user outside. There is also a separate

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-29 Thread Wang Shanker
Is there any further suggestion or review? > 在 2016年4月29日,03:25,Wang Shanker 写道: > > I think this is a logic error, rather than a change to the default > UDP checksum setting. As expected, take rx for example, the flag > `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is not set by default, and u

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
etting for L2TP tunnels when using IPv6. Unfortunately, > iproute2 doesn't let the user configure L2TP UDP checksum settings, so > without this fix, some users may see problems depending on the kernel > version differences on the L2TP peers. One for stable? > > Acked-by: James

[PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
This patch fixes a bug which causes the behavior of whether to ignore udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what userspace program requests. When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it is expected that udp6 checksums of received packets of the l2tp tunn

[PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-04-28 Thread Wang Shanker
This patch fixes a bug which causes the behavior of whether to ignore udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what userspace program requests. When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it is expected that udp6 checksums of received packets of the l2tp tunn

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-27 Thread Wang Shanker
> 在 2016年4月27日,23:33,Wang Shanker 写道: > > > >> 在 2016年4月27日,20:21,James Chapman 写道: >> >> On 26 April 2016 at 15:15, Wang Shanker wrote: >>> Hi, all >>> >>> It’s my first time to contribute to such an important open source pro

Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-27 Thread Wang Shanker
> 在 2016年4月27日,20:21,James Chapman 写道: > > On 26 April 2016 at 15:15, Wang Shanker wrote: >> Hi, all >> >> It’s my first time to contribute to such an important open source project. >> Things began when I upgraded my server, called "Server A"

[PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-04-26 Thread Wang Shanker
Hi, all It’s my first time to contribute to such an important open source project. Things began when I upgraded my server, called "Server A", form ubuntu 14.04 to 16.04, which is shipped with new kernel version, 4.4. After upgrade, I soon found a l2tp tunnel between this server and another linu