[PATCH net-next] net: ethtool: add support for forward error correction modes

2017-02-10 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of

[RFC PATCH net-next v2] net: ethtool: add support for forward error correction modes

2017-02-10 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of

[RFC PATCH v2] net: ethtool: add support for forward error correction modes

2017-02-10 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of

Re: [RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-11-08 Thread Vidya Sagar Ravipati
On Thu, Nov 3, 2016 at 6:24 AM, Gal Pressman wrote: > > > On 25/10/2016 05:50, Vidya Sagar Ravipati wrote: >> SET FEC option: >> root@tor: ethtool --set-fec swp1 encoding [off | RS | BaseR | auto] autoneg >> [off | on] >> >> Encoding: Types of encodin

[RFC PATCH ethtool 1/2] ethtool-copy.h: sync with net

2016-10-25 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Sending out this review as RFC to get early feedback on fec options and output changes as changes to kernel uapi to ethtool is under review on netdev currently and might change based on review.. http://patchwork.ozlabs.org/patch/686293/ Signed-off-by: Vidya Sagar

[RFC PATCH ethtool 0/2] ethtool: Add support for FEC encoding configuration

2016-10-25 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of

[RFC PATCH ethtool 2/2] ethtool: Support for FEC encoding control

2016-10-25 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati As FEC settings and different FEC modes are mandatory and configurable across various interfaces of 25G/50G/100G/40G , the lack of FEC encoding control and reporting today is a source for interoperability issues for many vendors set-fec/show-fec option(s) are

[RFC PATCH net-next] net: ethtool: add support for forward error correction modes

2016-10-24 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of

[ethtool PATCH v1] ethtool: Document ethtool advertised speeds for 1G/10G

2016-09-06 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Man page update to include updated advertised speeds for 1G/10G Signed-off-by: Vidya Sagar Ravipati --- ethtool.8.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index 821d0bc..376831d 100644 --- a/ethtool.8.in +++ b/ethtool

Re: [ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

2016-09-06 Thread Vidya Sagar Ravipati
Will send out man page fix. Missed it. On Tue, Sep 6, 2016 at 1:32 PM, Vidya Sagar Ravipati wrote: > Will send out man page fix too. Missed it. > > On Tue, Sep 6, 2016 at 1:16 PM, John W. Linville > wrote: >> >> On Sun, Aug 28, 2016 at 11:56:48PM -0700, Vidya Sagar R

[ethtool PATCH v1 0/2] ethtool: add support for 1000BaseX and missing 10G link mode

2016-08-29 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patchset enhances ethtool link mode bitmap to include missing interface modes for 1G/10G speeds Vidya Sagar Ravipati (2): ethtool-copy.h:sync with net ethtool: add support for 1000BaseX and missing 10G link mode ethtool-copy.h | 11 +-- ethtool.c

[ethtool PATCH v1 1/2] ethtool-copy.h:sync with net

2016-08-29 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This covers kernel changes upto: commit 5711a98221443aec54c4c81ee98c6ae46acccb65 Author: Vidya Sagar Ravipati Date: Fri Aug 26 01:25:50 2016 -0700 net: ethtool: add support for 1000BaseX and missing 10G link modes This patch enhances ethtool link mode

[ethtool PATCH v1 2/2] ethtool: add support for 1000BaseX and missing 10G link mode

2016-08-29 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch enhances ethtool link mode bitmap to include missing interface modes for 1G/10G speeds Changes: a) 1000baseX is the mode introduced to cover all 1G Fiber cases. All modes under 1000BaseX i.e. 1000BASE-SX, 1000BASE-LX, 1000BASE-LX10 and 1000BASE-BX10 are not

[PATCH net-next] net: ethtool: add support for 1000BaseX and missing 10G link modes

2016-08-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch enhances ethtool link mode bitmap to include missing interface modes for 1G/10G speeds Changes: 1000baseX is the mode introduced to cover all 1G Fiber cases. All modes under 1000BaseX i.e. 1000BASE-SX, 1000BASE-LX, 1000BASE-LX10 and 1000BASE-BX10 are not

Re: [ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-24 Thread Vidya Sagar Ravipati
es. Not aware of "make distcheck" and will be careful going forward. Quickly validated the build on SFP+/QSFP+/QSFP28 and everything seems fine > John > > P.S. I have not yet tagged this as an official release, so please test! > > On Tue, Aug 23, 2016 at 06:30:29AM -0

[ethtool PATCH v4 2/4] ethtool:Reorganizing SFF-8024 fields for SFP/QSFP

2016-08-23 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Moving the common

[ethtool PATCH v4 3/4] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-08-23 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Support for diagnostics information for QSFP Plus/QSFP28 modules based on SFF-8436/SFF-8636 Standards for QSFP+/QSFP28 a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016 b) SFF-8024 Rev 4.0 dated May 31, 2016 Signed

[ethtool PATCH v4 1/4] ethtool-copy.h:sync with net

2016-08-23 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This covers kernel changes upto: commit 89da45b8b5b2187734a11038b8593714f964ffd1 Author: Gal Pressman Date: Thu Jun 23 17:02:43 2016 +0300 ethtool: Add 50G baseSR2 link mode Add ETHTOOL_LINK_MODE_5baseSR2_Full_BIT bit. Signed-off-by: Gal Pressman

[ethtool PATCH v4 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-23 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Support

[ethtool PATCH v4 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-08-23 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Enhancing link mode bits to support 25G/50G/100G for supported and advertised speed mode bits Signed-off-by: Vidya Sagar Ravipati Acked-By: David Decotigny --- ethtool.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/ethtool.c b

Re: [ethtool PATCH v3 1/4] ethtool-copy.h:sync with net

2016-08-22 Thread Vidya Sagar Ravipati
John, I will re-submit v4 patchset with these updated bits. Thanks Vidya On Mon, Aug 22, 2016 at 12:26 PM, John W. Linville wrote: > On Sun, Aug 21, 2016 at 04:44:01PM -0700, Vidya Sagar Ravipati wrote: >> From: Vidya Sagar Ravipati >> >> This covers kernel chang

[ethtool PATCH v3 1/4] ethtool-copy.h:sync with net

2016-08-21 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This covers kernel changes upto: commit 3851112e4737cd52aaeda0ce8d084be9ee128106 Author: Vidya Sagar Ravipati Date: Sun May 22 23:59:00 2016 -0700 ethtool: add support for 25G/50G/100G speed modes This patch enhances ethtool link mode bitmap to include

[ethtool PATCH v3 2/4] ethtool:Reorganizing SFF-8024 fields for SFP/QSFP

2016-08-21 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Moving the common

[ethtool PATCH v3 3/4] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-08-21 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Support for diagnostics information for QSFP Plus/QSFP28 modules based on SFF-8436/SFF-8636 Standards for QSFP+/QSFP28 a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016 b) SFF-8024 Rev 4.0 dated May 31, 2016 Signed

[ethtool PATCH v3 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-08-21 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Support

[ethtool PATCH v3 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-08-21 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Enhancing link mode bits to support 25G/50G/100G for supported and advertised speed mode bits Signed-off-by: Vidya Sagar Ravipati Acked-By: David Decotigny --- ethtool.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/ethtool.c b

Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-07-24 Thread Vidya Sagar Ravipati
Yuval, I will try to resubmit the patches this week with updated comments Thanks Vidya Sagar On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz wrote: >> Enhancing link mode bits to support 25G/50G/100G for supported and >> advertised speed mode bits >> >> Signed-off-

[ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G

2016-06-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Enhancing link mode bits to support 25G/50G/100G for supported and advertised speed mode bits Signed-off-by: Vidya Sagar Ravipati --- ethtool.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/ethtool.c b/ethtool.c index 1d6564e

[ethtool PATCH v2 2/4] ethtool:Reorganizing SFF-8024 fields for SFP/QSFP

2016-06-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. Standards for SFF

[ethtool PATCH v2 1/4] ethtool-copy.h:sync with net

2016-06-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This covers kernel changes upto: commit 3851112e4737cd52aaeda0ce8d084be9ee128106 Author: Vidya Sagar Ravipati Date: Sun May 22 23:59:00 2016 -0700 ethtool: add support for 25G/50G/100G speed modes This patch enhances ethtool link mode bitmap to include

[ethtool PATCH v2 3/4] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch provides following support a) Support for diagnostics information for QSFP Plus/QSFP28 modules based on SFF-8436/SFF-8636 Standards for QSFP+/QSFP28 a) QSFP+/QSFP28 - SFF 8636 Rev 2.7 dated January 26,2016 b) SFF-8024 Rev 4.0 dated May 31, 2016 Signed

[ethtool PATCH v2 0/4] Add support for QSFP+/QSFP28 Diagnostics and 25G/50G/100G port speeds

2016-06-26 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Support

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Vidya Sagar Ravipati
On Sun, Jun 26, 2016 at 2:33 AM, Ben Hutchings wrote: > On Mon, 2016-06-13 at 16:27 -0700, Vidya Sagar Ravipati wrote: >> From: Vidya Sagar Ravipati >> >> This patch series provides following support >> a) Reorganized fields based out of SFF-8024 fields i.e. Identifie

Re: [ethtool PATCH v7 1/2] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-06-13 Thread Vidya Sagar Ravipati
Acked-by:Vidya Sagar Ravipati Validated this patch with various modules. Replied from wrong email alias earlier. On Thu, Jun 9, 2016 at 5:55 PM, David Decotigny wrote: > From: David Decotigny > > More info with kernel commit 8d3f2806f8fb ("Merge branch > 'ethtool-ksettings'"). > > Note: The n

[ethtool PATCH v1 0/2] Add support for QSFP+/QSFP28 Diagnostics

2016-06-13 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. b) Support

[ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-13 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This patch series provides following support a) Reorganized fields based out of SFF-8024 fields i.e. Identifier/ Encoding/Connector types which are common across SFP/SFP+ (SFF-8472) and QSFP+/QSFP28 (SFF-8436/SFF-8636) modules into sff-common files. a) Support

[ethtool PATCH v1 1/2] ethtool-copy.h:sync with net

2016-06-13 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati This covers kernel changes upto: commit 3851112e4737cd52aaeda0ce8d084be9ee128106 Author: Vidya Sagar Ravipati Date: Sun May 22 23:59:00 2016 -0700 ethtool: add support for 25G/50G/100G speed modes This patch enhances ethtool link mode bitmap to include

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread Vidya Sagar Ravipati
On Sat, Jun 11, 2016 at 3:51 PM, David Miller wrote: > From: vi...@cumulusnetworks.com > Date: Mon, 6 Jun 2016 22:55:26 -0700 > >> From: Vidya Sagar Ravipati >> >> This patch provides macro definitions for maximum possible >> memory map size of QSFP+/QSFP28