Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-16 Thread Vicente Jiménez
On Wed, Nov 16, 2016 at 2:14 AM, Florian Westphal wrote: > Vicente Jiménez wrote: >> 1- add warning with pr_warn_ratelimited. I like this idea. I also >> though about adding some message but I have no kernel experience and I >> preferred to have just a working solution. >

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Vicente Jiménez
gt; David Miller wrote: >> From: Vicente Jiménez >> Date: Tue, 15 Nov 2016 17:49:43 +0100 >> >> > On Mon, Nov 14, 2016 at 7:36 PM, David Miller wrote: >> >> From: Vicente Jimenez Aguilar >> >> Date: Fri, 11 Nov 2016 21:20:18 +0100 >

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Vicente Jiménez
On Mon, Nov 14, 2016 at 7:36 PM, David Miller wrote: > From: Vicente Jimenez Aguilar > Date: Fri, 11 Nov 2016 21:20:18 +0100 > >> @@ -819,6 +820,12 @@ static bool icmp_unreach(struct sk_buff *skb) >> /* fall through */ >> case 0: >>

[Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-10 Thread Vicente Jiménez
Handle weird ICMP fragmentation needed messages with next hop MTU equal to (or exceeding) dropped packet size Fixes: 46517008e116 ("ipv4: Kill ip_rt_frag_needed().") In a large corporate network, we spotted this weird ICMP message after a long troubleshooting. See attached capture file. Those ICM

Re: [Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-10 Thread Vicente Jiménez
Corrected patch attached. Thanks for the advices. I was unaware of those style policies. On Thu, Nov 10, 2016 at 2:22 AM, David Miller wrote: > From: Vicente Jiménez > Date: Mon, 7 Nov 2016 12:11:59 +0100 > >> From bfc9a00e6b78d8eb60e46dacd7d761669d29a573 Mon Sep 17 00:00:

[Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-07 Thread Vicente Jiménez
Handle weird ICMP fragmentation needed messages with next hop MTU equal to (or exceeding) dropped packet size Fixes: 46517008e116 ("ipv4: Kill ip_rt_frag_needed().") In a large corporate network, we spotted this weird ICMP message after a long troubleshooting. See attached capture file. Those ICM