[PATCH iproute2] etf: make printing of variable JSON friendly

2019-07-19 Thread Vedang Patel
In iproute2 txtime-assist series, it was pointed out that print_bool() should be used to print binary values. This is to make it JSON friendly. So, make the corresponding changes in ETF. Fixes: 8ccd49383cdc ("etf: Add skip_sock_check") Reported-by: Stephen Hemminger Signed-off-by: Ve

[PATCH iproute2 net-next v5 3/5] taprio: add support for setting txtime_delay.

2019-07-18 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index

[PATCH iproute2 net-next v5 5/5] tc: taprio: Update documentation

2019-07-18 Thread Vedang Patel
Add documentation for the latest options, flags and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 40 1 file changed, 40 insertions(+) diff --git

[PATCH iproute2 net-next v5 2/5] taprio: Add support for setting flags

2019-07-18 Thread Vedang Patel
: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- tc/q_taprio.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 62c8c591da99..1db2aba6efe7 100644 --- a/tc/q_taprio.c +++ b/tc/q_taprio.c @@ -159,6 +159,7 @@ static int

[PATCH iproute2 net-next v5 4/5] tc: etf: Add documentation for skip_sock_check.

2019-07-18 Thread Vedang Patel
Document the newly added option (skip_sock_check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7d2c7..4cb3b9e02d6e 100644 --- a/man/man8/tc-etf.8 +++ b

[PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check

2019-07-18 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476c61d..c2090589bc64 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13

[PATCH iproute2 net-next v4 3/6] taprio: Add support for setting flags

2019-07-16 Thread Vedang Patel
: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- tc/q_taprio.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 62c8c591da99..1db2aba6efe7 100644 --- a/tc/q_taprio.c +++ b/tc/q_taprio.c @@ -159,6 +159,7 @@ static int

[PATCH iproute2 net-next v4 6/6] tc: taprio: Update documentation

2019-07-16 Thread Vedang Patel
Add documentation for the latest options, flags and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 40 1 file changed, 40 insertions(+) diff --git

[PATCH iproute2 net-next v4 2/6] etf: Add skip_sock_check

2019-07-16 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476c61d..c2090589bc64 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13

[PATCH iproute2 net-next v4 1/6] Update kernel headers

2019-07-16 Thread Vedang Patel
The type for txtime-delay parameter will change from s32 to u32. So, make the corresponding change in the ABI file as well. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/pkt_sched.h b/include

[PATCH iproute2 net-next v4 5/6] tc: etf: Add documentation for skip-skb-check.

2019-07-16 Thread Vedang Patel
Document the newly added option (skip-skb-check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7d2c7..2e01a591dbaa 100644 --- a/man/man8/tc-etf.8 +++ b/man

[PATCH net-next v1] fix: taprio: Change type of txtime-delay parameter to u32

2019-07-16 Thread Vedang Patel
eported-by: Stephen Hemminger Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_taprio.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 1f623252abe8..18f185299

[PATCH iproute2 net-next v4 4/6] taprio: add support for setting txtime_delay.

2019-07-16 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index

[PATCH iproute2 net-next v3 5/5] tc: taprio: Update documentation

2019-07-15 Thread Vedang Patel
Add documentation for the latest options, flags and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 40 1 file changed, 40 insertions(+) diff --git

[PATCH iproute2 net-next v3 3/5] taprio: add support for setting txtime_delay.

2019-07-15 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index

[PATCH iproute2 net-next v3 4/5] tc: etf: Add documentation for skip-skb-check.

2019-07-15 Thread Vedang Patel
Document the newly added option (skip-skb-check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7d2c7..2e01a591dbaa 100644 --- a/man/man8/tc-etf.8 +++ b/man

[PATCH iproute2 net-next v3 2/5] taprio: Add support for setting flags

2019-07-15 Thread Vedang Patel
: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- tc/q_taprio.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 62c8c591da99..930ecb9d1eef 100644 --- a/tc/q_taprio.c +++ b/tc/q_taprio.c @@ -154,6 +154,7 @@ static struct

[PATCH iproute2 net-next v3 1/5] etf: Add skip_sock_check

2019-07-15 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476c61d..c2090589bc64 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13

[PATCH net-next v6 8/8] taprio: Adjust timestamps for TCP packets

2019-06-25 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v6 6/8] taprio: Add support for txtime-assist mode

2019-06-25 Thread Vedang Patel
it time is already known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 + net/

[PATCH net-next v6 4/8] taprio: calculate cycle_time when schedule is installed

2019-06-25 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v6 7/8] taprio: make clock reference conversions easier

2019-06-25 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v6 0/8] net/sched: Add txtime-assist support for taprio.

2019-06-25 Thread Vedang Patel
osed. ethtool -K eth0 gso off ethtool -K eth0 tso off # Disable energy efficient ethernet to make sure there are no latency # spikes when NIC is trying to wake up when the packet is supposed to be # sent. ethtool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (8): igb: clear out skb-

[PATCH net-next v6 5/8] taprio: Remove inline directive

2019-06-25 Thread Vedang Patel
Remove inline directive from length_to_duration(). We will let the compiler make the decisions. Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index a41d7d4434ee

[PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-25 Thread Vedang Patel
ook at skb_is_swtx_tstamp() and the callee function __sock_recv_timestamp() in net/socket.c for more details. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/et

[PATCH net-next v6 2/8] etf: Don't use BIT() in UAPI headers.

2019-06-25 Thread Vedang Patel
The BIT() macro isn't exported as part of the UAPI interface. So, the compile-test to ensure they are self contained fails. So, use _BITUL() instead. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/in

[PATCH net-next v6 3/8] etf: Add skip_sock_check

2019-06-25 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1 + net

[PATCH net-next v5 4/7] taprio: Remove inline directive

2019-06-21 Thread Vedang Patel
Remove inline directive from length_to_duration(). We will let the compiler make the decisions. Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index a41d7d4434ee

[PATCH net-next v5 5/7] taprio: Add support for txtime-assist mode

2019-06-21 Thread Vedang Patel
it time is already known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 + net/

[PATCH net-next v5 6/7] taprio: make clock reference conversions easier

2019-06-21 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v5 7/7] taprio: Adjust timestamps for TCP packets

2019-06-21 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v5 3/7] taprio: calculate cycle_time when schedule is installed

2019-06-21 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v5 0/7] net/sched: Add txtime-assist support for taprio.

2019-06-21 Thread Vedang Patel
ool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (7): igb: clear out skb->tstamp after reading the txtime etf: Add skip_sock_check taprio: calculate cycle_time when schedule is installed taprio: Remove inline directive taprio: Add support for txtime-assist mode taprio: make

[PATCH net-next v5 2/7] etf: Add skip_sock_check

2019-06-21 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1 + net

[PATCH net-next v5 1/7] igb: clear out skb->tstamp after reading the txtime

2019-06-21 Thread Vedang Patel
ook at skb_is_swtx_tstamp() and the callee function __sock_recv_timestamp() in net/socket.c for more details. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/et

[PATCH net-next v4 7/7] taprio: Adjust timestamps for TCP packets

2019-06-19 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v4 2/7] etf: Add skip_sock_check

2019-06-19 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1

[PATCH net-next v4 4/7] taprio: Remove inline directive

2019-06-19 Thread Vedang Patel
Remove inline directive from length_to_duration(). We will let the compiler make the decisions. Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index a41d7d4434ee

[PATCH net-next v4 6/7] taprio: make clock reference conversions easier

2019-06-19 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v4 5/7] taprio: Add support for txtime-assist mode

2019-06-19 Thread Vedang Patel
it time is already known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 + net/

[PATCH net-next v4 3/7] taprio: calculate cycle_time when schedule is installed

2019-06-19 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v4 1/7] igb: clear out tstamp after sending the packet

2019-06-19 Thread Vedang Patel
lse software timestamp on the receive side. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index fc925adbd9fa..f66dae72fe37 100

[PATCH net-next v4 0/7] net/sched: Add txtime-assist support for taprio.

2019-06-19 Thread Vedang Patel
eth0 tso off # Disable energy efficient ethernet to make sure there are no latency # spikes when NIC is trying to wake up when the packet is supposed to be # sent. ethtool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (7): igb: clear out tstamp after sending the packet etf: Add sk

[PATCH net-next v3 3/6] taprio: calculate cycle_time when schedule is installed

2019-06-17 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v3 0/6] net/sched: Add txtime-assist support for taprio.

2019-06-17 Thread Vedang Patel
wake up when the packet is supposed to be # sent. ethtool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (6): igb: clear out tstamp after sending the packet. etf: Add skip_sock_check taprio: calculate cycle_time when schedule is installed taprio: Add support for txtime-assist m

[PATCH net-next v3 5/6] taprio: make clock reference conversions easier

2019-06-17 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v3 2/6] etf: Add skip_sock_check

2019-06-17 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1

[PATCH net-next v3 1/6] igb: clear out tstamp after sending the packet.

2019-06-17 Thread Vedang Patel
lse software timestamp on the receive side. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index fc925adbd9fa..f66dae72fe37 100

[PATCH net-next v3 6/6] taprio: Adjust timestamps for TCP packets.

2019-06-17 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v3 4/6] taprio: Add support for txtime-assist mode.

2019-06-17 Thread Vedang Patel
it time is already known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 + net/

[PATCH iproute2 net-next v2 5/6] tc: etf: Add documentation for skip-skb-check.

2019-06-06 Thread Vedang Patel
Document the newly added option (skip-skb-check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7d2c7..2e01a591dbaa 100644 --- a/man/man8/tc-etf.8 +++ b/man

[PATCH iproute2 net-next v2 3/6] taprio: Add support for setting flags

2019-06-06 Thread Vedang Patel
: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- tc/q_taprio.c | 21 + 1 file changed, 21 insertions(+) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 62c8c591da99..930ecb9d1eef 100644 --- a/tc/q_taprio.c +++ b/tc/q_taprio.c @@ -154,6 +154,7 @@ static struct

[PATCH iproute2 net-next v2 1/6] Kernel header update for hardware offloading changes.

2019-06-06 Thread Vedang Patel
This should only be updated after the kernel patches related to txtime-offload have been merged into the kernel. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux

[PATCH iproute2 net-next v2 2/6] etf: Add skip_sock_check

2019-06-06 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476c61d..c2090589bc64 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13

[PATCH iproute2 net-next v2 4/6] taprio: add support for setting txtime_delay.

2019-06-06 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index

[PATCH iproute2 net-next v2 6/6] tc: taprio: Update documentation

2019-06-06 Thread Vedang Patel
Add documentation for the latest options, flags and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 40 1 file changed, 40 insertions(+) diff --git

[PATCH iproute2 net-next v1 6/6] tc: taprio: Update documentation

2019-06-06 Thread Vedang Patel
Add documentation for the latest options, offload and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 37 + 1 file changed, 37 insertions(+) diff --git a

[PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode

2019-06-06 Thread Vedang Patel
From: Vinicius Costa Gomes This allows a new parameter to be passed to taprio, "offload", accepting a hexadecimal number which selects the offloading flags thats should be enabled. Signed-off-by: Vinicius Costa Gomes --- tc/q_taprio.c | 21 + 1 file changed, 21 insertions(+

[PATCH iproute2 net-next v1 5/6] tc: etf: Add documentation for skip-skb-check.

2019-06-06 Thread Vedang Patel
Document the newly added option (skip-skb-check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7..2e01a591 100644 --- a/man/man8/tc-etf.8 +++ b/man/man8/tc

[PATCH iproute2 net-next v1 2/6] etf: Add skip_sock_check

2019-06-06 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476..85003dc1 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13 @@ static int

[PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes.

2019-06-06 Thread Vedang Patel
This should only be updated after the kernel patches related to txtime-offload have been merged into the kernel. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h

[PATCH iproute2 net-next v1 4/6] taprio: add support for setting txtime_delay.

2019-06-06 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 69e52ff5

[PATCH net-next v2 3/6] taprio: calculate cycle_time when schedule is installed

2019-06-06 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v2 4/6] taprio: Add support for txtime-assist mode.

2019-06-06 Thread Vedang Patel
sent in software mode. The transmit time is already known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h

[PATCH net-next v2 5/6] taprio: make clock reference conversions easier

2019-06-06 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v2 2/6] etf: Add skip_sock_check

2019-06-06 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1

[PATCH net-next v2 6/6] taprio: Adjust timestamps for TCP packets.

2019-06-06 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v2 1/6] igb: clear out tstamp after sending the packet.

2019-06-06 Thread Vedang Patel
lse software timestamp on the receive side. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index fc925adbd9fa..f66dae72fe37 100

[PATCH net-next v2 0/6] net/sched: Add txtime-assist support for taprio.

2019-06-06 Thread Vedang Patel
t ethernet to make sure there are no latency # spikes when NIC is trying to wake up when the packet is supposed to be # sent. ethtool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (6): igb: clear out tstamp after sending the packet. etf: Add skip_sock_check taprio: calculate cy

[PATCH iproute2 net-next v1 4/6] taprio: add support for setting txtime_delay.

2019-05-28 Thread Vedang Patel
This adds support for setting the txtime_delay parameter which is useful for the txtime offload mode of taprio. Signed-off-by: Vedang Patel --- tc/q_taprio.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tc/q_taprio.c b/tc/q_taprio.c index 69e52ff5

[PATCH iproute2 net-next v1 3/6] taprio: Add support for enabling offload mode

2019-05-28 Thread Vedang Patel
From: Vinicius Costa Gomes This allows a new parameter to be passed to taprio, "offload", accepting a hexadecimal number which selects the offloading flags thats should be enabled. Signed-off-by: Vinicius Costa Gomes --- tc/q_taprio.c | 21 + 1 file changed, 21 insertions(+

[PATCH iproute2 net-next v1 5/6] tc: etf: Add documentation for skip-skb-check.

2019-05-28 Thread Vedang Patel
Document the newly added option (skip-skb-check) on the etf man-page. Signed-off-by: Vedang Patel --- man/man8/tc-etf.8 | 10 ++ 1 file changed, 10 insertions(+) diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8 index 30a12de7..2e01a591 100644 --- a/man/man8/tc-etf.8 +++ b/man/man8/tc

[PATCH iproute2 net-next v1 2/6] etf: Add skip_sock_check

2019-05-28 Thread Vedang Patel
with them. So, add an option to skip this check. Signed-off-by: Vedang Patel --- tc/q_etf.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tc/q_etf.c b/tc/q_etf.c index 76aca476..85003dc1 100644 --- a/tc/q_etf.c +++ b/tc/q_etf.c @@ -130,6 +130,13 @@ static int

[PATCH iproute2 net-next v1 1/6] Kernel header update for hardware offloading changes.

2019-05-28 Thread Vedang Patel
This should only be updated after the kernel patches related to txtime-offload have been merged into the kernel. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h

[PATCH iproute2 net-next v1 6/6] tc: taprio: Update documentation

2019-05-28 Thread Vedang Patel
Add documentation for the latest options, offload and txtime-delay, to the taprio manpage. This also adds an example to run tc in txtime offload mode. Signed-off-by: Vedang Patel --- man/man8/tc-taprio.8 | 37 + 1 file changed, 37 insertions(+) diff --git a

[PATCH net-next v1 2/7] etf: Add skip_sock_check

2019-05-28 Thread Vedang Patel
kernel (e.g. ICMP packets) do not have any socket associated with them. So, this commit adds support for skip_sock_check. When this option is set, etf will skip checking for a socket and other associated options for all skbs. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1

[PATCH net-next v1 6/7] taprio: make clock reference conversions easier

2019-05-28 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions

[PATCH net-next v1 7/7] taprio: Adjust timestamps for TCP packets.

2019-05-28 Thread Vedang Patel
epresented in CLOCK_MONOTONIC clock. We need to respect the timestamp set by the TCP subsystem. So, convert this time to the clock which taprio is using and ensure that the packet is not transmitted before the deadline set by TCP. Signed-off-by: Vedang Patel --- net/sched/sch_

[PATCH net-next v1 5/7] taprio: Add support for txtime offload mode.

2019-05-28 Thread Vedang Patel
ready known in advance. So, we do not need the HR timers to advance the schedule and wakeup the dequeue side of taprio. So, HR timer won't be run when this mode is enabled. Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 1 + net/sched/sch_taprio.c | 326

[PATCH net-next v1 4/7] taprio: calculate cycle_time when schedule is installed

2019-05-28 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_tap

[PATCH net-next v1 1/7] igb: clear out tstamp after sending the packet.

2019-05-28 Thread Vedang Patel
lse software timestamp on the receive side. Signed-off-by: Vedang Patel --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 39f33afc479c..005c1693efc8 100

[PATCH net-next v1 0/7] net/sched: Add txtime assist support for taprio

2019-05-28 Thread Vedang Patel
order to get the best performance from taprio in this mode: # ip link set dev enp1s0 mtu 1514 # ethtool -K eth0 gso off # ethtool -K eth0 tso off # ethtool --set-eee eth0 eee off Thanks, Vedang Patel Vedang Patel (6): igb: clear out tstamp after sending the packet. etf: Add skip_sock_check

[PATCH net-next v1 3/7] taprio: Add the skeleton to enable hardware offloading

2019-05-28 Thread Vedang Patel
-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- include/uapi/linux/pkt_sched.h | 4 + net/sched/sch_taprio.c | 156 - 2 files changed, 158 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h