drivers/net/ethernet/mediatek/mtk_ppe_offload.c - suspicious code?

2021-04-18 Thread Valdis Klētnieks
While doing some code auditing for -Woverride_init, I spotted some questionable code commit 502e84e2382d92654a2ecbc52cdbdb5a11cdcec7 Author: Felix Fietkau Date: Wed Mar 24 02:30:54 2021 +0100 net: ethernet: mtk_eth_soc: add flow offloading support In drivers/net/ethernet/mediatek/mtk_ppe

next-20210302 - build issue with linux-firmware and rtl_nic/ firmware.

2021-03-03 Thread Valdis Klētnieks
So my kernel build died.. UPD drivers/base/firmware_loader/builtin/rtl_nic/rtl8106e-1.fw.gen.S make[4]: *** No rule to make target '/lib/firmware/rtl_nic/rtl8106e-1.fw', needed by 'drivers/base/firmware_loader/builtin/rtl_nic/rtl8106e-1.fw.gen.o'. Stop. make[3]: *** [scripts/Makefile.buil

Re: next-20210302 - build issue with linux-firmware and rtl_nic/ firmware.

2021-03-03 Thread Valdis Klētnieks
On Wed, 03 Mar 2021 07:51:06 +0100, Heiner Kallweit said: > > # Firmware loader > > CONFIG_EXTRA_FIRMWARE="rtl_nic/rtl8106e-1.fw" > > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware" > > > This is wrong, simply remove it. > > But then I take a closer look at drivers/net/ethernet/realtek/r8169_main.c >

Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-03 Thread Valdis Klētnieks
On Sun, 03 Jan 2021 10:20:11 -0800, Stephen Hemminger said: > You can use a qdisc that is a module, it just has to be available when device > is loaded. Typically that means putting it in initramfs. Apparently, that's not *quite* true regarding the default qdisc, because I hit this situation (copy

Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-02 Thread Valdis Klētnieks
Consider the following own goal I just discovered I scored: [~] zgrep -i fq_codel /proc/config.gz CONFIG_NET_SCH_FQ_CODEL=m CONFIG_DEFAULT_FQ_CODEL=y CONFIG_DEFAULT_NET_SCH="fq_codel" Obviously, fq_codel didn't get set as the default, because that happens before the module gets loaded (which may

[PATCH] bpfilter: document build requirements for bpfilter_umh

2020-05-08 Thread Valdis Klētnieks
It's not intuitively obvious that bpfilter_umh is a statically linked binary. Mention the toolchain requirement in the Kconfig help, so people have an easier time figuring out what's needed. Signed-off-by: Valdis Kletnieks diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig index fed9290e3b

Re: linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

2020-05-08 Thread Valdis Klētnieks
On Sat, 09 May 2020 12:45:22 +0900, Masahiro Yamada said: > > LD [U] net/bpfilter/bpfilter_umh > > /usr/bin/ld: cannot find -lc > > collect2: error: ld returned 1 exit status > > make[2]: *** [scripts/Makefile.userprogs:36: net/bpfilter/bpfilter_umh] > > Error 1 > > make[1]: *** [scripts/Makef

linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

2020-05-07 Thread Valdis Klētnieks
My kernel build came to a screeching halt with: CHECK net/bpfilter/bpfilter_kern.c CC [M] net/bpfilter/bpfilter_kern.o CC [U] net/bpfilter/main.o LD [U] net/bpfilter/bpfilter_umh /usr/bin/ld: cannot find -lc collect2: error: ld returned 1 exit status make[2]: *** [scripts/Makefile.use