[PATCH] kernel/bpf/cgroup.c - clean up kerneldoc warnings

2019-01-28 Thread valdis . kletnieks
cribed in '__cgroup_bpf_detach' Add a kerneldoc line for 'flags'. Fixing the warning for 'unused_flags' is best approached by removing the unused parameter on the function call. Signed-off-by: Valdis Kletnieks diff --git a/include/linux/bpf-cgroup.h b/include/linu

[PATCH] include/linux/bpf.h - fix missing prototype warnings...

2019-01-28 Thread valdis . kletnieks
__weak bpf_jit_free_exec(void *addr) | ^ All three are weak functions that archs can override, although none do so currently. Provide prototypes for when a new arch provides its own. Signed-off-by: Valdis Kletnieks diff --git a/include/linux/bpf.h b/include

[PATCH] kernel/bpf/core.c - fix bitrotted kerneldoc.

2019-01-28 Thread valdis . kletnieks
Over the years, the function signature has changed, the kerneldoc block hasn't. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index 2a81b8af3748..2728b6247091 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c @@ -1216,8 +1216,9 @@

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Mon, 28 Jan 2019 09:18:45 -0800, Song Liu said: > On Sun, Jan 27, 2019 at 8:43 PM wrote: > > The attached patch silences the warnings, because we *know* we're > > overwriting > > the default initializer. That leaves bpf/core.c with only 6 other warnings, > > which become more visible in compa

Re: [PATCH] bpf/core.c - silence warning messages

2019-01-28 Thread valdis . kletnieks
On Tue, 29 Jan 2019 00:22:26 +0100, Daniel Borkmann said: > I think moving in separate file would be overkill, imho. However, lets get > the kdoc and prototype warning fixed. I have a bunch of spare time at the moment, so the kdoc and prototype warnings are on my to-do list.

[PATCH] bpf/core.c - silence warning messages

2019-01-27 Thread valdis . kletnieks
s, because we *know* we're overwriting the default initializer. That leaves bpf/core.c with only 6 other warnings, which become more visible in comparison. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile index 4c2fa3ac56f6..2606665f2cb5 100644 --- a

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-20 Thread valdis . kletnieks
On Tue, 20 Mar 2018 18:39:47 +0200, Liran Alon said: > What is your opinion in regards if it's OK to put the flag enabling this > "fix" in /proc/sys/net/core? Do you think it's sufficient? Umm.. *which* /proc/sys/net/core? These could differ for things that are in different namespaces. Or are yo

Re: linux-next: ip6tables *broken* - last base chain position %u doesn't match underflow %u (hook %u

2018-03-20 Thread valdis . kletnieks
On Tue, 20 Mar 2018 16:48:42 +0100, Florian Westphal said: > valdis.kletni...@vt.edu wrote: > > (Resending because I haven't heard anything) > [ ip6tables broken ] > > Sorry, did not see this email before. > > I'll investigate asap, thanks for the detailed report. No problem, it reverts cleanly a

linux-next: ip6tables *broken* - last base chain position %u doesn't match underflow %u (hook %u

2018-03-20 Thread valdis . kletnieks
(Resending because I haven't heard anything) Am hitting an issue with this commit: commit 0d7df906a0e78079a02108b06d32c3ef2238ad25 Author: Florian Westphal Date: Tue Feb 27 19:42:37 2018 +0100 netfilter: x_tables: ensure last rule in base chain matches underflow/policy This trips on my s

linux-next 20180307 - UBSAN whine in lib/radix-tree.c

2018-03-12 Thread valdis . kletnieks
Seen in the dmesg: [0.00] [0.00] UBSAN: Undefined behaviour in lib/radix-tree.c:123:14 [0.00] member access within null pointer of type 'const struct radix_tree_node' [0.00] CPU: 0 PI

ip6tables - last base chain position %u doesn't match underflow %u (hook %u

2018-03-09 Thread valdis . kletnieks
Am hitting an issue with this commit: commit 0d7df906a0e78079a02108b06d32c3ef2238ad25 Author: Florian Westphal Date: Tue Feb 27 19:42:37 2018 +0100 netfilter: x_tables: ensure last rule in base chain matches underflow/policy This trips on my system: [ 64.402790] ip6_tables: last ba

IPv6 issue in next-20171102 - lockdep and BUG handling RA packet.

2017-11-06 Thread valdis . kletnieks
I've hit this 6 times now, across 3 boots: Nov 3 11:04:54 turing-police kernel: [ 547.814748] BUG: sleeping function called from invalid context at mm/slab.h:422 Nov 3 20:24:11 turing-police kernel: [ 60.093793] BUG: sleeping function called from invalid context at mm/slab.h:422 Nov 4 20:

Re: [PATCH v2] bpf: silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis . Kletnieks
On Sun, 31 Jul 2016 21:42:22 -0700, Alexei Starovoitov said: > and at least 2 other such patches for other files... > Is there a single warning where -Woverride-init was useful? > May be worth disabling this warning for the whole build? There's a few other cases that *aren't* the "define the arra

[PATCH v2] bpf: silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis Kletnieks
^~ kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]') Since they come from the way we intentionally build the table, silence that one specific warning. Signed-off-by: Valdis Kletnieks Version 2: Add bpf: subsystem tag to subject line diff --git a/kernel/bpf/Ma

[PATCH] silence warnings when building kernel/bpf/core.c with W=1

2016-07-31 Thread Valdis Kletnieks
^~ kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]') Since they come from the way we intentionally build the table, silence that one specific warning. Signed-off-by: Valdis Kletnieks diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile index eed911d091d

Re: [e1000_netpoll] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2016-07-28 Thread Valdis . Kletnieks
On Thu, 28 Jul 2016 09:45:12 +0200, Thomas Gleixner said: > On Tue, 26 Jul 2016, nick wrote: > > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index f42129d..e1830af 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Valdis . Kletnieks
On Mon, 11 Jul 2016 16:43:50 +0200, Bjørn Mork said: > Link: https://bugzilla.kernel.org/show_bug.cgi?id=121131 > Fixes: cc9da6cc4f56 ("ipv6: addrconf: use stable address generator for ARPHRD _NONE") > Reported-by: Valdis Kletnieks > Reported-by: Jonas Lippuner > Sugg

Re: [PATCH v2 net] ipv6: addrconf: fix Juniper SSL VPN client regression

2016-07-11 Thread Valdis . Kletnieks
On Mon, 11 Jul 2016 16:43:50 +0200, Bjørn Mork said: > And finally, Valdis and Jonas: could you please test this version too? It > works for me in my simulated setup, but I don't have the Juniper client > so I cannot verify that it actually solves the problem. The v1 patch worked. I'll be able t

linux-next: UBSAN whine and BUG in net/ipv4/fib_trie.c

2016-06-06 Thread Valdis Kletnieks
Seeing this in next-20160606 (next-20160530 is fine), does it ring any bells before I spend a long evening doing a bisect? The Google doesn't seem to have seen this traceback in the past week [ 226.938222] [ 2

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-24 Thread Valdis . Kletnieks
On Sun, 24 Apr 2016 14:00:17 -0700, Eric Dumazet said: > On Sun, 2016-04-24 at 15:56 -0400, valdis.kletni...@vt.edu wrote: > > On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > > > > > >>> + return !debug_locks || > > > >>> +lockdep_is_held(&sk->sk_lock) || > > > > > Issue he

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-24 Thread Valdis . Kletnieks
On Sun, 24 Apr 2016 12:46:42 -0700, Eric Dumazet said: > >>> + return !debug_locks || > >>> +lockdep_is_held(&sk->sk_lock) || > Issue here is that once lockdep detected a problem (not necessarily in > net/ tree btw), your helper always 'detect' a problem, since lockdep > automatically dis

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-21 Thread Valdis . Kletnieks
On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: > Hi, > > On Thu, Apr 21, 2016, at 02:30, Valdis Kletnieks wrote: > > linux-next 20160420 is whining at an incredible rate - in 20 minutes of > > uptime, I piled up some 41,000 hits from all over the place (clean

IPv6 patch mysteriously breaks IPv4 VPN

2016-04-20 Thread Valdis Kletnieks
I'll say up front - no, I do *not* have a clue why this commit causes this problem - it makes exactly zero fsking sense. Scenario: $WORK is blessed with a Juniper VPN system. I've been seeing for a while now (since Dec-ish) an issue where at startup, the tun0 device will get wedged. ifconfig re

linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-20 Thread Valdis Kletnieks
linux-next 20160420 is whining at an incredible rate - in 20 minutes of uptime, I piled up some 41,000 hits from all over the place (cleaned up to skip the CPU and PID so the list isn't quite so long): % grep include/net/sock.h /var/log/messages | cut -f5- -d: | sed -e 's/PID: [0-9]* /PID: (elid

Re: next-20151207 - crash in IPv6 code

2015-12-08 Thread Valdis . Kletnieks
On Tue, 08 Dec 2015 12:34:09 +0100, Florian Westphal said: > Valdis Kletnieks wrote: > > [ CC Pablo ] > > > Seen this in 2 boots out of two on next-20151207 when IPV6 networking > > was available. It was stable when no net was available. Also, > > next-20161127

next-20151207 - crash in IPv6 code

2015-12-07 Thread Valdis Kletnieks
Seen this in 2 boots out of two on next-20151207 when IPV6 networking was available. It was stable when no net was available. Also, next-20161127 is OK. Haven't bisected it yet - this ring any bells? [ 92.231022] BUG: unable to handle kernel NULL pointer dereference at (null) [ 92

e1000e driver - commit 37b12910 needs to be in Linus tree..

2015-08-18 Thread Valdis Kletnieks
Hate to bother everybody, but we're at -rc7.. Commit 83129b37ef is still in Linus's tree. This one causes a crash on my Dell Latitude after 4 hours uptime. commit 83129b37ef35bb6a7f01c060129736a8db5d31c4 Author: Yanir Lubetkin Date: Tue Jun 2 17:05:45 2015 +0300 e1000e: fix systim issues

next-20150714 - busted IPv6 source address selection...

2015-07-14 Thread Valdis Kletnieks
next-20150714 w/ one ethernet commit reverted. -0706 w/ same revert works. "ip addr show" for the wireless says: 5: wlp3s0b1: mtu 1500 qdisc fq_codel state UP group default qlen 1000 link/ether bc:85:56:1f:4f:6d brd ff:ff:ff:ff:ff:ff inet 172.30.42.75/27 brd 172.30.42.95 scope global dy

Re: [PATCH v2] add stealth mode

2015-07-06 Thread Valdis . Kletnieks
On Thu, 02 Jul 2015 10:56:01 +0200, Matteo Croce said: > Add option to disable any reply not related to a listening socket, > like RST/ACK for TCP and ICMP Port-Unreachable for UDP. > Also disables ICMP replies to echo request and timestamp. > The stealth mode can be enabled selectively for a singl

e1000e driver - hang after 4 hours of uptime - finally bisected!

2015-06-18 Thread Valdis Kletnieks
(follow up to a report from last week - bisecting took a while as I could only do 1 or 2 tests an evening) My Dell Latitude E6530 crashes with a specific kernel lockup almost exactly 4 hours after boot if there isn't a cable connected to the Ethernet port: [14508.846327] Kernel panic - not syncin

Re: next-20150610 - repeated hangs at e1000e_phc_gettime+0x2e/0x60

2015-06-12 Thread Valdis . Kletnieks
On Thu, 11 Jun 2015 22:57:48 -0400, Valdis Kletnieks said: > 0) next-20150603 works, so the problem landed in linux-next in the last week. > > 1) All 3 times happened while I was at home, using wireless, so > the interface didn't have link and was ifconfig'ed down. All

next-20150610 - repeated hangs at e1000e_phc_gettime+0x2e/0x60

2015-06-11 Thread Valdis Kletnieks
I'm seeing repeated hard lockups on my Dell Latitude E6530. Helpful info: 0) next-20150603 works, so the problem landed in linux-next in the last week. 1) All 3 times happened while I was at home, using wireless, so the interface didn't have link and was ifconfig'ed down. 2) Remarkably similar t

Re: tbench regression in 2.6.25-rc1

2008-02-18 Thread Valdis . Kletnieks
On Mon, 18 Feb 2008 16:12:38 +0800, "Zhang, Yanmin" said: > I also think __refcnt is the key. I did a new testing by adding 2 unsigned > long > pading before lastuse, so the 3 members are moved to next cache line. The > performance is > recovered. > > How about below patch? Almost all performan

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > > http://git.infradead.org/?p=users/pcmoore/lblnet-2.6_testing;a=commitdiff;h=02f1c89d6e36507476f78108a3dcc78538be460b Initial testing indicates that 2.6.24-rc6-mm1 plus this one commit is behaving itself correctly - my Tcl test case that reliab

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 14:07:46 EST, Paul Moore said: > There have been quite a few changes in lblnet-2.6_testing since > 2.6.24-rc6-mm1 > so I would recommend taking the whole tree. I'm also not quite sure if Weird. I did a 'git clone git://git.infradead.org/users/pcmoore/lblnet-2.6_testing' in

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 13:22:10 EST, [EMAIL PROTECTED] said: > Apparently the only new commit in there since the tree that was in > 24-rc6-mm1 is 5d95575903fd3865b884952bd93c339d48725c33 adding some warning > printk's. Would it be more productive to test against the full tree, or > leaving out the on

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 13:05:48 EST, [EMAIL PROTECTED] said: > I'm pulling git://git.infradead.org/users/pcmoore/lblnet-2.6_testing at the > moment, and seeing if there's already a fix in there for this. Apparently the only new commit in there since the tree that was in 24-rc6-mm1 is 5d95575903fd38

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Mon, 14 Jan 2008 11:36:40 EST, Paul Moore said: > Are you still only seeing these problems on loopback? I can't help but > wonder > if this is the skb_clone() problem where it wasn't copying skb->iif causing > SELinux to silently drop the packets. Yes, I've only spotted it on loopback. Th

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-14 Thread Valdis . Kletnieks
On Sun, 13 Jan 2008 02:35:33 EST, [EMAIL PROTECTED] said: > I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail is > listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject mail it > has just fetched from an outside server via IMAP - it will often just hang and >

2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-12 Thread Valdis . Kletnieks
I'm seeing problems with Sendmail on 24-rc6-mm1, where the main Sendmail is listening on ::1/25, and Fetchmail connects to 127.0.0.1:25 to inject mail it has just fetched from an outside server via IMAP - it will often just hang and not make any further progress. Looking at netstat shows something

2.6.24-rc5-mm1 - IPv6 throws section mismatches.

2007-12-18 Thread Valdis . Kletnieks
On Thu, 13 Dec 2007 02:40:50 PST, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc5/2.6.24-rc5-mm1/ git-net.patch (I'm guessing one of Daniel's commits, but not sure which one) causes some complaints: LD vmlinux.o MODPOST vmlinux.o WARNING: v

Re: namespace support requires network modules to say "GPL"

2007-12-02 Thread Valdis . Kletnieks
On Sun, 02 Dec 2007 13:51:04 GMT, Alan Cox said: > On Sat, 1 Dec 2007 16:30:35 -0800 > > I spoke too soon earlier, ndiswrapper builds and loads against current > > 2.6.24-rc3. Vmware and proprietary VPN software probably do not. Once again > > I don't > > give a damn, but the enterprise distro ven

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Valdis . Kletnieks
On Tue, 27 Nov 2007 22:09:42 +0100, Adrian Bunk said: > Are there common reasons why these drivers are not upstream? Well, on my laptop, I'm currently dragging along 3 out-of-tree kernel modules. 2 are well-known binary blobs so it's between me and the vendor, as usual. The third is a USB webcam

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

2007-11-27 Thread Valdis . Kletnieks
On Tue, 27 Nov 2007 13:34:57 PST, Michael Chan said: > Ideally, the BIOS should modify the NVRAM's setting when it is changed. > We will talk to Dell to get their opinion on this as this is very > confusing to the user. That would certainly explain what I'm seeing, and I can certainly wait if the

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-27 Thread Valdis . Kletnieks
On Tue, 27 Nov 2007 15:12:42 +0100, Andi Kleen said: > > OK, short of making IPv4 a module (which would be a worthy task :) > > At some point there were patches, it is probably not very difficult. > But DaveM resisted at some point because he didn't want people > to replace the network stack (alth

Re: 2.6.23-mm1 tg3 wake-on-lan oddity...

2007-11-27 Thread Valdis . Kletnieks
On Tue, 27 Nov 2007 08:04:28 PST, Michael Chan said: > [EMAIL PROTECTED] wrote: > > > (a) the Dell factory default is WOL disabled and (b) > > if it wasn't > > the default, I'd have *set* it to disabled, and (c) I even > > went back and > > rebooted and checked the BIOS setting - disabled. Nonethe

2.6.23-mm1 tg3 wake-on-lan oddity...

2007-11-27 Thread Valdis . Kletnieks
Scenario - Dell Latitude D820 laptop, tg3 driver says this at boot: eth0: Tigon3 [partno(BCM5752KFBG) rev 6002 PHY(5752)] (PCI Express) 10/100/1000Base-T Ethernet 00:15:c5:c8:33:4e eth0: RXcsums[1] LinkChgREG[0] MIirq[0] ASF[0] WireSpeed[1] TSOcap[1] eth0: dma_rwctrl[7618] dma_mask[64-bit] #

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-20 Thread Valdis . Kletnieks
On Sun, 21 Oct 2007 07:31:58 +0300, Al Boldi said: > > Well, for example to stop any transient packets being forwarded. You could > > probably hack around this using mark's, but you can't stop the implied > > route lookup, unless you stop it in prerouting. > > Basically, you have one big uninten

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-19 Thread Valdis . Kletnieks
On Sat, 20 Oct 2007 06:40:02 +0300, Al Boldi said: > Sure, the idea was to mark the filter table obsolete as to make people start > using the mangle table to do their filtering for new setups. The filter > table would then still be available for legacy/special setups. But this > would only be

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 20:18:06 BST, Denys Vlasenko said: > On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: > > Should this be redone to use the existing firmware loading framework to > > load the firmware instead? > > Not in every case. > > For example, bnx2 maintainer says that driver

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: > I plan to use gzip compression on following drivers' firmware, > if patches will be accepted: > >textdata bss dec hex filename > 17653 109968 240 127861 1f375 drivers/net/acenic.o >6628 120448 4 127

Re: follow-up: discrepancy with POSIX

2007-09-19 Thread Valdis . Kletnieks
On Wed, 19 Sep 2007 11:38:57 PDT, Rick Jones said: > One has to set their way-back machine pretty far back to find the *BSD > bits which used 0.0.0.0 as the "all nets, all subnets" (to mis-use a > term) broadcast IPv4 address when sending. Perhaps as far back as the > time before HP-UX 7 or Su

Re: [PATCH]: xfrm audit calls

2007-09-12 Thread Valdis . Kletnieks
On Tue, 11 Sep 2007 19:03:14 CDT, Joy Latten said: > This patch modifies the current ipsec audit layer > by breaking it up into purpose driven audit calls. > > So far, the only audit calls made are when add/delete > an SA/policy. What other audit calls do you envision adding in the future? pgpGA

Re: That whole "Linux stealing our code" thing

2007-09-01 Thread Valdis . Kletnieks
On Sun, 02 Sep 2007 01:09:18 EDT, "Constantine A. Murenin" said: > The idea here is that no patching was needed in the first place -- > most of the files are/were BSD-licensed, because they were forked from > OpenBSD. Oh, silly me. For some reason, I had it in my head that Jiri's original patch

Re: That whole "Linux stealing our code" thing

2007-09-01 Thread Valdis . Kletnieks
On Sun, 02 Sep 2007 03:55:37 +0200, Adrian Bunk said: > Jiri's patch would have wrongly not only removed the BSD statement from > dual licenced files but also from not dual licenced files. > > This was a mistake in this patch (that was never merged into the tree) > neither Jiri nor Alan noticed

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-29 Thread Valdis . Kletnieks
On Tue, 28 Aug 2007 18:11:55 BST, Christoph Hellwig said: > On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: > > ath5k, license is GPLv2 > > > > The files are available only under GPLv2 since now. > > Is this really a good idea? Most of the reverse-engineering was > done by the OpenBS

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Valdis . Kletnieks
On Tue, 21 Aug 2007 09:16:43 PDT, "Paul E. McKenney" said: > I agree that instant gratification is hard to come by when synching > up compiler and kernel versions. Nonetheless, it should be possible > to create APIs that are are conditioned on the compiler version. We've tried that, sort of. Se

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Valdis . Kletnieks
On Sat, 11 Aug 2007 02:38:40 +0200, Segher Boessenkool said: > >> That means GCC cannot compile Linux; it already optimises > >> some accesses to scalars to smaller accesses when it knows > >> it is allowed to. Not often though, since it hardly ever > >> helps in the cost model it employs. > > > >

Re: [2.6 patch] cleanup congestion control options

2007-07-13 Thread Valdis . Kletnieks
On Sat, 14 Jul 2007 06:09:54 +0200, Adrian Bunk said: > This patch contains the following cleanups: > - note in the prompt if an option depends on EXPERIMENTAL Who decided whether a particular option is 'experimental' or not? Lawrence S. Brakmo and Larry L. Peterson. TCP Vegas: end to end congest

Re: [dm-devel] Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-13 Thread Valdis . Kletnieks
On Thu, 12 Jul 2007 19:00:59 PDT, Mike Anderson said: > No, all admin tools and interfaces function as they do today. The > dm-netlink patch series only contains 9 deletions (actual just one true > deletion of existing kernel code the others are due to break up of the > patch into compilable chunk

2.6.22-rc3-mm1 - pppd hanging in netdev_run_todo while holding mutex

2007-06-04 Thread Valdis . Kletnieks
On Wed, 30 May 2007 23:58:23 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc3/2.6.22-rc3-mm1/ Under 22-rc2-mm1, if my VPN connection got reset, ppp0 just quietly went away. Under 22-rc3-mm1, it seems to end up wedged and waiting for references to

Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-03-08 Thread Valdis . Kletnieks
On Thu, 08 Mar 2007 22:48:29 GMT, David Howells said: > > diff --git a/include/linux/crypto.h b/include/linux/crypto.h > index 779aa78..ce092fe 100644 > --- a/include/linux/crypto.h > +++ b/include/linux/crypto.h > @@ -40,7 +40,10 @@ > #define CRYPTO_ALG_LARVAL0x0010 > #define CR

Re: Network drivers that don't suspend on interface down

2006-12-21 Thread Valdis . Kletnieks
On Wed, 20 Dec 2006 22:06:51 EST, Dan Williams said: > It's also complicated because some switches are supposed to rfkill both > an 802.11 module _and_ a bluetooth module at the same time, or I guess > some laptops may even have one rfkill switch for each wireless device. On my Dell D820, it's bio

Re: [PATCH 1/5] remove TxStartThresh and RxEarlyThresh

2006-10-15 Thread Valdis . Kletnieks
On Mon, 16 Oct 2006 07:26:37 +1000, Benjamin Herrenschmidt said: > Somebody patented FIFO thresholds ? Gack ? The US PTO is fundamentally busticated. http://www.engadget.com/2006/10/14/cisco-patents-the-triple-play/ Cisco got a patent on the concept of delivering voice, internet, and cable TV ov

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-02 Thread Valdis . Kletnieks
On Mon, 02 Oct 2006 10:52:45 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > % grep ioctl /tmp/foo2 | sort -u | more > > > ioctl(13, SIOCGIWESSID, 0xbfbcdb9c) = 0 > > > ioctl(13, SIOCGIWRANGE, 0xbfbc

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-30 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 23:31:07 EDT, [EMAIL PROTECTED] said: > Fair enough, I'm going to try reverting the 2 commits and see if things > behave better. OK, it's definitely something in those 2 commits - I reverted them and the resulting 2.6.18-mm2 kernel has been up and stable for 4 hours, even with

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:33:48 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > Here's the traceback I got: > > > > > > slab error in verify_redzone_free(): cache `size-32': memory outside > > > object wa

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 18:40:43 PDT, Jean Tourrilhes said: > On Fri, Sep 29, 2006 at 06:20:08PM -0700, Andrew Morton wrote: > > On Fri, 29 Sep 2006 20:01:54 -0400 > > > > > > A quick strace of gkrellm finds these likely ioctl's causing the problem: > > > > > > % grep ioctl /tmp/foo2 | sort -u | more

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-09-29 Thread Valdis . Kletnieks
On Fri, 29 Sep 2006 12:45:58 PDT, Andrew Morton said: (Adding a bunch of people to the cc: list now that I have a clue what is going on) > I'd expect it's the same bug - slab data structures have gone bad. *bing*! We have a winner. A quick check showed the kernel wasn't built with slab debu

Re: [PATCH 00/03][RESUBMIT] net: EtherIP tunnel driver

2006-09-24 Thread Valdis . Kletnieks
On Sat, 23 Sep 2006 15:27:36 +0200, Joerg Roedel said: > (I assume you are speaking of the position of the 3 in the header). The > RFC is not clear at this point. It defines that the first 4 bits in the > 16 bit Ethernet header MUST be 0011. But it don't defines the > byteorder of that 16 bit word

Re: 2.6.18-rc7-mm1: networking breakage on HPC nx6325 + SUSE 10.1

2006-09-19 Thread Valdis . Kletnieks
On Tue, 19 Sep 2006 23:30:34 +0200, "Rafael J. Wysocki" said: > Well, I can configure the interfaces manually, with ifconfig, but the SUSE's > configuration tools don't work. For example, "ifup eth0" tells me that > "No configuration found for eth0" and that's all. I'm seeing issues on a Dell La

Re: Fw: 2.6.18-rc4-mm3: BUG: warning at include/net/dst.h:154/dst_release()

2006-08-29 Thread Valdis . Kletnieks
On Tue, 29 Aug 2006 20:24:33 +0200, Thomas Graf said: > > Seeing this a lot on 2.6.18-rc4-mm3 with 2 different stack tracebacks > > (one for received packets, other for sending). I already picked up the > > fix for the ^ / confusion in fib_rules.c and that didn't help matters. > > Should be fixe

2.6.18-rc3-mm2 - BUG in rt6_lookup() from ipv6_del_addr()

2006-08-10 Thread Valdis . Kletnieks
On Sun, 06 Aug 2006 03:08:09 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/ After applying the patch that Patrick McHardy pointed me at, it lived longer. However, I'm now seeing problems at system shutdown (or anytime you try to

Re: 2.6.18-rc3-mm2 - IPV6_MULTIPLE_TABLES borked....

2006-08-10 Thread Valdis . Kletnieks
On Thu, 10 Aug 2006 22:02:03 +0200, Patrick McHardy said: > [EMAIL PROTECTED] wrote: > > On Sun, 06 Aug 2006 03:08:09 PDT, Andrew Morton said: > > > >>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/ > > > > > > Building a kernel with IPV6_MULTIPLE_TABLES

Re: 2.6.18-rc3-mm2 - IPV6_MULTIPLE_TABLES borked....

2006-08-10 Thread Valdis . Kletnieks
On Sun, 06 Aug 2006 03:08:09 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/ Building a kernel with IPV6_MULTIPLE_TABLES=y breaks my IPv6 connectivity quite badly. It basically totally refuses to answer an IPv6 Neighbor Solicit p

Re: [PATCH 0/7] Updated patchset w/James' comments

2006-07-17 Thread Valdis . Kletnieks
On Mon, 17 Jul 2006 11:52:24 EDT, [EMAIL PROTECTED] said: > Some changes in the patchset based on James Morris' comments over the > weekend, in > addition I rebased the patchset against 2.6.18-rc2. Minor comment - can you start posting these with Subject: lines that say something like: Subject:

Re: 2.6.18-rc1-mm1 - VPN chewing CPU like crazy..

2006-07-11 Thread Valdis . Kletnieks
On Mon, 10 Jul 2006 23:19:39 PDT, Andrew Morton said: > > Any suggestions/hints (besides rebuilding the implicated .ko with debugging > > symbols so oprofile can be more granular - that's already on the to-do > > list)? > > > > I'd suggest you whack sysrq-T 5-10 times when it happens, capture a

Re: Router stops routing after changing MAC Address

2006-03-14 Thread Valdis . Kletnieks
On Mon, 13 Mar 2006 17:35:50 EST, "linux-os (Dick Johnson)" said: > Bst... Not! There are not any MAC addresses associated with any > of the intercity links, usually not even in WANs! MAC is for > Ethernet! Once you go to fiber, ATM, T-N, etc., there are no > MAC addresses. This will come as