Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

2019-02-19 Thread Vaishali Thakkar
On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: > Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course, you're very much encouraged to contribute to other

Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

2016-08-18 Thread Vaishali Thakkar
On Friday 19 August 2016 09:37 AM, David Miller wrote: > From: Pavel Andrianov > Date: Tue, 16 Aug 2016 16:39:06 +0300 > >> smc_reset may be executed in parallel with timer function media_check. >> To avoid data race in smc_set_xcvr a spinlock was added. >> >> Found by Linux Driver Verification

Re: [PATCH] wl3501_cs: Add spinlock to wl3501_reset

2016-08-03 Thread Vaishali Thakkar
ock into the wl3501_reset and removes it from > wl3501_tx_timeout. > > Found by Linux Driver Verification project (linuxtesting.org) > > Signed-off-by: Pavel Andrianov Acked-by: Vaishali Thakkar > --- > drivers/net/wireless/wl3501_cs.c | 7 +++ > 1 file changed, 3 ins

Re: [ldv-project] [net] rtl8188ee: a potential race condition

2016-06-24 Thread Vaishali Thakkar
On Friday 10 June 2016 01:51 PM, Pavel Andrianov wrote: > Hi! > > There is a potential data race in > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rtl8188ee.ko. > > In the function rtl88ee_gpio_radio_on_off_checking the flag > ppsc->rfchange_inprogress is set with a spinlock protection. In

Re: [PATCH] libertas: Add spinlock to avoid race condition

2016-06-15 Thread Vaishali Thakkar
c3. > > Confirmed that lbs_mac_event_disconnected is being called on the > station when hostapd on access point is given SIGHUP. > > Signed-off-by: Pavel > Tested-by: James Cameron Looks good to me. Acked-by: Vaishali Thakkar > --- > drivers/net/wireless/marvell/libert

[PATCH] net: fjes: Use resource_size

2016-04-11 Thread Vaishali Thakkar
Use the function resource_size instead of explicit computation. Problem found using Coccinelle. Signed-off-by: Vaishali Thakkar --- drivers/net/fjes/fjes_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index

Re: [PATCH net-next 2/3] qeth: Convert use of __constant_htons to htons

2015-08-20 Thread Vaishali Thakkar
On Thu, Aug 20, 2015 at 11:28 PM, David Miller wrote: > From: Ursula Braun > Date: Thu, 20 Aug 2015 15:53:42 +0200 > >> qeth is an s390-driver, and s390 is a big-endian architecture. Thus >> arguments valid for little-endian do not apply to qeth-code. > > You can not throw out generally good tree

[PATCH] neterion: s2io: Use module_pci_driver

2015-07-08 Thread Vaishali Thakkar
; declarer name module_exit; declarer name module_pci_driver; @@ -module_exit(e); +module_pci_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/neterion/s2io.c | 26 +- drivers/net/ethernet/neterion/s2io.h | 2 -- 2 files changed, 1 insertion(+), 27 delet

[PATCH] net: systemport: Use eth_hw_addr_random

2015-07-07 Thread Vaishali Thakkar
off-by: Vaishali Thakkar --- Note that this patch is compile tested only and I have used file drivers/net/ethernet/hisilicon/hix5hd2_gmac.c as a reference. Also, original call didn't make assignment to NET_ADDR_RANDOM. So, it would be good if someone can test this change. --- drivers/net/

[PATCH] net: ec_bhf: Use module_pci_driver

2015-07-07 Thread Vaishali Thakkar
le_pci_driver; @@ -module_exit(e); +module_pci_driver(x); Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/ec_bhf.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c index d101750..f7b4248 100644 --- a/dri

[PATCH] atm: idt77105: Use setup_timer

2015-06-09 Thread Vaishali Thakkar
... when != a = e2 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/atm/idt77105.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/atm/idt77105.c b/drivers/atm/idt77105.c index 909c95b..feb023d 100644 --- a/drivers/atm/idt77105.c +++ b/drivers/atm/id

[PATCH] net: rose: Use mod_timer

2015-06-05 Thread Vaishali Thakkar
= e4 - add_timer (&e1); + mod_timer (&e1, e2); Signed-off-by: Vaishali Thakkar --- net/rose/rose_link.c | 16 net/rose/rose_loopback.c | 6 +- net/rose/rose_timer.c| 30 +- 3 files changed, 10 insertions(+), 42 deletions(-) diff --gi

[PATCH] isdn/hisax: Convert use of __constant_cpu_to_le16 to cpu_to_le16

2015-06-05 Thread Vaishali Thakkar
definition of __constant_cpu_to_le16 completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_cpu_to_le16(x) + cpu_to_le16(x) Signed-off-by: Vaishali Thakkar --- drivers/isdn/hisax/st5481_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] xen-netfront: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
-e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar --- drivers/net/xen-netfront.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 3f45afd..10a087a 100644 --- a/drivers/net/xen-netfront.c +++ b

[PATCH] ethernet/intel: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
e1, a, b); ... when != a = e2 when != b = e3 -e1.function = a; ... when != b = e4 -e1.data = b; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/intel/e100.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/in

[PATCH] net: dl2k: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
e1, a, b); ... when != a = e2 when != b = e3 -e1.data = b; ... when != a = e4 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/dlink/dl2k.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethern

[PATCH] net: mv643xx_eth: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
-e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar --- drivers/net/ethernet/marvell/mv643xx_eth.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 1c75829.

[PATCH] isdn/capi: Use setup_timer

2015-05-31 Thread Vaishali Thakkar
e1, a, b); ... when != a = e2 when != b = e3 -e1.data = b; ... when != a = e4 -e1.function = a; Signed-off-by: Vaishali Thakkar --- drivers/isdn/capi/capidrv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index