On Fri, Sep 16, 2016 at 2:21 PM, Anton Aksola wrote:
> Ok, I will post a new patch version. Should tests be posted in a separate
> patch?
>
> 2016-09-16 12:44 GMT+03:00 Nicolas Dichtel :
>>
>> Le 16/09/2016 à 11:23, Vadim Kochan a écrit :
>> [snip]
>> >
; $ cat test.batch
> netns add foo
> netns set foo 1234
> netns list-id
>
> Before your patch:
> $ ip -b test.batch
> nsid 1234 (iproute2 netns name: foo)
>
> After your patch:
> $ ip -b test.batch
> nsid 1234
Would it be useful to add test for this case into testsuite/ ?
Regards,
Vadim Kochan
e
used for 'ip addr' too.
> Cc: Vadim Kochan
> Signed-off-by: Phil Sutter
> ---
> ip/ipaddress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index df363b070d5de..1b5ee838ef3fe 100644
> --- a/ip/ipad
'-l' to 'state listen', '-f
> inet' to 'src inet:*' and pass everything ANDed together to
> ssfilter_parse(). Or maybe that would make things even worse. ;)
>
> Cheers, Phil
I thought I fixed & tested well ss filter, but seems it would be good to
have good automation testing.
Regards,
Vadim Kochan
On Thu, Oct 15, 2015 at 08:13:23PM -0700, roopa wrote:
> On 10/15/15, 7:38 PM, David Ahern wrote:
> > Hi Roopa:
> >
> > On 10/15/15 4:23 PM, Roopa Prabhu wrote:
> >> From: Roopa Prabhu
> >>
> >> replace exit with return -2 on rtnl_talk failure
> >>
> >> Signed-off-by: Roopa Prabhu
> >> ---
> >>
From: Vadim Kochan
Changed HRB -> HTB.
Signed-off-by: Vadim Kochan
---
man/man8/tc-htb.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/tc-htb.8 b/man/man8/tc-htb.8
index d196ecd..95f25de 100644
--- a/man/man8/tc-htb.8
+++ b/man/man8/tc-htb.8
@@ -48,7 +4
From: Vadim Kochan
Add check for Berkeley DB header & lib before compile arpd util.
Signed-off-by: Vadim Kochan
---
configure | 29 +++--
misc/Makefile | 6 +-
2 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 3ae
etdev" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wilhelm,
You can use 'name' before 'hel' like:
$ ip tun add name hel mode sit remote 10.200.0.2 local 10.200.1.2 ttl 255
a
On Wed, Aug 26, 2015 at 04:27:48PM +0100, Jeremy Harris wrote:
> On 17/08/15 20:22, Vadim Kochan wrote:
> > +.BR reorder_hdr " is " on
> > +then VLAN header will be not inserted immediately but only before passing
> > to the
> > +physical device (if this de
From: Vadim Kochan
Signed-off-by: Vadim Kochan
---
man/man8/ip-link.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 1896eb6..4928249 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -327,7 +327,7
02/ at 12
filter parent 1: protocol ip pref 5 u32 fh 800: ht divisor 1
Some additional info:
# tc -V
tc utility, iproute2-ss150413
# uname -a
Linux angus-think 4.0.4-2-ARCH #1 SMP PREEMPT Fri May 22 03:05:23 UTC 2015
x86_64 GNU/Linux
Regards,
Vadim Kochan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Vadim Kochan
Add little more info about how to manually set priority by iptables,
and some little clarifications about ingress/egress QoS mapping.
Signed-off-by: Vadim Kochan
---
man/man8/ip-link.8.in | 27 ---
1 file changed, 24 insertions(+), 3 deletions
rd...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Describe issue & send it to the netdev@vger.kernel.org and probably +CC to:
Stephen Hemminger
I assume this is an issue related to tc hash filters which you described
in LARTC maling
From: Vadim Kochan
Add more explanation about VLAN reordering and what it affects.
Signed-off-by: Vadim Kochan
---
man/man8/ip-link.8.in | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index
From: Vadim Kochan
Really by default ss dumps not only TCP sockets but any kind of socket
which is in ESTABLISHED state (TCP/UDP/UNIX).
Signed-off-by: Vadim Kochan
Reported-by: Miha Marolt
---
man/man8/ss.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ss.8 b
From: Vadim Kochan
It really partially reverts:
ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct)
but adds few fields (name & peer_name) from removed unixstat to sockstat struct
to easy
return original code.
Fixes: ec4d0d8a9def35 (ss: Replace unixstat struct by
On Mon, Jul 20, 2015 at 01:43:40PM -0700, Stephen Hemminger wrote:
> On Mon, 20 Jul 2015 22:46:23 +0300
> Vadim Kochan wrote:
>
> > + if (s->name)
> > + free(s->name);
>
> Please don't add unnecessary conditional.
> free(NU
From: Vadim Kochan
It really partially reverts:
ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct)
but adds few fields (name & peer_name) from removed unixstat to sockstat struct
to easy
return original code.
Fixes: ec4d0d8a9def35 (ss: Replace unixstat struct by
On Wed, Jul 15, 2015 at 09:57:51PM +0300, Vadim Kochan wrote:
> On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote:
> > > On Jul 15, 2015, at 9:49 AM, Rustad, Mark D
> > > wrote:
> > >
> > >> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wro
On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote:
> > On Jul 15, 2015, at 9:49 AM, Rustad, Mark D wrote:
> >
> >> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wrote:
> >> Would you please check this fix ?
> >>
> >> diff --git a/m
On Wed, Jul 15, 2015 at 04:09:03PM +0200, Marc Dietrich wrote:
> Hi,
>
> ss -p segfaults here with some kind of memory corruption:
>
> *** Error in `/work/iproute2/misc/ss': free(): invalid pointer:
> 0x00623000 ***
> === Backtrace: =
> /lib64/libc.so.6(+0x71c6d)[0x77885c
On Wed, Jul 15, 2015 at 04:09:03PM +0200, Marc Dietrich wrote:
> Hi,
>
> ss -p segfaults here with some kind of memory corruption:
>
> *** Error in `/work/iproute2/misc/ss': free(): invalid pointer:
> 0x00623000 ***
> === Backtrace: =
> /lib64/libc.so.6(+0x71c6d)[0x77885c
On Fri, Jul 10, 2015 at 09:09:46AM +0200, Miha Marolt wrote:
>
>
> On 07/09/2015 05:15 PM, Vadim Kochan wrote:
> >On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote:
> >>
> >>On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote:
> >>>On 07/09/20
On Thu, Jul 09, 2015 at 05:21:10PM +0200, Eric Dumazet wrote:
> On Thu, 2015-07-09 at 17:14 +0200, Eric Dumazet wrote:
>
> >
> > If I checkout iproute2 tree to db08bdb816d337102c5486744008db9c9faa43bf
> > (before buggy commit) we indeed had this result :
> >
> > # ./ss -an | grep 127.0.0.1
> > r
On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote:
>
>
> On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote:
> >On 07/09/2015 04:55 PM, Vadim Kochan wrote:
> >>On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote:
> >>>On 07/09/2015 0
On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote:
> On 07/09/2015 04:13 PM, Miha Marolt wrote:
> > Hi!
> >
> > I hope this is the right place to reports bugs. I apologize if it isn't.
> >
> > I have written a C program (see below for source code) that opens a raw
> > socket on
From: Vadim Kochan
Added possibility to check command output by grep from the testing
script.
Now TMP_OUT & TMP_ERR are passed from Makefile and changed to
STD_ERR & STD_OUT.
Also changed some existing tests to make output testing.
Signed-off-by: Vadim Kochan
---
testsuite/
From: Vadim Kochan
Used 16 char array for cong alg name instead of malloc.
Fixes: 8250bc9ff4e5 ("ss: Unify inet sockets output")
Reported-by: Jose R. Guzman Mosqueda
Signed-off-by: Vadim Kochan
---
v2:
Used 16 byte array for cong alg name instead of malloc
suggested by Er
On Fri, May 29, 2015 at 04:04:05AM -0700, Eric Dumazet wrote:
> On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote:
> > From: Vadim Kochan
> >
> > Use strdup instead of malloc, and get rid of bad strcpy.
> >
> > Signed-off-by: Vadim Kochan
> > ---
>
From: Vadim Kochan
Use strdup instead of malloc, and get rid of bad strcpy.
Signed-off-by: Vadim Kochan
---
misc/ss.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 347e3a1..a719466 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1908,8 +1908,7
From: Vadim Kochan
Indicate existence of libmnl which is required by tipc.
Signed-off-by: Vadim Kochan
---
configure | 16
1 file changed, 16 insertions(+)
diff --git a/configure b/configure
index f1325df..1605464 100755
--- a/configure
+++ b/configure
@@ -284,6 +284,17
Hi Jose,
On Thu, May 28, 2015 at 09:12:15PM +, Guzman Mosqueda, Jose R wrote:
>
> Hi all
>
> I'm Jose Guzman from a security team at Intel.
> We're using iproute2 in a GNU-Linux project and I'm analyzing the code
> to try to find possible issues/gaps/risks.
> Since I'm not too familiar with
From: Vadim Kochan
Remove double explanation of GROUP option from 'ip link set' section.
Signed-off-by: Vadim Kochan
---
man/man8/ip-link.8.in | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 823246f..714a
From: Vadim Kochan
Changed to forcely running each test in network
namespace to do not affect on current network setup.
Signed-off-by: Vadim Kochan
---
testsuite/Makefile | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testsuite/Makefile b/testsuite/Makefile
index
On Tue, Apr 28, 2015 at 03:22:33AM +0200, Mihai Moldovan wrote:
> Hi,
>
> Following up a bug report I received at
> http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=799 it looks like the current
> version iproute2's ss utility always returns an empty result set whenever
> specifying the -u flag.
>
On Tue, Apr 28, 2015 at 07:07:56AM +0200, Mihai Moldovan wrote:
> On 28.04.2015 06:47 AM, Vadim Kochan wrote:
> > On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote:
> >> On 28.04.2015 06:05 AM, Vadim Kochan wrote:> So by default ss prints
> >> socket wit
On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote:
> On 28.04.2015 06:05 AM, Vadim Kochan wrote:> So by default ss prints socket
> with
> CONNECTED state and even UDP can be
> > in the CONNECTED state on the Linux,
>
> UDP can be in a CONNECTED state... oo
From: Vadim Kochan
Use correct handle buffer length.
Signed-off-by: Vadim Kochan
---
tc/tc_util.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/tc/tc_util.c b/tc/tc_util.c
index 1d3153d..dc2b70f 100644
--- a/tc/tc_util.c
+++ b/tc/tc_util.c
@@ -128,30
38 matches
Mail list logo
