Re: [RFC] af_packet: allow disabling timestamps

2007-09-27 Thread Unai Uribarri
On vie, 2007-09-14 at 12:26 +0200, Stephen Hemminger wrote: > On Thu, 13 Sep 2007 14:24:06 +0200 > Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > On Thu, 13 Sep 2007 12:42:53 +0200 > > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > > Currently, af_packet does not allow disabling timestamps.

Re: [RFC] af_packet: allow disabling timestamps

2007-09-27 Thread Unai Uribarri
This small modification to Stephen's patch timestamps the skb when needed, so the timestamp can be reused by other af_packet sockets. Signed-off-by: Unai Uribarri <[EMAIL PROTECTED]> --- a/net/core/sock.c +++ b/net/core/sock.c @@ -259,7 +259,8 @@ static void sock_disable_timestamp(

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Unai Uribarri
On vie, 2007-08-10 at 12:34 +0400, Evgeniy Polyakov wrote: > Hi Unai. > > On Thu, Aug 09, 2007 at 08:44:21PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > wrote: > > There is another option: > > > > 1. Move timestampt activation to packet_set_ring(), so it'

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
Do not enable timestamps automatically on mmap'ed AF_PACKET sockets. --- commit d1d6e6bf196e31b6306fd0fef95f4190983c8a86 tree 22637506c0aafeabfbe05faf5352d0358c4d9460 parent 6a302358d87fedaf7bda12b8e909265ebf1ce674 author Unai Uribarri <[EMAIL PROTECTED]> Tue, 31 Jul 2007 20:38:42 +020

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
mime multipart format and they were removed from the list archives. I can resent them in plain text if needed. On jue, 2007-08-09 at 22:18 +0400, Evgeniy Polyakov wrote: > On Thu, Aug 09, 2007 at 08:13:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > wrote: > > On jue, 2007-08-

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
On jue, 2007-08-09 at 18:33 +0400, Evgeniy Polyakov wrote: > On Thu, Aug 09, 2007 at 04:21:54PM +0200, Unai Uribarri ([EMAIL PROTECTED]) > wrote: > > The attached patch removes the automatic timestamp activation, that > > only mmap'ed AF_PACKET sockets perform. I

[PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-09 Thread Unai Uribarri
my packet capturing application. The attached patch removes the automatic timestamp activation, that only mmap'ed AF_PACKET sockets perform. I known it can break user applications, but I believe that it's the correct solution. I will be very pleased to receive any feedback. Signed-o

[PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-08 Thread Unai Uribarri
my packet capturing application. The attached patch removes the automatic timestamp activation, that only mmap'ed AF_PACKET sockets perform. I known it can break user applications, but I believe that it's the correct solution. I will be very pleased to receive any feedback. Signed-o

[PATCH] Inconsistent behaviour at AF_PACKET

2007-08-01 Thread Unai Uribarri
Hello folks, Timestamps should be usually requested explicitly by setting the SOL_SOCKET/SO_TIMESTAMP option to 1. But if you setup a reception ring with the SOL_PACKET/PACKET_RX_RING option, timestamps are automatically enabled at the next packet recepcion. I think that is a bug so I have writte

Disabling timestamps on AF_PACKET sockets

2007-07-31 Thread Unai Uribarri
Hello, I want to capture huge amounts of packets without timestamps, since the machine the program is running on has a very slow clock that only yields 200,000 timestamps per second and uses 70% of CPU. But tpacket_rcv reenables the timestamps every time it receives a packet at af_packet.c:643 if