Re: [PATCH] vio: make remove callback return void

2021-01-29 Thread Tyrel Datwyler
urns > calling this unconditionally is the consistent behaviour which is > implemented here. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Tyrel Datwyler > --- > Hello, > > note that this change depends on > https://lore.kernel.org/r/20210121062005.53271-1-...@lin

[PATCH] ibmveth: fix DMA unmap error in ibmveth_xmit_start error path

2018-12-31 Thread Tyrel Datwyler
24/0x490 __qdisc_run+0x20c/0x980 __dev_queue_xmit+0x1bc/0xf20 This fixes the API misuse by unampping descs[0] with dma_unmap_single. Fixes: 6e8ab30ec677 ("ibmveth: Add scatter-gather support") Cc: sta...@vger.kernel.org Signed-off-by: Tyrel Datwyler --- drivers/net/ethernet/ibm/ibmveth.c

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-02 Thread Tyrel Datwyler
nt my review. -Tyrel > > Thank you for your review, > > On 02/01/2018 07:02 PM, Tyrel Datwyler wrote: >> On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: >>> Older versions of VIOS servers do not send the firmware level in the VPD >>> buffer for

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Tyrel Datwyler
On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Therefore, > this pat

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

2017-08-31 Thread Tyrel Datwyler
On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz > Cc: Tyrel Datwyl

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

2017-08-31 Thread Tyrel Datwyler
On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz > Cc: Tyrel Datwyl

Re: [PATCH] ibmvnic: Fix unused variable warning

2017-08-09 Thread Tyrel Datwyler
On 08/09/2017 04:16 AM, Michal Suchanek wrote: > Fixes: a248878d7a1d ("ibmvnic: Check for transport event on driver resume") > > Signed-off-by: Michal Suchanek > --- Reviewed-by: Tyrel Datwyler