IRQ enabling in cpsw_ndo_open() where CPTS is
> actually started.
>
> Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq")
> Reported-by: Tony Lindgren
> Signed-off-by: Grygorii Strashko
Thanks this works for me:
Tested-by: Tony Lindgren
* Navid Emamdoost [200605 03:28]:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
Looks like we have a similar patch already in Linux next,
care to check?
Regards,
Tony
* Dinghao Liu [200522 04:50]:
> When wlcore_fw_status() returns an error code, a pairing
> runtime PM usage counter decrement is needed to keep the
> counter balanced. It's the same for all error paths after
> wlcore_fw_status().
Acked-by: Tony Lindgren
* dinghao@zju.edu.cn [200521 04:55]:
> There is a check against ret after out_sleep tag. If
> wl1271_configure_suspend_ap()
> returns an error code, ret will be caught by this check and a warning will be
> issued.
OK thanks for checking. In that case this one too:
Acked-by: Tony Lindgren
* Dinghao Liu [691231 23:00]:
> There are two error handling paths in this functon. When
> wlcore_tx_work_locked() returns an error code, we should
> decrease the runtime PM usage counter the same way as the
> error handling path beginning from pm_runtime_get_sync().
Acked-by: Tony Lindgren
* Dinghao Liu [200520 12:47]:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
Acked-by: Tony Lindgren
* Dinghao Liu [200520 13:09]:
> When wl12xx_cmd_role_disable() returns an error code,
> a pairing runtime PM usage counter decrement is needed to
> keep the counter balanced.
Acked-by: Tony Lindgren
* Dinghao Liu [200520 12:58]:
> When wlcore_hw_interrupt_notify() returns an error code,
> a pairing runtime PM usage counter decrement is needed to
> keep the counter balanced.
We should probably keep the warning though, nothing will
get shown for wl1271_configure_suspend_ap() errors.
Otherwise
* Grygorii Strashko [200512 14:35]:
> On 12/05/2020 17:22, Tony Lindgren wrote:
> > However, there's at least one more issue left that shows up at least
> > on ti81xx dra62x-j5eco-evm on v5.7-rc5 that has commit b46b2b7ba6e1
> > ("ARM: dts: Fix dm814x Ethernet b
ITCHDEV
>...
> depends on TI_CPTS || !TI_CPTS
>
>which will ensure proper dependencies PTP_1588_CLOCK -> TI_CPTS ->
> TI_CPSW/TI_KEYSTONE_NETCP/TI_CPSW_SWITCHDEV and build type selection.
>
> Note. For NFS boot + CPTS all of above configs have to be built-in.
This bui
* Philippe Schenker [200507 15:17]:
> On Thu, 2020-05-07 at 18:12 +0300, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for
> > the
> > KSZ9031 PHY") the networking is broken on boards:
> > am437x-gp-evm
> > am437x-sk-evm
> > am437x-idk-evm
> >
* Philippe Schenker [200507 08:43]:
> On Wed, 2020-05-06 at 22:11 +0300, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for
> > the
> > KSZ9031 PHY") the networking is broken on boards:
> > am571x-idk
> > am572x-idk
> > am574x-idk
> > am57xx-bea
* Clay McClure [200502 23:41]:
> diff --git a/arch/arm/configs/omap2plus_defconfig
> b/arch/arm/configs/omap2plus_defconfig
> index 3cc3ca5fa027..e00f0d871c53 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -57,7 +57,6 @@ CONFIG_CPUFREQ_DT=m
>
* David Miller [190221 00:18]:
> From: Tony Lindgren
> Date: Wed, 20 Feb 2019 13:01:27 -0800
>
> > What I can do is set up a separate branch with just this
> > patch on top of the dts changes that the arm-soc guys can
> > then merge towards the end of the merge cycle
* David Miller [190220 20:42]:
> From: Tony Lindgren
> Date: Wed, 20 Feb 2019 12:33:26 -0800
>
> > * David Miller [190220 19:23]:
> >> From: Grygorii Strashko
> >> Date: Wed, 20 Feb 2019 17:25:19 +0200
> >>
> >> > Deprecate cpsw-phy-s
* David Miller [190220 19:23]:
> From: Grygorii Strashko
> Date: Wed, 20 Feb 2019 17:25:19 +0200
>
> > Deprecate cpsw-phy-sel driver as it's been replaced with new
> > TI phy-gmii-sel PHY driver.
> >
> > Signed-off-by: Grygorii Strashko
>
> Acked-by: David S. Miller
Thanks for the ack, but
Hi,
* Grygorii Strashko [190220 15:26]:
> Deprecate cpsw-phy-sel driver as it's been replaced with new
> TI phy-gmii-sel PHY driver.
I'm not going to pick up this one, seems that Dave can merge
this later on? That is unless Dave wants to ack this one.
Regards,
Tony
> Signed-off-by: Grygorii S
* Grygorii Strashko [190220 07:26]:
> Hi Tony,
>
> Hence prerequisite patches [1] have been merged already I'm sending final set
> of DT patches to complete conversation of TI CPSW driver to use phy-gmii-sel
> phy driver instead of cpsw-phy-sel.
>
> [1] https://lkml.org/lkml/2018/11/26/154
Gre
* Peter Ujfalusi [190219 08:02]:
> On 18/02/2019 18.26, Tony Lindgren wrote:
> > OK so sounds like these are OK to wait for v5.1 merge window
> > then as the dts changes alone won't fix anything?
>
> I think it would be better to send these to 5.0 to avoid the regress
* Peter Ujfalusi [190218 16:22]:
>
>
> On 18/02/2019 16.44, Tony Lindgren wrote:
> > * Peter Ujfalusi [190218 14:36]:
> >> Hi,
> >>
> >> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke
> >> the
> >
* Peter Ujfalusi [190218 14:36]:
> Hi,
>
> cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") broke the
> ethernet networking on evmsk (and most likely on the evm as well):
> https://patchwork.ozlabs.org/patch/1028527/
>
> v1 patch to fix the situation:
> https://patchwork.ozla
* Tony Lindgren [190110 13:27]:
> * Heiner Kallweit [190110 19:41]:
> > On 10.01.2019 20:24, Florian Fainelli wrote:
> > > On 1/10/19 11:22 AM, Heiner Kallweit wrote:
> > >> So far genphy_soft_reset was used automatically if the PHY driver
> > >> didn
th the
> >> mentioned commit and broke KSZ9031. To fix this configure the
> >> KSZ9031 PHY driver to use genphy_soft_reset.
> >>
> >> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> >> Reported-by: Tony Lindgren
> >>
reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren
> Signed-off-by: Heiner Kallweit
Thanks this fixes the regression for me:
Tested-by: Tony Lindgren
> ---
> drivers/net/phy/micrel.c | 1 +
> 1 file changed,
* Sekhar Nori [190110 11:52]:
> On 10/01/19 3:06 AM, Tony Lindgren wrote:
> > For TI hardware, Sekhar and TI network folks, can you guys
> > please check the various TI SoCs for multiple suspend resume
> > cycles with v5.0-rc1 and patch accordingly? See also below
>
>
Hi,
* Heiner Kallweit [190109 19:28]:
> On 09.01.2019 20:06, Tony Lindgren wrote:
> > Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
> > a regression where suspend resume cycle fails to bring up Ethernet on at
> > least cpsw on am437x-sk-e
Hi all,
Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
a regression where suspend resume cycle fails to bring up Ethernet on at
least cpsw on am437x-sk-evm.
Keerthy noticed this may not happen on the first resume, but usually
happens after few suspend resume cycles. The m
* Russell King - ARM Linux [181207 19:27]:
> You mentioned that edge mode didn't work as well as level mode on
> duovero smsc controller, I think this may help to solve the same
> issue but for edge IRQs - we need a mask_ack_irq function to avoid
> acking while the edge interrupt is masked. Let m
* Tony Lindgren [181207 18:14]:
> Hi,
>
> * Russell King - ARM Linux [181207 18:01]:
> > Hi Tony,
> >
> > You know most of what's been going on from IRC, but here's the patch
> > which gets me:
> >
> > 1) working interrupts for networ
Hi,
* Russell King - ARM Linux [181207 18:01]:
> Hi Tony,
>
> You know most of what's been going on from IRC, but here's the patch
> which gets me:
>
> 1) working interrupts for networking
> 2) solves the stuck-wakeup problem
>
> It also contains some of the debug bits I added.
This is excell
* Russell King - ARM Linux [181206 18:08]:
> reverted, the problem is still there. Revert:
>
> ec0daae685b2 ("gpio: omap: Add level wakeup handling for omap4 based SoCs")
>
> on top, and networking returns to normal. So it appears to be this
> last commit causing the issue.
>
> With that and
Hi,
* Russell King - ARM Linux [181206 13:23]:
> It looks very much like a receive problem - in that the board is not
> always aware of a packet having been received until it attempts to
> transmit (eg, in the case of TFTP, when it re-sends the ACK after a
> receive timeout, it _then_ notices tha
* Grygorii Strashko [181126 00:15]:
> Add CPSW Port's Interface Mode Selection PHY (phy-gmii-sel) DT Bindings
Looks good to me. Please send the dts changes separately
when they're OK to merge after the driver dependencies
have cleared.
For this patch:
Acked-by: Tony Lindgren
* Grygorii Strashko [180830 17:08]:
> On 08/29/2018 07:47 PM, Tony Lindgren wrote:
> > In general, it seems cpsw is just an interconnect instance
> > (L4_FAST) with a control module (CPSW_WR) and a pile of
> > independent other modules. That's described nicely in
> &
* Grygorii Strashko [180830 00:12]:
> Hi Tony,
>
> On 08/29/2018 10:00 AM, Tony Lindgren wrote:
> > The current cpsw usage for cpsw-phy-sel is undocumented but is used for
> > all the boards using cpsw. And cpsw-phy-sel is not really a child of
> > the cpsw device, it
andle instead of a child device for it. That way we can
properly describe the hardware in dts files for things like genpd.
Cc: devicet...@vger.kernel.org
Cc: Andrew Lunn
Cc: Grygorii Strashko
Cc: Ivan Khoronzhuk
Cc: Mark Rutland
Cc: Murali Karicheri
Cc: Rob Herring
Signed-off-by: Tony Lin
, so let's also
update the binding documentation accordingly.
Cc: devicet...@vger.kernel.org
Cc: Andrew Lunn
Cc: Grygorii Strashko
Cc: Ivan Khoronzhuk
Cc: Mark Rutland
Cc: Murali Karicheri
Cc: Rob Herring
Signed-off-by: Tony Lindgren
---
drivers/net/ethernet/ti/cpsw-phy-sel.c | 9 ++
* Tony Lindgren [180808 13:52]:
> * Andrew Lunn [180808 12:02]:
> >
> > Do you need to handle EPROBE_DEFER here? The phandle points to a
> > device which has not yet been loaded? I'm not sure exactly where it
> > will be returned, maybe it is bus_find_device
* Andrew Lunn [180808 12:02]:
> > +++ b/Documentation/devicetree/bindings/net/cpsw.txt
> > @@ -19,6 +19,9 @@ Required properties:
> > - slaves : Specifies number for slaves
> > - active_slave : Specifies the slave to use for time stamping,
> > ethtool
It's missing the related binding documentation, so let's also
update the binding documentation accordingly.
Cc: devicet...@vger.kernel.org
Cc: Grygorii Strashko
Cc: Ivan Khoronzhuk
Cc: Mark Rutland
Cc: Murali Karicheri
Cc: Rob Herring
Signed-off-by: Tony Lindgren
---
Documenta
* Adam Ford [170828 13:33]:
> On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko
> wrote:
> > Cc: Sekhar
> >
> > On 08/28/2017 10:32 AM, Adam Ford wrote:
> >>
> >> The davinvi_emac MAC address seems to attempt a call to
> >> ti_cm_get_macid in cpsw-common.c but it returns the message
> >> 'davinc
t; event index 3 at 1493259030.377741039
> event index 3 at 1493259031.378311139
> event index 3 at 1493259032.378881279
> event index 3 at 1493259033.379451424
> event index 3 at 1493259034.380021520
> event index 3 at 1493259035.380591660
> event index 3 at 1493259036.38116176
* Colin Ian King [170605 10:58]:
> Hi Tony,
>
> While running static analysis on linux-next, CoverityScan picked up a
> NULL pointer deference on ddata->pins when calling pinctrl_lookup_state:
>
> 466ddata->pins = devm_pinctrl_get(ddata->dev);
>
>1. Condition IS_ERR(ddata->pins), ta
* Arnd Bergmann [170428 08:06]:
> Tony Lindgren reports a kernel oops that resulted from my compile-time
> fix on the default config. This shows two problems:
>
> a) configurations that did not already enable PTP_1588_CLOCK will
>now miss the cpts driver
>
> b) when cpt
* Arnd Bergmann [170424 11:14]:
> On Mon, Apr 24, 2017 at 7:44 PM, Tony Lindgren wrote:
> > * Arnd Bergmann [170424 10:38]:
> >> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote:
> >> > Hi,
> >> >
> >> > Looks like commit 07fef3623
* Arnd Bergmann [170424 10:38]:
> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren wrote:
> > Hi,
> >
> > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers")
> > in mainline started triggering the following oops at least on j5eco-evm.
&g
Hi,
Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers")
in mainline started triggering the following oops at least on j5eco-evm.
Adding CONFIG_PTP_1588_CLOCK to .config solves it, but the oops hints
something is wrong with the dependencies.. CONFIG_TI_CPTS defaults to N
an
* Roger Quadros [170330 05:37]:
> Hi Tony & Dave,
>
> On 13/03/17 15:42, Roger Quadros wrote:
> > Hi,
> >
> > This series adds ethernet support to am335x-icev2 board.
> >
> > The ethernet PHYs on the board need an explicit GPIO reset pulse
> > to ensure they bootstrap to the correct mode. Witho
* Bjørn Mork [170319 10:23]:
> Tony Lindgren writes:
> > And the v3.8 kernel also has drivers/usb/serial/mdm6600.c:
> >
> > +static const struct usb_device_id mdm6600_id_table[] = {
> > + { USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x2a70, 0xff, 0xff, 0xff)
* Tony Lindgren [170319 10:05]:
> * Bjørn Mork [170319 09:33]:
> > This is a bit unusual, so I'd like to verify that it is correct. Do you
> > happen to have a "lsusb -v" or /sys/kernel/debug/usb/devices dump for
> > this device? Is this usage of vendor + c
* Bjørn Mork [170319 09:33]:
> Tony Lindgren writes:
>
> > This gets qmicli working with the MDM6600 modem.
> >
> > Cc: Bjørn Mork
> > Reviewed-by: Sebastian Reichel
> > Tested-by: Sebastian Reichel
> > Signed-off-by: Tony Lindgren
> > ---
This gets qmicli working with the MDM6600 modem.
Cc: Bjørn Mork
Reviewed-by: Sebastian Reichel
Tested-by: Sebastian Reichel
Signed-off-by: Tony Lindgren
---
drivers/net/usb/qmi_wwan.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb
* Kalle Valo [170130 22:36]:
> Tony Lindgren writes:
>
> > * Pavel Machek [170127 11:41]:
> >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote:
> >> > Pali Rohár writes:
> >> >
> >> > > On Friday 27 January 2017 14:26:22 Kalle Valo w
* Pavel Machek [170127 11:41]:
> On Fri 2017-01-27 17:23:07, Kalle Valo wrote:
> > Pali Rohár writes:
> >
> > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote:
> > >> Pali Rohár writes:
> > >>
> > >> > 2) It was already tested that example NVS data can be used for N900
> > >> > e.g.
> >
* Grygorii Strashko [170112 09:15]:
> According to errata i880 description the speed of Ethernet port 1 on AM572x
> SoCs rev 1.1 shuld be limited to 10/100Mbps, because RGMII2 Switching
> Characteristics are not compatible with 1000 Mbps operation [1].
> The issue is fixed with Rev 2.0 silicon.
>
* Grygorii Strashko [170109 11:26]:
>
>
> On 01/06/2017 03:54 PM, Tony Lindgren wrote:
> > * Grygorii Strashko [170106 12:56]:
> > > TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ
> > > generation in case of phy/link status changes. Th
* Grygorii Strashko [170106 12:56]:
> TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ
> generation in case of phy/link status changes. The INT/PWDN lines from both
> DP83867 phys are wired to DRA7 gpio6.16, so reflect the same in DT.
Hmm not seeing the patch 1/2 here.. Can this
* Kalle Valo [161220 09:12]:
> Tony Lindgren writes:
>
> > * Kalle Valo [161220 03:47]:
> >> Arend Van Spriel writes:
> >>
> >> > On 18-12-2016 13:09, Pali Rohár wrote:
> >> >
> >> >> File wl1251-nvs.bin is provided by linu
* Kalle Valo [161220 03:47]:
> Arend Van Spriel writes:
>
> > On 18-12-2016 13:09, Pali Rohár wrote:
> >
> >> File wl1251-nvs.bin is provided by linux-firmware package and contains
> >> default data which should be overriden by model specific calibrated
> >> data.
> >
> > Ah. Someone thought i
* Pali Rohár [161126 09:21]:
> On Thursday 24 November 2016 19:46:01 Aaro Koskinen wrote:
> > Hi,
> >
> > On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote:
> > > Proprietary, signed and closed bootloader NOLO does not support DT.
> > > So for booting you need to append DTS file to kerne
* Jeroen Hofstee [161028 11:19]:
> Hello Tony,
>
> On 28-10-16 17:52, Tony Lindgren wrote:
> > * Jeroen Hofstee [161028 08:33]:
> > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> > > id to common file") did not only move
* Jeroen Hofstee [161028 08:33]:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") did not only move the code for an am3517, it also
> added the slave parameter, resulting in an invalid (all zero) mac address
> being returned for an am3517, since it o
* Jeroen Hofstee [161021 02:31]:
> Aaah, lets wait a sec. I just saw there is another user of this function,
> so above is simply not true
>
> if (of_machine_is_compatible("ti,dra7"))
> return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);
Oh OK, then this will produce
* Jeroen Hofstee [161021 00:37]:
> Hello Tony,
>
> On 21-10-16 08:38, Tony Lindgren wrote:
> > * Jeroen Hofstee [161020 12:57]:
> > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> > > id to common file") did not only move
* Jeroen Hofstee [161020 12:57]:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") did not only move the code for an am3517, it also
> added the slave parameter, resulting in a invalid (all zero) mac address
> being returned. So change it back to alwa
ure the mac from DT is preserved.
>
> On a am3517 this address is incorrectly read as all zeros, making it
> impossible to set a valid mac address without this patch.
OK, at least I don't have better ideas for fixing this:
Acked-by: Tony Lindgren
bsystem.
>
> The code looks for an additional interrupt - apart from the
> ordinary device interrupt - and in case that is present,
> we register an interrupt handler to respons to this,
> and flag the device and this interrupt as a wakeup.
>
> Cc: Sudeep Holla
> Cc:
* Linus Walleij [160708 02:10]:
> The SMSC911x have a line out of the chip called "PME",
> Power Management Event. When connected to an asynchronous
> interrupt controller this is able to wake the system up
> from sleep in response to certain network events.
Cool, so far have not found any boards
feel free
to merge along with the other CPSW driver patches after the
pending comments are dealt with:
Acked-by: Tony Lindgren
* Al Viro [160509 08:41]:
> On Mon, May 09, 2016 at 08:21:38AM -0700, Tony Lindgren wrote:
>
> > Looks like with both patches applied I still also get this eventually:
> >
> > =
> > [ BUG: bad unlock balance detected! ]
> >
* Tony Lindgren [160509 08:15]:
> * Eric Dumazet [160509 07:16]:
> > On Mon, May 9, 2016 at 12:32 AM, Al Viro wrote:
> > > On Sun, May 08, 2016 at 03:16:29PM +0100, Al Viro wrote:
> > >
> > >> Very strange. We grab that rwsem at the entry into nfs_call_
* Eric Dumazet [160509 07:16]:
> On Mon, May 9, 2016 at 12:32 AM, Al Viro wrote:
> > On Sun, May 08, 2016 at 03:16:29PM +0100, Al Viro wrote:
> >
> >> Very strange. We grab that rwsem at the entry into nfs_call_unlink()
> >> and then either release it there and return or call nfs_do_call_unlink(
s [1].
>
> Nicolas Chauvet reported testing v2 on an HP t410 (dm8148).
>
> Markus Brunner reported testing v1 on the following [2]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
Quickly boot tested these against next on dra62x-j5eco EVM:
Tested-by: Tony Lindgren
gt;
> > Also add Mugunthan as maintainer and myself as the reviewer.
> >
> > Cc: "David S. Miller"
> > Cc: Tony Lindgren
> > Cc: Mugunthan V N
> > Cc: Richard Cochran
> > Signed-off-by: Grygorii Strashko
>
> Acked-by: Mugunthan V N
Looks good to me too thanks:
Acked-by: Tony Lindgren
* Grygorii Strashko [160420 09:19]:
> On 04/20/2016 05:23 PM, Tony Lindgren wrote:
> > * Grygorii Strashko [160420 04:26]:
> >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW
> >> (am33/am43/am57/dr7/davinci) to ensure that related patches
> >>
* Hannes Frederic Sowa [160420 08:24]:
> Hi,
>
> On 20.04.2016 17:01, Tony Lindgren wrote:
> > Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for
> > sock_owned_by_user") in next causes a regression at least for
> > smsc911x with CONFI
f-by?
This gets cpsw boards working in next for me again:
Tested-by: Tony Lindgren
* Tony Lindgren [160420 08:02]:
> Hi,
>
> Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for
> sock_owned_by_user") in next causes a regression at least for
> smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following
> message. Any ideas?
Sor
Hi,
Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for
sock_owned_by_user") in next causes a regression at least for
smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following
message. Any ideas?
Regards,
Tony
8<
WARNING: CPU: 0 PID: 0 at include/net/sock
* Grygorii Strashko [160420 04:26]:
> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW
> (am33/am43/am57/dr7/davinci) to ensure that related patches
> will go through dedicated linux-omap list.
>
> Also add Mugunthan as maintainer and myself as the reviewer.
>
> Cc: "David S. Miller"
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") started using of_machine_is_compatible for detecting
type but missed at dm8148 causing Ethernet to stop working.
Let's fix the issue by adding handling for dm814x.
Cc: Mugunthan V N
Sign
* Neil Armstrong [150922 02:01]:
> In case the DaVinci Emac is directly connected to a
> non-mdio PHY/device, it should be possible to provide
> a fixed link configuration in the DT.
>
> Signed-off-by: Neil Armstrong
Ethernet works for me with this patch:
Tested-by
ctional.
> Verified this on DRA72x with pcf as module and ramdisk.
>
> Signed-off-by: Mugunthan V N
Acked-by: Tony Lindgren
> ---
>
> Changes from v2:
> * Used mode-gpios, so that the driver is generic enough to handle
> multiple gpios
>
> This patch is tested on
* Mugunthan V N [150902 23:05]:
> In DRA72x EVM, by default slave 1 is connected to the onboard
> phy, but slave 2 pins are also muxed with video input module
> which is controlled by pcf857x gpio and currently to select slave
> 0 to connect to phy gpio hogging is used, but with
> omap2plus_defcon
* Mugunthan V N [150901 04:28]:
> --- a/Documentation/devicetree/bindings/net/cpsw.txt
> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
> @@ -26,6 +26,9 @@ Optional properties:
> - dual_emac : Specifies Switch to act as Dual EMAC
> - syscon : Phandle to the system cont
The interrupt handler may not be available when smsc911x probes if the
interrupt handler is a GPIO controller for example. Let's fix that
by adding handling for -EPROBE_DEFER.
Cc: Steve Glendinning
Signed-off-by: Tony Lindgren
---
drivers/net/ethernet/smsc/smsc911x.c | 5 -
1 file ch
* Guenter Roeck [150826 13:58]:
> Hi Tony,
>
> On 08/26/2015 01:16 PM, Tony Lindgren wrote:
> [ ... ]
>
> >>We may need two separate patches, one to fix up device_property_read_u32()
> >>to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the e
figuration. Should be tested with ACPI
> and FDT configurations.
Thanks this fixes smsc911x regression in Linux next for me with FDT:
Tested-by: Tony Lindgren
> drivers/net/ethernet/smsc/smsc911x.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --
* Guenter Roeck [150826 11:37]:
> On 08/26/2015 10:04 AM, Tony Lindgren wrote:
> >Hi,
> >
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >>the call to smsc911x_probe_config() unco
* Guenter Roeck [150826 10:40]:
> Hi Tony,
>
> On 08/26/2015 10:04 AM, Tony Lindgren wrote:
> >Hi,
> >
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >>the call to smsc91
* Jeremy Linton [150826 10:35]:
> On 08/26/2015 12:04 PM, Tony Lindgren wrote:
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >Looks like this change makes at least omap boards using smsc911x
>
Hi,
* Guenter Roeck [150817 13:48]:
> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if there is no phy node conf
* Mugunthan V N [150812 02:56]:
> CPSW driver has been updated with compatibles for enabling errata
> workarounds. So updating cpsw compatibles.
>
> Signed-off-by: Mugunthan V N
This too:
Acked-by: Tony Lindgren
> ---
> arch/arm/boot/dts/am33xx.dtsi | 2 +-
> 1 file
* Mugunthan V N [150812 02:56]:
> CPSW driver has been updated with compatibles for enabling errata
> workarounds. So updating cpsw compatibles.
>
> Signed-off-by: Mugunthan V N
Please feel free to merge this one via net tree once the changes
are reviewed:
Acked-by: T
94 matches
Mail list logo
