Re: [PATCH] ath10k: fix the status check and wrong return

2020-08-14 Thread Tom Psyborg
On 14/08/2020, Tang Bin wrote: > In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't > return NULL. Thus use IS_ERR() and PTR_ERR() to validate > the returned value instead of IS_ERR_OR_NULL(). > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/net/wireless/a

Re: [PATCH 00/20] drop useless LIST_HEAD

2018-12-25 Thread Tom Psyborg
there was discussion about this just some days ago. CC 4-5 lists is more than enough On 23/12/2018, Julia Lawall wrote: > > > On Sun, 23 Dec 2018, Tom Psyborg wrote: > >> Why do you CC this to so many lists? > > Because the different files are in different subsystems. Th

Re: [PATCH 00/20] drop useless LIST_HEAD

2018-12-23 Thread Tom Psyborg
Why do you CC this to so many lists? On 23/12/2018, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares is never used. > > --- > > drivers/dma/at_hdmac.c|5 - > drivers/dma/dw/core.c |1 - > drivers/dma/p