Re: [PATCH iproute2-next v2] iplink:macvlan: Added bcqueuelen parameter

2020-12-14 Thread Thomas Karlsson
On 2020-12-14 18:03, David Ahern wrote: > On 12/14/20 3:42 AM, Thomas Karlsson wrote: >> This patch allows the user to set and retrieve the >> IFLA_MACVLAN_BC_QUEUE_LEN parameter via the bcqueuelen >> command line argument >> >> This parameter controls th

[PATCH iproute2-next v2] iplink:macvlan: Added bcqueuelen parameter

2020-12-14 Thread Thomas Karlsson
the setting. However, it can of course not be directly set. Signed-off-by: Thomas Karlsson --- Note: This patch controls the parameter added in net-next with commit d4bff72c8401e6f56194ecf455db70ebc22929e2 v2 Rebased on origin/main v1 Initial version ip/iplink_macvlan.c | 33

Re: [PATCH iproute2-next v1] iplink macvlan: Added bcqueuelen parameter

2020-12-10 Thread Thomas Karlsson
On 2020-11-30 15:23, Thomas Karlsson wrote: > This is a follow up patch to iproute2 that allows the user > to set and retrieve the added IFLA_MACVLAN_BC_QUEUE_LEN parameter > via the bcqueuelen command line argument > > > v1 Initial version >Note: This patch fi

Re: [PATCH net-next v4] macvlan: Support for high multicast packet rate

2020-12-03 Thread Thomas Karlsson
> On Wed, 2 Dec 2020 19:49:58 +0100 Thomas Karlsson wrote: >> Background: >> Broadcast and multicast packages are enqueued for later processing. >> This queue was previously hardcoded to 1000. >> >> This proved insufficient for handling very high packet rates. >

[PATCH net-next v4] macvlan: Support for high multicast packet rate

2020-12-02 Thread Thomas Karlsson
. Signed-off-by: Thomas Karlsson --- v4 Updated after review (see interdiff for full details): - Initialize bc_queue_len_used to 0 when creating the port. - only change bc_queue_len_used from update_port_bc_queue_len() - Use NLA_REJECT for IFLA_MACVLAN_BC_QUEUE_LEN_USED

Re: [PATCH net-next v3] macvlan: Support for high multicast packet rate

2020-12-02 Thread Thomas Karlsson
On 2020-12-01 20:11, Jakub Kicinski wrote: > On Mon, 30 Nov 2020 15:00:43 +0100 Thomas Karlsson wrote: >> Background: >> Broadcast and multicast packages are enqueued for later processing. >> This queue was previously hardcoded to 1000. >> >> This proved insuffici

[PATCH iproute2-next v1] iplink macvlan: Added bcqueuelen parameter

2020-11-30 Thread Thomas Karlsson
setting. However, it cannot be directly set. Signed-off-by: Thomas Karlsson --- v1 Initial version Note: This patch first requires that the corresponding kernel patch in 0c88607c-1b63-e8b5-8a84-14b63e55e...@paneda.se to macvlan is merged to be usable. include/uapi/linux/if_link.h | 2

[PATCH net-next v3] macvlan: Support for high multicast packet rate

2020-11-30 Thread Thomas Karlsson
. Signed-off-by: Thomas Karlsson --- v3 switched to using netlink attributes v1/2 used module_param drivers/net/macvlan.c | 44 -- include/linux/if_macvlan.h | 1 + include/uapi/linux/if_link.h | 2 ++ tools/include/uapi/linux/if_link.h

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-27 Thread Thomas Karlsson
On 2020-11-27 18:27, Jakub Kicinski wrote: > On Thu, 26 Nov 2020 21:00:46 +0100 Thomas Karlsson wrote: >> On 2020-11-26 00:01, Jakub Kicinski wrote: >>> On Wed, 25 Nov 2020 23:15:39 +0100 Thomas Karlsson wrote: >>>> Or is there a way to set the parameters in a more

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-26 Thread Thomas Karlsson
On 2020-11-26 00:01, Jakub Kicinski wrote: > On Wed, 25 Nov 2020 23:15:39 +0100 Thomas Karlsson wrote: >>>> This is my first time ever attemting a contribution to the kernel so >>>> I'm quite happy to keep it simple like that too :) >>> >>> Modu

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-25 Thread Thomas Karlsson
On 2020-11-25 19:07, Jakub Kicinski wrote: > On Wed, 25 Nov 2020 18:12:34 +0100 Thomas Karlsson wrote: >>>> For this reason I would like to know if you would consider >>>> merging a patch using the module_param(...) variant instead? >>>> >>>>

[PATCH net-next v2] macvlan: Support for high multicast packet rate

2020-11-25 Thread Thomas Karlsson
patch make the queue len adjustable to accommodate for environments with very high multicast packet rate. But still keeps the default value of 1000 unless specified. The queue len is specified using the bc_queue_len module parameter. Signed-off-by: Thomas Karlsson --- v2: Patch created on top of

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-25 Thread Thomas Karlsson
On 2020-11-25 17:58, Jakub Kicinski wrote: > On Wed, 25 Nov 2020 13:51:41 +0100 Thomas Karlsson wrote: >> Den 2020-11-23 kl. 23:30, skrev Jakub Kicinski: >>> On Mon, 23 Nov 2020 14:22:31 +0000 Thomas Karlsson wrote: >>>> Hello, >>>> >>>&

[PATCH] macvlan: Support for high multicast packet rate

2020-11-25 Thread Thomas Karlsson
: This patch make the queue len adjustable to accommodate for environments with very high multicast packet rate. But still keeps the default value of 1000 unless specified. The queue len is specified using the bc_queue_len module parameter. Signed-off-by: Thomas Karlsson diff --git a/drivers/net

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-25 Thread Thomas Karlsson
Den 2020-11-23 kl. 23:30, skrev Jakub Kicinski: On Mon, 23 Nov 2020 14:22:31 + Thomas Karlsson wrote: Hello, There is a special queue handling in macvlan.c for broadcast and multicast packages that was arbitrarily set to 1000 in commit 07d92d5cc977a7fe1e683e1d4a6f723f7f2778cb . While

Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-23 Thread Thomas Karlsson
text/plain instead of html) Best regards, Thomas Karlsson