Re: [bisected] UDP / xfrm: NAT-T packets with bad UDP checksum get dropped

2019-09-16 Thread Thomas Jarosch
> After a few hours of bisecting with a test VM, > this commit was identified to cause the packet drop: > > *** > commit 0a80966b1043c3e2dc684140f155a3fded308660 > Author: Tom Herbert > Date: Wed May 7 16:52:39 2014 -0700 > > net: Verify UDP checksum before handoff to encap

[bisected] UDP / xfrm: NAT-T packets with bad UDP checksum get dropped

2019-09-12 Thread Thomas Jarosch
Hello together, after updating many machines already from 3.14 to 4.19.67, one site showed a non-working IPSec VPN connection with 4.19.x. This IPSec connection is using UDP NAT traversal on port 4500. The tunnel gets established fine, but no data flows. Output of "ip xfrm state" looked sane. Th

Re: 4.19: Traced deadlock during xfrm_user module load

2019-06-27 Thread Thomas Jarosch
e added a three second sleep during the initialisation of nf_conntrack_netlink. The events started to appear after the delayed init was completed. If this is the case, then using "_nowait" should suffice as a fix for the problem. Could you please confirm these assumptions and give us some piece of mind? Best regards, Juliana Rodrigueiro and Thomas Jarosch

4.19: Traced deadlock during xfrm_user module load

2019-06-25 Thread Thomas Jarosch
;s worth fixing. The related function netlink_create() unlocks the table before requesting modules and locks it afterwards again. We guess it's racy to call netlink_unlock_table() before doing the err = nlk->netlink_bind(net, group + 1); call in netlink_bind() ? What would be the best fix here? Best regards, Thomas Jarosch and Juliana Rodrigueiro

Re: [PATCH 5/5] isdn: move capi drivers to staging

2019-04-29 Thread Thomas Jarosch
Hi Arnd, You wrote on Thu, Apr 25, 2019 at 01:24:09PM +0200: > > > Right, this is what I'm trying to find out here. I realize that there > > > are (very few) remaining users of ISDN voice services, but this only > > > matters if someone uses them > > > > > > 1. with a modern Linux kernel, and plan

Re: [PATCH 5/5] isdn: move capi drivers to staging

2019-04-24 Thread Thomas Jarosch
ys some userspace API compatibility issue, a small patch needed here or a crash there. For example my colleague tries to figure out right now why the Microsoft Hyper-V network driver hangs on module load with kernel 4.19.35 while downgrading to the previous kernel works instantly. Sounds like git bisect "fun" for her... [1] https://avocado-framework.github.io/ https://github.com/intra2net/avocado-i2n Best regards, Thomas Jarosch

Re: [PATCH 5/5] isdn: move capi drivers to staging

2019-04-24 Thread Thomas Jarosch
It's a bit crazy, but people seem to love it. We deal with this on a weekly basis to support our customers during the migration period. Intra2net is currently in the process of upgrading to kernel 4.19.x and Karsten recently did all the necessary adaptions for mISDN. So the ISDN code is used with modern (LTS) kernels ^^ Best regards, Thomas Jarosch

[IRDA PATCH] mcs7780: Fix initialization when CONFIG_VMAP_STACK is enabled

2017-07-22 Thread Thomas Jarosch
ion of the maintainer. Thanks to Dan Williams for adding the "transfer buffer not dma capable" warning in the first place. It instantly pointed me in the right direction. Patch has been tested with transferring data from a Polar watch. Signed-off-by: Thomas Jarosch --- drivers/net

Re: [PATCH 3.19 and earlier] fib_rules: Fix dump_rules() not to exit early

2015-10-09 Thread Thomas Jarosch
Hi Roland, On Monday, 5. October 2015 10:29:28 Roland Dreier wrote: > From: Roland Dreier > > Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across > multiple skbs") introduced a regression in "ip rule show" - it ends up > dumping the first rule over and over and never exiting, becaus

Re: [bisected regression] e1000e: "Detected Hardware Unit Hang"

2015-07-29 Thread Thomas Jarosch
Hi Jeff and Yanir, On Saturday, 30. May 2015 01:18:44 Brown, Aaron F wrote: > > any news on this from the Intel labs? > > Nothing significant. Another one of our testers (whom works more closely > with the current e1000e driver owner than I) has managed to replicate it > on several systems and I

Re: RE: [bisected regression] e1000e: "Detected Hardware Unit Hang"

2015-05-27 Thread Thomas Jarosch
Hi Aaron, On Monday, 23. March 2015 22:37:08 Brown, Aaron F wrote: > > > > > > And with an internal reproduction of the issue I have created an > > > > internal > > > > > bug report, described my set of reproductions, referenced the similar > > > external ones and assigned it to our current e100