Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-16 Thread Thomas Higdon
On Sat, Sep 14, 2019 at 11:43:25AM -0400, Neal Cardwell wrote: > On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon wrote: > > > > For receive-heavy cases on the server-side, we want to track the > > connection quality for individual client IPs. This counter, similar to > &g

[PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-13 Thread Thomas Higdon
advantage of a hole. Signed-off-by: Thomas Higdon --- changes since v4: - optimize placement of rcv_ooopack to avoid increasing tcp_sock struct size include/linux/tcp.h | 2 ++ include/uapi/linux/tcp.h | 2 ++ net/ipv4/tcp.c | 2 ++ net/ipv4/tcp_input.c | 1 + 4 files changed

[PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

2019-09-13 Thread Thomas Higdon
pack field. Signed-off-by: Thomas Higdon --- changes since v4: - clarify comment include/uapi/linux/tcp.h | 4 net/ipv4/tcp.c | 1 + 2 files changed, 5 insertions(+) diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h index 20237987ccc8..81e697978e8b 100644 --- a/incl

[PATCH v4 2/2] tcp: Add snd_wnd to TCP_INFO

2019-09-13 Thread Thomas Higdon
pack field. Signed-off-by: Thomas Higdon --- changes from v3: - changed from rcv_wnd to snd_wnd include/uapi/linux/tcp.h | 1 + net/ipv4/tcp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h index 20237987ccc8..240654f22d98 10064

[PATCH v4 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-13 Thread Thomas Higdon
understanding to what degree receive-heavy sockets are experiencing out-of-order delivery and packet drops indicating congestion. Please note that this is similar to the counter in NetBSD TCP_INFO, and has the same name. Signed-off-by: Thomas Higdon --- no changes from v3 include/linux/tcp.h

Re: [PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO

2019-09-13 Thread Thomas Higdon
On Thu, Sep 12, 2019 at 10:14:33AM +0100, Dave Taht wrote: > On Thu, Sep 12, 2019 at 1:59 AM Neal Cardwell wrote: > > > > On Wed, Sep 11, 2019 at 6:32 PM Thomas Higdon wrote: > > > > > > Neal Cardwell mentioned that rcv_wnd would be useful for helping > &g

[PATCH v3 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-11 Thread Thomas Higdon
understanding to what degree receive-heavy sockets are experiencing out-of-order delivery and packet drops indicating congestion. Please note that this is similar to the counter in NetBSD TCP_INFO, and has the same name. Signed-off-by: Thomas Higdon --- include/linux/tcp.h | 2 ++ include/uapi

[PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO

2019-09-11 Thread Thomas Higdon
Neal Cardwell mentioned that rcv_wnd would be useful for helping diagnose whether a flow is receive-window-limited at a given instant. This serves the purpose of adding an additional __u32 to avoid the would-be hole caused by the addition of the tcpi_rcvi_ooopack field. Signed-off-by: Thomas

Re: [PATCH] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Thomas Higdon
On Mon, Sep 09, 2019 at 05:01:46PM +0200, Eric Dumazet wrote: > On Mon, Sep 9, 2019 at 4:30 PM Thomas Higdon wrote: > > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > > index b3564f85a762..20237987ccc8 100644 > > --- a/include/uapi/linux/tcp.h > &g