Re: [PATCH net 000/117] net: avoid to remove module when its debugfs is being used

2020-10-09 Thread Steve deRosier
On Fri, Oct 9, 2020 at 3:22 AM Johannes Berg wrote: > > On Fri, 2020-10-09 at 19:15 +0900, Taehee Yoo wrote: > > > > Okay, as you mentioned earlier in 001/117 patch thread, > > I will squash patches into per-driver/subsystem then send them as v2. > > Give me a bit. I think I figured out a less int

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Steve deRosier
Hi Mauro, On Thu, Aug 27, 2020 at 10:42 AM Mauro Carvalho Chehab wrote: > > Em Thu, 27 Aug 2020 08:48:30 -0700 > Steve deRosier escreveu: > > > On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab > > wrote: > > > > > > This patch causes a regr

Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"

2020-08-27 Thread Steve deRosier
On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab wrote: > > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > >wlcore: PHY firmware version: Rev 8.2.0.0.242 >wlcore:

Re: [PATCH] ath10k: fix the status check and wrong return

2020-08-17 Thread Steve deRosier
On Mon, Aug 17, 2020 at 6:43 PM Tang Bin wrote: > > Hi Kalle: > > 在 2020/8/17 22:26, Kalle Valo 写道: > >> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't > >> return NULL. Thus use IS_ERR() and PTR_ERR() to validate > >> the returned value instead of IS_ERR_OR_NULL(). > > Why? What'

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-22 Thread Steve deRosier
On Fri, May 22, 2020 at 2:51 PM Luis Chamberlain wrote: > > On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote: > > FWIW, I still completely disagree on that taint. You (Luis) obviously > > have been running into a bug in that driver, I doubt the firmware > > actually managed to wedge t

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Steve deRosier
On Mon, May 18, 2020 at 10:19 AM Luis Chamberlain wrote: > > On Mon, May 18, 2020 at 10:15:45AM -0700, Ben Greear wrote: > > > > > > On 05/18/2020 10:09 AM, Luis Chamberlain wrote: > > > On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote: > > > > > > > > > > > > On 05/18/2020 09:51 AM, Lui

Re: [PATCH] libertas_tf: remove set but not used variable 'flags'

2019-02-14 Thread Steve deRosier
'flags' set but not used [-Wunused-but-set-variable] > > It never used and can be removed. > > Signed-off-by: YueHaibing Acked-by: Steve deRosier

Re: [PATCH] wireless: remove unneeded semicolon

2019-01-17 Thread Steve deRosier
> > len -= ie_len; > data += ie_len; > - }; > + } > > ret = 0; > out: For ath6kl Acked-by: Steve deRosier

Re: [PATCH v2] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Steve deRosier
break; > case WMI_11AGN_CAP: > ht = true; > + /* fall through */ > case WMI_11AG_CAP: > band_2gig = true; > band_5gig = true; > -- > 2.7.4 Gustavo, Thanks for the adjustment. It now looks good to me. Reviewed-by: Steve deRosier

Re: RTL8723BE performance regression

2018-04-04 Thread Steve deRosier
8.33.18 That's the most basic setup, check the man page for more options. You will get best results if you can exclude other computers from your test network and other wireless devices from your airspace. - Steve -- Steve deRosier Cal-Sierra Consulting LLC https://www.cal-sierra.com/

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Steve deRosier
On Tue, Mar 20, 2018 at 8:39 AM, Ben Greear wrote: > On 03/20/2018 03:37 AM, Michal Kubecek wrote: >> >> On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> This is similar to ETHTOOL_GSTATS, but it allows you to specify >>> a 'level'. This l

Re: [PATCH v2 02/20] ath6kl: constify usb_device_id

2017-08-09 Thread Steve deRosier
atic struct usb_device_id ath6kl_usb_ids[] = { > +static const struct usb_device_id ath6kl_usb_ids[] = { > {USB_DEVICE(0x0cf3, 0x9375)}, > {USB_DEVICE(0x0cf3, 0x9374)}, > { /* Terminating entry */ }, > -- > 2.7.4 > Looks good. Also builds and works properly. Reviewed-by: Steve deRosier Tested-by: Steve deRosier - Steve

Re: [PATCH] ath6kl: fix spelling mistake: "Indicat" -> "Indicate"

2017-06-04 Thread Steve deRosier
action = ep->ep_cb.tx_full(ep->target, > packet); > if (action == HTC_SEND_FULL_DROP) { > -- > 2.11.0 > Looks good to me. Reviewed-by: Steve deRosier - Steve

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote: >> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: >> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> > > On Thu, Mar 30, 2017

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote: >> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote: >> > Fix fallout too. > [] >> My only question is why bother doing a format check on something >>

Re: [PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-31 Thread Steve deRosier
tion on the clauses that get compiled out?" So, it looks good to me as is, or if you feel like making the change I'm suggesting, that's fine too. And it builds and runs on my platforms. Reviewed-by: Steve deRosier - Steve