Re: [PATCH net-next v5 06/10] bnxt: Add devlink support for config get/set

2017-10-30 Thread Steve Lin
On Mon, Oct 30, 2017 at 1:35 PM, Jiri Pirko wrote: > Mon, Oct 30, 2017 at 03:46:12PM CET, steven.l...@broadcom.com wrote: >>Implements get and set of configuration parameters using new devlink >>config get/set API. Parameters themselves defined in later patches. >> >&

Re: [PATCH net-next v5 02/10] devlink: Adding SR-IOV enablement perm config param

2017-10-30 Thread Steve Lin
y. Value is permanent, so >>becomes the new default value for this device. >> >> DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV >> DEVLINK_PERM_CONFIG_ENABLE = Enable SR-IOV >> >>Signed-off-by: Steve Lin >>Acked-by: Andy Gospodarek >>--- >>

Re: [PATCH net-next v5 01/10] devlink: Add permanent config parameter get/set operations

2017-10-30 Thread Steve Lin
On Mon, Oct 30, 2017 at 1:03 PM, Jiri Pirko wrote: > Mon, Oct 30, 2017 at 03:46:07PM CET, steven.l...@broadcom.com wrote: >>Add support for permanent config parameter get/set commands. Used >>for persistent device configuration parameters. >> >>Signed-off-by:

[PATCH net-next v5 06/10] bnxt: Add devlink support for config get/set

2017-10-30 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Parameters themselves defined in later patches. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 258 +- drivers/net/ethernet

[PATCH net-next v5 10/10] bnxt: Adding num MSI-X vectors per VF perm config param

2017-10-30 Thread Steve Lin
Adding permanent config parameter for number MSI-X vectors per VF, using devlink API for get/set operation. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next v5 05/10] devlink: Adding num MSI-X vectors per VF perm config param

2017-10-30 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_MSIX_VECT_PER_VF permanent config parameter. Value is permanent, so becomes the new default value for this device. Value defines number of MSI-X vectors allocated per VF. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4

[PATCH net-next v5 07/10] bnxt: Adding SR-IOV enablement permanent cfg param

2017-10-30 Thread Steve Lin
Adding permanent config parameter for SR-IOV enablement, using devlink API for get/set operation. DEVLINK_PERM_CONFIG_DISABLE = SR-IOV disabled DEVLINK_PERM_CONFIG_ENABLE = SR-IOV enabled Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

[PATCH net-next v5 09/10] bnxt: Adding max PF MSI-X vectors perm config param

2017-10-30 Thread Steve Lin
Adding permanent config parameter for maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b

[PATCH net-next v5 01/10] devlink: Add permanent config parameter get/set operations

2017-10-30 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for persistent device configuration parameters. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 9 ++ include/uapi/linux/devlink.h | 33 + net/core/devlink.c | 293

[PATCH net-next v5 08/10] bnxt: Adding num VFs per PF perm config param

2017-10-30 Thread Steve Lin
Adding permanent config parameter for number of VFs per PF, using devlink API for get/set operation. Value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4

[PATCH net-next v5 00/10] Adding permanent config get/set to devlink

2017-10-30 Thread Steve Lin
ting permanent / persistent device configuration parameters, and enumerates the parameters as nested devlink attributes. Steve Lin (10): devlink: Add permanent config parameter get/set operations devlink: Adding SR-IOV enablement perm config param devlink: Adding num VFs per PF permanent config p

[PATCH net-next v5 03/10] devlink: Adding num VFs per PF permanent config param

2017-10-30 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter. Value is permanent, so becomes the new default value for this device. The value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4 net

[PATCH net-next v5 04/10] devlink: Adding max PF MSI-X vectors perm config param

2017-10-30 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Value is permanent, so becomes the new default value for this device. Value sets the maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4

[PATCH net-next v5 02/10] devlink: Adding SR-IOV enablement perm config param

2017-10-30 Thread Steve Lin
= Enable SR-IOV Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 18 +- net/core/devlink.c | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index

Re: [PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param

2017-10-27 Thread Steve Lin
Ok. > > >>value for this device. >> >> DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV >> DEVLINK_PERM_CONFIG_ENABLE = Enable SR-IOV >> >>Signed-off-by: Steve Lin >>Acked-by: Andy Gospodarek >>--- >> include/uapi/linux/devlink.h | 14 ++

Re: [PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations

2017-10-27 Thread Steve Lin
On Fri, Oct 27, 2017 at 5:04 PM, Jiri Pirko wrote: > Fri, Oct 27, 2017 at 10:54:05PM CEST, steven.l...@broadcom.com wrote: >>Add support for permanent config parameter get/set commands. Used >>for persistent device configuration parameters. >> >>Signed-off-by:

[PATCH net-next v4 06/10] bnxt: Add devlink support for config get/set

2017-10-27 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Parameters themselves defined in later patches. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 258 +- drivers/net/ethernet

[PATCH net-next v4 01/10] devlink: Add permanent config parameter get/set operations

2017-10-27 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for persistent device configuration parameters. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 7 ++ include/uapi/linux/devlink.h | 25 net/core/devlink.c | 287

[PATCH net-next v4 05/10] devlink: Adding num MSI-X vectors per VF perm config param

2017-10-27 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_MSIX_VECT_PER_VF permanent config parameter. Value is permanent, so becomes the new default value for this device. Value defines number of MSI-X vectors allocated per VF. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4

[PATCH net-next v4 07/10] bnxt: Adding SR-IOV enablement permanent cfg param

2017-10-27 Thread Steve Lin
Adding permanent config parameter for SR-IOV enablement, using devlink API for get/set operation. DEVLINK_PERM_CONFIG_DISABLE = SR-IOV disabled DEVLINK_PERM_CONFIG_ENABLE = SR-IOV enabled Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

[PATCH net-next v4 10/10] bnxt: Adding num MSI-X vectors per VF perm config param

2017-10-27 Thread Steve Lin
Adding permanent config parameter for number MSI-X vectors per VF, using devlink API for get/set operation. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next v4 08/10] bnxt: Adding num VFs per PF perm config param

2017-10-27 Thread Steve Lin
Adding permanent config parameter for number of VFs per PF, using devlink API for get/set operation. Value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4

[PATCH net-next v4 09/10] bnxt: Adding max PF MSI-X vectors perm config param

2017-10-27 Thread Steve Lin
Adding permanent config parameter for maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b

[PATCH net-next v4 04/10] devlink: Adding max PF MSI-X vectors perm config param

2017-10-27 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Value is permanent, so becomes the new default value for this device. Value sets the maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4

[PATCH net-next v4 03/10] devlink: Adding num VFs per PF permanent config param

2017-10-27 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter. Value is permanent, so becomes the new default value for this device. The value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 4 net

[PATCH net-next v4 00/10] Adding permanent config get/set to devlink

2017-10-27 Thread Steve Lin
, and enumerates the parameters as nested devlink attributes. Steve Lin (10): devlink: Add permanent config parameter get/set operations devlink: Adding SR-IOV enablement perm config param devlink: Adding num VFs per PF permanent config param devlink: Adding max PF MSI-X vectors perm config

[PATCH net-next v4 02/10] devlink: Adding SR-IOV enablement perm config param

2017-10-27 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config parameter. Value is permanent, so becomes the new default value for this device. DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV DEVLINK_PERM_CONFIG_ENABLE = Enable SR-IOV Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

Re: [PATCH net-next v3 01/10] devlink: Add permanent config parameter get/set operations

2017-10-24 Thread Steve Lin
On Tue, Oct 24, 2017 at 5:22 PM, Yuval Mintz wrote: >> Add support for permanent config parameter get/set commands. Used >> for persistent device configuration parameters. >> > ... >> + int (*perm_config_get)(struct devlink *devlink, >> +enum devlink_perm_config_par

Re: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Steve Lin
On Tue, Oct 24, 2017 at 4:52 PM, Michael Chan wrote: > On Tue, Oct 24, 2017 at 1:12 PM, Steve Lin wrote: >> Implements get and set of configuration parameters using new devlink >> config get/set API. Parameters themselves defined in later patches. >> >> Signed-off

[PATCH net-next v3 01/10] devlink: Add permanent config parameter get/set operations

2017-10-24 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for persistent device configuration parameters. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 6 + include/uapi/linux/devlink.h | 18 +++ net/core/devlink.c | 295

[PATCH net-next v3 05/10] devlink: Adding num MSI-X vectors per VF perm config param

2017-10-24 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config parameter. Value is permanent, so becomes the new default value for this device. Value defines number of MSI-X vectors allocated per VF. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 3

[PATCH net-next v3 07/10] bnxt: Adding SR-IOV enablement permanent cfg param

2017-10-24 Thread Steve Lin
Adding permanent config parameter for SR-IOV enablement, using devlink API for get/set operation. 0 = SR-IOV disabled 1 = SR-IOV enabled Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

2017-10-24 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Parameters themselves defined in later patches. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 262 +- drivers/net/ethernet

[PATCH net-next v3 00/10] Adding permanent config get/set to devlink

2017-10-24 Thread Steve Lin
ceed. -- Adds a devlink command for getting & setting permanent / persistent device configuration parameters, and enumerates the parameters as nested devlink attributes. bnxt driver patches makes use of these new devlink cmds. Steve Lin (10): devlink: Add permanent config parameter get/set

[PATCH net-next v3 02/10] devlink: Adding SR-IOV enablement perm config param

2017-10-24 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config parameter. Value is permanent, so becomes the new default value for this device. 0 = Disable SR-IOV 1 = Enable SR-IOV Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 8 +++- net/core

[PATCH net-next v3 09/10] bnxt: Adding max PF MSI-X vectors perm config param

2017-10-24 Thread Steve Lin
Adding permanent config parameter for maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b

[PATCH net-next v3 03/10] devlink: Adding num VFs per PF permanent config param

2017-10-24 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter. Value is permanent, so becomes the new default value for this device. The value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 3 +++ net

[PATCH net-next v3 04/10] devlink: Adding max PF MSI-X vectors perm config param

2017-10-24 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Value is permanent, so becomes the new default value for this device. Value sets the maximum number of PF MSI-X vectors. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 3

[PATCH net-next v3 10/10] bnxt: Adding num MSI-X vectors per VF perm config param

2017-10-24 Thread Steve Lin
Adding permanent config parameter for number MSI-X vectors per VF, using devlink API for get/set operation. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next v3 08/10] bnxt: Adding num VFs per PF perm config param

2017-10-24 Thread Steve Lin
Adding permanent config parameter for number of VFs per PF, using devlink API for get/set operation. Value sets the number of VFs per PF in SR-IOV mode. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 4 1 file changed, 4

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-23 Thread Steve Lin
On Mon, Oct 23, 2017 at 10:37 AM, Yuval Mintz wrote: >> >> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: >> >> > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: >> >> >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: >> >> >>> Thu, Oct 19, 2017 at 10:32:21PM CEST,

Re: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-23 Thread Steve Lin
On Sat, Oct 21, 2017 at 10:12 AM, Yuval Mintz wrote: >> On Thu, Oct 19, 2017 at 4:21 PM, Yuval Mintz >> wrote: >> >> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config >> parameter >> >> get/set operations >> >> >> >> Add support for permanent config parameter get/set commands. Used >

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-23 Thread Steve Lin
On Sat, Oct 21, 2017 at 9:59 AM, Yuval Mintz wrote: >> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: >> > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: >> >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: >> >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellan

Re: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-23 Thread Steve Lin
d support for permanent config parameter get/set commands. Used >>>>for parameters held in NVRAM, persistent device configuration. >>>> >>>>Signed-off-by: Steve Lin >>>>Acked-by: Andy Gospodarek >>>>--- >>>> include/net/devli

Re: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-20 Thread Steve Lin
On Fri, Oct 20, 2017 at 10:39 AM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 09:17:05PM CEST, steven.l...@broadcom.com wrote: >>Add support for permanent config parameter get/set commands. Used >>for parameters held in NVRAM, persistent device configuration. >> >>Signed

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-20 Thread Steve Lin
On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: > Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_V

Re: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-20 Thread Steve Lin
On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: >>> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent >>> config >>> parameter. Defines number of MSI-X vectors allocated per VF. >>> Value is permanent (stored in NVRAM),

Re: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-20 Thread Steve Lin
eport which parameters and options it supports (case (2))? Or are you suggesting something in the kernel API to handle case (1) above? > >> >> Signed-off-by: Steve Lin >> Acked-by: Andy Gospodarek >> --- >> include/net/devlink.h| 3 + >> include/uapi/li

Re: [PATCH net-next v2 6/6] bnxt: Add devlink support for config get/set

2017-10-19 Thread Steve Lin
On Thu, Oct 19, 2017 at 3:35 PM, Jiri Pirko wrote: > Thu, Oct 19, 2017 at 09:17:10PM CEST, steven.l...@broadcom.com wrote: >>Implements get and set of configuration parameters using new devlink >>config get/set API. > > Please split this patch too. One to introduce the infra, one per each > config

Re: [PATCH net-next v2 2/6] devlink: Adding SR-IOV enablement NVRAM config param

2017-10-19 Thread Steve Lin
his device. Value is permanent (stored >>in NVRAM), so becomes the new default value for this device. >> >>Signed-off-by: Steve Lin >>Acked-by: Andy Gospodarek >>--- >> include/uapi/linux/devlink.h | 5 + >> 1 file changed, 5 insertions(+) >> >&

[PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

2017-10-19 Thread Steve Lin
Add support for permanent config parameter get/set commands. Used for parameters held in NVRAM, persistent device configuration. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 3 + include/uapi/linux/devlink.h | 11 ++ net/core/devlink.c

[PATCH net-next v2 4/6] devlink: Adding max PF MSI-X vectors NVRAM config param

2017-10-19 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MAX_NUM_PF_MSIX_VECT permanent config parameter. Sets the maximum number of PF MSI-X (Message Signaled Interrupts) vectors. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v2 2/6] devlink: Adding SR-IOV enablement NVRAM config param

2017-10-19 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config parameter. If value is 1, SR-IOV is enabled. If value is 0, SR-IOV is disabled on this device. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek

[PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

2017-10-19 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent config parameter. Defines number of MSI-X vectors allocated per VF. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux

[PATCH net-next v2 0/6] Adding permanent config get/set to devlink

2017-10-19 Thread Steve Lin
h makes use of these new devlink cmds. Steve Lin (6): devlink: Add permanent config parameter get/set operations devlink: Adding SR-IOV enablement NVRAM config param devlink: Adding num VFs per PF NVRAM config param devlink: Adding max PF MSI-X vectors NVRAM config param devlink: Adding num MS

[PATCH net-next v2 3/6] devlink: Adding num VFs per PF NVRAM config param

2017-10-19 Thread Steve Lin
Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config parameter, which sets the number of VFs per PF in SR-IOV mode. Value is permanent (stored in NVRAM), so becomes the new default value for this device. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h

[PATCH net-next v2 6/6] bnxt: Add devlink support for config get/set

2017-10-19 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 245 +- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 17 ++ drivers

Re: [PATCH 2/7] devlink: Adding NPAR permanent config parameters

2017-10-19 Thread Steve Lin
On Thu, Oct 19, 2017 at 6:39 AM, Yuval Mintz wrote: >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_RESERVATION_VALID: 1 to use >> BW_RESERVATION setting, 0 to ignore. >> > ... >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT >> setting, 0 to ignore. > > While it probably ties to different fields

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-19 Thread Steve Lin
On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz wrote: >> +enum devlink_autoneg_protocol { >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, >> + DEVLINK_AUTONEG_PROTOCOL_BAM, /* Broad

[PATCH net-next] bnxt: Move generic devlink code to new file

2017-10-19 Thread Steve Lin
Moving generic devlink code (registration) out of VF-R code into new bnxt_devlink file, in preparation for future work to add additional devlink functionality to bnxt. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 11:22 AM, Or Gerlitz wrote: > On Tue, Oct 17, 2017 at 11:44 PM, Steve Lin > wrote: >> >> Add support for permanent config parameter get/set commands. Used >> for parameters held in NVRAM, persistent device configuration. >> The config_get

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 9:01 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:42PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: >>> >>> You need to split the config option to those that are per-port and to >>> those that are per-asic. For each famil

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 8:58 AM, Jiri Pirko wrote: > Wed, Oct 18, 2017 at 02:39:09PM CEST, steven.l...@broadcom.com wrote: >>On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: >>> Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: >>> Steve. As I originally requested, could you

Re: [PATCH 4/7] devlink: Adding perm config of link settings

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:31 AM, Jiri Pirko wrote: > > You need to split the config option to those that are per-port and to > those that are per-asic. For each family, you have to use ither > devlink_port of devlink handle. Also, you need to split into those that are > permanent and to those who

Re: [PATCH 6/7] bnxt: Move generic devlink code to new file

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:33 AM, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 10:44:28PM CEST, steven.l...@broadcom.com wrote: >>Moving generic devlink code (registration) out of VR-R code >>into new bnxt_devlink file. > > You can send this patch separatelly and let it be applied before the > patchset

Re: [PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-18 Thread Steve Lin
On Wed, Oct 18, 2017 at 3:11 AM, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 10:44:23PM CEST, steven.l...@broadcom.com wrote: > Steve. As I originally requested, could you please split this to: > 1) single patch adding config get/set commands, without any config attributes > 2) single patch per confi

Re: [PATCH 0/7] Adding permanent config get/set to devlink

2017-10-17 Thread Steve Lin
My apologies - this patchset was intended for net-next; I forgot to add that to the subject line, though. Steve On Tue, Oct 17, 2017 at 4:44 PM, Steve Lin wrote: > DIFFERENCES FROM RFC: > Implemented most of the changes suggested by Jiri and others. > Thanks for the valuable feedback!

[PATCH 1/7] devlink: Add permanent config parameter get/set operations

2017-10-17 Thread Steve Lin
. DEVLINK_ATTR_PERM_CFG_NUM_VF_PER_PF: Maximum number of VFs per PF, in SR-IOV mode. DEVLINK_ATTR_PERM_CFG_MAX_NUM_PF_MSIX_VECT: Maximum number of MSI-X vectors assigned per PF. DEVLINK_ATTR_PERM_CFG_MSIX_VECTORS_PER_VF: Number of MSI-X vectors allocated per VF. Signed-off-by: Steve Lin Acked-by: Andy

[PATCH 5/7] devlink: Adding pre-boot permanent config parameters

2017-10-17 Thread Steve Lin
t protocol; use enum devlink_mba_boot_protocol. DEVLINK_ATTR_PERM_CFG_MBA_LINK_SPEED: Configured link speed while executing MBA host software (PXI/iSCSI); use enum devlink_mba_link_speed. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devl

[PATCH 6/7] bnxt: Move generic devlink code to new file

2017-10-17 Thread Steve Lin
Moving generic devlink code (registration) out of VR-R code into new bnxt_devlink file. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net/ethernet/broadcom/bnxt

[PATCH 7/7] bnxt: Add devlink support for config get/set

2017-10-17 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 310 +- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 17 ++ drivers

[PATCH 3/7] devlink: Adding high level dev perm config params

2017-10-17 Thread Steve Lin
to enable Energy Efficient Ethernet (EEE), 0 to disable. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 27 ++- net/core/devlink.c | 12 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/include

[PATCH 0/7] Adding permanent config get/set to devlink

2017-10-17 Thread Steve Lin
bnxt driver patches make use of these new devlink cmds/ attributes. Steve Lin (7): devlink: Add permanent config parameter get/set operations devlink: Adding NPAR permanent config parameters devlink: Adding high level dev perm config params devlink: Adding perm config of link settings dev

[PATCH 4/7] devlink: Adding perm config of link settings

2017-10-17 Thread Steve Lin
devlink_pre_os_link_speed. DEVLINK_ATTR_PERM_CFG_PRE_OS_LINK_SPEED_D3: Configure default pre-OS link speed in sleep (D3) state; use enum devlink_pre_os_link_speed. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h | 27 ++- net/core/devlink.c

[PATCH 2/7] devlink: Adding NPAR permanent config parameters

2017-10-17 Thread Steve Lin
. DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT: Configures NPAR bandwidth or weight limit, in percent or 100 Mbps units, depending on BW_IN_PERCENT. DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT setting, 0 to ignore. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/uapi/linux/devlink.h

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
On Thu, Oct 12, 2017 at 3:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing object

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
ethtool settings to using devlink or rtnetlink API. Steve On Thu, Oct 12, 2017 at 10:35 AM, Roopa Prabhu wrote: > On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >> Adds a devlink command for getting & setting device configuration >> parameters, and enumerates a bunch of th

Re: [RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Steve Lin
t to have it >per-option. We need to make sure every option is very well described >and explained usecases. This is needed in order vendors to share > attributes among drivers. > > More nits inlined. > > >>Signed-off-by: Steve Lin >>Acked-by: Andy

[RFC 1/3] devlink: Add config parameter get/set operations

2017-10-12 Thread Steve Lin
restart is necessary for the setting to take effect. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- include/net/devlink.h| 4 + include/uapi/linux/devlink.h | 108 ++ net/core/devlink.c | 207 +++ 3 files

[RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Steve Lin
e case of the bnxt driver changes in this patchset, for which all the configuration changes affect NVM only, and aren't loaded until the next restart.) bnxt driver patches make use of these new devlink cmds/attributes. Steve Lin (3): devlink: Add config parameter get/set operations bnxt

[RFC 2/3] bnxt: Move generic devlink code to new file

2017-10-12 Thread Steve Lin
Moving generic devlink code (registration, etc.) out of VF-R code into new bnxt_devlink file. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + drivers/net/ethernet

[RFC 3/3] bnxt: Add devlink support for config get/set

2017-10-12 Thread Steve Lin
Implements get and set of configuration parameters using new devlink config get/set API. Signed-off-by: Steve Lin Acked-by: Andy Gospodarek --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 306 +- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 17 ++ drivers

[PATCH] net: ethernet: bgmac: Allow MAC address to be specified in DTB

2017-03-16 Thread Steve Lin
Allows the BCMA version of the bgmac driver to obtain MAC address from the device tree. If no MAC address is specified there, then the previous behavior (obtaining MAC address from SPROM) is used. Signed-off-by: Steve Lin --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 39