Re: [PATCH v2 07/16] clk: st: Remove uninitialized_var() usage

2020-06-22 Thread Stephen Boyd
.@mail.gmail.com/ > [3] > https://lore.kernel.org/lkml/ca+55afwgbgqhbp1fkxvrkepzyr5j8n1vkt1vzdz9knmpuxh...@mail.gmail.com/ > [4] > https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ > > Fixes: 5f7aa9071e93 ("clk: st: Support for QUADFS inside ClockGenB/C/D/E/F") > Signed-off-by: Kees Cook > --- Acked-by: Stephen Boyd

Re: [PATCH v2 09/16] clk: spear: Remove uninitialized_var() usage

2020-06-22 Thread Stephen Boyd
lkml/ca+55afwgbgqhbp1fkxvrkepzyr5j8n1vkt1vzdz9knmpuxh...@mail.gmail.com/ > [4] > https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ > > Fixes: 7d4998f71b29 ("clk: SPEAr: Vco-pll: Fix compilation warning") > Signed-off-by: Kees Cook > --- Acked-by: Stephen Boyd

Re: [PATCH 06/10] clk: st: Remove uninitialized_var() usage

2020-06-03 Thread Stephen Boyd
.@mail.gmail.com/ > [3] > https://lore.kernel.org/lkml/ca+55afwgbgqhbp1fkxvrkepzyr5j8n1vkt1vzdz9knmpuxh...@mail.gmail.com/ > [4] > https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ > > Signed-off-by: Kees Cook > --- Acked-by: Stephen Boyd

Re: [PATCH 2/4] r8169: Get and enable optional ether_clk clock

2018-08-30 Thread Stephen Boyd
Quoting Hans de Goede (2018-08-29 10:09:57) > Hi, > > On 27-08-18 21:14, Stephen Boyd wrote: > > Quoting Hans de Goede (2018-08-27 11:53:19) > >> On 27-08-18 20:47, Stephen Boyd wrote: > >>> How would you know that a clk device driver hasn't probed yet a

Re: [PATCH 3/4] clk: x86: Stop marking clocks as CLK_IS_CRITICAL

2018-08-29 Thread Stephen Boyd
g their battery > drain when suspended. > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102 > Cc: Johannes Stezenbach > Cc: Carlo Caione > Signed-off-by: Hans de Goede > --- Acked-by: Stephen Boyd

Re: [PATCH 2/4] r8169: Get and enable optional ether_clk clock

2018-08-27 Thread Stephen Boyd
Quoting Hans de Goede (2018-08-27 11:53:19) > On 27-08-18 20:47, Stephen Boyd wrote: > > How would you know that a clk device driver hasn't probed yet and isn't > > the driver that's actually providing the clk to this device on x86 > > systems? With DT systems

Re: [PATCH 2/4] r8169: Get and enable optional ether_clk clock

2018-08-27 Thread Stephen Boyd
clk driver commit adding the alias) > fixes things properly by making the r8169 get the clock and enable it when > it needs it. > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102 > Cc: Johannes Stezenbach > Cc: Carlo Caione > Signed-off-by: Hans d

Re: [PATCH 1/4] clk: x86: add "ether_clk" alias for Bay Trail / Cherry Trail

2018-08-27 Thread Stephen Boyd
g/show_bug.cgi?id=193891#c102 > Cc: Johannes Stezenbach > Cc: Carlo Caione > Signed-off-by: Hans de Goede > --- Acked-by: Stephen Boyd

[PATCH] net: ks8851: Drop eeprom_size structure member

2017-01-23 Thread Stephen Boyd
After commit 51b7b1c34e19 (KSZ8851-SNL: Add ethtool support for EEPROM via eeprom_93cx6, 2011-11-21) this structure member is unused. Delete it. Signed-off-by: Stephen Boyd --- Found while debugging an eeprom issue. drivers/net/ethernet/micrel/ks8851.c | 7 --- 1 file changed, 7 deletions

[PATCH] net: qrtr: Mark 'buf' as little endian

2017-01-09 Thread Stephen Boyd
types) net/qrtr/qrtr.c:276:16:expected unsigned int [unsigned] [usertype] net/qrtr/qrtr.c:276:16:got restricted __le32 [usertype] Silence it. Cc: Bjorn Andersson Signed-off-by: Stephen Boyd --- net/qrtr/qrtr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net

Re: [PATCH 2/6] net: ethernet: ti: cpts: add support for ext rftclk selection

2016-12-08 Thread Stephen Boyd
On 12/06, Grygorii Strashko wrote: > Subject: [PATCH] cpts refclk sel > > Signed-off-by: Grygorii Strashko > --- > arch/arm/boot/dts/keystone-k2e-netcp.dtsi | 10 +- > drivers/net/ethernet/ti/cpts.c| 52 > ++- > 2 files changed, 60 insertions(+), 2 de

Re: [PATCH v5 2/6] clk: gxbb: expose MPLL2 clock for use by DT

2016-09-07 Thread Stephen Boyd
On 09/06, Martin Blumenstingl wrote: > This exposes the MPLL2 clock as this is one of the input clocks of the > ethernet controller's internal mux. > > Signed-off-by: Martin Blumenstingl > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of

Re: [PATCH v3 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

2016-08-30 Thread Stephen Boyd
On 08/28, Martin Blumenstingl wrote: > +static int meson8b_init_clk(struct meson8b_dwmac *dwmac) > +{ > + struct clk_init_data init; > + int i, ret; > + struct device *dev = &dwmac->pdev->dev; > + char clk_name[32]; > + const char *clk_div_parents[1]; > + const char *mux_par

Re: [v7, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-04-01 Thread Stephen Boyd
On 03/31/2016 08:07 PM, Yangbo Lu wrote: > drivers/clk/clk-qoriq.c | 3 +-- > For clk part: Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable reparenting on rk3036

2016-03-15 Thread Stephen Boyd
t; So add the necessary clock-id and disable reparenting on set_rate calls. > > Signed-off-by: Heiko Stuebner > Signed-off-by: Caesar Wang > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC clock-id

2016-03-15 Thread Stephen Boyd
On 03/13, Caesar Wang wrote: > From: Xing Zheng > > Associate the new clock id the clock. > > Signed-off-by: Xing Zheng > Signed-off-by: Caesar Wang > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[PATCH] stmmac: ipq806x: Return error values instead of pointers

2015-12-02 Thread Stephen Boyd
Typically we return error pointers when we want to use those pointers in the non-error case, but this function is just returning error pointers or NULL for success. Change the style to plain int to follow normal kernel coding styles. Cc: Joachim Eastwood Signed-off-by: Stephen Boyd --- .../net