Re: E1000: bug on error path in e1000_probe()

2006-08-01 Thread Stephane Doyon
On Tue, 1 Aug 2006, Auke Kok wrote: Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifi

E1000: bug on error path in e1000_probe()

2006-08-01 Thread Stephane Doyon
Hi, The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_probe() calls netif_carrier_off(netdev); before re

tg3: oops on incompletely initialized rx ring

2006-07-12 Thread Stephane Doyon
void the nasty oops. Against 2.6.17. Thank you Signed-off-by: Stephane Doyon <[EMAIL PROTECTED]> --- linux/drivers/net/tg3.c.orig2006-07-12 12:20:33.0 -0400 +++ linux/drivers/net/tg3.c 2006-07-12 12:40:53.0 -0400 @@ -4143,7 +4143,8 @@ static void tg3_free_rings(stru