Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

2020-05-08 Thread Stefan Wahren
Hi Marek, Am 07.05.20 um 12:03 schrieb Marek Szyprowski: > Hi > > On 07.05.2020 11:46, Marek Szyprowski wrote: >> On 25.02.2020 14:11, Nicolas Saenz Julienne wrote: >>> Outdated Raspberry Pi 4 firmware might configure the external PHY as >>> rgmii although the kernel currently sets it as rgmii-rxi

Re: lan78xx and phy_state_machine

2019-10-17 Thread Stefan Wahren
Hi Daniel, Am 17.10.19 um 19:41 schrieb Daniel Wagner: > Hi Stefan, > > On Thu, Oct 17, 2019 at 07:05:32PM +0200, Stefan Wahren wrote: >> Am 17.10.19 um 08:52 schrieb Daniel Wagner: >>> On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: >>>> Pl

Re: lan78xx and phy_state_machine

2019-10-17 Thread Stefan Wahren
Hi Daniel, Am 17.10.19 um 08:52 schrieb Daniel Wagner: > On Wed, Oct 16, 2019 at 05:51:07PM +0200, Andrew Lunn wrote: >> Hi Daniel >> >> Please could you give this a go. It is totally untested, not even >> compile tested... > Sure. The system boots but ther is one splat: > this is a known issues s

Re: lan78xx and phy_state_machine

2019-10-15 Thread Stefan Wahren
Am 15.10.19 um 21:38 schrieb Heiner Kallweit: > On 15.10.2019 00:12, Russell King - ARM Linux admin wrote: >> On Mon, Oct 14, 2019 at 10:20:15PM +0200, Heiner Kallweit wrote: >>> On 14.10.2019 21:51, Stefan Wahren wrote: >>>> [add more recipients] >>>>

Re: lan78xx and phy_state_machine

2019-10-14 Thread Stefan Wahren
[add more recipients] Am 14.10.19 um 21:25 schrieb Daniel Wagner: > On Mon, Oct 14, 2019 at 05:30:04PM +0100, Russell King - ARM Linux admin > wrote: >> On Mon, Oct 14, 2019 at 04:06:04PM +0200, Daniel Wagner wrote: >>> Hi, >>> >>> I've trying to boot a RPi 3 Model B+ in 64 bit mode. While I can

Re: [PATCH v3 11/17] qca: no need to check return value of debugfs_create functions

2019-08-13 Thread Stefan Wahren
On 10.08.19 12:17, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: "David S. Miller" > Cc:

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-19 Thread Stefan Wahren
Hi Vasily, Am 18.02.19 um 22:24 schrieb Vasily Khoruzhick: > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: >> On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: >>> Add binding document for bluetooth part of RTL8723BS/RTL8723CS >>> >>> Signed-off-by: Vasily Khoruzhick >>> --

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-18 Thread Stefan Wahren
> Stefan Wahren hat am 18. Februar 2019 um 23:08 > geschrieben: > > > Hi Vasily, > > > Vasily Khoruzhick hat am 18. Februar 2019 um 22:24 > > geschrieben: > > > > > > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: > > &g

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-18 Thread Stefan Wahren
Hi Vasily, > Vasily Khoruzhick hat am 18. Februar 2019 um 22:24 > geschrieben: > > > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: > > > > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: > > > Add binding document for bluetooth part of RTL8723BS/RTL8723CS > > > > > > S

RE: lan78xx: WARNING: irq 79 handler enabled interrupts

2019-02-05 Thread Stefan Wahren
Hi, > Stefan Wahren hat am 1. Januar 2019 um 22:31 > geschrieben: > > > Hi Woojung, > > > woojung@microchip.com hat am 30. Dezember 2018 um 04:25 geschrieben: > > > > > > HI Marc & Stephen, > > > > Most of engineers are out

RE: lan78xx: WARNING: irq 79 handler enabled interrupts

2019-01-01 Thread Stefan Wahren
Hi Woojung, > woojung@microchip.com hat am 30. Dezember 2018 um 04:25 geschrieben: > > > HI Marc & Stephen, > > Most of engineers are out until New Year's Day. thanks. I didn't expect a reply that fast. > > LAN78xx driver uses irq_domain for phy interrupt, but smsc95xx uses polling. > N

hns3: Compilation of hns3_enet.c is triggered without changes

2018-12-29 Thread Stefan Wahren
Hi, during development i noticed that hns3_enet.c is compiled even without any changes to this file. I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define. Kind regards Stefan

lan78xx: WARNING: irq 79 handler enabled interrupts

2018-12-28 Thread Stefan Wahren
Hi, while booting my Raspberry Pi 3 B+ with Linux 4.20 (arm64/defconfig) i'm getting the following warning: [ 11.005738] irq 79 handler irq_default_primary_handler+0x0/0x8 enabled interrupts [ 11.024703] WARNING: CPU: 0 PID: 0 at kernel/irq/handle.c:153 __handle_irq_event_percpu+0x154/0x168

[PATCH] brcmfmac: Fix access point mode

2018-12-12 Thread Stefan Wahren
AP mode to fix this. Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") Suggested-by: Arend van Spriel Signed-off-by: Stefan Wahren --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/driv

Re: [PATCH] net: qca_spi: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-03 Thread Stefan Wahren
> Yangtao Li hat am 3. Dezember 2018 um 15:26 > geschrieben: > > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Acked-by: Stefan Wahren

[PATCH] net: smsc95xx: Fix MTU range

2018-11-08 Thread Stefan Wahren
("net: use core MTU range checking in USB NIC drivers") Signed-off-by: Stefan Wahren --- drivers/net/usb/smsc95xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 262e7a3..5974478 100644 --- a/drivers/net/usb/smsc95x

smsc95xx: Invalid max MTU

2018-09-05 Thread Stefan Wahren
Hi, recently there was a user who reports that his Raspberry Pi 3B didn't work as expected [1]. The problem is that the smsc95xx driver accepts to high MTU values ( > 9000) from userspace like dhcp-client, but according to the LAN9500 databook the chip seems only capable to handle MTU sizes <=

Re: [offlist] Re: Crash in netlink/sk_filter_trim_cap on ARMv7 on 4.18rc1

2018-08-17 Thread Stefan Wahren
Hi Daniel, > Daniel Borkmann hat am 17. August 2018 um 20:30 > geschrieben: > > > On 08/17/2018 06:17 PM, Russell King - ARM Linux wrote: > > On Fri, Aug 17, 2018 at 02:40:19PM +0200, Daniel Borkmann wrote: > >> I'd have one potential bug suspicion, for the 4.18 one you were trying, > >> could

net: smsc95xx: aligment issues

2018-04-28 Thread Stefan Wahren
Hi, after connecting a Raspberry Pi 1 B to my local network i'm seeing aligment issues under /proc/cpu/alignment: User: 0 System: 142 (_decode_session4+0x12c/0x3c8) Skipped:0 Half: 0 Word: 0 DWord: 127 Multi: 15 User faults:2 (fi

[PATCH v8 net-next 07/17] net: qca_spi: remove QCASPI_MTU

2017-05-29 Thread Stefan Wahren
There is no need for an additional MTU define. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index f155548..7464628

[PATCH v8 net-next 08/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-05-29 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qualcomm/qca_spi.c | 24

[PATCH v8 net-next 01/17] net: qualcomm: qca_7k: clean up header includes

2017-05-29 Thread Stefan Wahren
Currently the includes doesn't reflect the dependencies. So fix this up by removing all unnecessary entries and add the necessary ones explicit. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --

[PATCH v8 net-next 12/17] net: qualcomm: make qca_7k_common a separate kernel module

2017-05-29 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_7k_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile| 5 +++-- drivers

[PATCH v8 net-next 15/17] dt-bindings: slave-device: add current-speed property

2017-05-29 Thread Stefan Wahren
This adds a new DT property to define the current baud rate of the slave device. Signed-off-by: Stefan Wahren Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/serial/slave-device.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v8 net-next 13/17] dt-bindings: qca7000-spi: Rework binding

2017-05-29 Thread Stefan Wahren
In preparation for the QCA7000 UART binding rework the binding document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca-qca7000-spi.txt| 49 +- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/net/qca

[PATCH v8 net-next 03/17] net: qca_7k: Use BIT macro

2017-05-29 Thread Stefan Wahren
Use the BIT macro for the CONFIG and INT register values. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h

[PATCH v8 net-next 10/17] net: qualcomm: rename qca_framing.c to qca_7k_common.c

2017-05-29 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_7k_common would make it clear. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Makefile

[PATCH v8 net-next 00/17] net: qualcomm: add QCA7000 UART driver

2017-05-29 Thread Stefan Wahren
using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (17): net: qualcomm: qca_7k: clean up header includes net: qca_framing: use u16 for frame offset net: qca_7k: Use BIT macro net: qca_spi: Use SET_NETDEV_DEV() net: qualcomm: use net_device_ops

[PATCH v8 net-next 11/17] net: qualcomm: prepare frame decoding for UART driver

2017-05-29 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH v8 net-next 16/17] dt-bindings: qca7000: append UART interface to binding

2017-05-29 Thread Stefan Wahren
This merges the serdev binding for the QCA7000 UART driver (Ethernet over UART) into the existing document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca,qca7000.txt| 32 ++ 1 file changed, 32 insertions(+) diff --git a/Documentation/devicetree

[PATCH v8 net-next 02/17] net: qca_framing: use u16 for frame offset

2017-05-29 Thread Stefan Wahren
It doesn't make sense to use a signed variable for offset here, so fix it up. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_framing.h b/drivers/net/eth

[PATCH v8 net-next 14/17] dt-bindings: qca7000: rename binding

2017-05-29 Thread Stefan Wahren
Before we can merge the QCA7000 UART binding the document needs to be renamed. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca,qca7000.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/net/{

[PATCH v8 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-29 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm

[PATCH v8 net-next 09/17] net: qca_spi: Clarify MODULE_DESCRIPTION

2017-05-29 Thread Stefan Wahren
Since this driver is specific to the QCA7000, we should make the module description more precisely. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net

[PATCH v8 net-next 06/17] net: qualcomm: Improve readability of length defines

2017-05-29 Thread Stefan Wahren
In order to avoid mixing things up, make the MTU and frame length defines easier to read. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.c | 2 +- drivers/net/ethernet/qualcomm/qca_framing.h | 8 drivers/net/ethernet/qualcomm/qca_spi.c | 12

[PATCH v8 net-next 04/17] net: qca_spi: Use SET_NETDEV_DEV()

2017-05-29 Thread Stefan Wahren
Use SET_NETDEV_DEV() in qca_spi to create the "/sys/class/net//device" symlink. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_s

[PATCH v8 net-next 05/17] net: qualcomm: use net_device_ops instead of direct call

2017-05-29 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- drivers/net/ethernet/qualcomm

Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

2017-05-24 Thread Stefan Wahren
> David Miller hat am 24. Mai 2017 um 21:41 geschrieben: > > > From: Stefan Wahren > Date: Tue, 23 May 2017 15:12:37 +0200 > > > Most of the includes in qca_7k.c are unnecessary so we better remove them. > > > > Signed-off-by: Stefan Wahren > &

Re: [PATCH RESEND v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Stefan Wahren
Am 24.05.2017 um 16:21 schrieb Lino Sanfilippo: > Hi, > > >> This patch adds the Ethernet over UART driver for the >> Qualcomm QCA7000 HomePlug GreenPHY. >> >> Signed-off-by: Stefan Wahren >> --- > Reviewed-by: Lino Sanfilippo > Thanks Stefan

[PATCH RESEND v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm/qca_7k_common.h | 6 + drivers

[PATCH v7 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm/qca_7k_common.h | 6 + drivers

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-24 Thread Stefan Wahren
Am 23.05.2017 um 23:01 schrieb Lino Sanfilippo: > On 23.05.2017 21:38, Stefan Wahren wrote: >>> Lino Sanfilippo hat am 23. Mai 2017 um 20:16 >>> geschrieben: >>> >>> I suggest to avoid this possible race by first unregistering the netdevice >>> a

Re: [PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Stefan Wahren
> Lino Sanfilippo hat am 23. Mai 2017 um 20:16 > geschrieben: > > > Hi, > > On 23.05.2017 15:12, Stefan Wahren wrote: > > > > +} > > + > > +static void qca_uart_remove(struct serdev_device *serdev) > > +{ > > +

[PATCH v6 net-next 02/17] net: qca_framing: use u16 for frame offset

2017-05-23 Thread Stefan Wahren
It doesn't make sense to use a signed variable for offset here, so fix it up. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_framing.h b/drivers/net/eth

[PATCH v6 net-next 04/17] net: qca_spi: Use SET_NETDEV_DEV()

2017-05-23 Thread Stefan Wahren
Use SET_NETDEV_DEV() in qca_spi to create the "/sys/class/net//device" symlink. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_s

[PATCH v6 net-next 03/17] net: qca_7k: Use BIT macro

2017-05-23 Thread Stefan Wahren
Use the BIT macro for the CONFIG and INT register values. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h

[PATCH v6 net-next 12/17] net: qualcomm: make qca_7k_common a separate kernel module

2017-05-23 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_7k_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile| 5 +++-- drivers

[PATCH v6 net-next 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm/qca_7k_common.h | 6 + drivers

[PATCH v6 net-next 09/17] net: qca_spi: Clarify MODULE_DESCRIPTION

2017-05-23 Thread Stefan Wahren
Since this driver is specific to the QCA7000, we should make the module description more precisely. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net

[PATCH v6 net-next 15/17] dt-bindings: slave-device: add current-speed property

2017-05-23 Thread Stefan Wahren
This adds a new DT property to define the current baud rate of the slave device. Signed-off-by: Stefan Wahren Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/serial/slave-device.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v6 net-next 05/17] net: qualcomm: use net_device_ops instead of direct call

2017-05-23 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- drivers/net/ethernet/qualcomm

[PATCH v6 net-next 14/17] dt-bindings: qca7000: rename binding

2017-05-23 Thread Stefan Wahren
Before we can merge the QCA7000 UART binding the document needs to be renamed. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca,qca7000.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/net/{

[PATCH v6 net-next 10/17] net: qualcomm: rename qca_framing.c to qca_7k_common.c

2017-05-23 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_7k_common would make it clear. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Makefile

[PATCH v6 net-next 06/17] net: qualcomm: Improve readability of length defines

2017-05-23 Thread Stefan Wahren
In order to avoid mixing things up, make the MTU and frame length defines easier to read. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.c | 2 +- drivers/net/ethernet/qualcomm/qca_framing.h | 8 drivers/net/ethernet/qualcomm/qca_spi.c | 12

[PATCH v6 net-next 07/17] net: qca_spi: remove QCASPI_MTU

2017-05-23 Thread Stefan Wahren
There is no need for an additional MTU define. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index f155548..7464628

[PATCH v6 net-next 11/17] net: qualcomm: prepare frame decoding for UART driver

2017-05-23 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH v6 net-next 00/17] net: qualcomm: add QCA7000 UART driver

2017-05-23 Thread Stefan Wahren
hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (17): net: qualcomm: remove unnecessary includes net: qca_framing: use u16 for frame offset

[PATCH v6 net-next 13/17] dt-bindings: qca7000-spi: Rework binding

2017-05-23 Thread Stefan Wahren
In preparation for the QCA7000 UART binding rework the binding document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca-qca7000-spi.txt| 49 +- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/net/qca

[PATCH v6 net-next 16/17] dt-bindings: qca7000: append UART interface to binding

2017-05-23 Thread Stefan Wahren
This merges the serdev binding for the QCA7000 UART driver (Ethernet over UART) into the existing document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca,qca7000.txt| 32 ++ 1 file changed, 32 insertions(+) diff --git a/Documentation/devicetree

[PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

2017-05-23 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index

[PATCH v6 net-next 08/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-05-23 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qualcomm/qca_spi.c | 24

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

2017-05-19 Thread Stefan Wahren
Hi Rob, Am 12.05.2017 um 08:43 schrieb Jakub Kicinski: > On Fri, 12 May 2017 06:15:52 +, Michael Heimpold wrote: >> Hi, >> >> Zitat von Jakub Kicinski : >> >>> On Thu, 11 May 2017 21:12:22 +0200, Michael Heimpold wrote: >>>> Am Mittwoch, 1

Re: [PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-05-17 Thread Stefan Wahren
Hi Greg, Am 10.05.2017 um 10:53 schrieb Stefan Wahren: > Instead of returning the requested baudrate, we better return the > actual one because it isn't always the same. > > Signed-off-by: Stefan Wahren > Acked-by: Rob Herring > --- > drivers/tty/serdev/serdev-

[PATCH v5 04/17] net: qualcomm: use net_device_ops instead of direct call

2017-05-10 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.c | 4 ++-- drivers/net/ethernet/qualcomm

[PATCH v5 11/17] net: qualcomm: make qca_7k_common a separate kernel module

2017-05-10 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_7k_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile| 5 +++-- drivers

[PATCH v5 07/17] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-05-10 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qualcomm/qca_spi.c | 24

[PATCH v5 00/17] net: qualcomm: add QCA7000 UART driver

2017-05-10 Thread Stefan Wahren
(without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 [2] - http://marc.info/?l=linux-serial&m=149338017301309&w=2 Stefan Wahren (17): net:

[PATCH v5 10/17] net: qualcomm: prepare frame decoding for UART driver

2017-05-10 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH v5 08/17] net: qca_spi: Clarify MODULE_DESCRIPTION

2017-05-10 Thread Stefan Wahren
Since this driver is specific to the QCA7000, we should make the module description more precisely. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net

[PATCH v5 13/17] dt-bindings: qca7000: rename binding

2017-05-10 Thread Stefan Wahren
Before we can merge the QCA7000 UART binding the document needs to be renamed. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca-qca7000.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindings/net/{

[PATCH v5 12/17] dt-bindings: qca7000-spi: Rework binding

2017-05-10 Thread Stefan Wahren
In preparation for the QCA7000 UART binding rework the binding document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca-qca7000-spi.txt| 49 +- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bindings/net/qca

[PATCH v5 17/17] net: qualcomm: add QCA7000 UART driver

2017-05-10 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 16 + drivers/net/ethernet/qualcomm/Makefile| 2 + drivers/net/ethernet/qualcomm/qca_7k_common.h | 6 + drivers

[PATCH v5 14/17] dt-bindings: slave-device: add current-speed property

2017-05-10 Thread Stefan Wahren
This adds a new DT property to define the current baud rate of the slave device. Signed-off-by: Stefan Wahren --- Documentation/devicetree/bindings/serial/slave-device.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/slave-device.txt b

[PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

2017-05-10 Thread Stefan Wahren
This merges the serdev binding for the QCA7000 UART driver (Ethernet over UART) into the existing document. Signed-off-by: Stefan Wahren --- .../devicetree/bindings/net/qca-qca7000.txt| 32 ++ 1 file changed, 32 insertions(+) diff --git a/Documentation/devicetree

[PATCH v5 02/17] net: qca_framing: use u16 for frame offset

2017-05-10 Thread Stefan Wahren
It doesn't make sense to use a signed variable for offset here, so fix it up. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/qca_framing.h b/drivers/net/eth

[PATCH v5 01/17] net: qualcomm: remove unnecessary includes

2017-05-10 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index

[PATCH v5 06/17] net: qca_spi: remove QCASPI_MTU

2017-05-10 Thread Stefan Wahren
There is no need for an additional MTU define. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index a0dbb92..a239ac4

[PATCH v5 05/17] net: qualcomm: Improve readability of length defines

2017-05-10 Thread Stefan Wahren
In order to avoid mixing things up, make the MTU and frame length defines easier to read. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_framing.c | 2 +- drivers/net/ethernet/qualcomm/qca_framing.h | 8 drivers/net/ethernet/qualcomm/qca_spi.c | 12

[PATCH v5 09/17] net: qualcomm: rename qca_framing.c to qca_7k_common.c

2017-05-10 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_7k_common would make it clear. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Makefile

[PATCH v5 03/17] net: qca_7k: Use BIT macro

2017-05-10 Thread Stefan Wahren
Use the BIT macro for the CONFIG and INT register values. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h

[PATCH v5 16/17] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-05-10 Thread Stefan Wahren
Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren Acked-by: Rob Herring --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/s

[PATCH] net: qca_spi: Fix alignment issues in rx path

2017-05-09 Thread Stefan Wahren
The qca_spi driver causes alignment issues on ARM devices. So fix this by using netdev_alloc_skb_ip_align(). Signed-off-by: Stefan Wahren Fixes: 291ab06ecf67 ("net: qualcomm: new Ethernet over SPI driver for QCA7000") --- drivers/net/ethernet/qualcomm/qca_spi.c | 10 ++ 1 fi

Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

2017-05-09 Thread Stefan Wahren
Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm not happy with this patch. It d

Re: [PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:00 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> Currently serdev core doesn't provide functions to retrieve common >> UART settings like data bits, stop bits or parity. This patch adds >> the interface to

Re: [PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 17:44 schrieb Dan Williams: > On Mon, 2017-03-27 at 15:37 +0200, Stefan Wahren wrote: >> In order to share common functions between QCA7000 SPI and UART >> protocol >> driver the qca_common needs to be a separate kernel module. > Maybe "qca_eth_co

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren >> --- >> >> According to this bindin

[PATCH RFC v4 09/10] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-03-27 Thread Stefan Wahren
Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/dr

[PATCH RFC v4 02/10] net: qca_debug: use net_device_ops instead of direct call

2017-03-27 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files changed, 3 insertions

[PATCH RFC v4 08/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 10 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_common.h | 6 + drivers/net

[PATCH RFC v4 00/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
order of local variables where possible * implement basic serdev support (without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (10

[PATCH RFC v4 05/10] net: qualcomm: prepare frame decoding for UART driver

2017-03-27 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-27 Thread Stefan Wahren
This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). Signed-off-by: Stefan Wahren --- According to this binding are still some questions: Where should be the optional hardware flow control defined (at master or slave side)? Is it okay to have two bindings (qca-qca7000

[PATCH RFC v4 04/10] net: qualcomm: rename qca_framing.c to qca_common.c

2017-03-27 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Makefile

[PATCH RFC v4 03/10] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-03-27 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qualcomm/qca_spi.c | 24

[PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-27 Thread Stefan Wahren
Currently serdev core doesn't provide functions to retrieve common UART settings like data bits, stop bits or parity. This patch adds the interface to the core and the necessary implementation for serdev-ttyport. Signed-off-by: Stefan Wahren --- drivers/tty/serdev/core.c

[PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-27 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile | 5 +++-- drivers/net

[PATCH RFC v4 01/10] net: qualcomm: remove unnecessary includes

2017-03-27 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-03-03 Thread Stefan Wahren
Hi Baruch, Am 01.03.2017 um 11:54 schrieb Baruch Siach: > Hi Stefan, > > On Tue, Feb 28, 2017 at 07:32:09PM +0100, Stefan Wahren wrote: >>> Baruch Siach hat am 28. Februar 2017 um 19:07 >>> geschrieben: >>> On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wa

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Stefan Wahren
Hi Baruch, > Baruch Siach hat am 28. Februar 2017 um 19:07 geschrieben: > > > Hi Stefan, > > On Tue, Feb 28, 2017 at 05:21:18PM +0100, Stefan Wahren wrote: > > Am 28.02.2017 um 13:01 schrieb Baruch Siach: > > > On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch

Re: usb/net/hso: WARNING: ungligned urb->setup_dma

2017-02-28 Thread Stefan Wahren
Hi Baruch, Am 28.02.2017 um 13:01 schrieb Baruch Siach: Hi linux-usb list, (Dropped Jan's bouncing address, added Rpi3 platform lists) On Tue, Feb 28, 2017 at 10:28:10AM +0200, Baruch Siach wrote: Hi linux-usb list, I'm hitting this warning consistently on my Raspberry Pi 3 running kernel v4

  1   2   >