Re: [PATCH wpan-next v2 11/11] ieee802154: Give the user the association list

2023-09-18 Thread Stefan Schmidt
mimic the existing behavior inside nl802154_send_peer_info(), but I will drop that counter with no regrets. Yes, please drop for now. I does not serve a real purpose at the moment. If we need such a mechanism for userspace later we can see how we implement it when we have clear use cases. regards Stefan Schmidt

Re: [PATCH wpan-next v2 02/11] ieee802154: Internal PAN management

2023-09-16 Thread Stefan Schmidt
ded_addr; + default: + return false; + } +} Don't we already have such a helper already? regards Stefan Schmidt

Re: [PATCH wpan-next v2 11/11] ieee802154: Give the user the association list

2023-09-16 Thread Stefan Schmidt
? regards Stefan Schmidt

Re: [PATCH wpan-next v2 04/11] mac802154: Handle associating

2023-09-16 Thread Stefan Schmidt
? I see it icreases in free_peer_structure as weel as in associate. But I am not clear what this is used for. regards Stefan Schmidt

Re: [PATCH wpan-next v2 07/11] mac802154: Handle association requests from peers

2023-09-16 Thread Stefan Schmidt
ame.mhr.fc.version = IEEE802154_2003_STD; + frame.mhr.fc.source_addr_mode = IEEE802154_EXTENDED_ADDRESSING; + frame.mhr.seq = 10; Where does the 10 come from and what is the meaning? regards Stefan Schmidt

pull-request: ieee802154 for net 2021-04-07

2021-04-07 Thread Stefan Schmidt
avoid llsec handling on a monitor interface, which we do not support. Alex Shi removed a unused macro. Pavel Skripkin fixed another protection fault found by syzkaller. regards Stefan Schmidt The following changes since commit fcb3007371e1a4afb03280af1b336a83287fe115: Merge branch 'wireguard-

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-06 Thread Stefan Schmidt
ID locally here. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH RESEND wpan 00/15] net: ieee802154: forbid sec params for monitors

2021-04-06 Thread Stefan Schmidt
nl802154.c | 52 +++ 2 files changed, 56 insertions(+), 3 deletions(-) This series has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-03-08 Thread Stefan Schmidt
ey->tfm[i]) + if (!IS_ERR_OR_NULL(key->tfm[i])) crypto_free_aead(key->tfm[i]); kfree_sensitive(key); Alex, are you happy with this patch now? I would like to get it applied. Waiting for your review or ack given you had comments on the first version. regards Stefan Schmidt

Re: [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params

2021-03-02 Thread Stefan Schmidt
and 2 left out and only 3 applied. Could you resend 3-17 as a series and we can discuss 1 & 2 separately? regards Stefan Schmidt

Re: [PATCH wpan 03/17] net: ieee802154: nl-mac: fix check on panid

2021-03-02 Thread Stefan Schmidt
ch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned

2021-03-02 Thread Stefan Schmidt
the end of the range for u32. There is a path (info->attrs[NL802154_ATTR_IFTYPE] is not true) where we put type forward to rdev_add_virtual_intf() with its changed value but it would expect and enum which could hold -1 for UNSPEC. regards Stefan Schmidt

Re: [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs

2021-03-02 Thread Stefan Schmidt
hope. Thanks for the heads up. I dropped this patch and will take a look at the rest of the series today or tomorrow. regards Stefan Schmidt

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-24 Thread Stefan Schmidt
? Yes, I have it on my list. I will try to fix them at the weekend. Great, thank you! Thanks for handling these. Your first batch is reviewed and applied. I will wait for the next round before I send a pull request to net. regards Stefan Schmidt

Re: [PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey

2021-02-24 Thread Stefan Schmidt
Hello. On 21.02.21 18:43, Alexander Aring wrote: This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+368672e0da240db53...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --

Re: [PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey

2021-02-24 Thread Stefan Schmidt
This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH wpan 3/4] net: ieee802154: fix nl802154 add llsec key

2021-02-24 Thread Stefan Schmidt
This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev

2021-02-24 Thread Stefan Schmidt
patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH wpan 1/4] net: ieee802154: fix nl802154 del llsec key

2021-02-24 Thread Stefan Schmidt
Y_ATTR_ID], &id) < 0) This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] net/ieee802154: remove unused macros to tame gcc

2020-11-06 Thread Stefan Schmidt
Hello. On 06.11.20 09:10, Alex Shi wrote: Signed-off-by: Alex Shi Cc: Alexander Aring Cc: Stefan Schmidt Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-w...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- net/ieee802154/nl802154.c | 4 ---

Re: [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues

2020-11-03 Thread Stefan Schmidt
in 'ca8210_remove' drivers/net/ieee802154/ca8210.c:3104: warning: Function parameter or member 'spi_device' not described in 'ca8210_probe' drivers/net/ieee802154/ca8210.c:3104: warning: Excess function parameter 'priv' description in 'ca8210_prob

Re: [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc

2020-11-03 Thread Stefan Schmidt
s function parameter 'cas_ctrl' description in 'ca8210_rx_done' Cc: Harry Morris Cc: Alexander Aring Cc: Stefan Schmidt Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-w...@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

2020-10-06 Thread Stefan Schmidt
o Carvalho Chehab --- Documentation/networking/ieee802154.rst | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH v5 25/52] docs: net: ieee802154.rst: fix C expressions

2020-10-06 Thread Stefan Schmidt
On 06.10.20 16:03, Mauro Carvalho Chehab wrote: There are some warnings produced with Sphinx 3.x: Documentation/networking/ieee802154.rst:29: WARNING: Error in declarator or parameters Invalid C declaration: Expecting "(" in parameters. [error at 7] int sd = socket(

Re: [RESEND net-next 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-10-06 Thread Stefan Schmidt
t_mtx); - tasklet_init(&local->tasklet, -ieee802154_tasklet_handler, -(unsigned long)local); + tasklet_setup(&local->tasklet, ieee802154_tasklet_handler); skb_queue_head_init(&local->skb_queue); Acked-by: Stefan Schmidt regards Stefan Schmidt

pull-request: ieee802154 for net 2020-09-08

2020-09-08 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. A potential memory leak fix for ca8210 from Liu Jian, a check on the return for a register read in adf7242 and finally a user after free fix in the softmac tx function from Eric found by syzkaller. regards Stefan Schmidt The following

Re: [PATCH net] mac802154: tx: fix use-after-free

2020-09-08 Thread Stefan Schmidt
by: syzbot Cc: Alexander Aring Cc: Stefan Schmidt Cc: linux-w...@vger.kernel.org --- net/mac802154/tx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c index ab52811523e992f33f0855cdb711a2

Re: [PATCH 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Stefan Schmidt
;local->iflist_mtx); - tasklet_init(&local->tasklet, -ieee802154_tasklet_handler, -(unsigned long)local); + tasklet_setup(&local->tasklet, ieee802154_tasklet_handler); skb_queue_head_init(&local->skb_queue); Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg

2020-08-03 Thread Stefan Schmidt
read_reg(lp, 0, &len_u8); + ret = adf7242_read_reg(lp, 0, &len_u8); + if (ret) + return ret; len = len_u8; This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net] ieee802154: fix one possible memleak in ca8210_dev_com_init

2020-07-21 Thread Stefan Schmidt
CC. This allows me to track patches with patchwork. Applied this one manually. This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH 24/24] net: pass a sockptr_t into ->setsockopt

2020-07-20 Thread Stefan Schmidt
) + sockptr_t optval, unsigned int optlen) { struct dgram_sock *ro = dgram_sk(sk); struct net *net = sock_net(sk); @@ -882,7 +882,7 @@ static int dgram_setsockopt(struct sock *sk, int level, int optname, if (optlen < sizeof(int)) return -EINVAL; - if (get_user(val, (int __user *)optval)) + if (copy_from_sockptr(&val, optval, sizeof(int))) return -EFAULT; For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH v2 net] ieee802154: fix one possible memleak in adf7242_probe

2020-07-20 Thread Stefan Schmidt
ore sending a second version make sure you check replies to your patch postings. I already applied the v1 patch to my wpan tree which goes into net. As v2 it is identical v1 therei s nothing to do here for me. regards Stefan Schmidt

pull-request: ieee802154 for net 2020-07-20

2020-07-20 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. A potential memory leak fix for adf7242 from Liu Jian, and one more HTTPS link change from Alexander A. Klimov. regards Stefan Schmidt The following changes since commit 473309fb8372365ad211f425bca760af800e10a7: net: dp83640: fix

Re: [PATCH for v5.9] net: ieee802154: adf7242: Replace HTTP links with HTTPS ones

2020-07-20 Thread Stefan Schmidt
om/ADF7242 + * https://www.analog.com/ADF7242 */ #include This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: fix one possible memleak in adf7242_probe

2020-07-17 Thread Stefan Schmidt
i_device *spi) return ret; err_hw_init: + destroy_workqueue(lp->wqueue); +err_alloc_wq: mutex_destroy(&lp->bmux); ieee802154_free_hw(lp->hw); This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH 05/22] net: remove compat_sock_common_{get,set}sockopt

2020-07-17 Thread Stefan Schmidt
n_setsockopt, - .compat_getsockopt = compat_sock_common_getsockopt, -#endif For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH 1/2] docs: net: ieee802154: change link to new project URL

2020-06-19 Thread Stefan Schmidt
Hello. On 19.06.20 21:56, David Miller wrote: From: Stefan Schmidt Date: Fri, 19 Jun 2020 09:14:22 +0200 I see you marked both patches here as awaiting upstream in patchwork. I am not really sure what to do best now. Am I supposed to pick them up myself and send them in my usual ieee802154

pull-request: ieee802154 for net 2020-06-19

2020-06-19 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Just two small maintenance fixes to update references to the new project homepage. regards Stefan Schmidt The following changes since commit 0ad6f6e767ec2f613418cbc7ebe5ec4c35af540c: net: increment xmit_recursion level in

Re: [PATCH 1/2] docs: net: ieee802154: change link to new project URL

2020-06-19 Thread Stefan Schmidt
Hello Dave. On 16.06.20 08:58, Stefan Schmidt wrote: We finally came around to setup a new project website. Update the reference here. Signed-off-by: Stefan Schmidt --- Documentation/networking/ieee802154.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 2/2] MAINTAINERS: update ieee802154 project website URL

2020-06-16 Thread Stefan Schmidt
Update URL to our new home. Signed-off-by: Stefan Schmidt --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50659d76976b..6cd52c922bfa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8225,7 +8225,7 @@ M:Alexander Aring M

[PATCH 1/2] docs: net: ieee802154: change link to new project URL

2020-06-16 Thread Stefan Schmidt
We finally came around to setup a new project website. Update the reference here. Signed-off-by: Stefan Schmidt --- Documentation/networking/ieee802154.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/ieee802154.rst b/Documentation/networking

Re: [PATCH net-next] ieee802154: 6lowpan: remove unnecessary comparison

2020-05-08 Thread Stefan Schmidt
0xe8); } /* lowpan_rx_h_check checks on generic 6LoWPAN requirements This looks good to me. Thanks for fixing this. Signed-off-by: Stefan Schmidt Dave, can you apply this directly to your net tree? I have no other ieee802154 fixes pending to fill a pull request. regards Stefan Schmidt

pull-request: ieee802154 for net 2019-09-28

2019-09-28 Thread Stefan Schmidt
memcpy in the mcr20a driver I switched from branches to tags here to be pulled from. So far not annotated and not signed. Once I fixed my scripts it should contain this messages as annotations. If you want it signed as well just tell me. If there are any problems let me know. regards Stefan Schmidt

Re: [PATCH 4/5] ieee802154: enforce CAP_NET_RAW for raw sockets

2019-09-21 Thread Stefan Schmidt
02154_raw_ops; > break; > I assume this will go as a whole series into net. If you want me to pick it up into my tree directly let me know. Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: ANNOUNCE: rpld an another RPL implementation for Linux

2019-09-12 Thread Stefan Schmidt
leak fixes to config.c as well as a travis setup to get building on CI as well as submitting to Coverity scan service (the later two are already tested in practice with some dev branches I pushed to the github repo, hope you don't mind). regards Stefan Schmidt

pull-request: ieee802154 for net 2019-08-24

2019-08-24 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Yue Haibing fixed two bugs discovered by KASAN in the hwsim driver for ieee802154 and Colin Ian King cleaned up a redundant variable assignment. If there are any problems let me know. regards Stefan Schmidt The following changes

Re: [PATCH 17/17] ieee802154: no need to check return value of debugfs_create functions

2019-08-06 Thread Stefan Schmidt
xander Aring > Cc: Stefan Schmidt > Cc: "David S. Miller" > Cc: Harry Morris > Cc: linux-w...@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/net/ieee802154/adf7242.c | 12 +++- > drivers/net/ieee8021

Re: pull-request: ieee802154 for net 2019-04-25

2019-04-30 Thread Stefan Schmidt
Hello Dave. On 30.04.19 00:21, David Miller wrote: > From: Stefan Schmidt > Date: Thu, 25 Apr 2019 18:03:11 +0200 > >> An update from ieee802154 for your *net* tree. >> >> Another fix from Kangjie Lu to ensure better checking regmap updates in the >> mcr20a dr

pull-request: ieee802154 for net 2019-04-25

2019-04-25 Thread Stefan Schmidt
handle this? Just merge once every rc? Merge just before sending a pull request? Never merge, wait for Dave to pull and merge and do a pull of his tree directly afterwards? regards Stefan Schmidt The following changes since commit 1c5c12ee308aacf635c8819cd4baa3bd58f8a8b7: net/ncsi: handle

[PATCH] MAINTAINERS: ieee802154: update documentation file pattern

2019-04-08 Thread Stefan Schmidt
When moving the documentation for the ieee802154 subsystem from plain text to rst the file pattern in the MAINTAINERS file got wrong. Updating it here to fix scripts using this file. Reported-by: Joe Perches Signed-off-by: Stefan Schmidt --- MAINTAINERS | 2 +- 1 file changed, 1 insertion

pull-request: ieee802154 for net 2019-03-19

2019-03-19 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Kangjie Lu fixed a potential NULL pointer deref in the adf7242 driver and Li RongQing make sure we propagate a netlink return code to the caller. If there are any problems let me know. regards Stefan Schmidt The following changes

Re: [PATCH 0/2] doc: net: ieee802154: move from plain text to rst

2019-02-27 Thread Stefan Schmidt
Hello Jon. On 27.02.19 21:18, Jonathan Corbet wrote: > On Wed, 27 Feb 2019 20:59:12 +0100 > Stefan Schmidt wrote: > >> The patches are based on net-next, but they only touch the networking book >> so I >> would not expect and trouble. From what I have seen they wou

[PATCH 1/2] doc: net: ieee802154: introduce IEEE 802.15.4 subsystem doc in rst style

2019-02-27 Thread Stefan Schmidt
Moving the ieee802154 docs from a plain text file into the new rst style. This commit only does the minimal needed change to bring the documentation over. Follow up patches will improve and extend on this. Signed-off-by: Stefan Schmidt --- Documentation/networking/ieee802154.rst | 180

[PATCH 2/2] doc: net: ieee802154: remove old plain text docs after switching to rst

2019-02-27 Thread Stefan Schmidt
The plain text docs are converted to rst now, which allows us to remove the old text file from the tree. Signed-off-by: Stefan Schmidt --- Documentation/networking/ieee802154.txt | 177 1 file changed, 177 deletions(-) delete mode 100644 Documentation/networking

[PATCH 0/2] doc: net: ieee802154: move from plain text to rst

2019-02-27 Thread Stefan Schmidt
-next, but they only touch the networking book so I would not expect and trouble. From what I have seen they would go through Jonathan's tree after being acked by Dave? If you want this patches against a different tree let me know. regards Stefan Schmidt Stefan Schmidt (2): doc: net: ieee8

Re: [PATCH net-next] net: remove unused struct inet_frag_queue.fragments field

2019-02-26 Thread Stefan Schmidt
*fq, > struct sk_buff *skb, >skb_network_header_len(skb), >skb->csum); > > - fq->q.fragments = NULL; > fq->q.rb_fragments = RB_ROOT; > fq->q.fragments_tail = NULL; > fq->q.last_run_head = NULL; > diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c > index 24264d0a4b85..1a832f5e190b 100644 > --- a/net/ipv6/reassembly.c > +++ b/net/ipv6/reassembly.c > @@ -304,7 +304,6 @@ static int ip6_frag_reasm(struct frag_queue *fq, struct > sk_buff *skb, > rcu_read_lock(); > __IP6_INC_STATS(net, __in6_dev_get(dev), IPSTATS_MIB_REASMOKS); > rcu_read_unlock(); > - fq->q.fragments = NULL; > fq->q.rb_fragments = RB_ROOT; > fq->q.fragments_tail = NULL; > fq->q.last_run_head = NULL; > For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

pull-request: ieee802154-next 2019-02-19

2019-02-19 Thread Stefan Schmidt
any problems. regards Stefan Schmidt The following changes since commit c9b747dbc2036c917b1067fbb78dc38b105c4454: bnx2x: Remove set but not used variable 'mfw_vn' (2019-02-18 16:47:32 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/ssc

Re: [PATCH RFC net-next] 6lowpan: use rbtree for IP frag queue

2019-02-18 Thread Stefan Schmidt
exander Aring > > I tested this series and the code looks a lot simpler. Thanks. > > Stefan do you see any issues? >From my side it looks good as well. Thanks for the effort Peter to move this one over as well! This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

pull-request: ieee802154 for net 2019-01-31

2019-01-31 Thread Stefan Schmidt
these two before the final 5.0 let me know. Greetings from Brussels, FOSDEM ahead. :-) regards Stefan Schmidt The following changes since commit 3aa9179b2dfe06d32d4248f07cf6dd005a964507: Merge branch 'stmmac-fixes' (2019-01-30 22:24:49 -0800) are available in the Git reposi

Re: [PATCH] ieee802154: mcr20a: fix indentation, remove tabs

2019-01-14 Thread Stefan Schmidt
t; This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

pull-request: ieee802154 for net 2018-12-11

2018-12-11 Thread Stefan Schmidt
there are any problems with taking these two before the final 4.20 let me know. regards Stefan Schmidt The following changes since commit 35b827b6d06199841a83839e8bb69c0cd13a28be: tun: forbid iface creation with rtnl ops (2018-11-30 17:31:03 -0800) are available in the Git repository at: git

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

2018-12-11 Thread Stefan Schmidt
ong\n", > + "Received packet len (%u) erroneously long\n", > len > ); > goto finish; > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

2018-12-11 Thread Stefan Schmidt
efore I go ahead and apply it. I will take this one directly now and do some smoke testing. It will come together with another fix as pull request to you. regards Stefan Schmidt

pull-request: ieee802154-next 2018-10-04

2018-10-04 Thread Stefan Schmidt
pull, or let me know if there are any problems. regards Stefan Schmidt The following changes since commit 1042caa79e9351b81ed19dc8d2d7fd6ff51a4422: net-ipv4: remove 2 always zero parameters from ipv4_redirect() (2018-09-26 20:30:55 -0700) are available in the Git repository at: git

pull-request: ieee802154 for net 2018-09-28

2018-09-28 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for your *net* tree. Some cleanup patches throughout the drivers from the Huawei tag team Yue Haibing and Zhong Jiang. Xue is replacing some magic numbers with defines in his mcr20a driver. regards Stefan Schmidt The following changes since commit

Re: [PATCH] ieee802154: ca8210: remove redundant condition check before debugfs_remove

2018-09-27 Thread Stefan Schmidt
o); > dev_info(&priv->spi->dev, "Test interface removed\n"); > } > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: remove a redundant local variable 'i'

2018-09-27 Thread Stefan Schmidt
\ > Sorry, but this patch is wrong. The variable i is used in line 513 inside the CMD() macro. The compiler clearly tells this when running with your patch: net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’: net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first us

Re: [PATCH net-next] ieee802154: hwsim: fix missing unlock on error in hwsim_add_one()

2018-08-08 Thread Stefan Schmidt
l_others(phy); > - if (err < 0) > + if (err < 0) { > + mutex_unlock(&hwsim_phys_lock); > goto err_reg; > + } > } > list_add_tail(&phy->list, &hwsim_phys); > mutex_unlock(&hwsim_phys_lock); > Signed-off-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: hwsim: fix rcu handling

2018-08-08 Thread Stefan Schmidt
ix rcu address annotation"), but there was more which was > pointed out on my side by using newest sparse version. > > Cc: Stefan Schmidt > Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") > Signed-off-by: Alexander Aring > --- > After I instal

Re: [PATCH net-next] ieee802154: hwsim: fix copy-paste error in hwsim_set_edge_lqi()

2018-08-08 Thread Stefan Schmidt
{ > + if (!einfo) { > mutex_unlock(&hwsim_phys_lock); > return -ENOMEM; > } > Thanks a lot for finding and fixing these two bugs! Signed-off-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread Stefan Schmidt
ypes in comparison expression (different address spaces) > ... > > Some __rcu annotation was at non-pointers list head structures and one was > missing in edge information which is used by rcu_assign_pointer() to > update edge setting information. > > Cc: Stefan Schmidt > Fi

pull-request: ieee802154-next 2018-08-06

2018-08-06 Thread Stefan Schmidt
put them here and added a cc: stable to them. Please pull, or let me know if there are any problems. regards Stefan Schmidt The following changes since commit 981467033a37d916649647fa3afe1fe99bba1817: tc-testing: remove duplicate spaces in skbedit match patterns (2018-08-05 17:39:24 -0700

Re: [PATCH wpan 2/2] net: mac802154: tx: expand tailroom if necessary

2018-08-06 Thread Stefan Schmidt
will not submit another pull request for 4.18. Instead I added cc stable to the patch to make sure it gets picked into the stable tree once 4.18 is out. regards Stefan Schmidt

Re: [PATCHv2 wpan] net: 6lowpan: fix reserved space for single frames

2018-08-06 Thread Stefan Schmidt
t; ret = lowpan_header(skb, ldev, &dgram_size, &dgram_offset); > if (ret < 0) { > This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! I know you submitted this for wpan instead of wpan-next, but with rc

pull-request: ieee802154 for net 2018-07-11

2018-07-11 Thread Stefan Schmidt
BUG_ON vs WARN_ON usage. regards Stefan Schmidt The following changes since commit 5e7ba042fd05043416babace5a4a953e29cf2826: qed: Fix reading stale configuration information (2018-07-05 13:27:09 +0900) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

2018-07-06 Thread Stefan Schmidt
> + if (!skb) > + return NET_XMIT_DROP; > + } > > ret = lowpan_header(skb, ldev, &dgram_size, &dgram_offset); > if (ret < 0) { > The rest looks fine to me. regards Stefan Schmidt

Re: [PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

2018-07-06 Thread Stefan Schmidt
Hello David. On 06.07.2018 09:54, David Palma wrote: > Hi Stefan, > > On 05/07/18 13:16, Stefan Schmidt wrote: >> Hello. >> >> [CC David Palma and Rabi Narayan Sahoo] >> >> On 02.07.2018 22:32, Alexander Aring wrote: >>> This patch fixes patch

[PATCH net] MAINTAINERS: update my email address

2018-07-05 Thread Stefan Schmidt
The mail server hosting the old address is going to fade out. Time to update to an address I control directly. Signed-off-by: Stefan Schmidt --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b40d702337f2..ca3e75ec9308 100644

Re: [PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

2018-07-05 Thread Stefan Schmidt
and you please test these two patches and verify that it fixes the problems you have? regards Stefan Schmidt > --- > net/ieee802154/6lowpan/tx.c | 21 ++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/net/ieee802154/6lowpan/tx.c b/net

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-17 Thread Stefan Schmidt
Hello Greg. On 17.05.2018 10:59, Greg KH wrote: > On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: >> Hello. >> >> >> Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 >> >> (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x

net: ieee802154: 6lowpan: fix frag reassembly

2018-05-14 Thread Stefan Schmidt
it directly when i sent him the pull request. First time stable request on my side here, let me know if I got something wrong. regards Stefan Schmidt

Re: pull-request: ieee802154 2018-05-08

2018-05-09 Thread Stefan Schmidt
Hello. On 05/09/2018 02:06 AM, David Miller wrote: > From: Stefan Schmidt > Date: Tue, 8 May 2018 21:55:37 +0200 > >> On 05/08/2018 04:18 PM, David Miller wrote: >>> Please submit the -stable fix directly, you can feel free to CC: me. >> Will do when the patch hit

Re: pull-request: ieee802154 2018-05-08

2018-05-08 Thread Stefan Schmidt
Hello. On 05/08/2018 04:18 PM, David Miller wrote: > From: Stefan Schmidt > Date: Tue, 8 May 2018 10:29:27 +0200 > >> An update from ieee802154 for your *net* tree. >> >> Two fixes for the mcr20a driver, which was being added in the 4.17 merge >> window, >&

pull-request: ieee802154 2018-05-08

2018-05-08 Thread Stefan Schmidt
get IPv6 reassembly working again for the ieee802154 6lowpan adaptation. This got broken in 4.16 so please queue this one also up for the 4.16 stable tree. regards Stefan Schmidt The following changes since commit aa8f8778493c85fff480cdf8b349b1e1dcb5f243: ipv6: add RTA_TABLE and RTA_PREFSRC to

Re: [PATCH v4 net-next 08/19] inet: frags: use rhashtables for reassembly units

2018-04-16 Thread Stefan Schmidt
as I just found it and wanted to let you know in case you have an idea what's going on. I will try to make some room this week to help with debugging and fixing. regards Stefan Schmidt

Re: [PATCH] net: ieee802154: atusb: Replace GFP_ATOMIC with GFP_KERNEL in atusb_probe

2018-04-12 Thread Stefan Schmidt
(0, GFP_ATOMIC); > + atusb->tx_urb = usb_alloc_urb(0, GFP_KERNEL); > if (!atusb->tx_urb) > goto fail; > This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Stefan Schmidt
/* init mcr20a local data */ > @@ -1366,6 +1367,8 @@ mcr20a_probe(struct spi_device *spi) > > free_dev: > ieee802154_free_hw(lp->hw); > +free_pdata: > + kfree(pdata); > > return ret; > } This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

2018-04-10 Thread Stefan Schmidt
from there. No worries, I did this manually for you this time. For the next time please use the correct format to have this tracked. regards Stefan Schmidt

pull-request: ieee802154-next 2018-03-29

2018-03-29 Thread Stefan Schmidt
are simple fixes) let me know. regards Stefan Schmidt The following changes since commit 23e19fd4fb07eebf96909a86b8545bc4aa682e54: Merge branch 'tcp_bbr-more-GSO-work' (2018-03-01 21:44:29 -0500) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH net] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-08 Thread Stefan Schmidt
Hello Dave. On 03/06/2018 01:56 PM, Stefan Schmidt wrote: > Hello. > > > On 03/05/2018 05:51 PM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> A tun device type can trivially be set to arbitrary value using >> TUNSETLINK ioctl(). >> >> Therefo

Re: [PATCH net] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

2018-03-06 Thread Stefan Schmidt
2c88b5283f60d ("ieee802154: 6lowpan: remove check on null") > Signed-off-by: Eric Dumazet > Cc: Alexander Aring > Cc: Stefan Schmidt > Reported-by: syzbot > --- >  net/ieee802154/6lowpan/core.c |   12 >  1 file changed, 8 insertions(+), 4 deletions(-) >

Re: [PATCH][next] ieee802154: remove unused variable 'val'

2018-03-02 Thread Stefan Schmidt
IAR_RX_FRAME_FLT_NS_FT); This patch has been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH net-next 20/28] net: Convert cfg802154_pernet_ops

2018-02-27 Thread Stefan Schmidt
t; @@ -345,6 +345,7 @@ static void __net_exit cfg802154_pernet_exit(struct net > *net) > > static struct pernet_operations cfg802154_pernet_ops = { > .exit = cfg802154_pernet_exit, > + .async = true, > }; > > static int __init wpan_phy_class_init(void) > Acked-by: Stefan Schmidt regards Stefan Schmidt

pull-request: ieee802154-next 2018-02-26

2018-02-26 Thread Stefan Schmidt
Hello Dave. An update from ieee802154 for *net-next* Alexander corrected a setting which got lost during some 6lowpan rework a while back and Xue Liu provided us with a new driver for the MCR20A transceiver. If there are any issues let me know. If not, please pull. regards Stefan Schmidt The

pull-request: ieee802154-next 2017-12-04

2017-12-04 Thread Stefan Schmidt
Stefan Schmidt

pull-request: net-next: ieee802154 2017-11-09

2017-11-09 Thread Stefan Schmidt
cleanups across the subsystem from myself Please pull, thanks a lot! regards Stefan Schmidt The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b: Merge branch 'eBPF-based-device-cgroup-controller' (2017-11-05 23:26:51 +0900) are available in the git repository

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

2017-11-06 Thread Stefan Schmidt
been applied to the wpan-next tree and will be part of the next pull request to net-next. Thanks! regards Stefan Schmidt

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

2017-11-06 Thread Stefan Schmidt
t;regmap_short, REG_INTCON, > -BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE); > +BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE); > } > > static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 > channel) > Could you r

Re: linux-4.14-rc3/drivers/net/ieee802154/atusb.c:827: pointless test ?

2017-10-19 Thread Stefan Schmidt
Geert pointed the compiler warnign out a while ago and I actually did a fix that works for it already. https://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next.git/commit/?id=763556980dde78166886734ae470664c67067dd4 Its waiting for getting pulled into net-next right now. regards Stefan Schmidt

pull-request: ieee802154 2017-10-18

2017-10-18 Thread Stefan Schmidt
From: Stefan Schmidt Hello Dave. Please find below a pull request from the ieee802154 subsystem for net-next. regards Stefan Schmidt The following changes since commit b9f1f1ce866c28e3d9b86202441b220244754a69: tcp: fix tcp_xmit_retransmit_queue() after rbtree introduction (2017-10-18 14

  1   2   >