> From: Srinivasan Raju
> Sent: 26 February 2021 13:09
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
>
> This driver implementation has been based on the zd1211rw driver.
>
> Driver is based on 802.11 softMAC Architecture and
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v14:
- Endianess comments addressed
- Sparse checked and fixed warnings
- Firmware files renamed to lowercase
- All other review comments in v13 addressed
v13:
- Removed unused #defines
v12
> Having the firmware files under plfxlc/ directory looks good to me. But I'm
> not really a fan of upper case filenames, is there a reason for that? I would
> prefer have all lowercase filenames.
Thanks for your suggestions. We have renamed the firmware names to lower-case
and will submit v1
> That wasn't my point. My point was that the kernel code trusts the validity
> of the firmware image, in the sense of e.g. this piece:
>> + no_of_files = *(u32 *)&fw_packed->data[0];
> If the firmware file was corrupted (intentionally/maliciously or not), this
> could now be say 0xfff
Are you really doing CCK/OFDM in some (strange?) way?
Yes, your understanding is correct, and we use OFDM.
For now we will use the existing band definition.
Thanks
Srini
From: Johannes Berg
Sent: Friday, February 12, 2021 7:14 PM
To: Srinivasan Raju
Cc: M
> Ah, kbuild bot had already reported few issues:
> https://patchwork.kernel.org/project/linux-wireless/patch/20210212115030.124490-1-srini.r...@purelifi.com/
> Please fix those and I recommend waiting few days in case the bot finds
> more issues. After that you can submitt v14 fixing the comme
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v13
- Removed unused #defines
v12:
- Removed sysfs, procfs related code
- Addressed race condition bug
- Used macros instead of magic numbers in firmware.c
- Added copyright in all files
v11, v10
> I haven't had time to do a throrough review yet, but I suggest fixing
> the stuff I commented and submitting v12. I'll then do a new review with v12.
Hi Kalle,
We have submitted v12 of the driver for review.
Thanks
Srini
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v12:
- Removed sysfs, procfs related code
- Addressed race condition bug
- Used macros instead of magic numbers in firmware.c
- Added copyright in all files
v11, v10:
- Addressed review comment on
> I see lots of magic numbers in the driver like 2, 0x33 and 0x34 here.
> Please convert the magic numbers to proper defines explaining the meaning.
> And for vendor commands you could even use enum to group them better in .h
> file somewhere.
Hi Kalle,
Thanks for reviewing the driver, We wil
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v11, v10:
- Addressed review comment on readability
- Changed firmware names to match products and latest firmware
v9:
- Addressed review comments on style and content defects
- Used kmemdup instead of
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v10:
- Addressed review comment on readability
- Changed firmware names to match products
v9:
- Addressed review comments on style and content defects
- Used kmemdup instead of alloc and memcpy
v7 , v8
> What will be the directory structure in linux-firmware? It should be
> unique so that it's not possible to mix with other drivers.
I have created the following directory structure, Please let me know if this is
OK.
LICENCE.purelifi_firmware | 29 +
purelifi/Li-F
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v9:
- Addressed review comments on style and content defects
- Used kmemdup instead of alloc and memcpy
v7 , v8:
- Magic numbers removed and used IEEE80211 macors
- usb.c is split into two files
From: Srinivasan Raju
Sent: Thursday, November 26, 2020 10:31 AM
To: Kalle Valo
Cc: Mostafa Afgani; David S. Miller; Jakub Kicinski; Mauro Carvalho Chehab; Rob
Herring; Lukas Bulwahn; open list; open list:NETWORKING DRIVERS (WIRELESS);
open list:NETWORKING DRIVERS
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
---
v8:
- Addressed review comments on style and content defects
- Used kmemdup instead of alloc and memcpy
v7:
- Magic numbers removed and used IEEE80211 macors
- usb.c is split into two files firmware.c
> I haven't had a chance to review this yet but we have some documentation for
> new drivers:
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver
> Is the firmware publically available?
Thanks Kalle, We will make the firmware available in our website fo
> trivial notes and some style and content defects:
> (I stopped reading after awhile)
Thanks, I will address the comments.
Regards
Srini
ARM, x86 architectures and
compiled in powerpc architecture.
Signed-off-by: Srinivasan Raju
Changes v6->v7:
- Magic numbers removed and used IEEE80211 macors
- usb.c is split into two files firmware.c and dbgfs.c
- Other code style and timer function fixes (mod_timer)
Changes v5->v6:
- Code
> When you do, please start adding
> changelog information below the
> ---
> line to your patches.
>
> It's quite a chore to figure out
> what changed between revisions.
Ok, will add version logs to future revisions.
Thanks
Srini
> Overall, there are many magic numbers without comments, this makes it hard to
> understand the code. Using defines with proper naming helps and for 802.11
> stuff
> can use ieee80211_*/IEEE80211_* should be used.
Thanks for your comments Krishna, will work on them.
Regards,
Srini
ARM, x86 architectures and
compiled in powerpc architecture.
Reported-by: kernel test robot
Signed-off-by: Srinivasan Raju
---
MAINTAINERS|5 +
drivers/net/wireless/Kconfig |1 +
drivers/net/wireless/Makefile |1 +
drivers/net/wireless
Mostly trivial comments:
>> Ok Thanks, I will address them
ARM, x86 architectures and
compiled in powerpc architecture.
Reported-by: kernel test robot
Signed-off-by: Srinivasan Raju
---
MAINTAINERS|5 +
drivers/net/wireless/Kconfig |1 +
drivers/net/wireless/Makefile |1 +
drivers/net/wireless
> Suggested neatening patch on top of this:
Thanks for the neatening patch Joe, I will resubmit patch.
Thanks
Srini
ARM, x86 architectures and
compiled in powerpc architecture.
Reported-by: kernel test robot
Signed-off-by: Srinivasan Raju
---
MAINTAINERS|5 +
drivers/net/wireless/Kconfig |1 +
drivers/net/wireless/Makefile |1 +
drivers/net/wireless
Thanks for your comments Joe, I have resubmitted with the comments addressed
Regards,
Srini
, x86 architectures and
compiled in powerpc architecture
Signed-off-by: Srinivasan Raju
---
MAINTAINERS|5 +
drivers/net/wireless/Kconfig |1 +
drivers/net/wireless/Makefile |1 +
drivers/net/wireless/purelifi/Kconfig | 27 +
drivers
> I stopped here.
>
> Thanks
Thanks for your comments Leon, I will resubmit after the changes
Thanks
Srini
> Didn't look at the rest
Thanks for your comments Joe, I will refactor the code for clarity, remove
redundancy and address your comments.
Regards
Srini
and uses
native 802.11 for configuration and management
The driver is compiled and tested in ARM, x86 architectures and
compiled in powerpc architecture
Signed-off-by: Srinivasan Raju
---
MAINTAINERS |5 +
drivers/net/wireless/Kconfig |1
31 matches
Mail list logo
