Re: [PATCH 1/5] virtio-net: fix overflow inside virtnet_rq_alloc

2024-10-25 Thread Simon Horman
On Fri, Oct 25, 2024 at 10:35:53AM +0800, Xuan Zhuo wrote: > On Thu, 17 Oct 2024 15:42:59 +0200, Paolo Abeni wrote: > > > > > > On 10/14/24 05:12, Xuan Zhuo wrote: > > > When the frag just got a page, then may lead to regression on VM. > > > Specially if the sysctl net.core.high_order_alloc_disabl

Re: [RFC net-next 3/3] drivers/vdpa: add NFP devices vDPA driver

2024-08-07 Thread Simon Horman
On Fri, Aug 02, 2024 at 11:59:31AM +0200, Louis Peens wrote: > From: Kyle Xu > > Add a new kernel module ‘nfp_vdpa’ for the NFP vDPA networking driver. > > The vDPA driver initializes the necessary resources on the VF and the > data path will be offloaded. It also implements the ‘vdpa_config_ops

Re: [PATCH net-next] net: virtio: fix virtnet_sq_free_stats initialization

2024-07-12 Thread Simon Horman
On Fri, Jul 12, 2024 at 06:41:34AM -0400, Michael S. Tsirkin wrote: > On Fri, Jul 12, 2024 at 09:03:30AM +0100, Jean-Philippe Brucker wrote: > > Commit c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") > > added two new fields to struct virtnet_sq_free_stats, but commit > > 23c81a20b99

Re: [PATCH net-next 0/7] virtnet_net: prepare for af-xdp

2024-05-08 Thread Simon Horman
On Wed, May 08, 2024 at 04:05:07PM +0800, Xuan Zhuo wrote: > This patch set prepares for supporting af-xdp zerocopy. > There is no feature change in this patch set. > I just want to reduce the patch num of the final patch set, > so I split the patch set. > > #1-#3 add independent directory for vir

Re: [PATCH net-next v7 2/4] ethtool: provide customized dim profile management

2024-04-15 Thread Simon Horman
On Mon, Apr 15, 2024 at 05:36:36PM +0800, Heng Qi wrote: ... > @@ -10229,6 +10230,61 @@ static void netdev_do_free_pcpu_stats(struct > net_device *dev) > } > } > > +static int dev_dim_profile_init(struct net_device *dev) > +{ > +#if IS_ENABLED(CONFIG_DIMLIB) > + u32 supported = dev-

Re: [PATCH net-next v5 1/4] ethtool: provide customized dim profile management

2024-04-11 Thread Simon Horman
On Wed, Apr 10, 2024 at 11:13:15AM +0800, Heng Qi wrote: > > > 在 2024/4/10 上午9:44, Jakub Kicinski 写道: > > On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote: > > > +/** > > > + * coalesce_put_profile - fill reply with a nla nest with four child nla > > > nests. > > > + * @skb: socket buffer the me

Re: [PATCH net-next 2/4] virtio_net: Remove command data from control_buf

2024-03-28 Thread Simon Horman
On Mon, Mar 25, 2024 at 04:49:09PM -0500, Daniel Jurgens wrote: > Allocate memory for the data when it's used. Ideally the could be on the > stack, but we can't DMA stack memory. With this change only the header > and status memory are shared between commands, which will allow using a > tighter loc

Re: [PATCH net-next v5 0/9] virtio-net: support device stats

2024-03-21 Thread Simon Horman
On Thu, Mar 21, 2024 at 11:54:34AM +0800, Xuan Zhuo wrote: > On Wed, 20 Mar 2024 20:38:01 -0700, Jakub Kicinski wrote: > > On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > > > I have a question regarding the workflow for feature discussions. If we > > > consistently engage in discussions abou

Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-02-27 Thread Simon Horman
On Tue, Feb 27, 2024 at 04:03:00PM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > make virtio-net support getting the stats from the device by ethtool -S > . > > Signed-off-by: Xuan Zhuo ... > +static int vi

Re: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker

2024-01-16 Thread Simon Horman
On Tue, Jan 16, 2024 at 09:11:33PM +0800, Heng Qi wrote: > Accumulate multiple request commands to kick the device once, > and obtain the processing results of the corresponding commands > asynchronously. The batch command method is used to optimize the > CPU overhead of the DIM worker caused by th

Re: [PATCH net-next 2/3] virtio-net: batch dim request

2024-01-16 Thread Simon Horman
On Tue, Jan 16, 2024 at 09:11:32PM +0800, Heng Qi wrote: > Currently, when each time the driver attempts to update the coalescing > parameters for a vq, it needs to kick the device. > The following path is observed: > 1. Driver kicks the device; > 2. After the device receives the kick, CPU sche

Re: [PATCH net-next 3/6] virtio_net: support device stats

2024-01-03 Thread Simon Horman
On Fri, Dec 22, 2023 at 11:30:18AM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > Virtio-net supports to get the stats from the device by ethtool -S . > > Signed-off-by: Xuan Zhuo Hi Xuan Zhuo, some minor fe

[PATCH net-next] nfp: flower: add support for packet-per-second policing

2021-04-06 Thread Simon Horman
Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- .../net/ethernet/netronome/nfp/flower/main.h | 4 +- .../ethernet/netronome/nfp/flower/qos_conf.c | 161 +- 2 files changed, 119 insertions(+), 46 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp

[PATCH net] nfp: flower: ignore duplicate merge hints from FW

2021-03-30 Thread Simon Horman
ctx's which are a limited resource. Avoid the duplicate merge by using hash table to store the sub_flows to be merged. Fixes: 8af56f40e53b ("nfp: flower: offload merge flows") Signed-off-by: Yinjun Zhang Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../net/ethernet/

Re: [PATCH 08/19] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH] netfilter: ipvs: A spello fix

2021-03-27 Thread Simon Horman
+ netfilter-de...@vger.kernel.org On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote: > s/registerd/registered/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Simon Horman > --- > net/netfilter/ipvs/ip_vs_core.c | 2 +- > 1 file changed, 1 insert

[PATCH net-next 0/2] selftest: add tests for packet per second

2021-03-26 Thread Simon Horman
Add self tests for the recently added packet per second rate limiting feature of the TC policer action[1]. The forwarding selftest (patch 2/2) depends on iproute2 support for packet per second rate limiting, which has been posted separately[2] [1] [PATCH v3 net-next 0/3] net/sched: act_police: ad

[PATCH net-next 2/2] selftests: forwarding: Add tc-police tests for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Test tc-police action for packets per second. The test is mainly in scenarios Rx policing and Tx policing. The test passes with veth pairs ports. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- tools/testing/selftests/net/forwarding/lib.sh | 9

[PATCH net-next 1/2] selftests: tc-testing: add action police selftest for packets per second

2021-03-26 Thread Simon Horman
From: Baowen Zheng Add selftest cases in action police for packets per second. These tests depend on corresponding iproute2 command support. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman --- It is also planned, as a follow-up, to provide packet per second rate limiting tests in

[PATCH iproute2-next] police: add support for packet-per-second rate limiting

2021-03-26 Thread Simon Horman
action order 0: police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200 ref 1 bind 0 Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- man/man8/tc-police.8 | 35 --- tc/m_police.c| 50

Re: [PATCH] drivers: net: ethernet: struct sk_buff is declared duplicately

2021-03-25 Thread Simon Horman
On Thu, Mar 25, 2021 at 02:35:55PM +0800, Wan Jiabing wrote: > struct sk_buff has been declared. Remove the duplicate. > > Signed-off-by: Wan Jiabing Thanks, nice catch. Reviewed-by: Simon Horman

[PATCH net 2/3] nfp: flower: add ipv6 bit to pre_tunnel control message

2021-03-16 Thread Simon Horman
From: Louis Peens Differentiate between ipv4 and ipv6 flows when configuring the pre_tunnel table to prevent them trampling each other in the table. Fixes: 783461604f7e ("nfp: flower: update flow merge code to support IPv6 tunnels") Signed-off-by: Louis Peens Signed-off-by: Si

[PATCH net 0/3] Fixes for nfp pre_tunnel code

2021-03-16 Thread Simon Horman
Louis Peens says: The following set of patches fixes up a few bugs in the pre_tun decap code paths which has been hiding for a while. Louis Peens (3): nfp: flower: fix unsupported pre_tunnel flows nfp: flower: add ipv6 bit to pre_tunnel control message nfp: flower: fix pre_tun mask id alloc

[PATCH net 3/3] nfp: flower: fix pre_tun mask id allocation

2021-03-16 Thread Simon Horman
id, which triggers the allocation on the firmware side. This leads to the firmware mask being corrupted and causing all sorts of strange behaviour. Fixes: f12725d98cbe ("nfp: flower: offload pre-tunnel rules") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../ethernet/

[PATCH net 1/3] nfp: flower: fix unsupported pre_tunnel flows

2021-03-16 Thread Simon Horman
: 120ffd84a9ec ("nfp: flower: verify pre-tunnel rules") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../ethernet/netronome/nfp/flower/offload.c| 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/d

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-16 Thread Simon Horman
On Tue, Mar 16, 2021 at 09:53:49AM -0400, Jamal Hadi Salim wrote: > On 2021-03-12 9:22 a.m., Simon Horman wrote: > > On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > > > This series enhances the TC policer action implementation to allow a > > > policer a

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-16 Thread Simon Horman
Hi Ido, On Tue, Mar 16, 2021 at 10:35:35AM +0200, Ido Schimmel wrote: > Sorry for the delay. Was AFK yesterday No problem at all. ... > > > > As follow-ups we plan to provide: > > > > * Corresponding updates to iproute2 > > > > * Corresponding self tests (which depend on the iproute2 changes) >

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-15 Thread Simon Horman
On Sun, Mar 14, 2021 at 10:17:37AM +0200, Ido Schimmel wrote: > On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > > This series enhances the TC policer action implementation to allow a > > policer action instance to enforce a rate-limit based on > > packets-per

Re: [PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
On Fri, Mar 12, 2021 at 03:08:28PM +0100, Simon Horman wrote: > This series enhances the TC policer action implementation to allow a > policer action instance to enforce a rate-limit based on > packets-per-second, configurable using a packet-per-second rate and burst > parameters. .

[PATCH v3 net-next 2/3] flow_offload: reject configuration of packet-per-second policing in offload drivers

2021-03-12 Thread Simon Horman
Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/dsa/sja1105/sja1105_flower.c | 6 ++ .../net/ethernet/chelsio/cxgb4/cxgb4_tc_matchall.c| 11 ++- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 5 + drivers/net/ethernet

[PATCH v3 net-next 3/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
uncover a performance impact of this change on existing features. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net/sch_generic.h | 14 +++ include/net/tc_act/tc_police.h | 48 -- include/uapi/linux/pkt_cls.h | 2

[PATCH v3 net-next 1/3] flow_offload: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
, and TC code portion of this feature into separate patches with the aim of providing a logical flow for review. And the implementation of these helpers will be filled out by a follow-up patch. Signed-off-by: Xingfeng Hu Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net

[PATCH v3 net-next 0/3] net/sched: act_police: add support for packet-per-second policing

2021-03-12 Thread Simon Horman
This series enhances the TC policer action implementation to allow a policer action instance to enforce a rate-limit based on packets-per-second, configurable using a packet-per-second rate and burst parameters. In the hope of aiding review this is broken up into three patches. * [PATCH 1/3] flow

Re: [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf

2021-03-11 Thread Simon Horman
> > Since they are so close just update nfp to make use of ethtool_gsprintf > > Signed-off-by: Alexander Duyck Reviewed-by: Simon Horman

Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-03-05 Thread Simon Horman
inux/issues/115 > Signed-off-by: Gustavo A. R. Silva Thanks Gustavo, this looks good to me. Acked-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net

[PATCH net v2] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-25 Thread Simon Horman
10. Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core") Signed-off-by: Yinjun Zhang Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- V2: (suggested by Jakub Kicinski) - A better change to fix the check of exceeding max count as well --- ne

[PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-23 Thread Simon Horman
10. Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core") Signed-off-by: Yinjun Zhang Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- net/ethtool/channels.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/etht

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Sat, Jan 30, 2021 at 04:57:38PM +0200, Ido Schimmel wrote: > On Fri, Jan 29, 2021 at 03:04:51PM -0800, Cong Wang wrote: > > On Fri, Jan 29, 2021 at 2:29 AM Simon Horman > > wrote: > > I didn't get v2 (didn't made it to the list), but I did leave feedback >

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
Hi Cong, On Fri, Jan 29, 2021 at 03:04:51PM -0800, Cong Wang wrote: > On Fri, Jan 29, 2021 at 2:29 AM Simon Horman > wrote: > > +/** > > + * psched_ratecfg_precompute__() - Pre-compute values for reciprocal > > division > > + * @rate: Rate to compute

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Mon, Feb 01, 2021 at 01:31:17PM +0100, Simon Horman wrote: > On Thu, Jan 28, 2021 at 06:19:33PM +0200, Ido Schimmel wrote: > > On Mon, Jan 25, 2021 at 04:18:19PM +0100, Simon Horman wrote: > > > From: Baowen Zheng > > > > > > Allow a policer act

Re: [PATCH net-next v2] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Fri, Jan 29, 2021 at 09:30:00AM -0500, Jamal Hadi Salim wrote: > On 2021-01-29 5:28 a.m., Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packet-per-second rate

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-02-01 Thread Simon Horman
On Thu, Jan 28, 2021 at 06:19:33PM +0200, Ido Schimmel wrote: > On Mon, Jan 25, 2021 at 04:18:19PM +0100, Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packe

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-28 Thread Simon Horman
On Wed, Jan 27, 2021 at 12:02:23PM +0100, Simon Horman wrote: > Hi Jakub, > > On Tue, Jan 26, 2021 at 06:38:12PM -0800, Jakub Kicinski wrote: > > On Mon, 25 Jan 2021 16:18:19 +0100 Simon Horman wrote: > > > From: Baowen Zheng > > > > > > Allow a polic

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-28 Thread Simon Horman
On Wed, Jan 27, 2021 at 12:59:05PM -0800, Jakub Kicinski wrote: > On Wed, 27 Jan 2021 12:02:23 +0100 Simon Horman wrote: > > > > +void psched_ppscfg_precompute(struct psched_pktrate *r, > > > > + u64 pktrate64) > > > > +{

Re: [PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-27 Thread Simon Horman
Hi Jakub, On Tue, Jan 26, 2021 at 06:38:12PM -0800, Jakub Kicinski wrote: > On Mon, 25 Jan 2021 16:18:19 +0100 Simon Horman wrote: > > From: Baowen Zheng > > > > Allow a policer action to enforce a rate-limit based on packets-per-second, > > configurable using a packe

[PATCH RFC net-next] net/sched: act_police: add support for packet-per-second policing

2021-01-26 Thread Simon Horman
parent : u32 match \ u32 0 0 police pkts_rate 3000 pkts_burst 1000 Testing was unable to uncover a performance impact of this change on existing features. Signed-off-by: Baowen Zheng Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- include/net/sch_generic.h | 15

Re: [PATCH] nfp: remove h from printk format specifier

2020-12-24 Thread Simon Horman
w if its intentionally that the following was left alone in ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo() snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu" If the above was not intentional then perhaps you could respin with that updated and resubmit when net-next re-opens. Feel free to add: Reviewed-by: Simon Horman

[PATCH net] nfp: move indirect block cleanup to flower app stop callback

2020-12-16 Thread Simon Horman
problem may be resolved by moving the indirect block cleanup to the stop callback, where txbufs are still available. As suggested by Jakub Kicinski and Louis Peens. Fixes: a1db217861f3 ("net: flow_offload: fix flow_indr_dev_unregister path") Signed-off-by: Simon Horman Signed-off-by: L

Re: [PATCH net] nfp: do not send control messages during cleanup

2020-12-15 Thread Simon Horman
On Mon, Dec 14, 2020 at 06:26:50PM -0800, Jakub Kicinski wrote: > On Fri, 11 Dec 2020 10:27:38 +0100 Simon Horman wrote: > > On cleanup the txbufs are freed before app cleanup. But app clean-up may > > result in control messages due to use of common control paths. There is no >

[PATCH net] nfp: do not send control messages during cleanup

2020-12-11 Thread Simon Horman
t;net: flow_offload: fix flow_indr_dev_unregister path") Cc: wenxu Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n

2020-12-09 Thread Simon Horman
gt; > Reported-by: kernel test robot > Signed-off-by: Jakub Kicinski Thanks Jakub, this looks good to me. Reviewed-by: Simon Horman

[PATCH] nfp: Replace zero-length array with flexible-array member

2020-12-04 Thread Simon Horman
ed[2]. [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays Cc: Gustavo A. R. Silva Signed-off-by: Simon Horman Signed-off-by: Louis Peens --- drivers/net/ethernet/netronome/nfp/crypto/fw.h

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Simon Horman
ochip/Kconfig | 1 + > drivers/net/ethernet/netronome/Kconfig | 1 + > drivers/net/ethernet/nxp/Kconfig| 1 + > drivers/net/ethernet/rocker/Kconfig | 1 + > 10 files changed, 10 insertions(+) Hi Arnd, I'm slightly curious to know how you configured the kernel to build the Netronome NFP driver but not CRC32 but nonetheless I have no objection to this change. For the Netronome portion: Acked-by: Simon Horman

Re: [PATCH][next] nfp: tls: Fix unreachable code issue

2020-11-17 Thread Simon Horman
ion > of macro 'fallthrough' > 299 | fallthrough; > | ^~~ > > Reported-by: kernel test robot > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Simon Horman

Re: [PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread Simon Horman
Thanks, this does indeed seem to be the case. Reviewed-by: Simon Horman

Re: [iproute2-next] tc flower: use right ethertype in icmp/arp parsing

2020-10-26 Thread Simon Horman
On Sun, Oct 25, 2020 at 03:18:48PM -0600, David Ahern wrote: > On 10/19/20 5:47 AM, Zahari Doychev wrote: > > Currently the icmp and arp prsing functions are called with inccorect > > ethtype in case of vlan or cvlan filter options. In this case either > > cvlan_ethtype or vlan_ethtype has to be us

Re: [PATCH] ipvs: adjust the debug order of src and dst

2020-09-24 Thread Simon Horman
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote: > From: ylg > > adjust the debug order of src and dst when tcp state changes > > Signed-off-by: ylg Hi, This sounds reasonable to me but please provide your real name in the Signed-off-by name, which should be consistent with the

Re: [PATCH net-next] ipvs: Remove unused macros

2020-09-21 Thread Simon Horman
On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote: > They are not used since commit e4ff67513096 ("ipvs: add > sync_maxlen parameter for the sync daemon") > > Signed-off-by: YueHaibing Thanks, this look good to me. Acked-by: Simon Horman Pablo, please con

Re: [PATCH net] nfp: use correct define to return NONE fec

2020-09-17 Thread Simon Horman
- param->active_fec = ETHTOOL_FEC_NONE_BIT; > - param->fec = ETHTOOL_FEC_NONE_BIT; > + param->active_fec = ETHTOOL_FEC_NONE; > + param->fec = ETHTOOL_FEC_NONE; > > port = nfp_port_from_netdev(netdev); > eth_port = nfp_port_get_eth_port(port); Reviewed-by: Simon Horman

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

Re: [PATCH] drivers/net/ethernet: fix a typo for stmmac_pltfr_suspend

2020-09-09 Thread Simon Horman
Hi Wang, On Wed, Sep 09, 2020 at 08:19:21PM +0800, Wang Qing wrote: > Change the comment typo: "direcly" -> "directly". > > Signed-off-by: Wang Qing > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) git log tells me that the

Re: [PATCH] net/netfilter: fix a typo for nf_conntrack_proto_dccp.c

2020-09-09 Thread Simon Horman
Hi Wang, On Wed, Sep 09, 2020 at 08:12:44PM +0800, Wang Qing wrote: > Change the comment typo: "direcly" -> "directly". > > Signed-off-by: Wang Qing git log tells me that the correct prefix for this patch is "netfilter: conntrack:" rather than "net/netfilter:" Probably this patch is targeted

Re: [PATCH v2 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread Simon Horman
ext" in the subject, like this: [PATCH v2 net-next 16/20] ... The patch itself seems fine to me. So with the above fixed feel free to add: Reviewed-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +++ > 1 file changed, 3 insertions(+

Re: [PATCH net-next v2 3/3] ipmr: Use full VIF ID in netlink cache reports

2020-09-09 Thread Simon Horman
On Tue, Sep 08, 2020 at 10:04:08AM +1200, Paul Davey wrote: > Insert the full 16 bit VIF ID into ipmr Netlink cache reports. > > The VIF_ID attribute has 32 bits of space so can store the full VIF ID > extracted from the high and low byte fields in the igmpmsg. > > Signed-off-by: Paul Davey > --

Re: [PATCH net-net] netfilter: conntrack: nf_conncount_init is failing with IPv6 disabled

2020-09-07 Thread Simon Horman
t") > Signed-off-by: Eelco Chaudron Reviewed-by: Simon Horman > --- > net/netfilter/nf_conntrack_proto.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/netfilter/nf_conntrack_proto.c > b/net/netfilter/nf_conntrack_proto.c > index 95f79980348c

Re: [PATCH net] nfp: flower: fix ABI mismatch between driver and firmware

2020-09-02 Thread Simon Horman
On Wed, Sep 02, 2020 at 04:00:54PM -0700, David Miller wrote: > From: Simon Horman > Date: Wed, 2 Sep 2020 17:04:58 +0200 > > > From: Louis Peens > > > > Fix an issue where the driver wrongly detected ipv6 neighbour updates > > from the NFP as corrupt. Add a

[PATCH net] nfp: flower: fix ABI mismatch between driver and firmware

2020-09-02 Thread Simon Horman
pport ipv6 tunnel keep-alive messages from fw") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c b/drivers/ne

[PATCH net-next 1/2] nfp: flower: check that we don't exceed the FW key size

2020-08-20 Thread Simon Horman
From: Louis Peens Add a check to make sure the total length of the flow key sent to the firmware stays within the supported limit. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.h | 2 ++ drivers/net/ethernet/netronome/nfp/flower

[PATCH net-next 2/2] nfp: flower: add support to offload QinQ match

2020-08-20 Thread Simon Horman
0x8100 as before. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- .../net/ethernet/netronome/nfp/flower/cmsg.h | 17 .../net/ethernet/netronome/nfp/flower/main.h | 4 +- .../net/ethernet/netronome/nfp/flower/match.c | 62 +- .../ethernet/netronome/nfp/flower/offload.c

[PATCH net-next 0/2] nfp: flower: add support for QinQ matching

2020-08-20 Thread Simon Horman
Louis says: Add new feature to the Netronome flower driver to enable QinQ offload. This needed a bit of gymnastics in order to not break compatibility with older firmware as the flow key sent to the firmware had to be updated in order to make space for the extra field. Louis Peens (2): nfp: flo

Re: [oss-drivers] [PATCH 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Simon Horman
ned-off-by: Romain Perier > Signed-off-by: Allen Pais Reviewed-by: Simon Horman But: This series should be targeted at net-next, and thus have net-next in its subject [PATCH net-next x/y] ... And it should be posted when net-next is open: it is currently closed. http://v

Re: [PATCH net] nfp: update maintainer

2020-08-11 Thread Simon Horman
On Mon, Aug 10, 2020 at 12:11:42PM -0700, David Miller wrote: > From: Jakub Kicinski > Date: Mon, 10 Aug 2020 10:32:04 -0700 > > > I'm not doing much work on the NFP driver any more. > > > > Signed-off-by: Jakub Kicinski > > Applied. Thanks, for the record I'm happy to take this over on beha

Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-11 Thread Simon Horman
Anastasov Pablo, could you consider this for nf-next or should we repost when net-next re-opens? Reviewed-by: Simon Horman

Re: [PATCH net-next 01/12] nfp: convert to new udp_tunnel_nic infra

2020-07-14 Thread Simon Horman
his feature for free. > > Signed-off-by: Jakub Kicinski Thanks Jakub, looks good to me. Reviewed-by: Simon Horman

Re: [PATCH net v5 0/4] several fixes for indirect flow_blocks offload

2020-06-22 Thread Simon Horman
On Fri, Jun 19, 2020 at 08:13:42PM -0700, David Miller wrote: > From: we...@ucloud.cn > Date: Thu, 18 Jun 2020 20:49:07 +0800 > > > From: wenxu > > > > v2: > > patch2: store the cb_priv of representor to the flow_block_cb->indr.cb_priv > > in the driver. And make the correct check with the statm

Re: [PATCH net v5 0/4] several fixes for indirect flow_blocks offload

2020-06-19 Thread Simon Horman
r block offload successful. The representor maybe > gone away and the ingress qdisc can work in software mode. > > > wenxu (4): > flow_offload: add flow_indr_block_cb_alloc/remove function > flow_offload: use flow_indr_block_cb_alloc/remove function > net: flow_offload: fix flow_indr_dev_unregister path > net/sched: cls_api: fix nooffloaddevcnt warning dmesg log Reviewed-by: Simon Horman

Re: [v2,net-next] net: qos offload add flow status with dropped count

2020-06-19 Thread Simon Horman
| 3 ++- > 25 files changed, 60 insertions(+), 50 deletions(-) Netronome portion: Reviewed-by: Simon Horman

Re: [PATCHv2 net] tc-testing: update geneve options match in tunnel_key unit tests

2020-06-18 Thread Simon Horman
th old and new > iproute2, let's accept both "geneve_opt" and "geneve_opts". > > Suggested-by: Davide Caratti > Signed-off-by: Hangbin Liu Reviewed-by: Simon Horman

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Simon Horman
On Fri, Jun 19, 2020 at 10:25:24AM +0800, Hangbin Liu wrote: > On Thu, Jun 18, 2020 at 12:51:08PM +0200, Simon Horman wrote: > > On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > > > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" &

Re: [PATCH iproute2] tc: m_tunnel_key: fix geneve opt output

2020-06-18 Thread Simon Horman
On Thu, Jun 18, 2020 at 06:44:20PM +0800, Hangbin Liu wrote: > Commit f72c3ad00f3b changed the geneve option output from "geneve_opt" > to "geneve_opts", which may break the program compatibility. Reset > it back to geneve_opt. > > Fixes: f72c3ad00f3b ("tc: m_tunnel_key: add options support for vx

Re: [PATCH net v4 0/4] several fixes for indirect flow_blocks offload

2020-06-18 Thread Simon Horman
PP which lead the warning > demesg log. > The block->nooffloaddevcnt should always count for indr block. > even the indr block offload successful. The representor maybe > gone away and the ingress qdisc can work in software mode. Thanks Wenxu, Pablo's minor comment wrt patch #1 not withstanding this series is now looking good to me. With that fixed feel free to add: Reviewed-by: Simon Horman

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:18:16PM +0800, wenxu wrote: > > 在 2020/6/16 22:34, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > >> 在 2020/6/16 18:51, Simon Horman 写道: > >>> On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@uc

Re: [PATCH net v3 1/4] flow_offload: fix incorrect cleanup for flowtable indirect flow_blocks

2020-06-16 Thread Simon Horman
removed, > then identify the indirect flow_blocks that need to be removed by > the release callback. > > Fixes: 1fac52da5942 ("net: flow_offload: consolidate indirect flow_block > infrastructure") > Signed-off-by: wenxu Reviewed-by: Simon Horman

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 10:20:46PM +0800, wenxu wrote: > > 在 2020/6/16 18:51, Simon Horman 写道: > > On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > >> From: wenxu > >> > >> In the function __flow_block_indr_cleanup, The match stataments

Re: [PATCH net v3 2/4] flow_offload: fix incorrect cb_priv check for flow_block_cb

2020-06-16 Thread Simon Horman
On Tue, Jun 16, 2020 at 11:19:38AM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the function __flow_block_indr_cleanup, The match stataments > this->cb_priv == cb_priv is always false, the flow_block_cb->cb_priv > is totally different data with the flow_indr_dev->cb_priv. > > Store the rep

Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack

2020-06-16 Thread Simon Horman
On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote: > From: xidongwang > > The stack object “zone_limit” has 3 members. In function > ovs_ct_limit_get_default_limit(), the member "count" is > not initialized and sent out via “nla_put_nohdr”. Hi Xidong, thanks for your patch. It appear

[PATCH net-next] nfp: flower: fix incorrect flag assignment

2020-05-28 Thread Simon Horman
bits") Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) This fix is for net-next as the patch that introduces this problem hasn't propagated to Linus's tre

[PATCH net] nfp: flower: fix used time of merge flow statistics

2020-05-27 Thread Simon Horman
ned-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/offload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c b/drivers/net/ethernet/netronome/nfp/flower/offload.c index c6

[PATCH net-next v2 0/2] nfp: flower: feature bit updates

2020-05-19 Thread Simon Horman
Hi, this short series has two parts. * The first patch cleans up the treatment of existing feature bits. There are two distinct methods used and the code now reflects this more clearly. * The second patch informs firmware of flower features. This allows the firmware to disable certain featu

[PATCH net-next v2 1/2] nfp: flower: renaming of feature bits

2020-05-19 Thread Simon Horman
From: Louis Peens Clean up name aliasing. Some features gets enabled using a slightly different method, but the bitmap for these were stored in the same field. Rename their #defines and move the bitmap to a new variable. Signed-off-by: Louis Peens Signed-off-by: Simon Horman --- drivers/net

[PATCH net-next v2 2/2] nfp: flower: inform firmware of flower features

2020-05-19 Thread Simon Horman
: Simon Horman --- .../net/ethernet/netronome/nfp/flower/main.c | 106 +- .../net/ethernet/netronome/nfp/flower/main.h | 11 ++ 2 files changed, 87 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp

Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

2020-05-18 Thread Simon Horman
On Fri, May 15, 2020 at 12:49:01PM -0700, Jakub Kicinski wrote: > Core will now perform this check. > > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman > --- > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [oss-drivers] [RFC v2] current devlink extension plan for NICs

2020-05-13 Thread Simon Horman
On Fri, May 01, 2020 at 11:14:49AM +0200, Jiri Pirko wrote: > Hi all. > > First, I would like to apologize for very long email. But I think it > would be beneficial to the see the whole picture, where we are going. > > Currently we are working internally on several features with > need of extensi

[PATCH net-net] nfp: flower: inform firmware of flower features in the driver

2020-05-13 Thread Simon Horman
: Simon Horman --- .../net/ethernet/netronome/nfp/flower/main.c | 110 +- .../net/ethernet/netronome/nfp/flower/main.h | 11 ++ 2 files changed, 91 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp

Re: [PATCH 37/38] docs: networking: convert ipvs-sysctl.txt to ReST

2020-04-28 Thread Simon Horman
gt; Signed-off-by: Mauro Carvalho Chehab Acked-by: Simon Horman

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Simon Horman
On Mon, Oct 21, 2019 at 09:09:44AM +0100, Russell King - ARM Linux admin wrote: > On Mon, Oct 21, 2019 at 09:40:31AM +0200, Simon Horman wrote: > > On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > > > From: Russell King > > > > > > A bitrate of

Re: [PATCH 1/3] ethtool: correctly interpret bitrate of 255

2019-10-21 Thread Simon Horman
On Fri, Oct 18, 2019 at 09:31:13PM +0100, Russell King wrote: > From: Russell King > > A bitrate of 255 is special, it means the bitrate is encoded in > byte 66 in units of 250MBaud. Add support for parsing these bit > rates. Hi Russell, it seems from the code either that 0 is also special or

Re: [PATCH v14 1/5] fs/nsfs.c: added ns_match

2019-10-18 Thread Simon Horman
On Thu, Oct 17, 2019 at 12:00:28PM -0300, Carlos Neira wrote: > ns_match returns true if the namespace inode and dev_t matches the ones > provided by the caller. > > Signed-off-by: Carlos Neira > --- > fs/nsfs.c | 8 > include/linux/proc_ns.h | 2 ++ > 2 files changed, 10

Re: [PATCH v3 net 1/2] dpaa2-eth: add irq for the dpmac connect/disconnect event

2019-10-16 Thread Simon Horman
On Wed, Oct 16, 2019 at 11:10:56AM +, Ioana Ciornei wrote: > > Subject: Re: [PATCH v3 net 1/2] dpaa2-eth: add irq for the dpmac > > connect/disconnect event > > > > On Wed, Oct 16, 2019 at 10:36:22AM +0300, Ioana Ciornei wrote: > > > From: Florin Chiculita > > > > > > Add IRQ for the DPNI end

Re: [PATCH v3 net 1/2] dpaa2-eth: add irq for the dpmac connect/disconnect event

2019-10-16 Thread Simon Horman
On Wed, Oct 16, 2019 at 10:36:22AM +0300, Ioana Ciornei wrote: > From: Florin Chiculita > > Add IRQ for the DPNI endpoint change event, resolving the issue > when a dynamically created DPNI gets a randomly generated hw address > when the endpoint is a DPMAC object. > > Signed-off-by: Florin Chic

  1   2   3   4   5   6   7   8   9   10   >