Re: [PATCH bpf-next RFC 2/2] Add MPLS label push/pop functions for EBPF

2018-03-29 Thread Shrijeet mukherjee
On 03/28, David Ahern wrote: > On 3/28/18 10:27 AM, Shrijeet Mukherjee wrote: > > > +static int bpf_skb_mpls_net_grow(struct sk_buff *skb, int len_diff) > > +{ > > + u32 off = skb_mac_header_len(skb); /*LL_RESERVED_SPACE ?? */ > > + int ret; > > +

[PATCH bpf-next RFC 1/2] Organize MPLS headers

2018-03-28 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee Prepare shared headers for new MPLS label push/pop EBPF helpers Signed-off-by: Shrijeet Mukherjee --- include/net/mpls.h| 1 + net/core/filter.c | 2 ++ net/mpls/af_mpls.c| 8 net/mpls/internal.h | 31

[PATCH bpf-next RFC 2/2] Add MPLS label push/pop functions for EBPF

2018-03-28 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee Push: takes an array/size of labels and encaps Pop : Takes a number and pops the top "n" labels Signed-off-by: Shrijeet Mukherjee PS: Will be adding tests as well, refactoring my test into something smaller. --- include/linux/bpf.h | 2 + include/

RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-02 Thread Shrijeet Mukherjee
> -Original Message- > From: Jesper Dangaard Brouer [mailto:bro...@redhat.com] > Sent: Wednesday, November 2, 2016 7:27 AM > To: Thomas Graf > Cc: Shrijeet Mukherjee ; Alexei Starovoitov > ; Jakub Kicinski ; John > Fastabend ; David Miller > ; alexander.du...@gm

RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-28 Thread Shrijeet Mukherjee
> -Original Message- > From: Alexei Starovoitov [mailto:alexei.starovoi...@gmail.com] > Sent: Friday, October 28, 2016 11:22 AM > To: Jakub Kicinski > Cc: John Fastabend ; David Miller > ; alexander.du...@gmail.com; m...@redhat.com; > bro...@redhat.com; shrij...@gmail.com; t...@herbertland

RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-27 Thread Shrijeet Mukherjee
> -Original Message- > From: Shrijeet Mukherjee [mailto:s...@cumulusnetworks.com] > Sent: Thursday, October 27, 2016 5:02 PM > To: John Fastabend ; Jesper Dangaard Brouer > ; David Miller > Cc: m...@redhat.com; shrij...@gmail.com; t...@herbertland.com; > netdev@v

RE: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-27 Thread Shrijeet Mukherjee
> > > > Looking at the virtio_net.c code, the function call receive_big() > > might actually be okay for XDP, unless the incoming packet is larger > > than PAGE_SIZE and thus uses several pages (via a linked list in page- > >private). > > > > The receive_mergeable() does not look compatible with XD

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-23 Thread Shrijeet Mukherjee
On Sun, Oct 23, 2016 at 9:38 AM, Stephen Hemminger wrote: > Overall, I am glad to see XDP support more widely available. Minor stuff > in implementation. > >> >> +/* this function is not called from the receive_buf path directly as >> + * we want to use the page model for rx merge buffer and big b

[PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-21 Thread Shrijeet Mukherjee
This patch adds support for xdp ndo and also inserts the xdp program call into the merged RX buffers and big buffers paths * The small packet skb receive is skipped for now * No TX for now Signed-off-by: Shrijeet Mukherjee --- drivers/net/virtio_net.c | 133

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

2015-07-06 Thread Shrijeet Mukherjee
No no problem, Just trying to get the functional aspects worked out. the global search replace will be easy. Was hoping to see some more responses on the naming suggestions here from the community. If there is not disagreement we can spin patches with MRF as the name. On Mon, Jul 6, 2015 at 8:4

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-09 Thread Shrijeet Mukherjee
On Tue, Jun 9, 2015 at 5:35 AM, Nikolay Aleksandrov wrote: > On Mon, Jun 8, 2015 at 8:35 PM, Shrijeet Mukherjee > wrote: > > vrf_kill_one_slave() calls netdev_rx_handler_unregister() which does > synchronize_rcu() and > here you're running with the queue spinlock hel

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-09 Thread Shrijeet Mukherjee
On Tue, Jun 9, 2015 at 7:55 AM, Nicolas Dichtel wrote: > Le 09/06/2015 16:21, David Ahern a écrit : >> >> Hi Nicolas: >> >> On 6/9/15 2:58 AM, Nicolas Dichtel wrote: >>> >>> I'm not really in favor of the name 'vrf'. This term is very >>> controversial and >>> having a consensus of what is/contain

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
On Mon, Jun 8, 2015 at 1:33 PM, Hannes Frederic Sowa wrote: > On Mon, Jun 8, 2015, at 22:22, Shrijeet Mukherjee wrote: >> On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa >> wrote: >> > Hi Shrijeet, >> > >> > This let's incoming and arp reque

Re: [RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
On Mon, Jun 8, 2015 at 12:58 PM, Hannes Frederic Sowa wrote: > Hi Shrijeet, > > From an architectural level I think the output path looks good. For the > input path I would also to propose my (I think) more flexible solution: > > For rx layer I want to also propose my try: > > [PATCH net-next RFC]

Re: [RFC net-next 0/3] Proposal for VRF-lite

2015-06-08 Thread Shrijeet Mukherjee
Good catch, as you know I used to have the device getting modified in the RX path and that made it all work generic ip_rcv will need a fix to make RX visible to tcpdump, but yes, that is the goal. On Mon, Jun 8, 2015 at 12:13 PM, David Ahern wrote: > On 6/8/15 12:35 PM, Shrijeet Mukherjee wr

[RFC iproute2] Add the ability to create a VRF device and specify it's table binding.

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee Modified from the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee --- include/linux/if_link.h |8 ip/Makefile |2 +- ip/iplink_vrf.c | 93 +++ 3 files changed, 102 insertions

[RFC net-next 3/3] rcv path changes for vrf traffic

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee Incoming frames for IP protocol stacks need the IIF to be changed from the actual interface to the VRF device. This allows the IIF rule to be used to select tables (or do regular PBR) This change selects the iif to be the VRF device if it exists and the incoming iif is

[RFC net-next 2/3] VRF driver and needed infrastructure

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to enslaved devices

[RFC net-next 1/3] Symbol preparation for VRF driver

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee This change is needed for the following VRF driver which creates a routing domain and allows applications to bind to the domain. No active code path changes. Signed-off-by: Shrijeet Mukherjee --- net/ipv4/fib_frontend.c |1 + net/ipv4/fib_trie.c |2 ++ 2

[RFC net-next 0/3] Proposal for VRF-lite

2015-06-08 Thread Shrijeet Mukherjee
From: Shrijeet Mukherjee In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in