From: [EMAIL PROTECTED]
When the sk_timer function x25_heartbeat_expiry() is called by the kernel
in a running/terminating process, spinlock-recursion and spinlock-lockup
locks up the kernel.
This has happened with testing on some distro's and the patch below fixed it.
Signed-off-by:Shaun Pereir
From: [EMAIL PROTECTED]
Allows use of the optional user facility to insert ITU-T
(http://www.itu.int/ITU-T/) specified DTE facilities in call set-up x25 packets.
This feature is optional; no facilities will be added if the ioctl is not used,
and call setup packet remains the same as before.
If th
From: [EMAIL PROTECTED]
Allows dte facility patch to use 32 64 bit ioctl
conversion mechanism
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
---
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net/x25/af_x25.c
linux-2.6.16-rc3/net/x25/af_x25.c
--- linux-2.6.16-rc3-vanilla/net/x25/af_x25.c 200
From: [EMAIL PROTECTED]
To allow 32 bit x25 module structures to be passed to
a 64 bit kernel via ioctl using the new compat_sock_ioctl registration
mechanism instead of the obsolete 'register_ioctl32_conversion into hash table'
mechanism
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by:
From: [EMAIL PROTECTED]
Fixes the following error from kernel
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net
From: [EMAIL PROTECTED]
Since the register_ioctl32_conversion() patch in the kernel
is now obsolete, provide another method to allow 32 bit user space
ioctls to reach the kernel.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
diff -uprN -X dontdiff
From: [EMAIL PROTECTED]
Get socket timestamp handler function that does not
use the ioctl32_hash_table.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/include/net/compat.h
linux-2.6.16-rc3/include/ne
. all these patches have
the same subject...
Regards
Shaun
On Thu, 2006-02-16 at 15:18 +0100, Ingo Oeser wrote:
> Shaun Pereira wrote:
> > removed magic number 33 as suggested by Arnaldo
>
> But are you sure, you use the right substitute for it?
>
> > struct x25_cal
removed magic number 33 as suggested by Arnaldo
32 bit modular socket ioctl emulation for 64 bit kernel
This patch is a re-submit of an earlier patch submitted by Andrew Hendry
that did not make it into the Linux Kernel. Here is some more information
about this patch.
This patch allows use of
32 - 64 converstion for patch 5
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net/x25/af_x25.c
linux-2.6.16-rc3/net/x25/af_x25.c
--- linux-2.6.16-rc3-vanilla/net/x25/af_x25.c 2006-02-16 15:33:48.0
+1100
+++ linux-2.6.16-rc3/net/x25/af_
32 bit modular socket ioctl emulation for 64 bit kernel
This patch allows 32 bit x25 module structures to be passed to
a 64 bit kernel via ioctl using the new compat_sock_ioctl registration
mechanism instead of the obsolete 'register_ioctl32_conversion into hash table'
mechanism.
Signed-off-b
32 bit modular socket ioctl emulation for 64 bit kernel
This patch allows an x25 server application to run on a 64 bit kernel, by
fixing the following error message from the kernel.
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
Signed-off-by:Shaun Pe
Includes correction from Arnaldo's suggestions.
32 bit modular socket ioctl emulation for 64 bit kernel
The following patch provides 32 bit userland ioctl support for modular (x.25
type)
socket ioctls in a 64 bit kernel. Since the the register_ioctl32_conversion()
is now obsolete, this patch pr
32 bit modular socket ioctl emulation for 64 bit kernel
This patch is the first step towards migration of the 'handler functions'
for 32-64 bit userspace-kernel conversion, away from the ioctl32_hash_table.
It will be used by the x25 socket layer.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED
Thanks for that Aranaldo
I have corrected this so as to be compliant with OSI Network services
for DTE facilities and rebuilt and retested the patches
Corrected patches follow.
On Wed, 2006-02-15 at 20:35 -0200, Arnaldo Carvalho de Melo wrote:
> On 2/15/06, Shaun Pereira <[EMAIL PRO
32 bit modular socket ioctl emulation for 64 bit kernel
This patch is a re-submit of an earlier patch submitted by Andrew Hendry
that did not make it into the Linux Kernel. Here is some more information
about this patch.
This patch allows use of the optional user facility to insert ITU-T
(http
Allow patch 5 to use 32-64 bit conversion mechanism
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net/x25/af_x25.c
linux-2.6.16-rc3/net/x25/af_x25.c
--- linux-2.6.16-rc3-vanilla/net/x25/af_x25.c 2006-02-15 11:17:03.0
+1100
+++ linux-2.
32 bit modular socket ioctl emulation for 64 bit kernel
This patch is the first step towards migration of the 'handler functions'
for 32-64 bit userspace-kernel conversion, away from the ioctl32_hash_table.
It will be used by the x25 socket layer.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED
32 bit modular socket ioctl emulation for 64 bit kernel
This patch allows 32 bit x25 module structures to be passed to
a 64 bit kernel via ioctl using the new compat_sock_ioctl registration
mechanism instead of the obsolete 'register_ioctl32_conversion into hash table'
mechanism.
Signed-off-b
32 bit modular socket ioctl emulation for 64 bit kernel
This patch allows an x25 server application to run on a 64 bit kernel, by
fixing the following error message from the kernel.
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
Signed-off-by:Shaun Pe
Sorry Dave,
My mail client line wrapped the patch. I will resend the lot
Please ignore the previous set.
The following patch provides 32 bit userland ioctl support for modular (x.25
type)
socket ioctls in a 64 bit kernel. Since the the register_ioctl32_conversion()
is now obsolete, this patch
Allow patch 5 to use 32-64 bit conversion mechanism
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
diff -uprN -X dontdiff linux-2.6.16-rc3-vanilla/net/x25/af_x25.c
linux-2.6.16-rc3/net/x25/af_x25.c
--- linux-2.6.16-rc3-vanilla/net/x25/af_x25.c 2006-02-15
11:17:03.0 +1100
+++ linux-2.6.
Hi
The following patch provides 32 bit userland ioctl support for modular
(x.25 type) socket ioctls in a 64 bit kernel. Since the the
register_ioctl32_conversion() is now obsolete, this patch provides a
mechanism to allow 32 bit user space ioctls to reach the kernel.
Signed-off-by:Shaun Pereira
This patch is the first step towards migration of the 'handler
functions' for 32-64 bit userspace-kernel conversion, away from the
ioctl32_hash_table. It will be used by the x25 socket layer.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
diff -uprN
This patch allows 32 bit x25 module structures to be passed to
a 64 bit kernel via ioctl using the new compat_sock_ioctl registration
mechanism instead of the obsolete 'register_ioctl32_conversion into hash
table' mechanism.
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergma
This patch is a re-submit of an earlier patch submitted by Andrew Hendry
that did not make it into the Linux Kernel. Here is some more
information about this patch. Hope this is helpful.
This patch allows use of the optional user facility to insert ITU-T
(http://www.itu.int/ITU-T/) specified DTE
This patch allows an x25 server application to run on a 64 bit kernel,
by fixing the following error message from the kernel.
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
Signed-off-by:Shaun Pereira <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL
Hi Arnd
Here is the corrected version.
Using the x25_subscrip_struct structure (extend value = 1) set
the following values in the kernel after copy_from_user
global facility mask is F
Extended value is 1
Using the 32 bit compat_x25_subscrip_struct
set the following values in the stru
Hi
Here are the corrected patches
/Shaun
diff -uprN -X dontdiff linux-2.6.15-vanilla/include/linux/net.h
linux-2.6.15/include/linux/net.h
--- linux-2.6.15-vanilla/include/linux/net.h2006-01-03
14:21:10.0 +1100
+++ linux-2.6.15/include/linux/net.h2006-01-17 09:43:56.0 +1100
Allows x25 to work in 32 bit mode on 64 bit kernel
diff -uprN -X dontdiff linux-2.6.15-vanilla/net/x25/af_x25.c
linux-2.6.15/net/x25/af_x25.c
--- linux-2.6.15-vanilla/net/x25/af_x25.c 2006-01-03 14:21:10.0
+1100
+++ linux-2.6.15/net/x25/af_x25.c 2006-01-17 09:56:02.0 +
Provides a 32 bit conversion function for SIOCGSTAMP
diff -uprN -X dontdiff linux-2.6.15-vanilla/include/net/compat.h
linux-2.6.15/include/net/compat.h
--- linux-2.6.15-vanilla/include/net/compat.h 2006-01-03
14:21:10.0 +1100
+++ linux-2.6.15/include/net/compat.h 2006-01-17 09:52:50.000
A small fix for the following error, when trying to run a 64 bit x25
server application.
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
diff -uprN -X dontdiff linux-2.6.15-vanilla/net/x25/af_x25.c
linux-2.6.15/net/x25/af_x25.c
--- linux-2.6.15-vanilla/ne
ock_get_timestamp);
On Fri, 2006-01-13 at 11:46 +, Arnd Bergmann wrote:
> On Friday 13 January 2006 03:14, Shaun Pereira wrote:
> > Thank you for reviewing that bit of code.
> > I had a look at compat_sys_gettimeofday and sys32_gettimeofday codes.
> > They seem to work in
4 +, Arnd Bergmann wrote:
> On Thursday 12 January 2006 06:02, Shaun Pereira wrote:
> > +int compat_sock_get_timestamp(struct sock *sk, struct timeval __user
> > *userstamp)
> > +{
> > + struct compat_timeval __user *ctv;
> > + ctv = (struct com
The x25 bit, many thanks Arnd for this.
diff -uprN -X dontdiff linux-2.6.15-vanilla/net/x25/af_x25.c
linux-2.6.15/net/x25/af_x25.c
--- linux-2.6.15-vanilla/net/x25/af_x25.c 2006-01-03 14:21:10.0
+1100
+++ linux-2.6.15/net/x25/af_x25.c 2006-01-12 16:06:54.0 +1100
@@ -54,
A small fix for the following error, when trying to run a 64 bit x25
server application.
T2 kernel: schedule_timeout:
wrong timeout value from 88164796
diff -uprN -X dontdiff linux-2.6.15-vanilla/net/x25/af_x25.c
linux-2.6.15/net/x25/af_x25.c
--- linux-2.6.15-vanilla/ne
The second part of this series.
This routine is needed by the x25 module (32-64 bit patch), as
recommended it has been added to compat.c
diff -uprN -X dontdiff linux-2.6.15-vanilla/include/net/compat.h
linux-2.6.15/include/net/compat.h
--- linux-2.6.15-vanilla/include/net/compat.h 2006-01-03
1
Hi all,
Attached is the corrected patch. Thanks heaps Arnd for your help (and
patience :-) The following text is just a repeat of what was sent
earlier.
The attached patch is a follow up to a post made earlier to this site
with regard to 32 bit (socket layer) ioctl emulation for 64 bit kernels.
I
And the correct x.25 patch, (will build a [PATCH] if this is ok).
Tested with with xot to a Cisco box.
Thanks once again for your help
/Shaun
Index: linux-2.6.15/net/x25/af_x25.c
===
--- linux-2.6.15.orig/net/x25/af_x25.c
+++ linux-
Hi Arnd
Thanks for reviewing those patches, and your feedback. I have made the
changes recommended. If these are acceptable, I will build a proper
[PATCH] for submission.Is there anyone in particular that I need to mail
in order that these patches go into the next release?
Here is the updated pat
Hi Arnd, Arnaldo
Thanks for your comments. I initially did not wish to change any of the
other modules, but based on Arnd's comments I have removed the
extra macro, SOCKOPS_COMPAT_WRAP and use the original SOCKOPS_WRAP.
I'm a bit pressed for time to use the lock_sock() in each of the
functions p
x25 module patch
diff -uprN -X dontdiff linux-2.6.15-vanilla/include/net/x25.h
linux-2.6.15/include/net/x25.h
--- linux-2.6.15-vanilla/include/net/x25.h 2006-01-03 14:21:10.0
+1100
+++ linux-2.6.15/include/net/x25.h 2006-01-10 16:15:16.0 +1100
@@ -223,6 +223,18 @@ extern
Hi all,
The attached patch is a follow up to a post made earlier to this site
with regard to 32 bit (socket layer) ioctl emulation for 64 bit kernels.
I needed to implement 32 bit userland ioctl support for modular (x.25)
socket ioctls in a 64 bit kernel. With the removal of the
register_ioctl32_c
Hi
Have included a patch fix for the x25 module in the latest stable
version of the kernel.
Problem:
When a user-space server application calls bind on a socket, then
in kernel space this bound socket is considered 'x25-linked' and the
SOCK_ZAPPED flag is unset.(As in x25_bind()/af_x25.c).
Now
44 matches
Mail list logo
