Re: Bonding MAC address

2016-10-28 Thread Shanker Wang
I think it is intentional. Because changing mac address of an interface would cause problems. As a result, if you find it necessary to change the mac address, it should be done manually. Consider these two example: * A host is connecting the internet through a bond interface, and obtain ip add

Re: [PATCH 0786/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Shanker Wang
I don’t think macros is clearer, and the meaning of those so called “magic numbers” like 0644 is clear enough. People are used to that. As a result, it is not meaningful to replace them with macro. > 在 2016年8月2日,19:46,Baole Ni 写道: > > I find that the developers often just specified the numeric

[PATCH] iproute2: ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

2016-07-21 Thread Shanker Wang
Three options are added for the user to control whether the checksum is enabled Signed-off-by: Miao Wang --- ip/ipl2tp.c | 45 + 1 file changed, 45 insertions(+) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 1f84c61..9ebda13 100644 --- a/ip/ipl2tp.c ++

Re: IPv6 IPSec incompatibilities between 2.6.23 and 3.6.18 (and probably later)

2016-07-20 Thread Shanker Wang
> 在 2016年7月19日,23:03,Ilan Tayari 写道: > >> On the receiving side (e.g. fd01:1b10:1000::1) I see the decrypted packets >> with >> the 2.6.23 kernel: >> but NOT with the newer kernel: > > Hi Joerg, > > First steps to debug this would be: > cat /proc/net/xfrm_stat > ip -s xfrm state > ip -s xfrm

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-07-16 Thread Shanker Wang
在 2016年6月19日,18:40,Richard Weinberger 写道: > > Am 19.06.2016 um 12:36 schrieb Shanker Wang: >> >>> 在 2016年6月19日,12:13,Richard Weinberger 写道: >>> >>> Am 19.06.2016 um 07:21 schrieb Shanker Wang: >>>> This patch removes the check for CAP_NE

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Shanker Wang
> 在 2016年6月19日,12:13,Richard Weinberger 写道: > > Am 19.06.2016 um 07:21 schrieb Shanker Wang: >> This patch removes the check for CAP_NET_ADMIN in the initial namespace >> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user >> namespace the net na

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-18 Thread Shanker Wang
> 在 2016年6月19日,07:24,David Miller 写道: > > From: Shanker Wang > Date: Sun, 19 Jun 2016 07:21:27 +0200 > >> This patch removes the check for CAP_NET_ADMIN in the initial namespace >> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user >> namesp

[PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-18 Thread Shanker Wang
This patch removes the check for CAP_NET_ADMIN in the initial namespace when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user namespace the net namespace was created so that /dev/ppp cat get opened in a unprivileged container. Cc: Hannes Frederic Sowa Cc: Richard Weinberger Cc: G

[PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-18 Thread Shanker Wang
This patch removes the check for CAP_NET_ADMIN in the initial namespace when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user namespace the net namespace was created so that /dev/ppp cat get opened in a unprivileged container. Cc: Hannes Frederic Sowa Cc: Richard Weinberger Cc: G