Re: [PATCH net] net: bridge: start hello timer only if device is up

in its ndo_stop() function, they never get disabled if the > device is destroyed before it's upped. > > To reproduce: > $ while :; do ip l add br0 type bridge hello_time 100; brctl stp br0 on; > ip l del br0; done; > > CC: Xin Long > CC: Ivan Vecera > CC: Sebas

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On Thu, 1 Jun 2017, Xin Long wrote: > On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott > wrote: > > [...] > I couldn't see any bridge-related thing here, and it couldn't be reproduced > with virbr0 (stp=1) on my box (on both s390x and x86_64), I guess there > i

Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

Hi, A system running v4.12-rc3-11-gf511c0b on s390 hangs after boot with no messages on the console. The message buffer obtained via a system dump looked like this: [...] [ 17.870712] virbr0: port 1(virbr0-nic) entered disabled state [ 19.618523] Unable to handle kernel pointer dereference in

mlx5: net_device.addr_list_lock usage before initialization

Hi, I ran into the following lockdep complaint: [7.059561] INFO: trying to register non-static key. [7.059566] the code is fine but needs lockdep annotation. [7.059570] turning off the locking correctness validator. [7.059579] CPU: 6 PID: 6 Comm: kworker/u32:0 Not tainted 4.9.0-0

Re: [PATCH net-next V2 1/7] net/mlx5e: Implement Fragmented Work Queue (WQ)

Hi, On Wed, 30 Nov 2016, Saeed Mahameed wrote: > From: Tariq Toukan > > Add new type of struct mlx5_frag_buf which is used to allocate fragmented > buffers rather than contiguous, and make the Completion Queues (CQs) use > it as they are big (default of 2MB per CQ in Striding RQ). > > This fixe

mlx5: ifup failure due to huge allocation

Hi, Ifup on an interface provided by CX4 (MLX5 driver) on s390 fails with: [ 22.318553] [ cut here ] [ 22.318564] WARNING: CPU: 1 PID: 399 at mm/page_alloc.c:3421 __alloc_pages_nodemask+0x2ee/0x1298 [ 22.318568] Modules linked in: mlx4_ib ib_core mlx5_core mlx4_en m

mlx4: panic during shutdown

Hi, After a userspace update (fedora 23->24) I reproducibly run into the following oops during shutdown (on s390): [ 71.054832] Unable to handle kernel pointer dereference in virtual kernel address space [ 71.054835] Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803 [ 71.054838] Fau

Re: [PATCH] net/mlx4_en: fix off by one in error handling

On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 4:53 PM, Sebastian Ott wrote: > > On Wed, 14 Sep 2016, Tariq Toukan wrote: > > > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > > > If an error occurs in mlx4_init_eq_table the index used in the > > &g

Re: [PATCH] net/mlx4_en: fix off by one in error handling

Hello Tariq, On Wed, 14 Sep 2016, Tariq Toukan wrote: > On 14/09/2016 2:09 PM, Sebastian Ott wrote: > > If an error occurs in mlx4_init_eq_table the index used in the > > err_out_unmap label is one too big which results in a panic in > > mlx4_free_eq. This patch fixes the in

[PATCH] net/mlx4_en: fix off by one in error handling

If an error occurs in mlx4_init_eq_table the index used in the err_out_unmap label is one too big which results in a panic in mlx4_free_eq. This patch fixes the index in the error path. Signed-off-by: Sebastian Ott --- drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++-- 1 file changed, 2

ipv6 csum failures on MLX4 VFs

Hi, I receive tons of these csum failure warnings. The patch mentioned here: https://patchwork.ozlabs.org/patch/512005/ seems to work. Will something like that be integrated upstream? Sebastian

Re: mlx4: "failed to allocate default counter port 1"

On Wed, 1 Jul 2015, Or Gerlitz wrote: > On 6/30/2015 5:17 PM, Sebastian Ott wrote: > > On Tue, 30 Jun 2015, Or Gerlitz wrote: > > > On 6/30/2015 4:24 PM, Sebastian Ott wrote: > > > > > > Do you run the VF on the same system/kernel as the PF, or the VF is > &

Re: mlx4: "failed to allocate default counter port 1"

On Wed, 1 Jul 2015, Or Gerlitz wrote: > On Wed, Jul 1, 2015 at 5:18 PM, Sebastian Ott > wrote: > > OK, using this patch it worked: > > yep, I forgot to recap err to zero. > > By "it worked" you mean the VF is live and kicking, all functionality > you ha

Re: mlx4: "failed to allocate default counter port 1"

On Wed, 1 Jul 2015, Sebastian Ott wrote: > On Wed, 1 Jul 2015, Or Gerlitz wrote: > > On 6/30/2015 5:17 PM, Sebastian Ott wrote: > > > On Tue, 30 Jun 2015, Or Gerlitz wrote: > > > > On 6/30/2015 4:24 PM, Sebastian Ott wrote: > > > > > > > Do you

Re: mlx4: "failed to allocate default counter port 1"

On Wed, 1 Jul 2015, Or Gerlitz wrote: > On 6/30/2015 5:17 PM, Sebastian Ott wrote: > > On Tue, 30 Jun 2015, Or Gerlitz wrote: > > > On 6/30/2015 4:24 PM, Sebastian Ott wrote: > > > > > > Do you run the VF on the same system/kernel as the PF, or the VF is > &

Re: mlx4: "failed to allocate default counter port 1"

On Tue, 30 Jun 2015, Or Gerlitz wrote: > On 6/30/2015 4:24 PM, Sebastian Ott wrote: > > > >Do you run the VF on the same system/kernel as the PF, or the VF is > > > >probed to > > > >VM which runs the latest kernel and the PF runsolder kernel (which?) >

Re: mlx4: "failed to allocate default counter port 1"

On Tue, 30 Jun 2015, Or Gerlitz wrote: > On 6/30/2015 1:45 PM, Sebastian Ott wrote: > > [ 88.909558] mlx4_slave_cmd op=3840, ret=-22, status=3 > > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: > > failed to allocate default counter port 1 err

Re: mlx4: "failed to allocate default counter port 1"

On Tue, 30 Jun 2015, Or Gerlitz wrote: > On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott > wrote: > > after the latest mellanox update the mlx4 driver fails to probe a VF: > > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: > > failed to allocate de

mlx4: "failed to allocate default counter port 1"

Hello, after the latest mellanox update the mlx4 driver fails to probe a VF: [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed to allocate default counter port 1 err -22 [ 88.909564] mlx4_core :00:00.0: Failed to allocate default counters, aborting [ 88.961735