Re: [PATCH] can: flexcan: use devm_platform_ioremap_resource() to simplify code

2019-09-29 Thread Sean Nyekjaer
On 29/09/2019 10.32, Joakim Zhang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together to simplify the code. Signed-off-by: Joakim Zhang Reviewed-by: Sean Nyekjaer --- drivers/net/can/flexcan.c | 4

Re: [PATCH] can: flexcan: free error skb if enqueueing failed

2019-09-13 Thread Sean Nyekjaer
On 01/08/2019 09.59, Martin Hundebøll wrote: On 15/07/2019 20.53, Martin Hundebøll wrote: If the call to can_rx_offload_queue_sorted() fails, the passed skb isn't consumed, so the caller must do so. Fixes: 30164759db1b ("can: flexcan: make use of rx-offload's irq_offload_fifo") Signed-off-

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-09-10 Thread Sean Nyekjaer
On 05/09/2019 09.10, Joakim Zhang wrote: Hi Sean, Could you update lastest flexcan driver using linux-can-next/flexcan and then merge below two patches from linux-can/testing? d0b53616716e (HEAD -> testing, origin/testing) can: flexcan: add LPSR mode support for i.MX7D 803eb6bad65b can: fle

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-09-05 Thread Sean Nyekjaer
On 05/09/2019 09.10, Joakim Zhang wrote: Hi Sean, Could you update lastest flexcan driver using linux-can-next/flexcan and then merge below two patches from linux-can/testing? d0b53616716e (HEAD -> testing, origin/testing) can: flexcan: add LPSR mode support for i.MX7D 803eb6bad65b can: fle

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-09-04 Thread Sean Nyekjaer
On 29/08/2019 09.30, Joakim Zhang wrote: Hi Sean, I'm sorry that I can't get the debug log as the site can't be reached. And I connect two boards to do test at my side, this issue can't be reproduced. Best Regards, Joakim Zhang Hi Joakim, What commit and branch are you doing your tests w

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-28 Thread Sean Nyekjaer
On 20/08/2019 13.55, Sean Nyekjaer wrote: I have added some more debug, same test setup: https://gist.github.com/sknsean/81208714de23aa3639d3e31dccb2f3e0 root@iwg26:~# systemctl suspend ... https://gist.github.com/sknsean/2a786f1543305056d4de03d387872403 /Sean Any luck reproducing this

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Sean Nyekjaer
Unfortunatly it's still possible to reproduce the deadlock with this patch... [ 689.921717] flexcan: probe of 2094000.flexcan failed with error -110 My test setup: PC with CAN-USB dongle connected to can0 and can1. PC: $ while true; do cansend can0 '123#DEADBEEF'; done iMX6ull: root@iwg26:

Re: [PATCH REPOST 1/2] can: flexcan: fix deadlock when using self wakeup

2019-08-20 Thread Sean Nyekjaer
On 16/08/2019 10.20, Joakim Zhang wrote: As reproted by Sean Nyekjaer below: When suspending, when there is still can traffic on the interfaces the flexcan immediately wakes the platform again. As it should :-). But it throws this error msg: [ 3169.378661] PM: noirq suspend of devices failed

Re: [PATCH] can: flexcan: free error skb if enqueueing failed

2019-08-20 Thread Sean Nyekjaer
CC'ing Joakim Zhang On 15/07/2019 20.53, Martin Hundebøll wrote: If the call to can_rx_offload_queue_sorted() fails, the passed skb isn't consumed, so the caller must do so. Fixes: 30164759db1b ("can: flexcan: make use of rx-offload's irq_offload_fifo") Signed-off-by: Martin Hundebøll --- dr

Re: [PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property

2019-08-20 Thread Sean Nyekjaer
On 29/04/2019 19.39, Rob Herring wrote: On Tue, 9 Apr 2019 10:39:49 +0200, Sean Nyekjaer wrote: add wakeup-source boolean property. Signed-off-by: Sean Nyekjaer --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Rob

Re: [PATCH] can: flexcan: fix deadlock when using self wakeup

2019-06-11 Thread Sean Nyekjaer
On 11/06/2019 08.58, Joakim Zhang wrote: How is it going with the updated patch? Hi Sean, I still need discuss with Marc about the solution. Joakim Zhang Hi, Joakim Please include me in the loop :-) /Sean

Re: [PATCH] can: flexcan: fix deadlock when using self wakeup

2019-06-08 Thread Sean Nyekjaer
On 17/05/2019 04.39, Joakim Zhang wrote: As reproted by Sean Nyekjaer bellow: When suspending, when there is still can traffic on the interfaces the flexcan immediately wakes the platform again. As it should :-) But it throws this error msg: [ 3169.378661] PM: noirq suspend of devices failed

Re: [PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source'

2019-06-08 Thread Sean Nyekjaer
kind ping :-) On 09/04/2019 10.39, Sean Nyekjaer wrote: The flexcan controller can be forced as a wakeup source by stating that explicitly in the device's .dts file using the "wakeup-source" boolean property. Signed-off-by: Sean Nyekjaer --- drivers/net/can/flexcan.c |

[PATCH] can: flexcan: fix deadlock when using self wakeup

2019-04-16 Thread Sean Nyekjaer
h the current driver it can't recover from this even with a soft reboot, it requires a hard reboot. Fixes: de3578c198c6 ("can: flexcan: add self wakeup support") Signed-off-by: Sean Nyekjaer --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/2] can: flexcan: add support for DT property 'wakeup-source'

2019-04-09 Thread Sean Nyekjaer
The flexcan controller can be forced as a wakeup source by stating that explicitly in the device's .dts file using the "wakeup-source" boolean property. Signed-off-by: Sean Nyekjaer --- drivers/net/can/flexcan.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/

[PATCH 2/2] dt-bindings: can: flexcan: add can wakeup property

2019-04-09 Thread Sean Nyekjaer
add wakeup-source boolean property. Signed-off-by: Sean Nyekjaer --- Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl

[PATCH] net: phy: micrel: KSZ8795 do not set SUPPORTED_[Asym_]Pause

2017-01-27 Thread Sean Nyekjaer
As pr commit "net: phy: phy drivers should not set SUPPORTED_[Asym_]Pause" this phy driver should not set these feature bits. Signed-off-by: Sean Nyekjaer Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795") --- drivers/net/phy/micrel.c | 2 +- 1 file change

[PATCH v2] net: phy: micrel: add support for KSZ8795

2017-01-26 Thread Sean Nyekjaer
This is adds support for the PHYs in the KSZ8795 5port managed switch. It will allow to detect the link between the switch and the soc and uses the same read_status functions as the KSZ8873MLL switch. Signed-off-by: Sean Nyekjaer --- Changes in v2: - Removed "switch" name drive

[PATCH v1] net: phy: micrel: add KSZ8795 ethernet switch

2017-01-22 Thread Sean Nyekjaer
This is add support for the PHYs in the KSZ8795 5port managed switch. It will allow to detect the link between the switch and the soc and uses the same read_status functions as the KSZ8873MLL switch. This ethernet switch have unfortunately the same phy id as KSZ8051. Signed-off-by: Sean

[PATCH] net: phy: micrel: add KSZ8795 ethernet switch

2017-01-20 Thread Sean Nyekjaer
This ethernet switch have unfortunately the same phy id as KSZ8051. Signed-off-by: Sean Nyekjaer --- drivers/net/phy/micrel.c | 14 ++ include/linux/micrel_phy.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index