[PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'

2020-05-08 Thread Samuel Zou
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set but not used [-Wunused-but-set-variable] u32 prev_time = 0; ^ Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/d

Re: [PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags

2020-05-06 Thread Samuel Zou
Both of you are right. I neglected, and this patch is wrong. Thanks. On 2020/5/6 23:15, Joe Perches wrote: On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote: On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote: On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote: This silences the

[PATCH -next] net: ethernet: mediatek: Make mtk_m32 static

2020-05-05 Thread Samuel Zou
Fix the following sparse warning: drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning: symbol 'mtk_m32' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- 1 file changed, 1 inser

[PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags

2020-05-05 Thread Samuel Zou
This silences the following coccinelle warning: "WARNING: sum of probable bitmasks, consider |" Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-05 Thread Samuel Zou
Fixes coccicheck warning: drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/ethernet/ti/am65-cpts.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet

Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler

2020-04-29 Thread Samuel Zou
On 2020/4/30 2:43, David Miller wrote: From: Zou Wei Date: Wed, 29 Apr 2020 12:17:40 +0800 fix coccinelle warning, use ARRAY_SIZE drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE -- Please don't put this "---" here. diff --git a/drivers/n

Re: [PATCH -next] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler

2020-04-28 Thread Samuel Zou
Hi Joe, Thanks for your comments, I will modify and send the v2 On 2020/4/29 11:23, Joe Perches wrote: On Wed, 2020-04-29 at 11:15 +0800, Zou Wei wrote: fix coccinelle warning, use ARRAY_SIZE drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE Reported-by: Hulk