Re: [PATCH] ppp: Move PFC decompression to PPP generic layer

Hi Guillaume, On Wed, Dec 19, 2018 at 4:38 PM Guillaume Nault wrote: > > On Wed, Dec 19, 2018 at 02:08:08AM +0200, Sam Protsenko wrote: > > Extract "Protocol" field decompression code from transport protocols to > > PPP generic layer, where it actually belongs. As a

[PATCH v2] ppp: Move PFC decompression to PPP generic layer

omments instead. Signed-off-by: Sam Protsenko --- Changes in v2: - Fix the order of checking skb data room and proto decompression - Remove "inline" keyword from ppp_decompress_proto() - Don't split line before function name - Prefix ppp_decompress_proto() function with &qu

[PATCH] ppp: Move PFC decompression to PPP generic layer

omments instead. Signed-off-by: Sam Protsenko --- drivers/net/ppp/ppp_async.c | 14 +++--- drivers/net/ppp/ppp_generic.c | 21 +++-- drivers/net/ppp/ppp_synctty.c | 9 - drivers/net/ppp/pptp.c| 5 - net/l2tp/l2tp_ppp.c | 4 5 fi

Re: [PATCH 2/2] l2tp: Add Protocol field compression

Hi Guillaume, On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet should be transmitted without leading

Re: [PATCH] l2tp: Add protocol field decompression

Hi Guillaume, On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 07:59:21PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet will be received without leading 0x00

[PATCH 1/2] l2tp: Bring back ->flags to struct pppol2tp_session

Flags field will be used in further commits (e.g. for keeping SC_COMP_PROT), so let's bring those back. This commit effectively reverts commit 1998b5ed9c9b ("l2tp: drop ->flags from struct pppol2tp_session"), with some cosmetic changes. Signed-off-by: Sam Protsenko --- net/l2

[PATCH 2/2] l2tp: Add Protocol field compression

Of course, we don't compress Protocol field when sending LCP packets. As stated in RFC 1661, section 6.5: The Protocol field is never compressed when sending any LCP packet. This rule guarantees unambiguous recognition of LCP packets. Signed-off-by: Sam Protsenko --- net/l2tp/l2t

[PATCH] l2tp: Add protocol field decompression

x0021 in PPP packet there will be Protocol=0x21. This patch unwraps it back to 0x0021, which fixes the issue. Sending the compressed Protocol field will be implemented in subsequent patch, this one is self-sufficient. Signed-off-by: Sam Protsenko --- net/l2tp/l2tp_ppp.c | 4 1 file changed,

Re: problems with L2TP

> Tom and I discussed this and we're not clear what you are running. Have > you changed create_pppox() in mtpd with the code fragment from your > original mail? Here is the commit for mtpd where I'm changing Android L2TP implementation to mainline implementation: http://git.linaro.org/people/semen

Re: problems with L2TP

Thanks for your reply, Tom! > How is the tunnel/session being created on the server side? My server is xl2tpd. If I understand correctly, session and tunnel are being created in start_pppd() function, see [1]. Judging from xl2tpd logs (see [2]), start_pppd() function is executed, in turn, from co

problems with L2TP

Hi, I'm having issues running user-space code, which uses net/l2tp/l2tp_ppp.c. The code is supposed to be running in LAC mode (which is I believe is default). My server configuration described here: https://wiki.linaro.org/LMG/Kernel/PPP I was trying to use next code snippets as user-space part: