Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Fri, 2020-08-07 at 10:26 +0200, Rouven Czerwinski wrote: > On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > > kernel &g

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > kernel > > results in a EOPNOTSUPP message during sendmsg: > > > > set

[PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-05 Thread Rouven Czerwinski
path for the TLS device implementation, however the flag hasn't been added there for lack of testing hardware. Signed-off-by: Rouven Czerwinski --- net/tls/tls_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 24f64bc

Re: [PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-05 Thread Rouven Czerwinski
On Wed, 2020-08-05 at 17:45 -0700, David Miller wrote: > Neither of these patches apply cleanly to net-next. The compat handling > and TLS code has been changed quite a bit lately. Indeed, Patch 1 is no longer required on net-next. I'll drop the patch. > ALso, you must provide a proper header "[

[PATCH 2/2] net: tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-05 Thread Rouven Czerwinski
The MSG_CMSG_COMPAT flag is valid if the system has CONFIG_COMPAT enabled and a 32bit userspace. Signed-off-by: Rouven Czerwinski --- net/tls/tls_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 24f64bc0de18..a332ae123bda

[PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-05 Thread Rouven Czerwinski
If compat_{s,g}etsockopt for TLS are not implemented, the TLS layer will never be called on a system where CONFIG_COMPAT is enabled and userspace is 32bit. Implement both to support CONFIG_COMPAT. Signed-off-by: Rouven Czerwinski --- net/tls/tls_main.c | 28 1 file