Re: [PATCH] proc_fs.h redux

2007-10-28 Thread Roman Zippel
Hi, On Sunday 28 October 2007, Russell King wrote: > On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote: > > and forward declarations of > > > > struct proc_dir_entry; > > struct file_operations; > > > > As a general rule, I think it better to use includes > > than use naked forward decl

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > Tough, the kernel community has voted against you. > > It makes far more sense to include a driver during kernel configuration, and > have that driver pull in its libraries via 'select'. The lame alternative > requires developers to know which librar

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > > select seriously screws with the dependencies, it's especially problematic > > if the selected symbol has other dependencies as HDLC in this case, it makes > > it only more complicated to get the dependencies correct again. > > Please use it only if

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Actually I can't see any bad idea here. > The original dependency was certainly, uhm, not the best one. select seriously screws with the dependencies, it's especially problematic if the selected symbol has other dependencies as HDLC in this case

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-07 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > What's the advantage? The HDLC option is directly before this? > > You don't have to know it's required, you can just select a driver > for your hardwar

Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

2007-05-06 Thread Roman Zippel
Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Allow enabling WAN drivers without selecting generic HDLC first, > HDLC will be selected automatically. > > Signed-off-by: Krzysztof Halasa <[EMAIL PROTECTED]> > > diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig > index 8897f53..3

Re: [PATCH -rt DO NOT APPLY] Fix for tg3 networking lockup

2006-08-09 Thread Roman Zippel
Hi, On Tue, 8 Aug 2006, Steven Rostedt wrote: > OK, but still, if it is expected to expire, which this one is, then it > should be converted to a hrtimer, instead of a normal timer. The hrtimers > were introduced to make it more efficient for expiring timers. Well, they > really were introduced

Re: [git patches] 2.6.x net driver updates

2006-01-13 Thread Roman Zippel
Hi, On Thu, 12 Jan 2006, Linus Torvalds wrote: > > Yes, I think that's much more Aunt-Nellie-friendly, but Roman considers it > > abuse of the Kconfig system in ways which I never completely understood? > > Hmm. If Roman dislikes it, he must dislike the fact that we already do > exactly this fo

Re: [PATCH] net drivers: make some driver families subordinate

2005-07-25 Thread Roman Zippel
Hi, On Sun, 24 Jul 2005, David S. Miller wrote: > I'll sit on this until we get some feedback from Roman. The second patch looks better, minus the typo in the description and the initial comment in the patch is a little redundant. bye, Roman - To unsubscribe from this list: send the line "unsu

Re: [2.6 patch] fix IP_FIB_HASH kconfig warning

2005-07-04 Thread Roman Zippel
Hi, On Mon, 4 Jul 2005, Adrian Bunk wrote: > --- linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig.old2005-07-02 > 20:07:25.0 +0200 > +++ linux-2.6.13-rc1-mm1-full/net/ipv4/Kconfig2005-07-02 > 20:13:05.0 +0200 > @@ -58,8 +58,9 @@ > depends on IP_ADVANCED_ROUTER >