On 09/11/17 10:28, Roger Quadros wrote:
> On 08/11/17 11:49, Chris Zhong wrote:
>> Hi Florian Fainelli
>>
>>
>> On 2017年11月08日 02:26, Florian Fainelli wrote:
>>> On 11/07/2017 01:51 AM, Chris Zhong wrote:
>>>>
>>>> On 2017年11月07日 15:54,
On 08/11/17 11:49, Chris Zhong wrote:
> Hi Florian Fainelli
>
>
> On 2017年11月08日 02:26, Florian Fainelli wrote:
>> On 11/07/2017 01:51 AM, Chris Zhong wrote:
>>>
>>> On 2017年11月07日 15:54, Vladimir Zapolskiy wrote:
Hello Chris,
On 11/07/2017 04:49 AM, Chris Zhong wrote:
> The et
Hi,
On 07/11/17 09:54, Vladimir Zapolskiy wrote:
> Hello Chris,
>
> On 11/07/2017 04:49 AM, Chris Zhong wrote:
>> The ethernet phy of rk3066a-rayeager has a reset pin, it controlled by
>> GPIO1_D6, this pin should be pull down then pull up to reset the phy.
>> Add a phy-reset property in emac, ma
e width must be defined, which is
> the maximum value of all individual PHYs RESET pulse widths determined
> by reading their datasheets.
>
> Fixes: 69226896ad63 ("mdio_bus: Issue GPIO RESET to PHYs.")
> Signed-off-by: Florian Fainelli
Reviewed-by: Roger Quadros
> --
On 25/04/17 19:31, Florian Fainelli wrote:
> On 04/25/2017 09:22 AM, Lars-Peter Clausen wrote:
>> On 04/24/2017 11:04 AM, Roger Quadros wrote:
>>> On 24/04/17 02:35, Andrew Lunn wrote:
>>>> On Fri, Apr 21, 2017 at 03:31:09PM +0200, Lars-Peter Clausen wrote:
>&
On 25/04/17 19:22, Lars-Peter Clausen wrote:
> On 04/24/2017 11:04 AM, Roger Quadros wrote:
>> On 24/04/17 02:35, Andrew Lunn wrote:
>>> On Fri, Apr 21, 2017 at 03:31:09PM +0200, Lars-Peter Clausen wrote:
>>>> On 04/21/2017 03:15 PM, Roger Quadros wrote:
>>>&
On 24/04/17 02:35, Andrew Lunn wrote:
> On Fri, Apr 21, 2017 at 03:31:09PM +0200, Lars-Peter Clausen wrote:
>> On 04/21/2017 03:15 PM, Roger Quadros wrote:
>>> diff --git a/Documentation/devicetree/bindings/net/mdio.txt
>>> b/Documentation/devicetree/bindings/net/mdio.t
nterrupt. At the same time PHY state machine expect that PHY started
> auto-negotiation and is waiting for interrupt from PHY and it won't get it.
>
> Signed-off-by: Alexander Kochetkov
> Cc: stable # v4.9+
Tested-by: Roger Quadros
I think the following commit broke functional
ET de-assertion in the MDIO bus driver.
[1] - am572x-idk, am571x-idk, a437x-idk
Signed-off-by: Roger Quadros
---
v4:
- use dev_err() instead of pr_err()
- put PHYs back in RESET on failure or mdiobus_unregister()
- typo fixes uS -> us
v3:
- added more information in the DT binding document.
v2:
- ad
Hi Florian,
On 21/04/17 04:23, Florian Fainelli wrote:
> Hi Roger,
>
> On 04/20/2017 07:11 AM, Roger Quadros wrote:
>> Some boards [1] leave the PHYs at an invalid state
>> during system power-up or reset thus causing unreliability
>> issues with the PHY which manifest
ET de-assertion in the MDIO bus driver.
[1] - am572x-idk, am571x-idk, a437x-idk
Signed-off-by: Roger Quadros
---
v3:
- added more information in the DT binding document.
v2:
- add device tree binding document (mdio.txt)
- specify default reset delay in of_mdio.c instead of mdio_bus.c
Document
On 20/04/17 16:13, Andrew Lunn wrote:
> On Thu, Apr 20, 2017 at 11:39:20AM +0300, Roger Quadros wrote:
>> Some boards [1] leave the PHYs at an invalid state
>> during system power-up or reset thus causing unreliability
>> issues with the PHY which manifests as PHY not being de
the 1 second delay that my patch
had.
So,
Tested-by: Roger Quadros
>
> If MAC use phy_start_aneg() instead of phy_start() my patch will not work as
> expected. Roger, if patch don’t work for you please check what MAC bring up
> PHY using
> phy_start():
Our MAC driver is using
ET de-assertion in the MDIO bus driver.
[1] - am572x-idk, am571x-idk, a437x-idk
Signed-off-by: Roger Quadros
---
v2:
- add device tree binding document (mdio.txt)
- specify default reset delay in of_mdio.c instead of mdio_bus.c
Documentation/devicetree/bindings/net/mdio.txt | 20
dr
On 19/04/17 16:38, Andrew Lunn wrote:
> On Wed, Apr 19, 2017 at 02:56:48PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> On 19/04/17 14:39, Andrew Lunn wrote:
>>> On Wed, Apr 19, 2017 at 12:24:26PM +0300, Roger Quadros wrote:
>>>> Some boards [1] leave the P
Hi,
On 19/04/17 14:39, Andrew Lunn wrote:
> On Wed, Apr 19, 2017 at 12:24:26PM +0300, Roger Quadros wrote:
>> Some boards [1] leave the PHYs at an invalid state
>> during system power-up or reset thus causing unreliability
>> issues with the PHY which manifests as PHY not
ET de-assertion in the MDIO bus driver.
[1] - am572x-idk, am571x-idk, a437x-idk
Signed-off-by: Roger Quadros
---
drivers/net/phy/mdio_bus.c | 26 ++
drivers/of/of_mdio.c | 4
include/linux/phy.h| 5 +
3 files changed, 35 insertions(+)
diff --git a/driver
Hi,
On 28/03/17 13:05, Roger Quadros wrote:
> +Andrew Davis & Sekhar.
>
> Hi,
>
> Andrew Davis posted a few comments offline which I'm clarifying here.
>
> On 27/03/17 14:59, Roger Quadros wrote:
>> The Ethernet link on an interrupt driven PHY was not co
On 08/04/17 18:18, Florian Fainelli wrote:
>
>
> On 04/08/2017 08:10 AM, Andrew Lunn wrote:
>> On Sat, Apr 08, 2017 at 06:55:45AM -0700, David Miller wrote:
>>> From: Roger Quadros
>>> Date: Wed, 5 Apr 2017 11:33:57 +0300
>>>
>>>> Some boa
On 06/04/17 15:05, Andrew Lunn wrote:
>>> Do you really need more than one GPIO? A single gpio would make all
>>> this code a lot simpler.
>>>
>>
>> Yes we need. Some of our boards have separate GPIO RESET lines for
>> different PHYs on the same MDIO bus.
>
> If you have a one-to-one mapping of G
Hi,
On 05/04/17 18:03, Andrew Lunn wrote:
> On Wed, Apr 05, 2017 at 11:33:57AM +0300, Roger Quadros wrote:
>> Some boards [1] leave the PHYs at an invalid state
>> during system power-up or reset thus causing unreliability
>> issues with the PHY like not being detected by th
On 04/04/17 19:01, Tony Lindgren wrote:
> * Roger Quadros [170330 05:37]:
>> Hi Tony & Dave,
>>
>> On 13/03/17 15:42, Roger Quadros wrote:
>>> Hi,
>>>
>>> This series adds ethernet support to am335x-icev2 board.
>>>
>>> T
dling for such cases.
[1] - am572x-idk, am571x-idk, a437x-idk.
Signed-off-by: Roger Quadros
Signed-off-by: Sekhar Nori
---
.../devicetree/bindings/net/davinci-mdio.txt | 2 +
drivers/net/ethernet/ti/davinci_mdio.c | 68 +++---
2 files changed, 62 insertions(
Florian,
On 30/03/17 23:02, Florian Fainelli wrote:
> On 03/27/2017 04:59 AM, Roger Quadros wrote:
>> The Ethernet link on an interrupt driven PHY was not coming up if the
>> Ethernet cable was plugged before the Ethernet interface was brought up.
>>
>> The PHY stat
Hi Tony & Dave,
On 13/03/17 15:42, Roger Quadros wrote:
> Hi,
>
> This series adds ethernet support to am335x-icev2 board.
>
> The ethernet PHYs on the board need an explicit GPIO reset pulse
> to ensure they bootstrap to the correct mode. Without the
> GPIO r
+Andrew Davis & Sekhar.
Hi,
Andrew Davis posted a few comments offline which I'm clarifying here.
On 27/03/17 14:59, Roger Quadros wrote:
> The Ethernet link on an interrupt driven PHY was not coming up if the
> Ethernet cable was plugged before the Ethernet interface was broug
().
There is no way of knowing in phy.c whether auto-negotiation was
restarted or not by the PHY driver so we just wait for the next
poll/interrupt to update the PHY state machine.
Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not
polling.")
Cc: stable # v
On 23/03/17 11:52, Sergei Shtylyov wrote:
> Hello!
>
> On 3/22/2017 2:02 PM, Roger Quadros wrote:
>
>> he ethernet link on an interrupt driven PHY was not coming up if the
>
>s/he/The/?
>
>> ethernet cable was plugged before the ethernet interface was b
_aneg().
Fixes: 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not
polling.")
Cc: stable # v4.9+
Signed-off-by: Roger Quadros
---
drivers/net/phy/phy.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..49d
stable # v4.9+
Signed-off-by: Roger Quadros
---
drivers/net/phy/phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 49dedf8..ab14e7b 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -907,6 +907,7 @@ void phy_
Hi,
These 2 patches fix the following 2 issues with the PHY state machine
when used with interrupt driven PHYs.
- PHY link not coming up if Ethernet cable is plugged before Ethernet network
interface is brought up.
- PHY not being suspended when PHY is halted.
cheers,
-roger
Roger Quadros (2
On 20/03/17 18:41, Florian Fainelli wrote:
> On 03/16/2017 12:46 AM, Roger Quadros wrote:
>> On 15/03/17 17:49, Andrew Lunn wrote:
>>> On Wed, Mar 15, 2017 at 05:00:08PM +0200, Roger Quadros wrote:
>>>> Andrew,
>>>>
>>>> On 15/03/17 16:08,
On 15/03/17 17:49, Andrew Lunn wrote:
> On Wed, Mar 15, 2017 at 05:00:08PM +0200, Roger Quadros wrote:
>> Andrew,
>>
>> On 15/03/17 16:08, Andrew Lunn wrote:
>>> On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote:
>>>> Since commit 3c293f4e08b5
Andrew,
On 15/03/17 16:08, Andrew Lunn wrote:
> On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote:
>> Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change
>> and not polling.")
>> phy_suspend() doesn't get called
hine so that it can
see the new PHY state (HALTED) and suspend the PHY.
Signed-off-by: Roger Quadros
---
drivers/net/phy/phy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1be69d8..8fef03b 100644
--- a/drivers/net/phy/phy.c
+++ b/driver
DP83848_PHY i.e. [TI TLK10X 10/100 Mbps PHY] is used on the
am335x-icev2 board. Enable the PHY driver for it.
Signed-off-by: Roger Quadros
---
arch/arm/configs/omap2plus_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/omap2plus_defconfig
b/arch/arm/configs
Enable the 2 ethernet ports as CPSW ports in dual-mac mode
Signed-off-by: Roger Quadros
[nsek...@ti.com: use AM33XX_IOPAD()]
Signed-off-by: Sekhar Nori
---
v2:
- use phy-handle instead of phy_id
arch/arm/boot/dts/am335x-icev2.dts | 121 +
1 file changed
Hi,
This series adds ethernet support to am335x-icev2 board.
The ethernet PHYs on the board need an explicit GPIO reset pulse
to ensure they bootstrap to the correct mode. Without the
GPIO reset they just don't work.
cheers,
-roger
Roger Quadros (2):
net: davinci_mdio: add GPIO reset
dling for such cases.
[1] - am572x-idk, am571x-idk, a437x-idk.
Signed-off-by: Roger Quadros
Signed-off-by: Sekhar Nori
---
.../devicetree/bindings/net/davinci-mdio.txt | 2 +
drivers/net/ethernet/ti/davinci_mdio.c | 68 +++---
2 files changed, 62 insertions(
Enable the 2 ethernet ports as CPSW ports in dual-mac mode
Signed-off-by: Roger Quadros
[nsek...@ti.com: use AM33XX_IOPAD()]
Signed-off-by: Sekhar Nori
---
arch/arm/boot/dts/am335x-icev2.dts | 113 +
1 file changed, 113 insertions(+)
diff --git a/arch/arm
This PHY has a compatible register set with DP83848x so
add support for it.
Acked-by: Andrew F. Davis
Signed-off-by: Roger Quadros
---
drivers/net/phy/dp83848.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
index 03d54c4..800b39f
On 13/05/16 22:36, Sergei Shtylyov wrote:
> Hello.
>
> On 05/13/2016 12:07 PM, Roger Quadros wrote:
>
> [...]
>
>>>> +}
>>>> +EXPORT_SYMBOL(mdio_device_reset);
>>>> +
>>>> /**
>>>> * mdio_probe - probe an M
Hi Sergei,
On 12/05/16 21:42, Uwe Kleine-König wrote:
> Hello Sergei,
>
> [we already talked about this patch in #armlinux, I'm now just
> forwarding my comments on the list. Background was that I sent an easier
> and less complete patch with the same idea. See
> http://patchwork.ozlabs.org/patch
On 12/05/16 17:02, Roger Quadros wrote:
> Hi,
>
> On 12/05/16 16:50, Nishanth Menon wrote:
>> On 05/12/2016 05:00 AM, Uwe Kleine-König wrote:
>>> The framework only asserts (for now) that the reset gpio is not active.
>>>
>>> Signed-off-by: Uwe Kleine-Kö
/
>> +reset_gpios = devm_gpiod_get_array_optional(dev, "reset",
>> +GPIOD_OUT_LOW);
>> +if (IS_ERR(reset_gpios))
>> +return PTR_ERR(reset_gpios);
>> +
>> /* Disable the interrupt if the PHY doesn't support it
>> * but the interrupt is still a valid one
>> */
>>
>
> This looks like the right approach to me at least: I see that TI EVMs
> will also benefit with this approach.
>
Agreed. Although on some of our boards we actually need a RESET pulse
to get the PHY in a sane state. I can send a patch on top for that.
Reviewed-by: Roger Quadros
--
cheers,
-roger
45 matches
Mail list logo
