[PATCH][net/sched/sch_teql.c] duplicate IFF_BROADCAST in FMASK, remove 2nd

Untested patch below, please confirm it's the right fix (should it be some other IFF_*?) -- duplicate IFF_BROADCAST, remove 2nd Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index c0ed06d..a53acf4 100644 --- a/net/sched/sch_t

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv & ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '| A

[PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91_ether.c

include/linux/mii.h:48:#define BMCR_RESET 0x8000 The function reset_phy() is in "#if 0" inactivated code -- Replace logical "&&" by bit "&" before BMCR_RESET Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/arm/at91_ethe

[PATCH 1/1] replace logical- by bit-or in smctr_make_tx_status_code(), drivers/net/tokenring/smctr.c

drivers/net/tokenring/smctr.h:50:#define IBM_PASS_SOURCE_ADDR0x01 -- replace logical- by bit-or for IBM_PASS_SOURCE_ADDR Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tokenring/smctr.c b/drivers/net/tokenring/smctr.c index 93da3a3..ec29766 100644

Re: [2.6 patch] atm/idt77105.c: fix section mismatch

/powerpc/kernel/vio.c:309:EXPORT_SYMBOL(vio_unregister_device); __cpu_init arch/x86/kernel/topology.c:60:EXPORT_SYMBOL(arch_register_cpu); -- EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/arm/mach-imx/generic.c b/arch/arm/

[PATCH drivers/net/skfp/h/fplustm.h] parentheses around RX_FIFO_SPACE definition

smc->hw.fp.fifo.rx2_fifo_size = RX_FIFO_SPACE * SMT_R2_RXD_COUNT/(SMT_R1_RXD_COUNT+SMT_R2_RXD_COUNT) ; Add parentheses to definition to prevent operator precedence errors Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/skfp/h/fplustm.h b/drivers/net/skfp/h/fplustm.h i

[PATCH] NET: parentheses around definitions

There are multiplictions wherein these defines are abused in: drivers/net/netxen/netxen_nic_ethtool.c:705 drivers/net/s2io.c:350 -- Add parentheses to prevent operator precedence errors Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/netxen/netxen_nic_ethtoo

cqe, cqe_skb: return when both or when either NULL?

In function ehea_poll() drivers/net/ehea/ehea_main.c:667, in a loop cqe and cqe_skb - both struct ehea_cqe pointers - are assigned: -- cqe = ehea_poll_rq1(pr->qp, &wqe_index); cqe_skb = ehea_poll_cq(pr->send_cq); if (!cqe && !cqe_skb) return rx; -- Is it intended that only when both are NU

Re: [BUG] in inet6_create

Pavel Emelyanov wrote: > Roel Kluin wrote: >> Pavel Emelyanov wrote: >>> Roel Kluin wrote: >>>> Pavel Emelyanov wrote: >>>>> Roel Kluin wrote: >>>>>> Roel Kluin wrote: >>>>>>> I got this bug recently, I am not sure

Re: [BUG] in inet6_create

Pavel Emelyanov wrote: > Roel Kluin wrote: >> Pavel Emelyanov wrote: >>> Roel Kluin wrote: >>>> Roel Kluin wrote: >>>>> I got this bug recently, I am not sure whether this is related to any >>>>> previously >>>>> reported

[PATCH] Fix incorrect usage of strncat in bdx_get_drvinfo(); drivers/net/tehuti.c

Fix incorrect length for strncat by replacing it with strlcat Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index 4e1b84e..21230c9 100644 --- a/drivers/net/tehuti.c +++ b/drivers/net/tehuti.c @@ -2168,10 +2168,10 @@ bdx_get_d

[PATCH] prevent that myri_do_handshake lies about ticks in drivers/net/myri_sbus.c

With '<=' tick can be incremented up to 26, The last loop is redundant since even when 'softstate' becomes 'STATE_READY', 'if (tick > 25)' will still cause the function to return -1, Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git

Re: [PATCH] postfix decrement error in smc911x_reset(); drivers/net/smc911x.c

Darn, another. Sorry for the noise; I also removed a whitespace in this one -- If timeout causes the loop to end, a postfix decrement causes its value to become 4294967295 (unsigned int), not 0. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/smc911x.c b/drive

Re: [PATCH] postfix decrement error in smc911x_reset(); drivers/net/smc911x.c

And there was another one... -- If timeout causes the loop to end, a postfix decrement causes its value to become 4294967295 (unsigned int), not 0. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index dd18af0..fac1d2a 100644

[PATCH] postfix decrement error in smc911x_reset(); drivers/net/smc911x.c

If timeout causes the loop to end, a postfix decrement causes its value to become 4294967295 (unsigned int), not 0. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index dd18af0..41f3c8f 100644 --- a/drivers/net/smc911x.c +++ b/d

Re: [BUG] in inet6_create

Pavel Emelyanov wrote: > Roel Kluin wrote: >> Roel Kluin wrote: >>> I got this bug recently, I am not sure whether this is related to any >>> previously >>> reported ones. It was a recently pulled git kernel. Also I have been >>> hacking my >&g

Re: [BUG] in inet6_create

Roel Kluin wrote: > I got this bug recently, I am not sure whether this is related to any > previously > reported ones. It was a recently pulled git kernel. Also I have been hacking > my > kernel a bit lately, but I think that I haven't got any changes in the > cur

[BUG] in inet6_create

I got this bug recently, I am not sure whether this is related to any previously reported ones. It was a recently pulled git kernel. Also I have been hacking my kernel a bit lately, but I think that I haven't got any changes in the currently running kernel. FYI: my network card was not running (

Re: [2.6 patch] fix drivers/net/wan/lmc/ compilation

Adrian Bunk wrote: > Documentation/SubmitChecklist, point 1: > > <-- snip --> > > ... > CC drivers/net/wan/lmc/lmc_main.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wan/lmc/lmc_main.c: In > function ‘lmc_ioctl’: > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/wa

Re: [PATCH 1] net: fix and typo's

m sure this will get > picked > up anyway.) Ok, I've split the patch and sent the rest to wireless. Here's this single fix again you acked. -- Fix priority mistakes similar to '!x & y' Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff

[PATCH 5, last for now] net: unlock before return

before return fixes Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/cris/eth_v10.c b/drivers/net/cris/eth_v10.c index edd6828..5478549 100644 --- a/drivers/net/cris/eth_v10.c +++ b/drivers/net/cris/eth_v10.c @@ -1476,6 +1476,7 @@ e100_ioctl(struct net_devic

[PATCH 4] Unlock before BUG, but preserve normal operation

. for embedded systems - the BUG(); will not kill the process and there should not be a double unlock in that case. -- Unlock before BUG(), but preserve normal operation in the case that CONFIG_BUG is disabled. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/d

[PATCH 1] net: fix and typo's

he change of '!x & y,' to '!(x & y)' may change behavior. if not desired, I propose changing this to '!x && y', to make it explicitly clear. These '&' typo's can be spotted with: a="A-Za-z0-9_" git-grep "\![^$a()]*[$a]\+\

[PATCH 3] isdn: incorrect assignments in if

incorrect assignments in if Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c index 948a9b2..ed610ed 100644 --- a/drivers/isdn/hisax/elsa.c +++ b/drivers/isdn/hisax/elsa.c @@ -883,7 +883,7 @@ setup_elsa_isa(

[PATCH 2] isdn: fix 'and' typo's

se changing this to '!x && y', to make it explicitly clear. -- Fix priority mistakes similar to '!x & y' Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/isdn/act2000/module.c b/drivers/isdn/act2000/module.c index ee2b