[PATCH v2 12/13] ARM: pxa: remove the DMA IO resources

2018-05-24 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH v2 06/13] net: smc911x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc911x.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 05157442a980..4c3713bd5caa 100644 --- a/drivers/net/ethernet/smsc

[PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Ulf Hansson --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host

[PATCH v2 10/13] dmaengine: pxa: document pxad_param

2018-05-24 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH v2 11/13] dmaengine: pxa: make the filter function internal

2018-05-24 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers

[PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Signed-off-by: Daniel Mack Signed-off-by: Robert Jarzmik --- drivers/mtd/nand/raw/marvell_nand.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 10e953218948

[PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/media/platform/pxa_camera.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index

[PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- sound/soc/pxa/pxa2xx-i2s.c | 6 ++ 4 files changed, 12 insertions(+), 46 deletions(-) diff --git a/sound

[PATCH v2 01/13] dmaengine: pxa: use a dma slave map

2018-05-24 Thread Robert Jarzmik
tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann Acked-by: Vinod Koul --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --

[PATCH v2 00/13] ARM: pxa: switch to DMA slave maps

2018-05-24 Thread Robert Jarzmik
that the cpu device provides the DMA - I added pxa2xx-i2s which was forgotten Therefore I need a new ack - Arnd and Daniel / SSP topic / 0013 Review and ack of this one Happy review. -- Robert Robert Jarzmik (13): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map

[PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

2018-05-24 Thread Robert Jarzmik
x" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik --- Since v1: Removed channel names from platform_data --- arch/arm/plat-pxa/ssp.c| 47 -

[PATCH v2 07/13] net: smc91x: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 12 +--- drivers/net/ethernet/smsc/smc91x.h | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 080428762858..4c600f430f6d

Re: [PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-12 Thread Robert Jarzmik
Mark Brown writes: > On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote: >> As the pxa architecture switched towards the dmaengine slave map, the >> old compatibility mechanism to acquire the dma requestor line number and >> priority are not needed anymore. >

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Robert Jarzmik
Ulf Hansson writes: > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >> Hi, >> >> This serie is aimed at removing the dmaengine slave compat use, and transfer >> knowledge of the DMA requestors into architecture code. >> As this looks like a patch bomb, each m

Re: [PATCH 02/15] ARM: pxa: add dma slave map

2018-04-03 Thread Robert Jarzmik
Arnd Bergmann writes: >> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) }, > > This one is interesting, as you are dealing with an off-chip device, > and

[PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 02/15] ARM: pxa: add dma slave map

2018-04-02 Thread Robert Jarzmik
In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-02 Thread Robert Jarzmik
ware, including : - pxamci - pxa_camera - smc* - ASoC and SSP Happy review. Robert Jarzmik (15): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map mmc: pxamci: remove the dmaengine compat need media: pxa_camera: remove the dmaengine compat need mtd: nand: pxa3xx: remov

[PATCH 01/15] dmaengine: pxa: use a dma slave map

2018-04-02 Thread Robert Jarzmik
tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pxa_

[PATCH 03/15] mmc: pxamci: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc

[PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 06/15] net: smc911x: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- 3 files changed, 10 insertions(+), 42 deletions(-) diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c

[PATCH 07/15] net: smc91x: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 11/15] dmaengine: pxa: document pxad_param

2018-04-02 Thread Robert Jarzmik
Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -25,7 +25,6

[PATCH 12/15] dmaengine: pxa: make the filter function internal

2018-04-02 Thread Robert Jarzmik
As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

2018-04-02 Thread Robert Jarzmik
device tree platforms, the dma node should be hooked into the pxa-pcm-audio node. Signed-off-by: Robert Jarzmik --- arch/arm/plat-pxa/ssp.c| 50 +- include/linux/pxa2xx_ssp.h | 4 ++-- sound/soc/pxa/pxa-ssp.c| 5 ++--- 3 files changed, 9

[PATCH 14/15] ARM: pxa: change SSP devices allocation

2018-04-02 Thread Robert Jarzmik
In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik --- arch/arm

[PATCH 13/15] ARM: pxa: remove the DMA IO resources

2018-04-02 Thread Robert Jarzmik
As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-02 Thread Robert Jarzmik
-off-by: Robert Jarzmik --- drivers/staging/irda/drivers/pxaficp_ir.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/staging/irda/drivers/pxaficp_ir.c index 2ea00a6531f9..9dd6e21dc11e 100644 --- a/drivers

Re: [PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-05 Thread Robert Jarzmik
t; see the changes ping -f x.x.x.x This both with your patch and without, it works in both cases, and the former as a smaller throughput, which makes me believe the patch is fine. Tested-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Robert Jarzmik
Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. I have the hardware. Do you want anything specific to be tested, like set

[PATCH] net: smc91x: fix neponset breakage by pxa u16 writes

2016-10-19 Thread Robert Jarzmik
wrongly removed include. Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround") Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc91x.h b/drivers/net/ethernet/s

Re: [linux-next:master 1436/1582] drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of function 'machine_is_assabet'

2016-10-19 Thread Robert Jarzmik
David Miller writes: > Please send me a fixup follow-on patch. > > If changes are in my tree, they are part of the permanent record > and won't be rebased out. Ok, understood, I'm on it. Thanks. -- Robert

Re: [linux-next:master 1436/1582] drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of function 'machine_is_assabet'

2016-10-19 Thread Robert Jarzmik
Hi David, Here is a little mess I created with my former serie : >drivers/net/ethernet/smsc/smc91x.c: In function 'smc_drv_probe': >>> drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of >>> function 'machine_is_assabet' [-Werror=implicit-function-declaration] > if

[PATCH v3 3/4] net: smc91x: take into account half-word workaround

2016-10-17 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa

[PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

2016-10-17 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree

[PATCH v3 2/4] net: smc91x: isolate u16 writes alignment workaround

2016-10-17 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik -- Since v2: fixed arch/mn10300 case removed machine_is_*() calls --- arch/mn10300/unit-asb2303/include/unit/smc9.h | 2

[PATCH v3 1/4] ARM: pxa: enhance smc91x platform data

2016-10-17 Thread Robert Jarzmik
Instead of having the smc91x driver relying on machine_is_*() calls, provide this data through platform data, ie. idp, mainstone and stargate. This way, the driver doesn't need anymore machine_is_*() calls, which wouldn't work anymore with a device-tree build. Signed-off-by: Robe

[PATCH v3 0/4] support smc91x on mainstone and devicetree

2016-10-17 Thread Robert Jarzmik
to work on a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. As a sum up, this extends an existing mechanism to device-tree based pxa platforms. Cheers. -- Robert Robert Jarzmik (4): ARM: pxa: enhance smc91x platform data

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-16 Thread Robert Jarzmik
Robert Jarzmik writes: > diff --git a/drivers/net/ethernet/smsc/smc91x.h > b/drivers/net/ethernet/smsc/smc91x.h > index ea8465467469..dff165ed106d 100644 > --- a/drivers/net/ethernet/smsc/smc91x.h > +++ b/drivers/net/ethernet/smsc/smc91x.h And there is also the specific case

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-15 Thread Robert Jarzmik
Sorry David, I just noticed you weren't in the "To:" of this serie, but I won't forget you for the v3 I need to release anyway (https://lkml.org/lkml/2016/10/15/104). Robert Jarzmik writes: > + lp->half_word_align4 = > + machine_is_mainst

[PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms

2016-10-15 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree

[PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-15 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 78 +- 2 fi

[PATCH v2 2/3] net: smc91x: take into account half-word workaround

2016-10-15 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa

[PATCH v2 0/3] support smc91x on mainstone and devicetree

2016-10-15 Thread Robert Jarzmik
to work on a device-tree build, exaclty as it's been working for years with the legacy arch/arm/mach-pxa/mainstone.c definition. Cheers. -- Robert Robert Jarzmik (3): net: smc91x: isolate u16 writes alignment workaround net: smc91x: take into account half-word workaround net: smsc91x: a

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-13 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Sun, 9 Oct 2016 22:33:45 +0200 > >> Writes to u16 has a special handling on 3 PXA platforms, where the >> hardware wiring forces these writes to be u32 aligned. >> >> This patch isolates this handling

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-09 Thread Robert Jarzmik
Andy Shevchenko writes: >> +#define SMC_outw(lp, v, a, r) \ >> + _SMC_outw_align4((v), (a), (r), \ >> +IS_BUILTIN(CONFIG_ARCH_PXA) && ((r) & 2) &&\ >> +lp->half_word_

[PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-09 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 80 ++ 2 fi

[PATCH v2 2/3] net: smc91x: take into account half-word workaround

2016-10-09 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- Since v1: rename dt property to pxa

[PATCH v2 3/3] net: smsc91x: add u16 workaround for pxa platforms

2016-10-09 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik Cc: Jeremy Linton --- Since v1: rename dt property to pxa-u16-align4 change the binding documentation file --- Documentation/devicetree

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-05 Thread Robert Jarzmik
Robert Jarzmik writes: > Mark Rutland writes: > >> On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: >>> Mark Rutland writes: >>> >>> reg-u16-align4 tells that a specific hardware doesn't support 16 bit writes >>> not >>

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: >> Mark Rutland writes: >> >> reg-u16-align4 tells that a specific hardware doesn't support 16 bit writes >> not >> being 32 bits aligned, or said differently that a &q

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Jeremy Linton writes: > Hi Robert, > > On 10/03/2016 04:05 AM, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- &g

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- >>

[PATCH 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-03 Thread Robert Jarzmik
pes. This patch was tested on 2 PXA platforms : mainstone, which relies on the workaround, and lubbock, which doesn't. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 6 ++- drivers/net/ethernet/smsc/smc91x.h | 80 ++ 2 fi

[PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net

[PATCH 2/3] net: smc91x: take into account half-word workaround

2016-10-03 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c

[PATCH] net: smc91x: take into account register shift

2016-09-25 Thread Robert Jarzmik
This aligns smc91x with its cousin, namely smc911x.c. This also allows the driver to run also in a device-tree based lubbock board build, on which it was tested. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH v2] net: smc91x: fix SMC accesses

2016-08-27 Thread Robert Jarzmik
on on all ARM > machines") > Signed-off-by: Russell King > --- > Robert, this is the full patch - can I add your tested-by to this for > the subset patch please? Yes, I just retested it, so : Tested-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-27 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> >> dri

Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes

2016-08-25 Thread Robert Jarzmik
Arnd Bergmann writes: > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> drivers/net/ethernet/smsc/smc91x.h | 50 >> +++--- >> 1 file changed, 30 insertions(+), 20 deletions(-) >> >> While this patch fixes one bug on Neponset, it probably doe

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

2016-08-09 Thread Robert Jarzmik
sis of the core in non-OF/ACPI case is the reason I didn't post a patch for dm9000 ... I was overconfident in finding a reason in irq core code within a couple of days. Therefore: Acked-by: Robert Jarzmik And I can make a test for you on my cm-x300 board, even if your patch is very alike the dr

Re: [PATCH] net: smc91x: ACPI Enable lan91x adapters

2016-06-26 Thread Robert Jarzmik
Jeremy Linton writes: > Enable lan91x adapters in some ARM machines and models > when booted with an ACPI kernel. > > Signed-off-by: Jeremy Linton Hi Jeremy, I launched your change in my Jenkins yesterday (on Linus's mainline, not linux-next), and I got: CC drivers/net/ethernet/smsc/smc9

[PATCH v2] net: smc911x: convert pxa dma to dmaengine

2016-03-19 Thread Robert Jarzmik
Convert the dma transfers to be dmaengine based, now pxa has a dmaengine slave driver. This makes this driver a bit more PXA agnostic. The driver was only compile tested. The risk is quite small as no current PXA platform I'm aware of is using smc911x driver. Signed-off-by: Robert Ja

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-03-15 Thread Robert Jarzmik
Robert Jarzmik writes: > Fabio Estevam writes: >> Tested-by: Fabio Estevam > > Thanks Fabio for the test. > > I also tried with a different different approach. > > I built the different platforms (imx v6, etc ...) : > - one version (a) on a vanilla v4.5-rc2 >

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-03-03 Thread Robert Jarzmik
Fabio Estevam writes: > On Sat, Feb 20, 2016 at 12:48 PM, Robert Jarzmik > wrote: > >> Hello, >> >> I'll reping once more, to see if any of you could give this patch a try. >> So far Hitoshi doesn't have the hardware anymore, so it leaves only Guennad

[PATCH v3] net: ethernet: davicom: fix devicetree irq resource

2016-02-20 Thread Robert Jarzmik
t_irq(), which handles the deferral. Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse IRQ flags from resources"), the interrupt trigger flags are honored in platform_get_irq(), so remove the needless code in dm9000. Signed-off-by: Robert Jarzmik Acked-by: Marc

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-20 Thread Robert Jarzmik
Hitoshi Mitake writes: > Hi Robert, > > On Sat, Feb 6, 2016 at 6:05 PM, Robert Jarzmik wrote: > > Please just keep pinging people to properly test this. > > Okay, let's have another try. > > Hi Guennadi, Hitoshi, Fabio, > >

Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

2016-02-07 Thread Robert Jarzmik
Sergei Shtylyov writes: >> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse > >Fixes: tag here? Heuh no. It doesn't fix this commit, it uses a feature brought by this commit. >> +if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE) >> dev_warn(db->de

Re: [PATCH v2] net: ethernet: davicom: fix devicetree irq resource

2016-02-07 Thread Robert Jarzmik
Francois Romieu writes: > Robert Jarzmik : > [...] >> diff --git a/drivers/net/ethernet/davicom/dm9000.c >> b/drivers/net/ethernet/davicom/dm9000.c >> index cf94b72dbacd..2bae5c8c1f85 100644 >> --- a/drivers/net/ethernet/davicom/dm9000.c >> +++ b/d

[PATCH v2] net: ethernet: davicom: fix devicetree irq resource

2016-02-06 Thread Robert Jarzmik
t_irq(), which handles the deferral. Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse IRQ flags from resources"), the interrupt trigger flags are honored in platform_get_irq(), so remove the needless code in dm9000. Signed-off-by: Robert Jarzmik Acked-by: Marc

[PATCH v2] net: smc91x: propagate irq return code

2016-02-06 Thread Robert Jarzmik
The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. Fix this by propagating the platform_get_irq() error code as the probe return value. Signed-off-by: Robert Jarzmik Cc: S

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-06 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Fri, 05 Feb 2016 22:44:56 +0100 > >> Apart from Alberto who answered he cannot test it by lack of hardware, the >> others didn't answer. >> >> So how can I move forward ? Would you want me to amend the

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-05 Thread Robert Jarzmik
Robert Jarzmik writes: > David Miller writes: > >> From: Robert Jarzmik >> Date: Mon, 30 Nov 2015 22:40:28 +0100 >> >>> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >>> slave driver. This makes this driver a bit more

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > >Your patch summary prefixes are too verbose, it was enough to say only > "dm9000: ". Well, I don't agree here. The subsystem should be fully specified, at least this is something I require in pxa, something that is also required in sound/*, etc ... If David

[PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-03 Thread Robert Jarzmik
t_irq(), which handles the deferral. Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse IRQ flags from resources"), the interrupt trigger flags are honored in platform_get_irq(), so remove the needless code in dm9000. Signed-off-by: Robert Jarzmik Acked-by:

Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Robert Jarzmik
Sergei Shtylyov writes: > On 02/01/2016 11:41 PM, Robert Jarzmik wrote: > >>>> The smc91x driver doesn't honor the probe deferral mechanism when the >>>> interrupt source is not yet available, such as one provided by a gpio >>>> controller not pro

Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > > On 2/1/2016 1:46 AM, Robert Jarzmik wrote: > >> The smc91x driver doesn't honor the probe deferral mechanism when the >> interrupt source is not yet available, such as one provided by a gpio >> controller not probed. &g

[PATCH] net: smc91x: propagate irq return code

2016-01-31 Thread Robert Jarzmik
The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. Fix this by propagating the platform_get_irq() error code as the probe return value. Signed-off-by: Robert Jarzmik --- driver

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2015-12-03 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Mon, 30 Nov 2015 22:40:28 +0100 > >> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >> slave driver. This makes this driver a bit more PXA agnostic. >> >> The driver was only compil

[PATCH] net: smc911x: convert pxa dma to dmaengine

2015-11-30 Thread Robert Jarzmik
Convert the dma transfers to be dmaengine based, now pxa has a dmaengine slave driver. This makes this driver a bit more PXA agnostic. The driver was only compile tested. The risk is quite small as no current PXA platform I'm aware of is using smc911x driver. Signed-off-by: Robert Ja

[PATCH v3 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-26 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: removed mach/dma.h include, which is the goal --- drivers/net/irda

[PATCH v3 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-26 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik Tested-by: Petr Cvek --- Since v1: modified __REG macro to cope

[PATCH v3 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-26 Thread Robert Jarzmik
previously the minimum turnaround time was counted in 76ns steps, while with this patch it is counted in microsecond steps. The strictly equal formula would have been : while ((sched_clock() - si->last_clk) * 76 < mtt) Signed-off-by: Robert Jarzmik --- Since v2: fixed clock calculat

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-22 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Fri, 18 Sep 2015 18:36:56 +0200 > >> Which brings me to wonder which is the more correct : >> (a) replace to reproduce the same calculation >> Previously mtt was compared to a difference of 76ns steps (as 3

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-18 Thread Robert Jarzmik
David Miller writes: >> My understanding is that the flow will be : >> sched_clock() >>rd->read_sched_clock() (cyc_to_ns() transformed for return) >> pxa_read_sched_clock() >>readl_relaxed(OSCR) >> >> I didn't see any timings issue, as the flow looks equivalent to the >> readl

Re: [PATCH] net: smc91x: convert pxa dma to dmaengine

2015-09-16 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Thu, 10 Sep 2015 21:26:04 +0200 > >> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >> slave driver. This makes this driver a bit more PXA agnostic. >> >> The driver was tested

Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-16 Thread Robert Jarzmik
David Miller writes: > From: Robert Jarzmik > Date: Sat, 12 Sep 2015 13:45:22 +0200 > >> Instead of using directly the OS timer through direct register access, >> use the standard sched_clock(), which will end up in OSCR reading >> anyway. >> >> This is

[PATCH v2 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Convert the pxa IRDA driver to readl and writel primitives, and remove another set of direct registers access. This leaves only the DMA registers access, which will be dealt with dmaengine conversion. Signed-off-by: Robert Jarzmik --- Since v1: modified __REG macro to cope with STIER, ST

[PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-12 Thread Robert Jarzmik
Instead of using directly the OS timer through direct register access, use the standard sched_clock(), which will end up in OSCR reading anyway. This is a first step for direct access register removal and machine specific code removal from this driver. Signed-off-by: Robert Jarzmik --- drivers

[PATCH v2 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-12 Thread Robert Jarzmik
Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from raw DMA registers access to pxa_dma dmaengine driver, convert this driver to dmaengine. Signed-off-by: Robert Jarzmik --- Since v1: removed mach/dma.h include, which is the goal --- drivers/net/irda/pxaficp_ir.c | 149

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-12 Thread Robert Jarzmik
Petr Cvek writes: And it is true I have not tested the rootfs special case, where drivers are not yet initialized (and more specifically gpio and interrupt chip). Your backtrace should tell me if you fall into this category of issues ... but I digress, this h

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-10 Thread Robert Jarzmik
Petr Cvek writes: >> Should have been posted to linux arm kernel mailing list, unless my mailer >> failed ... >> > Searching for: > > "ARM: pxa: add resources to pxaficp_ir" > > did not found anything, same was for "ficp" in the > linux-arm-kernel/netdev/linux-kernel > mailing list archiv

[PATCH] net: smc91x: convert pxa dma to dmaengine

2015-09-10 Thread Robert Jarzmik
Convert the dma transfers to be dmaengine based, now pxa has a dmaengine slave driver. This makes this driver a bit more PXA agnostic. The driver was tested on pxa27x (mainstone) and pxa310 (zylonite), ie. only pxa platforms. Signed-off-by: Robert Jarzmik Cc: Russell King Cc: Arnd Bergmann

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-10 Thread Robert Jarzmik
Petr Cvek writes: > Dne 9.9.2015 v 08:25 Robert Jarzmik napsal(a): >> Petr Cvek writes: >> >>> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a): >>>> >>>> Did you defined resources somewhere? Actual resources are in >>>> "pxa_ir_resource

Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-08 Thread Robert Jarzmik
can be used for normal UART). That's because you have to remove from magician.c: pxa_set_stuart_info(NULL); Cheers. -- Robert [1] >From ea242c5b1c4dcdf2a99ea604ee542ded5e6384b9 Mon Sep 17 00:00:00 2001 From: Robert Jarzmik Date: Sat, 29 Aug 2015 00:37:51 +0200 Subject: [PATCH] ARM: pxa: add res

  1   2   >