[PATCH v2] igb: dont drop packets if rx flow control is enabled

2019-10-22 Thread Robert Beckett
drop enable bit if rx flow control is not enabled. Since v1: always enable dropping of packets if VFs in use. Signed-off-by: Robert Beckett --- drivers/net/ethernet/intel/igb/igb.h | 1 + drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 drivers/net/ethernet/intel/igb/igb_main.c

[PATCH] igb: dont drop packets if rx flow control is enabled

2019-10-21 Thread Robert Beckett
enabled. Signed-off-by: Robert Beckett --- drivers/net/ethernet/intel/igb/igb.h | 1 + drivers/net/ethernet/intel/igb/igb_ethtool.c | 8 drivers/net/ethernet/intel/igb/igb_main.c| 46 ++-- 3 files changed, 41 insertions(+), 14 deletions(-) diff --git a/drivers

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Robert Beckett
On Thu, 2019-10-17 at 08:44 -0700, Jakub Kicinski wrote: > On Thu, 17 Oct 2019 12:24:03 +0100, Robert Beckett wrote: > > On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > > > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > > > > From: Robert Beck

Re: [net-next 2/7] igb: add rx drop enable attribute

2019-10-17 Thread Robert Beckett
On Wed, 2019-10-16 at 16:55 -0700, Jakub Kicinski wrote: > On Wed, 16 Oct 2019 16:47:06 -0700, Jeff Kirsher wrote: > > From: Robert Beckett > > > > To allow userland to enable or disable dropping packets when > > descriptor > > ring is exhausted, add RX_DROP_EN p

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-13 Thread Robert Beckett
On Thu, 2019-09-12 at 10:41 -0700, Florian Fainelli wrote: > On 9/12/19 9:46 AM, Robert Beckett wrote: > > On Thu, 2019-09-12 at 09:25 -0700, Florian Fainelli wrote: > > > On 9/12/19 2:03 AM, Ido Schimmel wrote: > > > > On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robe

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Robert Beckett
On Thu, 2019-09-12 at 09:25 -0700, Florian Fainelli wrote: > On 9/12/19 2:03 AM, Ido Schimmel wrote: > > On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robert Beckett wrote: > > > On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > > > > On Tue, Sep 10, 2019 at 09:4

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-12 Thread Robert Beckett
On Thu, 2019-09-12 at 00:52 +0200, Andrew Lunn wrote: > > It is not just for broadcast storm protection. The original issue > > that > > made me look in to all of this turned out to be rx descritor ring > > buffer exhaustion due to the CPU not being able to keep up with > > packet > > reception. >

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli wrote: > > +Ido, Jiri, > > > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > > This patch-set adds support for some features of the Marvell > > &

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Wed, 2019-09-11 at 10:16 +0100, Robert Beckett wrote: > On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > > This enables us to negoatia

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 13:19 -0400, Vivien Didelot wrote: > Hi Robert, > > On Tue, 10 Sep 2019 16:41:46 +0100, Robert Beckett < > bob.beck...@collabora.com> wrote: > > This patch-set adds support for some features of the Marvell switch > > chips that can b

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 09:49 -0700, Florian Fainelli wrote: > +Ido, Jiri, > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > This patch-set adds support for some features of the Marvell switch > > chips that can be used to handle packet storms. > > > > The ra

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-11 Thread Robert Beckett
On Tue, 2019-09-10 at 11:29 -0700, Florian Fainelli wrote: > On 9/10/19 11:26 AM, Andrew Lunn wrote: > > On Tue, Sep 10, 2019 at 04:41:47PM +0100, Robert Beckett wrote: > > > This enables us to negoatiate pause frame transmission to > > > prioritise > >

[PATCH 6/7] net: dsa: mv88e6xxx: add egress rate limiting

2019-09-10 Thread Robert Beckett
Add code for specifying egress rate limiting per port. The rate can be specified as ethernet frames or bits per second. Signed-off-by: Robert Beckett --- drivers/net/dsa/mv88e6xxx/chip.c | 72 ++--- drivers/net/dsa/mv88e6xxx/chip.h | 3 +- drivers/net/dsa/mv88e6xxx/port.c

[PATCH 7/7] dt-bindings: mv88e6xxx: add egress rate limiting

2019-09-10 Thread Robert Beckett
Document port egress rate limiting settings. Add defines for specifying egress rate limiting mode. Signed-off-by: Robert Beckett --- .../devicetree/bindings/net/dsa/marvell.txt | 22 +++ include/dt-bindings/net/dsa-mv88e6xxx.h | 5 + 2 files changed, 27 insertions

[PATCH 4/7] net: dsa: mv88e6xxx: add ability to set queue scheduling

2019-09-10 Thread Robert Beckett
Add code to set Schedule for any port that specifies "schedule" in their device tree node. This allows port prioritization in conjunction with port default queue priorities or packet priorities. Signed-off-by: Robert Beckett --- drivers/net/dsa/mv88e6xxx/c

[PATCH 5/7] dt-bindings: mv88e6xxx: add ability to set queue scheduling

2019-09-10 Thread Robert Beckett
Document port queue scheduling settings. Add definitions for specific valid values. Signed-off-by: Robert Beckett --- .../devicetree/bindings/net/dsa/marvell.txt | 12 include/dt-bindings/net/dsa-mv88e6xxx.h | 17 + 2 files changed, 29 insertions

[PATCH 3/7] dt-bindings: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Robert Beckett
Document a new setting for Marvell switch chips to set the default queue priorities per port. Signed-off-by: Robert Beckett --- Documentation/devicetree/bindings/net/dsa/marvell.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b

[PATCH 2/7] net: dsa: mv88e6xxx: add ability to set default queue priorities per port

2019-09-10 Thread Robert Beckett
Add code to set DefQPri for any port that specifies "defqpri" in their device tree node. This allows setting the default output queue priority for all packets entering the switch via the port that uses this, which is useful for prioritizing traffic based on port. Signed-off-by: Robe

[PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-10 Thread Robert Beckett
Configure autoneg for phy connected CPU ports. This allows us to use autoneg between the CPU port's phy and the link partner's phy. This enables us to negoatiate pause frame transmission to prioritise packet delivery over throughput. Signed-off-by: Robert Beckett --- net/dsa/p

[PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-10 Thread Robert Beckett
[patch 5/7] dt-bindings for patch 4. [patch 6/7] allows ports to rate limit their egress. This can be used to stop the host CPU from becoming swamped by packet delivery and exhasting descriptors. [patch 7/7] dt-bindings for patch 6. Robert Beckett (7): net/dsa: configure autoneg for CPU

[PATCH v2] igb: add rx drop enable attribute

2019-09-09 Thread Robert Beckett
when the host CPU cannot keep up with packet delivery, but data delivery is more important than throughput via multiple queues. Userland can set this flag to 0 via ethtool to disable packet dropping. Signed-off-by: Robert Beckett --- Notes: Changes since v1: re-written to use ethtool priv flags

[PATCH] igb: add rx drop enable attribute

2019-08-28 Thread Robert Beckett
useful when the host CPU cannot keep up with packet delivery, but data delivery is more important than throughput via multiple queues. Userland can write 0 to rx_drop_en to disable packet dropping via udev. Signed-off-by: Robert Beckett --- drivers/net/ethernet/intel/igb/igb.h | 1 + drivers