Routing Policy Database Rule 0

2015-10-19 Thread Richard Laing
ode in net/core/fib_rules.c does not seem to protect against deletion of this rule and I was wondering if there is a reason for this. If not I will submit a patch to address it. Simply running "ip rule del" shows the issue . Regards, Richard Laing -- *Richard Laing* Software Team Leader*

[PATCH 1/1] net/ipv6: Correct PIM6 mrt_lock handling

2015-09-02 Thread Richard Laing
correctly. Signed-off-by: Richard Laing --- net/ipv6/ip6mr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 74ceb73..5f36266 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -550,7 +550,7 @@ static void ipmr_mfc_seq_stop(struct

Re: [PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-04 Thread Richard Laing
Hi Oleg, I hadn't seen that patch, thanks, it looks like a pretty thorough solution. Best Regards, Richard On 08/04/2015 07:37 PM, Oleg A Arkhangelsky wrote: > > 04.08.2015, 04:29, "Richard Laing" : >> Enable flow-based ECMP. > Looks like your approach is on

Re: [PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-04 Thread Richard Laing
015 13:28:47 +1200 > Richard Laing wrote: > >> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h >> index 5fa643b..7db9f72 100644 >> --- a/include/net/ip_fib.h >> +++ b/include/net/ip_fib.h >> @@ -117,6 +117,8 @@ struct fib_info { >>

[PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-08-03 Thread Richard Laing
more details on the problems associated with packet based ECMP routing. This patch relies on the skb hash value to select between routes. The selection uses a hash-threshold algorithm (see RFC2992). Signed-off-by: Richard Laing --- include/net/flow.h |8 include/net/ip_fib.h

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-29 Thread Richard Laing
On 07/30/2015 04:12 AM, Tom Herbert wrote: > On Tue, Jul 28, 2015 at 11:11 PM, Michal Kubecek wrote: >> On Tue, Jul 28, 2015 at 09:20:02PM +, Richard Laing wrote: >>>>> diff --git a/include/net/flow.h b/include/net/flow.h >>>>> index 8109a15..d1d933

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 09:15 AM, Tom Herbert wrote: > On Tue, Jul 28, 2015 at 2:02 PM, Tom Herbert wrote: >> On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing >> wrote: >>> From: Richard Laing >>> >>> Enable flow-based ECMP. >>> >>> Currently i

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 09:02 AM, Tom Herbert wrote: > On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing > wrote: >> From: Richard Laing >> >> Enable flow-based ECMP. >> >> Currently if equal-cost multipath is enabled the kernel chooses between >> equal cost p

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 07:51 AM, Stephen Hemminger wrote: > On Tue, 28 Jul 2015 02:27:57 + > Richard Laing wrote: > >> From: Richard Laing >> >> Enable flow-based ECMP. >> >> Currently if equal-cost multipath is enabled the kernel chooses between >&

[RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-27 Thread Richard Laing
From: Richard Laing Enable flow-based ECMP. Currently if equal-cost multipath is enabled the kernel chooses between equal cost paths for each matching packet, essentially packets are round-robined between the routes. This means that packets from a single flow can traverse different routes. If