> From: Patrick McHardy [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, February 20, 2008 3:22 PM
> To: David Miller
> Cc: Ramkrishna Vepa; Sreenivasa Honnur; netdev@vger.kernel.org;
> [EMAIL PROTECTED]; support
> Subject: Re: [PATCH 2.6.25 2/4]S2io: Multiqueue network devic
> Sreenivasa Honnur wrote:
> > - Resubmit #2
> > - Transmit fifo selection based on TCP/UDP ports.
> > - Added tx_steering_type loadable parameter for transmit fifo
selection.
> > 0x0 NO_STEERING: Default FIFO is selected.
> > 0x1 TX_PRIORITY_STEERING: FIFO is selected based on skb->priority.
>
Please apply. Looks good.
Ram
> -Original Message-
> From: Adrian Bunk [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, February 13, 2008 1:31 PM
> To: Surjit Reang; Sreenivasa Honnur; Ramkrishna Vepa; Rastapur
Santosh;
> Sivakumar Subramani
> Cc: netdev@vger.kernel.org
ted by
> > 4 bytes if the packet contains vlan header.
> > - resubmit for 2.6.24 kernel
> >
> > Signed-off-by: Surjit Reang <[EMAIL PROTECTED]>
> > Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
>
> it's difficult to sort through these patche
The patches failed because they were applied on the 2.6.25 branch, while
they were meant for the 2.6.24 branch (upstream-linus).
Ram
> -Original Message-
> From: Ramkrishna Vepa
> Sent: Friday, February 01, 2008 11:01 AM
> To: 'Jeff Garzik'; Sreenivasa Honnur
>
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of David Miller
> Sent: Wednesday, January 23, 2008 11:30 PM
>
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Thu, 24 Jan 2008 08:25:49 +0100
>
> > > have done away with handling tx completion in the interrupt
handler,
> and
> > > ar
> > [Ram] I am assuming that this is with regards to msi-x interrupts.
We
>
> Yes.
>
> And avoiding bouncing locks for device state between CPUs.
>
> > have done away with handling tx completion in the interrupt handler,
and
> > are instead handling them in the context of the transmit. The slow
> Sreenivasa Honnur <[EMAIL PROTECTED]> writes:
>
> > Multiqueue netwrok device support implementation.
> > - Added a loadable parameter "multiq" to enable/disable multiqueue
> support,
> > by default it is disabled.
> > - skb->queue_mapping is not used for queue/fifo selection. FIFO
> iselectio
Al,
Thanks for finding this. We have a few patches lined up and will submit
this patch.
Ram
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of Al Viro
> Sent: Sunday, December 23, 2007 10:15 PM
> To: [EMAIL PROTECTED]
> Cc: netdev@vger.kernel.org; [EMA
: Ramkrishna Vepa
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH 3/7]: [NET]: Do not check netif_running() and
carrier
> state in ->poll()
>
> From: "Ramkrishna Vepa" <[EMAIL PROTECTED]>
> Date: Tue, 8 Jan 2008 18:01:32 -0500
>
> > Dave,
> > Sorr
d Miller [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, January 08, 2008 2:48 PM
> To: Ramkrishna Vepa
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH 3/7]: [NET]: Do not check netif_running() and
carrier
> state in ->poll()
>
> From: "Ramkrishna Vepa" <[EMA
Dave,
This change is not required as the macro, is_s2io_card_up() checks for
an internal state of the adapter and not netif's state. We want to make
sure that the adapter registers are not accessed when the adapter is
being brought down.
> @@ -2704,9 +2704,6 @@ static int s2io_poll(struct napi_st
verse.
- Enable transmit interrupts for all configured transmit fifos.
- Fixed typo errors.
Signed-off-by: Surjit Reang <[EMAIL PROTECTED]>
Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp 2-0-26-15-1/drivers/net/s2i
transmit descriptor (TXD).
- Added boundary checks for number of FIFOs enabled and FIFO length.
Signed-off-by: Surjit Reang <[EMAIL PROTECTED]>
Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp 2-0-26-10/dr
Thanks. Patch looks good. Please accept.
Ram
> -Original Message-
> From: Adrian Bunk [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, December 11, 2007 2:23 PM
> To: [EMAIL PROTECTED]; Rastapur Santosh; Sivakumar Subramani;
> Sreenivasa Honnur; [EMAIL PROTECTED]
> Cc: netdev@vger.kernel.org; [
:
>
> commit 926930b202d56c3dfb6aea0a0c6bfba2b87a8c03
> Author: Sivakumar Subramani <[EMAIL PROTECTED]>
> Date: Sat Feb 24 01:59:39 2007 -0500
>
> so this problem hasn't been around forever.
>
> Recent patches from Ramkrishna Vepa <[EMAIL PROTECTED]>
lan tagged
packets
>
> Ramkrishna Vepa wrote:
> > - Fix to aggregate vlan packets. IP offset is incremented by
> > 4 bytes if the packet contains vlan header.
> >
> > Signed-off-by: Santoshkumar Rastapur <[EMAIL PROTECTED]>
> > Signed-off-by: Ramkrishna Ve
strip the vlan tag
> > vlan_tag_strip - 1: Always strip the vlan tag
> > vlan_tag_strip - 2 (default): strip the vlan tag if the
> > vlan group is not NULL.
> >
> > Signed-off-by: Santoshkumar Rastapur <[EMAIL PROTECTED]>
> > Signed-off-by: Ra
Jeff,
We got an ACK back last week from Dave Miller that the following 2
patches were already applied - reply follows.
" > [Ram] The version numbers are different for the 2 patches. Was the
> MSI-X leak bug fix applied prior to resubmission (we had swapped the
> version numbers on the patches f
an_tag_strip - 2 (default): strip the vlan tag if the
vlan group is not NULL.
Signed-off-by: Santoshkumar Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.26.6/drivers/net/s2io.c 2.0.26.8P1/drivers/net/s2io.c
--- 2.0.26.6/drivers
- Fix to aggregate vlan packets. IP offset is incremented by
4 bytes if the packet contains vlan header.
Signed-off-by: Santoshkumar Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.26.8P1/drivers/net/s2io.c 2.0.26.8P2/driver
Got it. Thanks,
Ram
> -Original Message-
> From: David Miller [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, November 14, 2007 2:56 PM
> To: Ramkrishna Vepa
> Cc: Sreenivasa Honnur; netdev@vger.kernel.org; [EMAIL PROTECTED];
support
> Subject: Re: [PATCH 2.6.24 1/1]S2i
> > Scheduling for the 2.6.25 merge window is fine. Curious - why did
you
> > have to remove the driver version? We use it to keep track of our
> > changes submitted.
>
> Because it conflicted with the driver version bump you did
> for the MSI-X leak bug fix.
[Ram] The version numbers are differe
Scheduling for the 2.6.25 merge window is fine. Curious - why did you
have to remove the driver version? We use it to keep track of our
changes submitted.
Thanks,
Ram
> -Original Message-
> From: David Miller [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, November 14, 2007 1:43 AM
> To: Sre
is a very small incremental change.
Thanks,
Ram
> -Original Message-
> From: Ramkrishna Vepa [mailto:[EMAIL PROTECTED]
> Sent: Monday, November 05, 2007 6:40 PM
> To: Dave Johnson; David Miller; [EMAIL PROTECTED];
> [EMAIL PROTECTED]; [EMAIL PROTECTED];
[EMAIL PROTE
The Xframe (S2io) adapter can be programmed dynamically to either,
always strip the vlan tag or not. In this case, if the vlan group is
NULL, it can be programmed at run time to NOT strip the vlan tag.
When a packet with a Vlan id is received that is not added to the group,
should it be dropped or
Stephen,
> Fix warnings from sparse checker about shadowed definition and
improperly
> formatted ethtool_strings.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
>
> ---
> CHECK drivers/net/s2io.c
> - * lro: Specifies whether to enable Large Receive Offload (LRO) or
not.
> + * lro_e
Jeff,
> > - Added check to return from the traffic handling function, if the
card
> status
> > is DOWN.
> >
> > Signed-off-by: Sivakumar Subramani
<[EMAIL PROTECTED]>
> > Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
> > Signed-off-by: R
- Removed bimodal interrupt support - unused feature
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -urpN patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c
--- patch1/drivers/net/s2io.c 2007-08-10 11:53:46.000
- Changed kmalloc+memset to k[zc]alloc as per Mariusz's patch
<[EMAIL PROTECTED]>
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -urpN org/drivers/net/s2io.c patch1/drivers/net/s2io.c
--- org/drivers/net
- Added check to return from the traffic handling function, if the card status
is DOWN.
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp patch3/drivers
- Optimized interrupt routine fast path.
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp patch4/drivers/net/s2io.c patch5/drivers/net/s2io.c
--- patch4/
igned-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c
--- patch1/drivers/net/s2io.c 2007-08-15 08:55:53.0 -0700
+++ patch2/drivers/net/s2io.c 2007-08-15 08:57:44.0 -0700
@@ -263,7 +263,14 @@ static char ethtool
- Removed the unused variable, intr_type, in device private structure.
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp patch2/drivers/net/s2io.c patch3/
- Added support to unmask entire set of device errors and alarms.
Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]>
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -Nurp orig/drivers/net/s2io.c patch1/drivers/n
007 10:16 AM
> To: Ramkrishna Vepa
> Cc: Jeff Garzik; Rick Jones; Sivakumar Subramani;
netdev@vger.kernel.org;
> support
> Subject: Re: [PATCH 2.6.24]S2io: Default to IntA interrupt type when
there
> are less than 4 CPUs in the system.
>
> "Ramkrishna Vepa" <[EMA
We had found during performance measurement/analysis that with 2 cpus
and napi disabled, and the system transmitting (tcp), the cpus get too
busy due to receive interrupt handling, reducing performance by around
10%.
But then again, when the number of cpus increase, the interrupt scaling
is much
Brandon,
Before slot_reset event is called io_error_detected could be called
(where pci_disable_device() is called), right?
The pci_reenable_device() will call enable only if the device was
enabled before and would not be enabled if the device were disabled. Is
this the intended behavior?
Ram
We have a few patches queued and can send this patch in along with ours.
Ram
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of Jeff Garzik
> Sent: Tuesday, August 07, 2007 2:58 PM
> To: Mariusz Kozlowski
> Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
And
- Added support to poll for entire set of device errors and alarms.
- Optimized interrupt routine fast path.
- Removed the unused variable, intr_type, in device private structure.
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
--
y: Sivakumar Subramani
<[EMAIL PROTECTED]>
> > Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
>
> This patch series looks a bit big to apply this far past the merge
> window. It changes behavior in the middle of a -rc stream, which is
> something to avoid sin
- Mask single and double bit ETQ ecc errors to inhibit spurious interrupts.
(Resending; Removed HTML sections in the patch)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.24.1/drivers/net/s2io-regs.h 2.0.24.1P1/drivers/net/s2io-regs.h
--- 2.0.24.1/drivers/net/s2io-regs.h
- Fix to increment the received packet count correctly.
(Resending; Removed HTML sections in the patch)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.24.1P2/drivers/net/s2io.c 2.0.24.1P3/drivers/net/s2io.c
--- 2.0.24.1P2/drivers/net/s2io.c 2007-07-20 16:26:13.0
- Removed the call to pci_set_power_state to reset the adapter as it was
resulting
in system crash on some platforms.
(Resending; Removed HTML sections in the patch)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.24.1P1/drivers/net/s2io.c 2.0.24.1P2/drivers/net/s2io.c
-
- Mask single and double bit ETQ ecc errors to inhibit spurious interrupts.
(Resending; Removed HTML sections in patch)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp 2.0.24.1/drivers/net/s2io-regs.h 2.0.24.1P1/drivers/net/s2io-regs.h
--- 2.0.24.1/drivers/net/s2io-regs.h20
Peter,
Where is your git tree located?
Ram
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of Waskiewicz Jr, Peter P
> Sent: Thursday, June 07, 2007 3:56 PM
> To: David Miller; [EMAIL PROTECTED]
> Cc: Kok, Auke-jan H; [EMAIL PROTECTED]; [EMAIL PROTECT
Patch looks good. Yes, please add a comment as to reason for cast.
Ram
> -Original Message-
> From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED]
> On Behalf Of Michael Buesch
> Sent: Saturday, May 26, 2007 10:04 AM
> To: Andreas Schwab
> Cc: netdev@vger.kernel.org
> Subject: Re: [PATCH] Av
- Changed the maintainers for the S2io driver.
(Resending; forgot to send to netdev)
Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]>
---
diff -pNur linux-2.6.org/drivers/net/s2io.c linux-2.6/drivers/net/s2io.c
--- linux-2.6.org/drivers/net/s2io.c2007-03-29 18:49:39.0
> > Ideally s2io_reset should
> > return a failure in this case (return is void now)
>
> Would you care to provide a patch that did this? I could
> experiment a bit, and try to do this myself; but I really
> don't know this hardware, or this driver, that well.
[Ram] Yes, I can submit a patch to ad
- Remove unused variables from s2io_nic structure
- Changed the memory failure printk messages to print only in debug mode
- Updated the copyright messages
(Resending; due to patch being corrupted)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp patch/drivers/net/s2io.c patc
- Save/Restore unused buffer mappings in 2/3 buffer mode to avoid
frequent mapping
- Save/Restore adapter reset count during adapter reset
(Resending; forgot to cc netdev)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp patch1/drivers/net/s2io.c patch2/drivers/net/s2io.c
---
- Remove unused variables from s2io_nic structure
- Changed the memory failure printk messages to print only in debug mode
- Updated the copyright messages
(Resending; forgot to cc netdev)
Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]>
---
diff -Nurp patch/drivers/net/s2io.c patch1/drive
Jeff,
Please apply and forward this patch upstream.
Ram
> -Original Message-
> From: Ramkrishna Vepa
> Sent: Monday, March 05, 2007 2:34 PM
> To: 'Linas Vepstas'
> Cc: Wen Xiong; linux-kernel@vger.kernel.org; linux-
> [EMAIL PROTECTED]; netdev@vger.ker
before failing to reset the slot?
Ram
> -Original Message-
> From: Linas Vepstas [mailto:[EMAIL PROTECTED]
> Sent: Thursday, February 15, 2007 3:09 PM
> To: Ramkrishna Vepa; Raghavendra Koushik; Ananda Raju
> Cc: Wen Xiong; linux-kernel@vger.kernel.org; linux-
> [EMAI
> -Original Message-
> From: Roland Dreier [mailto:[EMAIL PROTECTED]
> Sent: Monday, November 06, 2006 12:55 PM
> To: Christoph Hellwig
> Cc: Ramkrishna Vepa; Benjamin Herrenschmidt; Jeff Garzik; Linus
Torvalds;
> netdev@vger.kernel.org; [EMAIL PROTECTED]
> Subj
The 64 bit io operation on the IA64 platform is a 64 bit transaction on
the pci bus and is optimal to leave it as such. I prefer Jeff's
suggestion -
guaranteeing that a "good enough for drivers" readq() and writeq() exist
on all platforms even 32-bit platforms where the operation isn't
inherentl
56 matches
Mail list logo
