Hello Sergei,
Thanks for your patch.
> Subject: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings
>
> Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD
> bindings.
>
> Signed-off-by: Sergei Shtylyov
Reviewed-by: Ramesh Shanmugasundaram
Thanks,
Ramesh
> >>> On 08/18/2017 02:39 PM, Franklin S Cooper Jr wrote:
> During test transmitting using CAN-FD at high bitrates (4 Mbps)
> only resulted in errors. Scoping the signals I noticed that
> only a single bit was being transmitted and with a bit more
> investiga
r generic versions.
>
> - reg: physical base address and size of the R-Car CAN FD register map.
> -- interrupts: interrupt specifier for the Global & Channel interrupts
> +- interrupts: interrupt specifiers for the Channel & Global interrupts
Thanks for correcting it.
Acked-by: Ramesh Shanmugasundaram
Thanks,
Ramesh
Hi Andreas,
> Subject: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller
> driver
>
> This CAN Controller is found on MEN Chameleon FPGAs.
>
> The driver/device supports the CAN2.0 specification.
> There are 255 RX and 255 Tx buffer within the IP. The pointer for the
> buffer are h
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
Acked-by: Rob Herring
Reviewed-by: Ulrich Hecht
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 +
drivers
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
* Removed testmodes & debugfs code (suggested by Oliver H)
* Fixed tx path race issue by introducing lock (suggested by Marc K)
* Removed __maybe_unused attribute of rcar_canfd_of_table
Ramesh Shanmugasundaram (2):
can: rcar_canfd: Add Renesas R-Car CAN FD driver
can: rcar
Hi Ulrich,
> Thanks for the patch, this is a lot easier to handle.
>
[...]
> > +#define RCANFD_RFPTR_RFTS(x) (((x) >> 0) & 0xff)
>
> That should be "(((x) >> 0) & 0x)".
>
> > +
[...]
> > +/* RSCFDnCFDRMXXXq -> RCANFD_F_RMXXX(q) */
> > +#define RCANFD_F_RMID(q) (0x20
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
Acked-by: Rob Herring
Reviewed-by: Ulrich Hecht
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 +
drivers
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
)
* Fixed tx path race issue by introducing lock (suggested by Marc K)
* Removed __maybe_unused attribute of rcar_canfd_of_table
Ramesh Shanmugasundaram (2):
can: rcar_canfd: Add Renesas R-Car CAN FD driver
can: rcar_can: Move Renesas CAN driver to rcar dir
.../device
driver/net/can/rcar dir (as
suggested by Oliver H)
* Updated commit message
Changes since v1:
* Removed testmodes & debugfs code (suggested by Oliver H)
* Fixed tx path race issue by introducing lock (suggested by Marc K)
* Removed __maybe_unused attribute
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
Acked-by: Rob Herring
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 +
drivers/net/can/Kconfig
> > On 06/03/2016 07:03 PM, Ulrich Hecht wrote:
> >
> >> Thanks; I missed that every register is described twice.
> >>
> >> Nevertheless, names often vary more or less subtly between your patch
> >> and the specs, making it very hard to review. Some have letters
> >> added, some have letters remove
Hi Uli,
Thanks for the review
> Thank you for your patch.
>
> On Thu, Jun 2, 2016 at 11:45 AM, Ramesh Shanmugasundaram
> wrote:
> [...]
> > diff --git a/drivers/net/can/rcar/rcar_canfd.c
> > b/drivers/net/can/rcar/rcar_canfd.c
> > new file mode 100644
> &
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
Acked-by: Rob Herring
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
drivers/net/can/Kconfig
_maybe_unused attribute of rcar_canfd_of_table
Ramesh Shanmugasundaram (2):
can: rcar_canfd: Add Renesas R-Car CAN FD driver
can: rcar_can: Move Renesas CAN driver to rcar dir
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
drivers/net/can/Kconfig| 11 +-
Hi Rob,
> On Thu, Apr 28, 2016 at 01:23:07PM +0100, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD only mode by default.
> >
> > CAN FD mode supports both Classical
Hi Oliver,
Thanks :-)
Actually it will be v5 patch set & I have sent it now. Marc comments were on
old v2 patch.
Thanks,
Ramesh
> -Original Message-
> From: Oliver Hartkopp [mailto:socket...@hartkopp.net]
> Sent: 28 April 2016 07:28
> To: Ramesh Shanmugasundaram ;
>
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
drivers/net/can/Kconfig|1 +
drivers/
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
* Fixed tx path race issue by introducing lock (suggested by Marc K)
* Removed __maybe_unused attribute of rcar_canfd_of_table
Ramesh Shanmugasundaram (2):
can: rcar_canfd: Add Renesas R-Car CAN FD driver
can: rcar_can: Move Renesas CAN driver to rcar dir
.../devicetree/bindi
HI Marc,
Gentle reminder!
Are you happy with the open comment's disposition? I can send a next version of
patch if we have a closure on current set of comments.
Thanks,
Ramesh
> -Original Message-
> From: Ramesh Shanmugasundaram
> Sent: 01 April 2016 13:49
> To: Ramesh
Hi Marc,
Thanks for your time & review comments.
> -Original Message-
(...)
> > +#define RCANFD_NAPI_WEIGHT 8 /* Rx poll quota */
> > +
> > +#define RCANFD_NUM_CHANNELS2
> > +#define RCANFD_CHANNELS_MASK 0x3 /* Two channels max */
>
> (BIT(
This patch clubs the Renesas controller drivers in one rcar dir.
Signed-off-by: Ramesh Shanmugasundaram
---
drivers/net/can/Kconfig | 10 --
drivers/net/can/Makefile | 1 -
drivers/net/can/rcar/Kconfig | 10 ++
drivers/net/can/rcar/Makefile
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
Acked-by: Rob Herring
---
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
drivers/net/can/Kconfig
gested by Marc K)
* Removed __maybe_unused attribute of rcar_canfd_of_table
Ramesh Shanmugasundaram (2):
can: rcar_canfd: Add Renesas R-Car CAN FD driver
can: rcar_can: Move Renesas CAN driver to rcar dir
.../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
drivers
Hi Marc,
> Subject: Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver
>
> On 03/15/2016 10:48 AM, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
---
Hi All,
Thanks for the review comments.
This updated patch is based on linux-can-next tag
(linux-can-next-for-4.6-20160310)
Hi Oliver, Marc,
> On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote:
>
> >> In fact you provided a CAN driver which is "CAN-FD-only".
> >
> > Yes. That's the status of current submission.
(...)
> >
> > I did try this option earlier bu
Hi Oliver,
Thanks for the comments.
> On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote:
>
> >
> > As you mentioned further down, when a user does this
> >
> > "ip link set can0 up type can bitrate 100"
> >
> > the intention is to
Hi Oliver,
Thanks for the comments.
> On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote:
>
> >>>>> + /* Ensure channel starts in FD mode */
> >>>>> + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) {
> >>>>> +
Hi Rob,
Thanks for the review comments.
> On Thu, Mar 03, 2016 at 03:38:35PM +0000, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD mode by default.
> >
> > CAN FD m
Hi Marc,
> On 03/07/2016 09:02 AM, Ramesh Shanmugasundaram wrote:
> > Hi Oliver,
> >
> > Thanks for the review comments.
> >
> >> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
> >>
> >>> Changes since v1:
> >>> * Rem
Hi Oliver,
Thanks for the review comments.
> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
>
> > Changes since v1:
> > * Removed testmodes & debugfs code (suggested by Oliver H)
> > * Fixed tx path race issue by introducing lock (suggested
e maximum number of message RAM area the controller can use is 3584
bytes. It is specified 10752 bytes in the manual.
Signed-off-by: Ramesh Shanmugasundaram
---
Changes since v1:
* Removed testmodes & debugfs code (suggested by Oliver H)
* Fixed tx path race issue by introducin
Hi Marc,
Sorry for the late response.
> On 03/02/2016 11:08 AM, Ramesh Shanmugasundaram wrote:
> >>>> I see no locking for the tx-path.
> >>>
> >>> I am not sure why locking is needed in tx-path?
> >>
> >> If the tx-path is shared b
Hi Marc,
> On 03/02/2016 09:41 AM, Ramesh Shanmugasundaram wrote:
> >> Is the channel loopback mode configurable per channel? If so, please
> >> remove the module parameter and make use of CAN_CTRLMODE_LOOPBACK to
> >> configure it.
> >
> > The l
Hi Oliver,
Thanks for the review.
> On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD mode by default. Two
> > test modes are available and
Hi Marc,
Thanks for the review.
> On 03/01/2016 10:34 AM, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD mode by default. Two
> > test modes are available and
FD controller.
This is not documented.
4. The minimum value of NTSEG1 in RSCFDnCFDCmNCFG register is 2 Tq. It
is mentioned 4 Tq in the manual.
5. The maximum number of message RAM area the controller can use is 3584
bytes. It is mentioned 10752 bytes in the manual.
Signed-off-by: Ramesh Sh
Hi Marc,
> On 02/29/2016 11:00 AM, Marc Kleine-Budde wrote:
> > I think it's better to fix the algorithm. I'll look into it.
>
> What about:
>
> > ./can-calc-bit-timing -c 3998 rcar_can
> > Bit timing parameters for rcar_can with 39.98 MHz ref clock
> > nominal
Added r8a7795 SoC support.
Signed-off-by: Ramesh Shanmugasundaram
---
Hi All,
This patch is based on linux-can-next (tag:linux-can-next-for-4.6-20160226)
Pinctrl & Clock related to the controller are already submitted as below:
https://lkml.org/lkml/2016/2/25/546
https://lkml
Hi Geert,
> On Mon, Feb 29, 2016 at 10:21 AM, Ramesh Shanmugasundaram
> wrote:
> > --- a/drivers/net/can/rcar_can.c
> > +++ b/drivers/net/can/rcar_can.c
> > @@ -808,6 +808,10 @@ static int rcar_can_probe(struct platform_device
> *pdev)
> > pr
Hi Marc,
> On 02/29/2016 10:21 AM, Ramesh Shanmugasundaram wrote:
> > Added r8a7795 SoC support.
> >
> > For smoother bit timing calculation, the rounded clock frequency is
> used.
>
> Why this? From my point of view this introduces a clock error.
Thanks for the c
Adds CAN controller nodes for r8a7795.
Note: CAN channel register base address mentioned in R-Car Gen3 Hardware
User Manual v0.5E is incorrect. The corrected base addresses are:
CAN Channel 0 - 0xe6c3
CAN Channel 1 - 0xe6c38000
Signed-off-by: Ramesh Shanmugasundaram
---
arch/arm64/boot
Added r8a7795 SoC support.
For smoother bit timing calculation, the rounded clock frequency is used.
Signed-off-by: Ramesh Shanmugasundaram
---
Documentation/devicetree/bindings/net/can/rcar_can.txt | 12
drivers/net/can/Kconfig| 2 +-
drivers/net
7238.html
The compatibility string used follows the same format as in this patch:
http://www.spinics.net/lists/netdev/msg365756.html
Ramesh Shanmugasundaram (2):
can: rcar_can: Add r8a7795 support
arm64: dts: r8a7795: Add CAN support
.../devicetree/bindings/net/can/rcar_can.txt
50 matches
Mail list logo
