RE: [PATCH 1/5] net: qlcnic: don't set unused function argument

>-Original Message- >From: Arnd Bergmann [mailto:a...@arndb.de] >Sent: Thursday, June 16, 2016 5:08 PM >To: Dept-GE Linux NIC Dev >Cc: Arnd Bergmann ; David Miller >; Rajesh Borundia ; >netdev ; linux-kernel ker...@vger.kernel.org> >Subject: [PATCH 1/5] ne

RE: [PATCH net v2 0/2] qlcnic fixes

>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Friday, March 11, 2016 2:47 AM >To: Rajesh Borundia >Cc: netdev ; Dept-GE Linux NIC Dev gelinuxnic...@qlogic.com> >Subject: Re: [PATCH net v2 0/2] qlcnic fixes > >From: Rajesh Borundia

[PATCH net v2 0/2] qlcnic fixes

counter to record this condition. v2: o Added patch that removes usage of atomic_t as we are not implemeting atomicity by using atomic_t value. Please apply these fixes to net. Thanks, Rajesh Rajesh Borundia (2): qlcnic: Remove unnecessary usage of atomic_t qlcnic: Fix mailbox completion

[PATCH net v2 1/2] qlcnic: Remove unnecessary usage of atomic_t

o atomic_t usage is incorrect as we are not implementing any atomicity. Signed-off-by: Rajesh Borundia --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 2 +- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH net v2 2/2] qlcnic: Fix mailbox completion handling during spurious interrupt

and ignore the spurious interrupt. Also added a stats counter to record this condition. Signed-off-by: Rajesh Borundia --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 1 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 15 +++ drivers/net/ethernet/qlogic/qlcnic

[PATCH net] qlcnic: Fix mailbox completion handling during spurious interrupt

and ignore the spurious interrupt. Also added a stats counter to record this condition. Signed-off-by: Rajesh Borundia --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h|1 + .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c| 12 .../net/ethernet/qlogic/qlcnic

RE: [PATCH] net: qlcnic: clean up sysfs error codes

>- return QLC_STATUS_UNSUPPORTED_CMD; >+ return -EOPNOTSUPP; > > if (offset >= adapter->ahw->max_vnic_func) >- return QL_STATUS_INVALID_PARAM; >+ return -EINVAL; > > ret = qlcnic_clear_esw_stats(adapter, QLCNIC_STATS_PORT, offset, >QLCNIC_QUERY_RX_COUNTER); >@@ -953,9 +951,7 @@ static ssize_t >qlcnic_83xx_sysfs_flash_read_handler(struct file *filp, > struct qlcnic_adapter *adapter = dev_get_drvdata(dev); > > if (!size) >- return QL_STATUS_INVALID_PARAM; >- if (!buf) >- return QL_STATUS_INVALID_PARAM; >+ return -EINVAL; > > count = size / sizeof(u32); > >@@ -1132,9 +1128,6 @@ static ssize_t >qlcnic_83xx_sysfs_flash_write_handler(struct file *filp, > struct device *dev = container_of(kobj, struct device, kobj); > struct qlcnic_adapter *adapter = dev_get_drvdata(dev); > >- if (!buf) >- return QL_STATUS_INVALID_PARAM; >- > ret = kstrtoul(buf, 16, &data); > > switch (data) { >-- >2.1.4 Acked-by: Rajesh Borundia Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] net: qlcnic: clean up sysfs error codes

>-Original Message- >From: dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com >[mailto:dept_hsg_linux_nic_dev-boun...@qlclistserver.qlogic.com] On >Behalf Of Vladimir Zapolskiy >Sent: Tuesday, May 26, 2015 6:20 AM >To: David Miller; Shahed Shaikh; Dept-GE Linux NIC Dev >Cc: netdev >Sub