[PATCH net] cxgb4: avoid collecting SGE_QBASE regs during traffic

2021-03-27 Thread Rahul Lakkireddy
ned-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cudbg_lib.c| 23 +++ drivers/net/ethernet/chelsio/cxgb4/t4_hw.c| 3 ++- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/che

[PATCH net-next v2] cxgb4: collect serial config version from register

2021-02-08 Thread Rahul Lakkireddy
Collect serial config version information directly from an internal register, instead of explicitly resizing VPD. v2: - Add comments on info stored in PCIE_STATIC_SPARE2 register. Signed-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cudbg_entity.h | 3 --- .../net/ethernet

[PATCH net-next] cxgb4: collect serial config version from register

2021-02-08 Thread Rahul Lakkireddy
Collect serial config version information directly from an internal register, instead of explicitly resizing VPD. Signed-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cudbg_entity.h | 3 --- .../net/ethernet/chelsio/cxgb4/cudbg_lib.c| 24 +++ drivers/net

Re: [PATCH resend net-next v2 2/3] PCI/VPD: Change Chelsio T4 quirk to provide access to full virtual address space

2021-02-08 Thread Rahul Lakkireddy
On Friday, February 02/05/21, 2021 at 23:31:24 +0100, Heiner Kallweit wrote: > On 05.02.2021 22:46, Bjorn Helgaas wrote: > > [+cc Casey, Rahul] > > > > On Fri, Feb 05, 2021 at 08:29:45PM +0100, Heiner Kallweit wrote: > >> cxgb4 uses the full VPD address space for accessing its EEPROM (with some >

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-04 Thread Rahul Lakkireddy
On Monday, August 08/03/20, 2020 at 14:13:04 -0700, Jakub Kicinski wrote: > On Sun, 2 Aug 2020 22:42:28 +0530 Rahul Lakkireddy wrote: > > The config file contains very low-level firmware and device specific > > params and most of them are dependent on the type of Chelsio NIC. >

[PATCH net-next] cxgb4: add TC-MATCHALL IPv6 support

2020-08-03 Thread Rahul Lakkireddy
Matching IPv6 traffic require allocating their own individual slots in TCAM. So, fetch additional slots to insert IPv6 rules. Also, fetch the cumulative stats of all the slots occupied by the Matchall rule. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 2

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-08-02 Thread Rahul Lakkireddy
On Saturday, August 08/01/20, 2020 at 21:22:02 -0700, Jakub Kicinski wrote: > On Sat, 1 Aug 2020 02:47:38 +0530 Rahul Lakkireddy wrote: > > I thought /lib/firmware is where firmware related files need to be > > placed and ethtool --flash needs to be used to program them to >

Re: [PATCH net-next] cxgb4: Add support to flash firmware config image

2020-07-31 Thread Rahul Lakkireddy
On Friday, July 07/31/20, 2020 at 11:00:08 -0700, Jakub Kicinski wrote: > On Fri, 31 Jul 2020 16:39:04 +0530 Ganji Aravind wrote: > > On Thursday, July 07/30/20, 2020 at 16:23:35 -0700, Jakub Kicinski wrote: > > > On Thu, 30 Jul 2020 20:41:38 +0530 Ganji Aravind wrote: > > > > Update set_flash to

[PATCH net-next] cxgb4: fix extracting IP addresses in TC-FLOWER rules

2020-07-31 Thread Rahul Lakkireddy
me code. Fixes: c8729cac2a11 ("cxgb4: add ethtool n-tuple filter insertion") Signed-off-by: Rahul Lakkireddy --- .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.c| 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.

[PATCH net-next] cxgb4: fix check for running offline ethtool selftest

2020-07-31 Thread Rahul Lakkireddy
The flag indicating the selftest to run is a bitmask. So, fix the check. Also, the selftests will fail if adapter initialization has not been completed yet. So, add appropriate check and bail sooner. Fixes: 7235ffae3d2c ("cxgb4: add loopback ethtool self-test") Signed-off-by: Rahul

[PATCH net] cxgb4: fix all-mask IP address comparison

2020-07-08 Thread Rahul Lakkireddy
Convert all-mask IP address to Big Endian, instead, for comparison. Fixes: f286dd8eaad5 ("cxgb4: use correct type for all-mask IP address comparison") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +- 1 file changed, 5 insert

[PATCH net-next v3 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-30 Thread Rahul Lakkireddy
disable mirror VI support. v3: - Replace mirror VI refcount_t with normal u32 variable. v2: - Add mutex to protect all mirror VI data, instead of just mirror Rxqs. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 11 ++ .../net/ethernet/chelsio/cxgb4

[PATCH net-next v3 3/3] cxgb4: add main VI to mirror VI config replication

2020-06-30 Thread Rahul Lakkireddy
cxgb4_port_mirror_start() in cxgb_open(), which was there in v1, but got missed in v2 during refactoring. v2: - Simplify the replication code by refactoring t4_set_rxmode() to handle mirror VI, instead of duplicating the t4_set_rxmode() calls in multiple places. Signed-off-by: Rahul Lakkireddy

[PATCH net-next v3 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-30 Thread Rahul Lakkireddy
mutex in patch 2. - Simplify the replication code by refactoring t4_set_rxmode() to handle mirror VI, instead of duplicating the t4_set_rxmode() calls in multiple places in patch 3. Rahul Lakkireddy (3): cxgb4: add mirror action to TC-MATCHALL offload cxgb4: add support for mirror Rxqs cxgb4

[PATCH net-next v3 2/3] cxgb4: add support for mirror Rxqs

2020-06-30 Thread Rahul Lakkireddy
mutex to protect all mirror VI data, instead of just mirror Rxqs. - Remove the un-needed mirror Rxq mutex. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 9 + .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 66 - .../net/ethernet/chelsio/cxgb4

[PATCH net-next v2 3/3] cxgb4: add main VI to mirror VI config replication

2020-06-29 Thread Rahul Lakkireddy
, instead of duplicating the t4_set_rxmode() calls in multiple places. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 4 +- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 100 -- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c| 27 - 3

[PATCH net-next v2 2/3] cxgb4: add support for mirror Rxqs

2020-06-29 Thread Rahul Lakkireddy
. - Remove the un-needed mirror Rxq mutex. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 9 + .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 66 - .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 235 -- 3 files changed, 288 insertions

[PATCH net-next v2 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-29 Thread Rahul Lakkireddy
disable mirror VI support. v2: - Add mutex to protect all mirror VI data, instead of just mirror Rxqs. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 11 ++ .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 103 +- .../ethernet/chelsio/cxgb4

[PATCH net-next v2 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-29 Thread Rahul Lakkireddy
, instead of just mirror Rxqs, in patch 1 and 2. - Remove the un-needed mirror Rxq mutex in patch 2. - Simplify the replication code by refactoring t4_set_rxmode() to handle mirror VI, instead of duplicating the t4_set_rxmode() calls in multiple places in patch 3. Rahul Lakkireddy (3): cxgb4: add

Re: [PATCH net-next 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-27 Thread Rahul Lakkireddy
On Friday, June 06/26/20, 2020 at 21:18:44 -0700, Jakub Kicinski wrote: > On Thu, 25 Jun 2020 17:28:41 +0530 Rahul Lakkireddy wrote: > > + if (refcount_read(&pi->vi_mirror_refcnt) > 1) { > > + refcount_dec(&pi->vi_mirror_refcnt); > > +

Re: [PATCH net-next 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-26 Thread Rahul Lakkireddy
On Friday, June 06/26/20, 2020 at 21:17:50 -0700, Jakub Kicinski wrote: > On Sat, 27 Jun 2020 02:20:12 +0530 Rahul Lakkireddy wrote: > > On Friday, June 06/26/20, 2020 at 09:55:49 -0700, Jakub Kicinski wrote: > > > On Fri, 26 Jun 2020 15:36:15 +0530 Rahul Lakkireddy wrote: &

Re: [PATCH net-next 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-26 Thread Rahul Lakkireddy
On Friday, June 06/26/20, 2020 at 09:55:49 -0700, Jakub Kicinski wrote: > On Fri, 26 Jun 2020 15:36:15 +0530 Rahul Lakkireddy wrote: > > On Thursday, June 06/25/20, 2020 at 15:55:10 -0700, Jakub Kicinski wrote: > > > On Thu, 25 Jun 2020 17:28:40 +0530 Rahul Lakkireddy wrote: &

Re: [PATCH net-next 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-26 Thread Rahul Lakkireddy
On Thursday, June 06/25/20, 2020 at 15:55:10 -0700, Jakub Kicinski wrote: > On Thu, 25 Jun 2020 17:28:40 +0530 Rahul Lakkireddy wrote: > > This series of patches add support to mirror all ingress traffic > > for TC-MATCHALL ingress offload. > > > > Patch 1 adds supp

[PATCH net-next 3/3] cxgb4: add main VI to mirror VI config replication

2020-06-25 Thread Rahul Lakkireddy
When mirror VI is enabled, replicate various VI config params enabled on main VI to mirror VI. These include replicating MTU, promiscuous mode, all-multicast mode, and enabled netdev Rx feature offloads. Signed-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 155

[PATCH net-next 2/3] cxgb4: add support for mirror Rxqs

2020-06-25 Thread Rahul Lakkireddy
When mirror VI is enabled, allocate the mirror Rxqs and setup the mirror VI RSS table. The mirror Rxqs are allocated/freed when the mirror VI is created/destroyed or when underlying port is brought up/down, respectively. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4

[PATCH net-next 1/3] cxgb4: add mirror action to TC-MATCHALL offload

2020-06-25 Thread Rahul Lakkireddy
disable mirror VI support. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 10 ++ .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 94 ++- .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 16 +++- .../ethernet/chelsio/cxgb4/cxgb4_tc_flower.h | 3

[PATCH net-next 0/3] cxgb4: add mirror action support for TC-MATCHALL

2020-06-25 Thread Rahul Lakkireddy
mirror Rxqs and setup RSS for the mirror VI. Patch 3 adds support to replicate all the main VI configuration to mirror VI. This includes replicating MTU, promiscuous mode, all-multicast mode, and enabled netdev Rx feature offloads. Thanks, Rahul Rahul Lakkireddy (3): cxgb4: add mirror action to

[PATCH net 01/12] cxgb4: move handling L2T ARP failures to caller

2020-06-23 Thread Rahul Lakkireddy
Move code handling L2T ARP failures to the only caller. Fixes following sparse warning: skbuff.h:2091:29: warning: context imbalance in 'handle_failed_resolution' - unexpected unlock Fixes: 749cb5fe48bb ("cxgb4: Replace arpq_head/arpq_tail with SKB double link-list code")

[PATCH net 00/12] cxgb4/cxgb4vf: fix warnings reported by sparse

2020-06-23 Thread Rahul Lakkireddy
cxgb4 driver. Patch 12 fixes several kernel-doc comment warnings in cxgb4vf driver. Thanks, Rahul Rahul Lakkireddy (12): cxgb4: move handling L2T ARP failures to caller cxgb4: move PTP lock and unlock to caller in Tx path cxgb4: use unaligned conversion for fetching timestamp cxgb4: parse

[PATCH net 03/12] cxgb4: use unaligned conversion for fetching timestamp

2020-06-23 Thread Rahul Lakkireddy
Use get_unaligned_be64() to fetch the timestamp needed for ns_to_ktime() conversion. Fixes following sparse warning: sge.c:3282:43: warning: cast to restricted __be64 Fixes: a456950445a0 ("cxgb4: time stamping interface for PTP") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethern

[PATCH net 02/12] cxgb4: move PTP lock and unlock to caller in Tx path

2020-06-23 Thread Rahul Lakkireddy
terface for PTP") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index 1359158652b7.

[PATCH net 11/12] cxgb4: update kernel-doc line comments

2020-06-23 Thread Rahul Lakkireddy
IN and smt index") Fixes: 3f8cfd0d95e6 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()") Fixes: d429005fdf2c ("cxgb4/cxgb4vf: Add support for SGE doorbell queue timer") Fixes: 0e395b3cb1fb ("cxgb4: add FLOWC based QoS offload") Signed-off-by: Rahul

[PATCH net 07/12] cxgb4: fix SGE queue dump destination buffer context

2020-06-23 Thread Rahul Lakkireddy
:got restricted __be64 [usertype] Fixes: 736c3b94474e ("cxgb4: collect egress and ingress SGE queue contexts") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[PATCH net 05/12] cxgb4: fix endian conversions for L4 ports in filters

2020-06-23 Thread Rahul Lakkireddy
__be16 [usertype] dst Fixes: dca4faeb812f ("cxgb4: Add LE hash collision bug fix path in LLD driver") Fixes: 62488e4b53ae ("cxgb4: add basic tc flower offload support") Fixes: 557ccbf9dfa8 ("cxgb4: add tc flower support for L3/L4 rewrite") Signed-off-by: Rahul Lak

[PATCH net 09/12] cxgb4: move DCB version extern to header file

2020-06-23 Thread Rahul Lakkireddy
Move the DCB version string array extern to header file. Fixes following sparse warning: cxgb4_dcb.c:13:12: warning: symbol 'dcb_ver_array' was not declared. Should it be static? Fixes: ebddd97afb89 ("cxgb4: add support to display DCB info") Signed-off-by: Rahul Lakkired

[PATCH net 08/12] cxgb4: remove cast when saving IPv4 partial checksum

2020-06-23 Thread Rahul Lakkireddy
:expected restricted __sum16 [usertype] check sge.c:1539:44:got unsigned short [usertype] Fixes: d0a1299c6bf7 ("cxgb4: add support for vxlan segmentation offload") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 3 +-- 1 file changed, 1 inser

[PATCH net 12/12] cxgb4vf: update kernel-doc line comments

2020-06-23 Thread Rahul Lakkireddy
imer_setup()") Fixes: 3f8cfd0d95e6 ("cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 7 --- drivers/net/ethernet/c

[PATCH net-next 0/2] cxgb4: fix more warnings reported by sparse

2020-06-23 Thread Rahul Lakkireddy
Patch 1 ensures all callers take on-chip memory lock when flashing PHY firmware to fix lock context imbalance warnings. Patch 2 moves all static arrays in header file to respective C file in device dump collection path. Thanks, Rahul Rahul Lakkireddy (2): cxgb4: always sync access when

[PATCH net-next 1/2] cxgb4: always sync access when flashing PHY firmware

2020-06-23 Thread Rahul Lakkireddy
b6961410b7 ("cxgb4: Add PHY firmware support for T420-BT cards") Fixes: 4ee339e1e92a ("cxgb4: add support to flash PHY image") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 5 +++--

[PATCH net-next 2/2] cxgb4: move device dump arrays in header to C file

2020-06-23 Thread Rahul Lakkireddy
t-variable=] 513 | static const u32 t6_hma_ireg_array[][IREG_NUM_ELEM] = { Fixes: a7975a2f9a79 ("cxgb4: collect register dump") Fixes: 17b332f48074 ("cxgb4: add support to read serial flash") Signed-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cudbg_entity.h |

[PATCH net 06/12] cxgb4: use correct type for all-mask IP address comparison

2020-06-23 Thread Rahul Lakkireddy
ia tc-flower offload") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filt

[PATCH net 10/12] cxgb4: fix set but unused variable when DCB is disabled

2020-06-23 Thread Rahul Lakkireddy
, n10g = 0, qidx = 0, n1g = 0; ^ Fixes: 116ca924aea6 ("cxgb4: fix checks for max queues to allocate") Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH net 04/12] cxgb4: parse TC-U32 key values and masks natively

2020-06-23 Thread Rahul Lakkireddy
) cxgb4_tc_u32.c:57:21:expected unsigned int [usertype] val cxgb4_tc_u32.c:57:21:got restricted __be32 [usertype] val cxgb4_tc_u32_parse.h:48:24: warning: cast to restricted __be32 Fixes: 2e8aad7bf203 ("cxgb4: add parser to translate u32 filters to internal spec") Signed-off-by: Rahul

[PATCH net-next 3/3] cxgb4: add EOTID tracking and software context dump

2020-05-15 Thread Rahul Lakkireddy
Rework and add support for dumping EOTID software context used by TC-MQPRIO. Also track number of EOTIDs in use. Signed-off-by: Rahul Lakkireddy --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 144 ++ .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + .../ethernet

[PATCH net-next 2/3] cxgb4: tune burst buffer size for TC-MQPRIO offload

2020-05-15 Thread Rahul Lakkireddy
ic class configuration API similar to the firmware API counterpart. Signed-off-by: Rahul Lakkireddy --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 30 ++- .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- .../ethernet/chelsio/cxgb4/cxgb4_tc_mqprio.c | 7 + drivers/net/

[PATCH net-next 1/3] cxgb4: improve credits recovery in TC-MQPRIO Tx path

2020-05-15 Thread Rahul Lakkireddy
Request credit update for every half credits consumed, including the current request. Also, avoid re-trying to post packets when there are no credits left. The credit update reply via interrupt will eventually restore the credits and will invoke the Tx path again. Signed-off-by: Rahul Lakkireddy

[PATCH net-next 0/3] cxgb4: improve and tune TC-MQPRIO offload

2020-05-15 Thread Rahul Lakkireddy
re queue contexts used by TC-MQPRIO offload. Thanks, Rahul Rahul Lakkireddy (3): cxgb4: improve credits recovery in TC-MQPRIO Tx path cxgb4: tune burst buffer size for TC-MQPRIO offload cxgb4: add EOTID tracking and software context dump drivers/net/ethernet/chelsio/cxgb4/cxgb4.h

[PATCH net] cxgb4: fix EOTID leak when disabling TC-MQPRIO offload

2020-04-29 Thread Rahul Lakkireddy
sent outside the wire, to make room for FLOWC request. Also, move the FLOWC descriptor consumption logic closer to when the FLOWC request is actually posted to hardware. Fixes: 0e395b3cb1fb ("cxgb4: add FLOWC based QoS offload") Signed-off-by: Rahul Lakkireddy --- drivers/net/etherne

[PATCH net-next v2] cxgb4: collect hardware queue descriptors

2018-09-03 Thread Rahul Lakkireddy
Collect descriptors of all ULD and LLD hardware queues managed by LLD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Move inline functions to header file. - Add missing undefine for QDESC_GET_* macros. drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 42

[PATCH net-next] cxgb4: collect hardware queue descriptors

2018-08-31 Thread Rahul Lakkireddy
Collect descriptors of all ULD and LLD hardware queues managed by LLD. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 42 +++ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 3 +- drivers/net/ethernet/chelsio/cxgb4

Re: [endianness bug] cxgb4: mk_act_open_req() buggers ->{local,peer}_ip on big-endian hosts

2018-08-06 Thread Rahul Lakkireddy
.fip[3] << 24; > + memcpy(&req->local_ip, f->fs.val.lip, 4); > + memcpy(&req->peer_ip, f->fs.val.fip, 4); > req->opt0 = cpu_to_be64(NAGLE_V(f->fs.newvlan == VLAN_REMOVE || > f->fs.newvlan == VLAN_REWRITE) | > DELACK_V(f->fs.hitcnts) | Thanks for fix Al! Acked-by: Rahul Lakkireddy

Re: [endianness bug?] cxgb4_next_header .match_val/.match_mask should be net-endian

2018-08-06 Thread Rahul Lakkireddy
On Sunday, August 08/05/18, 2018 at 20:58:11 +0530, Al Viro wrote: > AFAICS, cxgb4_next_header() expects to find match_val/match_mask in > struct cxgb4_next_header stored as big-endian: > > /* Found a possible candidate. Find a key that > *

[PATCH net-next] cxgb4: print ULD queue information managed by LLD

2018-07-27 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 296 +++-- 1 file changed, 277 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio

[PATCH net-next 2/2] cxgb4: move Tx/Rx free pages collection to common code

2018-07-24 Thread Rahul Lakkireddy
This information needs to be collected in vmcore device dump as well. So, move to common code. Fixes: fa145d5dfd61 ("cxgb4: display number of rx and tx pages free") Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_enti

[PATCH net-next 0/2] cxgb4: collect free Tx/Rx pages and page pointers

2018-07-24 Thread Rahul Lakkireddy
Patch 1 collects number of free PSTRUCT page pointers in context memory. Patch 2 moves the collection logic for Tx/Rx free pages to common code, since this information needs to be collected in vmcore device dump as well. Thanks, Rahul Rahul Lakkireddy (2): cxgb4: collect number of free

[PATCH net-next 1/2] cxgb4: collect number of free PSTRUCT page pointers

2018-07-24 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 3 +++ drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 15 +-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 ++- drivers/net/ethernet/chelsio/cxgb4

[PATCH net-next] cxgb4: collect ASIC LA dumps from ULP TX

2018-07-16 Thread Rahul Lakkireddy
From: Surendra Mobiya Signed-off-by: Surendra Mobiya Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 6 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c| 32 +-- drivers/net/ethernet/chelsio

[PATCH net-next 1/2] cxgb4: remove stats fetched from firmware

2018-07-09 Thread Rahul Lakkireddy
When running ethtool -S, some stats are requested from firmware. Since getting these stats via firmware mailbox is slow, some packets get dropped under heavy load while running ethtool -S. So, remove these stats from ethtool -S. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[PATCH net-next 2/2] cxgb4: expose stats fetched from firmware via debugfs

2018-07-09 Thread Rahul Lakkireddy
Expose stats obtained from firmware via debugfs. These stats can't be part of ethtool -S because the slow firmware mailbox can cause packet drops under heavy load. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c

[PATCH net-next 0/2] cxgb4: move stats fetched from firmware to debugfs

2018-07-09 Thread Rahul Lakkireddy
. Thanks, Rahul Rahul Lakkireddy (2): cxgb4: remove stats fetched from firmware cxgb4: expose stats fetched from firmware via debugfs drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 164 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 133 - 2 files

[PATCH net-next] vmcore: move get_vmcore_size out of __init

2018-05-21 Thread Rahul Lakkireddy
is often because vmcore_add_device_dump lacks a __init annotation or the annotation of get_vmcore_size.constprop.5 is wrong. Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes") Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- fs/proc/vmcore.c |

[PATCH net] cxgb4: fix offset in collecting TX rate limit info

2018-05-18 Thread Rahul Lakkireddy
Correct the indirect register offsets in collecting TX rate limit info in UP CIM logs. Also, T5 doesn't support these indirect register offsets, so remove them from collection logic. Fixes: be6e36d916b1 ("cxgb4: collect TX rate limit info in UP CIM logs") Signed-off-by: Rahul Lak

[PATCH net-next] cxgb4: collect SGE PF/VF queue map

2018-05-18 Thread Rahul Lakkireddy
For T6, collect info on queue mapping to corresponding PF/VF in SGE. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 17 drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c| 47 ++- drivers/net

[PATCH net-next] cxgb4: update LE-TCAM collection for T6

2018-05-16 Thread Rahul Lakkireddy
-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 3 ++ drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c| 40 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h

[PATCH net-next v8 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-02 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - No changes. v7: - No changes. v6: - No changes

[PATCH net-next v8 3/3] cxgb4: collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - No changes. v7

[PATCH net-next v8 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - Added missing linux/types.h header include. - Removed __vmcore_add_device_dump(). v7: - Removed "CHELSIO" vendor identifier in Elf Note name. Instead, writing "LINUX". - Moved vmcoredd_header to ne

[PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-02 Thread Rahul Lakkireddy
. Suggested by Eric Biederman . - Added new crashdd module that exports /proc/crashdd/ containing driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Up

[PATCH net-next v7 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-01 Thread Rahul Lakkireddy
/ containing driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to col

[PATCH net-next v7 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-01 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - No changes. v6: - No changes. v5: - No changes

[PATCH net-next v7 3/3] cxgb4: collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - Removed "CH

[PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - Removed "CHELSIO" vendor identifier in Elf Note name. Instead, writing "LINUX". - Moved vmcoredd_header to new file include/uapi/linux/vmcore.h - Reworked vmcoredd_header to include Elf Note as pa

[PATCH net-next v6 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-30 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - No changes. v5: - No changes. v4: - No changes

[PATCH net-next v6 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-30 Thread Rahul Lakkireddy
atch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/n

[PATCH net-next v6 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - Reworked device dump elf note name to contain vendor identifier. - Added vmcoredd_header that precedes actual dump in the Elf Note. - Device dump's name is moved inside vmcoredd_header. v5: - Remove

[PATCH net-next v6 3/3] cxgb4: collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - Added "CHELSIO&qu

[PATCH net-next v5 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-21 Thread Rahul Lakkireddy
in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + d

[PATCH net-next v5 3/3] cxgb4: collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - No changes. v4: - No

[PATCH net-next v5 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-21 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - No changes. v4: - No changes. v3: - Patch add

[PATCH net-next v5 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - Removed enabling CONFIG_PROC_VMCORE_DEVICE_DUMP by default and updated help message to indicate that the driver must be present in second kernel's initramfs to collect the underlying device snapshot.

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Friday, April 04/20/18, 2018 at 19:06:09 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman > > wrote: > >> Rahul Lakkireddy writes: > >> > >> > On Thursd

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > >> On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > >> > On Wednesday, April

Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 13:54:56 +0530, Greg KH wrote: > On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > > +config PROC_VMCORE_DEVICE_DUMP > > + bool "Device Hardware/Firmware Log Collection" > > + depends on PROC_VMCORE > >

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > > > Hi Rahul, > > > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: &g

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 19:58:01 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > >> Hi Rahul, > >> On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > >>

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > Hi Rahul, > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even months. It is > &

[PATCH net-next v4 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-17 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - No changes. v3: - Patch added in this ve

[PATCH net-next v4 3/3] cxgb4: collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - No changes. v3

[PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-17 Thread Rahul Lakkireddy
- Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/ne

[PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - Made __vmcore_add_device_dump() static. - Moved compile check to define vmcore_add_device_dump() to crash_dump.h to fix compilation when vmcore.c is not compiled in. - Convert ---help--- to help in Kconfig as indicat

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-02 Thread Rahul Lakkireddy
On Monday, April 04/02/18, 2018 at 14:41:43 +0530, Jiri Pirko wrote: > Fri, Mar 30, 2018 at 08:42:00PM CEST, ebied...@xmission.com wrote: > >Rahul Lakkireddy writes: > > > >> On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote: > >>>

[PATCH net-next v3 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-31 Thread Rahul Lakkireddy
e in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/che

[PATCH net-next v3 2/3] vmcore: append device dumps to vmcore as elf notes

2018-03-31 Thread Rahul Lakkireddy
igned address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Patch added in this version. - Exported dumps a

[PATCH net-next v3 1/3] vmcore: add API to collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
erman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Dropped sysfs crashdd module. - Added CONFIG_PROC_VMCORE_DEVICE_DUMP to allow configuring device dump support. - Moved logic related to adding dumps from crashdd to vmcore module. - Rename all crashdd* to vmcoredd*

[PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Replaced all crashdd

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-30 Thread Rahul Lakkireddy
On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote: > Sat, Mar 24, 2018 at 11:56:33AM CET, rahul.lakkire...@chelsio.com wrote: > >Add a new module crashdd that exports the /sys/kernel/crashdd/ > >directory in second kernel, containing collected hardware/firmware > >dumps. > > > >Th

Re: [PATCH net-next 0/9] devlink: Add support for region access

2018-03-30 Thread Rahul Lakkireddy
> > regions and register them. A device which exposes a region will allow > > access to it using devlink. > > Hi Alex > > Did you see the work Rahul Lakkireddy has been doing? > > https://patchwork.kernel.org/patch/10305935/ > > It seems like these are simil

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-27 Thread Rahul Lakkireddy
On Tuesday, March 03/27/18, 2018 at 18:47:34 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman > > wrote: > >> > >> Rahul Lakkireddy writes: > >> > >>

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-26 Thread Rahul Lakkireddy
On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman wrote: > > Rahul Lakkireddy writes: > > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even months. It is > > important to co

[PATCH net-next v2 2/2] cxgb4: collect hardware dump in second kernel

2018-03-24 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available under /sys/kernel/crashdd/cxgb4/ directory in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - No

  1   2   3   >