Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

ext Brian King wrote: > Ragner Magalhaes wrote: >> ext Brian King wrote: >> >>> + >>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data) >>> +{ >>> + struct ibmveth_adapter *adapter = dev->priv; >>> + >>

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

ext Brian King wrote: > + > +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data) > +{ > + struct ibmveth_adapter *adapter = dev->priv; > + Why do not to do if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum)) return 0; less two lines. > +