RE: [PATCH net-next] net: add a helper to avoid issues with HW TX timestamping and SO_TXTIME

2021-03-10 Thread Po Liu
Hi Can it just move skb->tstamp = ktime_set(0, 0); into skb_tstamp_tx(skb, &shhwtstamps); if it always need to clear for HW tstamp setting. > -Original Message- > From: Vladimir Oltean > Sent: 2021年3月10日 22:51 > To: Jakub Kicinski ; netdev@vger.kernel.org;

RE: [PATCH net 2/2] net: enetc: allow hardware timestamping on TX queues with tc-etf enabled

2021-03-09 Thread Po Liu
Ok to me. > -Original Message- > From: Vladimir Oltean > Sent: 2021年3月7日 21:24 > To: David S . Miller ; Jakub Kicinski ; > netdev@vger.kernel.org; Po Liu > Cc: Alexandru Marginean ; Claudiu Manoil > ; Michael Walle ; Vladimir > Oltean ; Vinicius Costa Gomes >

RE: [PATCH v3 net] enetc: Let the hardware auto-advance the taprio base-time of 0

2020-11-24 Thread Po Liu
It makes sense to me for this patch. Thanks! > -Original Message- > From: Vladimir Oltean > Sent: 2020年11月25日 6:03 > To: Jakub Kicinski ; netdev@vger.kernel.org; Po Liu > ; Claudiu Manoil > Cc: Vinicius Costa Gomes > Subject: [PATCH v3 net] enetc: Let the hard

RE: [PATCH net] enetc: Advance the taprio base time in the future

2020-11-23 Thread Po Liu
Hi Vladimir, > -Original Message- > From: Vladimir Oltean > Sent: 2020年11月24日 9:20 > To: Jakub Kicinski ; netdev@vger.kernel.org; Po Liu > ; Claudiu Manoil > Cc: Vinicius Costa Gomes > Subject: [PATCH net] enetc: Advance the taprio base time in the future > &

[v2,net-next] net:qos: police action offloading parameter 'burst' change to the original value

2020-06-29 Thread Po Liu
Since 'tcfp_burst' with TICK factor, driver side always need to recover it to the original value, this patch moves the generic calculation and recover to the 'burst' original value before offloading to device driver. Signed-off-by: Po Liu Acked-by: Vladimir Oltean --- dr

[v1,net-next] net:qos: police action offloading parameter 'burst' change to the original value

2020-06-28 Thread Po Liu
Since 'tcfp_burst' with TICK factor, driver side always need to recover it to the original value, this patch moves the generic calculation and recover to the 'burst' original value before offloading to device driver. Signed-off-by: Po Liu Signed-off-by: Vladimir Oltean

[v2,iproute2-next 2/2] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Po Liu
Current police action must set 'rate' and 'burst'. 'mtu' parameter set the max frame size and could be set alone without 'rate' and 'burst' in some situation. Offloading to hardware for example, 'mtu' could limit the flow max frame size.

[v2,iproute2-next 1/2] action police: change the print message quotes style

2020-06-28 Thread Po Liu
Change the double quotes to single quotes in fprintf message to make it more readable. Signed-off-by: Po Liu --- v1->v2 changes: - Patch new added tc/m_police.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tc/m_police.c b/tc/m_police.c index a5bc20c0..7eb47

RE: Re: [iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Po Liu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: 2020年6月29日 4:16 > To: Po Liu > Cc: dsah...@gmail.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; da...@davemloft.net; j...@mojatatu.com; > v...@buslov.dev; Claudiu Manoil ; Vladimir

[iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-27 Thread Po Liu
Current police action must set 'rate' and 'burst'. 'mtu' parameter set the max frame size and could be set alone without 'rate' and 'burst' in some situation. Offloading to hardware for example, 'mtu' could limit the flow max frame size.

RE: Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-26 Thread Po Liu
Hi Jamal, > -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月26日 21:28 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu &

RE:Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread Po Liu
> -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月24日 20:45 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu > Man

[v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-24 Thread Po Liu
From: Po Liu Flow metering entries in IEEE 802.1Qci is an optional function for a flow filtering module. Flow metering is two rates two buckets and three color marker to policing the frames. This patch only enable one rate one bucket and in color blind mode. Flow metering instance are as

[v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-24 Thread Po Liu
From: Po Liu Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some hardware own the capability to limit the frame size. If the frame size larger than the setting, the frame would be dropped. For the police action itself already accept the 'mtu

[v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-24 Thread Po Liu
From: Po Liu Base on the tc flower offload police action add max frame size by the parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci stream filter can implement the max frame size filtering. Add it to the current hardware tc flower stearm filter driver. Signed-off-

[v2,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread Po Liu
From: Po Liu Hardware device may include more than one police entry. Specifying the action's index make it possible for several tc filters to share the same police action when installing the filters. Propagate this index to device drivers through the flow offload intermediate representatio

RE: Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Po Liu
Hi Jamal, > -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月23日 20:18 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu &

RE: Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Po Liu
Hi Jamal, > -Original Message- > From: Jamal Hadi Salim > Sent: 2020年6月23日 18:09 > To: Po Liu ; da...@davemloft.net; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; ido...@idosch.org > Cc: j...@resnulli.us; vinicius.go...@intel.com; v...@buslov.dev; Claudiu &

RE:Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Po Liu
Hi Ido, Sorry, ignore previous email. > -Original Message- > From: Ido Schimmel > Sent: 2020年6月23日 15:10 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; j...@resnulli.us; vinicius.go...@intel.com; > v...@buslo

RE: [EXT] Re: [v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-23 Thread Po Liu
Hi Ido, > -Original Message- > From: Ido Schimmel > Sent: 2020年6月23日 15:10 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; j...@resnulli.us; vinicius.go...@intel.com; > v...@buslov.dev; Claudiu Manoil ; Vladimir

[v1,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-22 Thread Po Liu
From: Po Liu Flow metering entries in IEEE 802.1Qci is an optional function for a flow filtering module. Flow metering is two rates two buckets and three color marker to policing the frames. This patch only enable one rate one bucket and in color blind mode. Flow metering instance are as

[v1,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-22 Thread Po Liu
From: Po Liu Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some hardware own the capability to limit the frame size. If the frame size larger than the setting, the frame would be dropped. For the police action itself already accept the 'mtu

[v1,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-22 Thread Po Liu
From: Po Liu Hardware may own many entries for police flow. So that make one(or multi) flow to be policed by one hardware entry. This patch add the police action index provide to the driver side make it mapping the driver hardware entry index. Signed-off-by: Po Liu --- include/net

[v1,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-22 Thread Po Liu
From: Po Liu Base on the tc flower offload police action add max frame size by the parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci stream filter can implement the max frame size filtering. Add it to the current hardware tc flower stearm filter driver. Signed-off-

RE: Re: [RFC,net-next 8/9] net: qos: police action add index for tc flower offloading

2020-06-21 Thread Po Liu
Hi Ido, > -Original Message- > From: Ido Schimmel > Sent: 2020年6月21日 18:04 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; Claudiu Manoil > ; Vladimir Oltean ; > Alexandru Marginean ; Xia

[v2,net-next] net: qos offload add flow status with dropped count

2020-06-18 Thread Po Liu
From: Po Liu This patch adds a drop frames counter to tc flower offloading. Reporting h/w dropped frames is necessary for some actions. Some actions like police action and the coming introduced stream gate action would produce dropped frames which is necessary for user. Status update shows how

RE: [PATCH net-next v2] net/sched: fix a couple of splats in the error path of tcf_gate_init()

2020-05-30 Thread Po Liu
Hi David, > -Original Message- > From: Davide Caratti > Sent: 2020年5月30日 2:09 > To: netdev@vger.kernel.org; David S. Miller ; Po > Liu > Cc: Jamal Hadi Salim ; Ivan Vecera > > Subject: [PATCH net-next v2] net/sched: fix a couple of splats in the >

RE: [PATCH net-next] net/sched: fix a couple of splats in the error path of tfc_gate_init()

2020-05-28 Thread Po Liu
Hi Davide, > -Original Message- > From: Davide Caratti > Sent: 2020年5月29日 6:06 > To: Jamal Hadi Salim ; Po Liu ; > netdev@vger.kernel.org; David S. Miller > Cc: Ivan Vecera > Subject: [PATCH net-next] net/sched: fix a couple of splats in the > error path of tfc

RE: Re: [next-queue RFC 0/4] ethtool: Add support for frame preemption

2020-05-19 Thread Po Liu
Hi Vinicius, > -Original Message- > From: Vinicius Costa Gomes > Sent: 2020年5月19日 3:34 > To: Michal Kubecek ; netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; jeffrey.t.kirs...@intel.com; Vladimir > Oltean ; Po Liu ; m- > kariche...@ti.com; jose.ab...@s

[v5,iproute2-next 2/2] iproute2-next: add gate action man page

2020-05-08 Thread Po Liu
This patch is to add the man page for the tc gate action. Signed-off-by: Po Liu --- changes before v4: No changes. changes from v4: - Update the examples with input/output time and size routine support man/man8/tc-gate.8 | 123 + 1 file changed, 123

[v5,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-08 Thread Po Liu
here would be 2ns for this case. #tc filter add dev eth0 parent : protocol ip \ flower skip_hw ip_proto icmp dst_mac 10:00:80:00:00:00 \ action gate index 12 base-time 13570ns \ sched-entry CLOSE 2ns \ clockid CLOCK_TAI

RE: Re: [v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-07 Thread Po Liu
Hi Stephen, > -Original Message- > From: Po Liu > Sent: 2020年5月7日 10:53 > To: Stephen Hemminger > Cc: dsah...@gmail.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; > da...@davemloft.net; v...@buslov.dev; Claudiu Manoi

[net-next] net:enetc: bug fix for qos sfi operate space after freed

2020-05-07 Thread Po Liu
'Dan Carpenter' reported: This code frees "sfi" and then dereferences it on the next line: > kfree(sfi); > clear_bit(sfi->index, epsfp.psfp_sfi_bitmap); This "sfi->index" should be "index". Reported-by: Da

RE: Re: [v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-06 Thread Po Liu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: 2020年5月6日 23:22 > To: Po Liu > Cc: dsah...@gmail.com; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; > da...@davemloft.net; v...@buslov.dev; Claudiu Manoi

RE: [EXT] Re: [v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-06 Thread Po Liu
Hi Davide, > -Original Message- > From: Davide Caratti > Sent: 2020年5月6日 20:54 > To: Po Liu ; dsah...@gmail.com; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org > Cc: vinicius.go...@intel.com; step...@networkplumber.org; > da...@davemloft.net; v...@buslo

[v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-06 Thread Po Liu
lter add dev eth0 parent : protocol ip \ flower skip_hw ip_proto icmp dst_mac 10:00:80:00:00:00 \ action gate index 12 base-time 13570 \ sched-entry CLOSE 2 \ clockid CLOCK_TAI Signed-off-by: Po Liu --- These patches continue requ

[v4,iproute2-next 2/2] iproute2-next: add gate action man page

2020-05-06 Thread Po Liu
This patch is to add the man page for the tc gate action. Signed-off-by: Po Liu --- man/man8/tc-gate.8 | 123 + 1 file changed, 123 insertions(+) create mode 100644 man/man8/tc-gate.8 diff --git a/man/man8/tc-gate.8 b/man/man8/tc-gate.8 new file

RE: [PATCH net-next] enetc: Fix use after free in stream_filter_unref()

2020-05-05 Thread Po Liu
Hi Dan, > -Original Message- > From: Dan Carpenter > Sent: 2020年5月6日 4:47 > To: Claudiu Manoil ; Po Liu > Cc: David S. Miller ; netdev@vger.kernel.org; > kernel-janit...@vger.kernel.org > Subject: [PATCH net-next] enetc: Fix use after free in > stream_filter_u

RE: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

2020-05-05 Thread Po Liu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: 2020年5月5日 8:07 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; v...@buslov.dev; > Claudiu Manoil ; Vladimir Oltean &g

RE: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

2020-05-05 Thread Po Liu
Hi Stephen, David, > -Original Message- > From: Stephen Hemminger > Sent: 2020年5月5日 8:05 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; v...@buslov.dev; > Claudiu Manoil ; Vladimir

[v3,iproute2 1/2] iproute2:tc:action: add a gate control action

2020-05-02 Thread Po Liu
lter add dev eth0 parent : protocol ip \ flower skip_hw ip_proto icmp dst_mac 10:00:80:00:00:00 \ action gate index 12 base-time 13570 \ sched-entry CLOSE 2 \ clockid CLOCK_TAI Signed-off-by: Po Liu --- These patches continue requ

[v3,iproute2 2/2] iproute2: add gate action man page

2020-05-02 Thread Po Liu
This patch is to add the man page for the tc gate action. Signed-off-by: Po Liu --- man/man8/tc-gate.8 | 123 + 1 file changed, 123 insertions(+) create mode 100644 man/man8/tc-gate.8 diff --git a/man/man8/tc-gate.8 b/man/man8/tc-gate.8 new file

RE: Re: [v5,net-next 0/4] Introduce a flow gate control action and apply IEEE

2020-05-02 Thread Po Liu
Hi David, Stephen, > -Original Message- > From: David Miller > Sent: 2020年5月2日 7:09 > To: Po Liu > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; > vinicius.go...@intel.com; v...@buslov.dev; Claudiu Manoil > ; Vladimir Oltean ; > Alexandru

[v5,net-next 3/4] net: enetc: add hw tc hw offload features for PSPF capability

2020-04-30 Thread Po Liu
enable for any entry of per stream filtering and stream gate or stream identify but get how much capabilities for each feature. Signed-off-by: Po Liu --- drivers/net/ethernet/freescale/enetc/enetc.c | 23 + drivers/net/ethernet/freescale/enetc/enetc.h | 48 +++ .../net

[v5,net-next 1/4] net: qos: introduce a gate control flow action

2020-04-30 Thread Po Liu
v eth0 parent : protocol ip \ flower skip_hw ip_proto icmp dst_mac 10:00:80:00:00:00 \ action gate index 12 base-time 13570 \ sched-entry close 2 -1 -1 \ clockid CLOCK_TAI Signed-off-by: Po Liu --- include/net/tc_act/tc_gate.h

[v5,net-next 4/4] net: enetc: add tc flower psfp offload driver

2020-04-30 Thread Po Liu
te module. Keep the gate open for 200ms and limit the traffic volume to 8MB in this sched-entry. Then direct the frames to the ingress queue 1. Signed-off-by: Po Liu --- drivers/net/ethernet/freescale/enetc/enetc.c | 25 +- drivers/net/ethernet/freescale/enetc/enetc.h | 46 +- .../net

[v5,net-next 0/4] Introduce a flow gate control action and apply IEEE

2020-04-30 Thread Po Liu
nstance entry would refer the gate action parameters. Stream filter instance entry would refer the stream gate index and assign a stream handle value matches to the stream identify instance. Po Liu (4): net: qos: introduce a gate control flow action net: schedule: add action gate offloading ne

[v5,net-next 2/4] net: schedule: add action gate offloading

2020-04-30 Thread Po Liu
Add the gate action to the flow action entry. Add the gate parameters to the tc_setup_flow_action() queueing to the entries of flow_action_entry array provide to the driver. Signed-off-by: Po Liu --- include/net/flow_offload.h | 10 include/net/tc_act/tc_gate.h | 99

RE: Re: [v4,net-next 2/4] net: schedule: add action gate offloading

2020-04-30 Thread Po Liu
Hi Vlad, > -Original Message- > From: Vlad Buslov > Sent: 2020年4月30日 1:41 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; Claudiu Manoil > ; Vladimir Oltean ; > Alexandru Marginean ; >

RE: [EXT] Re: [v4,net-next 1/4] net: qos: introduce a gate control flow action

2020-04-29 Thread Po Liu
Hi Vlad, > -Original Message- > From: Vlad Buslov > Sent: 2020年4月30日 1:04 > To: Po Liu > Cc: da...@davemloft.net; linux-ker...@vger.kernel.org; > netdev@vger.kernel.org; vinicius.go...@intel.com; Claudiu Manoil > ; Vladimir Oltean ; > Alexandru Marginean ; >

RE: [PATCH] net: tsn: add an netlink interface between kernel and application layer

2019-01-04 Thread Po Liu
Hi Ilias, > -Original Message- > From: Ilias Apalodimas [mailto:ilias.apalodi...@linaro.org] > Sent: 2019年1月3日 19:39 > To: Po Liu > Cc: Vinicius Costa Gomes ; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; da...@davemloft.net; haus...@cisco.com; > nicola

RE: [PATCH] net: tsn: add an netlink interface between kernel and application layer

2019-01-03 Thread Po Liu
Hi Ilias, Br, Po Liu > -Original Message- > From: Ilias Apalodimas [mailto:ilias.apalodi...@linaro.org] > Sent: 2019年1月3日 17:16 > To: Vinicius Costa Gomes > Cc: Po Liu ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; da...@davemloft.net; haus...@cisco

RE: [PATCH] net: tsn: add an netlink interface between kernel and application layer

2019-01-02 Thread Po Liu
Hi Vinicius, Thanks! As comments below. Br, Po Liu > -Original Message- > From: Vinicius Costa Gomes [mailto:vinicius.go...@intel.com] > Sent: 2019年1月3日 3:02 > To: Po Liu ; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: da...@davemloft.net; haus...@cis

RE: [PATCH] net: tsn: add an netlink interface between kernel and application layer

2018-12-28 Thread PO LIU
not only the end station and also the switch. LS1028 is such a kind of device. And your advises are precious for us. Let's make out an easy and flexible interface for TSN. Br, Po Liu > -Original Message- > From: Vinicius Costa Gomes [mailto:vinicius.go...@intel.com] > Sen

[PATCH] net: tsn: add an netlink interface between kernel and application layer

2018-12-27 Thread PO LIU
patch not support the pure software only TSN protocols(like Qcc) but hardware related configuration. TSN Protocols supports by this patch: Qbv/Qci/Qbu/Credit-base Shaper(Qav). This patch verified on NXP ls1028ardb board. Will add more protocols in the future. Signed-off-by: Po Liu