> -Original Message-
> From: Larry Finger [mailto:larry.fin...@gmail.com] On Behalf Of Larry Finger
> Sent: Monday, April 19, 2021 9:23 AM
> To: Pkshih; Maciej S. Szmigiero
> Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org;
> linux-ker...@vger.k
> -Original Message-
> From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name]
> Sent: Sunday, April 18, 2021 2:08 AM
> To: Pkshih
> Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org;
> linux-ker...@vger.kernel.org;
> johan...@sipsolutions.net; kv...@
> -Original Message-
> From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name]
> Sent: Thursday, April 08, 2021 4:53 AM
> To: Larry Finger; Pkshih
> Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org;
> linux-ker...@vger.kernel.org;
> johan...
On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote:
> On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote:
> > On 06.04.2021 12:00, Kalle Valo wrote:
> >> "Maciej S. Szmigiero" writes:
> >>
> >>> On 29.03.2021 00:54, Maciej S. Szmigiero wrote:
> Hi,
>
> It looks like rtlwifi/rtl8192cu A
On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote:
> Pkshih writes:
>
> >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
> >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c
> >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8
On Mon, 2021-02-22 at 20:57 +0800, Hao Chen wrote:
> Because I only have the `HONOR magic 14` laptop with rtl8822ce wifi chip
> :-(
>
> I will try to find out why the target platform can't properly resume with
> this declaration.Thanks.
>
> 在 2021/2/22 下午7:36, Pkshih
On Mon, 2021-02-22 at 12:29 +0200, Kalle Valo wrote:
> Hao Chen writes:
>
> > The laptop's wifi disconnect after the laptop HONOR MagicBook 14
> > sleep to S3/S4 and wake up.
> >
> > The dmesg of kernel report:
> > "[ 99.990168] pcieport :00:01.2: can't change power state from D3hot
> > to
On Mon, 2021-02-22 at 09:27 +0200, Kalle Valo wrote:
> 陈浩 writes:
>
> > By git blame command, I know that the assignment of .driver.pm =
> > RTW_PM_OPS
> >
> > was in commit 44bc17f7f5b3b("rtw88: support wowlan feature for
> > 8822c"),
> >
> > and another commit 7dc7c41607d19("avoid unused functi
On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
> WARNING: Comparison of 0/1 to bool variable.
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
> WARNING: Compari
On Fri, 2021-01-15 at 10:06 +, Jiapeng Zhong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
> WARNING: Comparison of 0/1 to bool variable.
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
> WARNING: Compari
On Tue, 2021-01-12 at 16:39 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/ps.c:803:7-21: WARNING:
> Comparison to bool
>
> Reported-by: Abaci Robot
> Signed-off-by: YANG LI
> ---
> drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
> 1 f
On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot
> Signed-off-by: YANG LI
>
I think your name of Signed-off-by
On Mon, 2021-01-11 at 09:22 +, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
> Comparison of 0/1 to bool variable
>
> Signed-off-by: YANG LI
> Reported-by: Abaci Robot---
> drivers/net/wireless/realtek/rtw88/debug.c
> -Original Message-
> From: Tian Tao [mailto:tiant...@hisilicon.com]
> Sent: Tuesday, December 22, 2020 8:29 PM
> To: tony0620e...@gmail.com; kv...@codeaurora.org; da...@davemloft.net;
> k...@kernel.org
> Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org
> Subject: [PATCH] rtw8
On Wed, 2020-12-16 at 13:04 +, Zheng Yongjun wrote:
> The parameter of kfree function is NULL, so kfree code is useless, delete it.
>
> Signed-off-by: Zheng Yongjun
Acked-by: Ping-Ke Shih
> ---
> drivers/net/wireless/realtek/rtw88/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --
On Thu, 2020-12-03 at 17:51 +, Colin King wrote:
> From: Colin Ian King
>
> Currently the variable 'interval' is not initialized and is only set
> to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing
> variable interval to 0 (which I'm assuming is the intended default).
>
> -Original Message-
> From: Lee Jones [mailto:lee.jo...@linaro.org]
> Sent: Friday, November 27, 2020 4:57 PM
> To: Pkshih
> Cc: Tony Chuang; kv...@codeaurora.org; linux-ker...@vger.kernel.org;
> linux-wirel...@vger.kernel.org;
> da...@davemloft.net; netd
On Fri, 2020-11-27 at 07:38 +, Lee Jones wrote:
> On Fri, 27 Nov 2020, Pkshih wrote:
>
> >
> > The subject prefix doesn't need 'realtek:'; use 'rtw88:'.
> >
> > On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote:
> > &
The subject prefix doesn't need 'realtek:'; use 'rtw88:'.
On Thu, 2020-11-26 at 13:31 +, Lee Jones wrote:
> Also strip out other duplicates from driver specific headers.
>
> Ensure 'main.h' is explicitly included in 'pci.h' since the latter
> uses some defines from the former. It avoids iss
On Wed, 2020-11-18 at 09:53 +0800, Jia-Ju Bai wrote:
> In rtl88ee_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on
> line 677:
> dma_addr_t mapping = dma_map_single(..., skb->data, ...);
>
> On line 680, skb->data is assigned to hdr after cast:
> struct ieee80211_hdr *hdr = (struct i
On Mon, 2020-10-19 at 11:09 +0800, Jia-Ju Bai wrote:
> In rtl92ce_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on
> line 530:
> dma_addr_t mapping = dma_map_single(..., skb->data, ...);
>
> On line 533, skb->data is assigned to hdr after cast:
> struct ieee80211_hdr *hdr = (struct i
On Tue, 2020-10-27 at 11:16 +0800, WeitaoWangoc wrote:
> During realtek USB wireless NIC initialization, it's unexpected
> disconnection will cause urb sumbmit fail. On the one hand,
> _rtl_usb_cleanup_rx will be called to clean up rx stuff, especially for
> rtl_wq. On the other hand, disconnection
On Tue, 2020-10-20 at 19:38 +0800, WeitaoWangoc wrote:
For rtlwifi driver, please use 'rtlwifi: ' as prefix of mail subject, like
"rtlwifi: Fix non-canonical address access issues"
> During realtek USB wireless NIC initialization, it's unexpected
> disconnection will cause urb sumbmit fail.On the
On Mon, 2020-10-26 at 22:29 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> There are thousands of warnings in a W=2 build from just one file:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/table.c:3788:15: warning:
> pointer targets in initialization of 'u8 *' {aka 'unsigned char *'}
On Mon, 2020-07-27 at 01:27 -0700, Joe Perches wrote:
> On Mon, 2020-07-27 at 06:07 +0000, Pkshih wrote:
> > On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote:
> > > Make these statements a little simpler.
> []
> > > diff --git a/drivers/net/wireless/realtek/rt
On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote:
> Make these statements a little simpler.
>
> Signed-off-by: Joe Perches
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 14 +--
> .../rtlwifi/btcoexist/halbtc8192e2ant.c | 23 ++-
> .../rtlwifi/btcoexist
On Mon, 2020-07-27 at 02:16 +, Xu Wang wrote:
> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memcpy().
>
> Signed-off-by: Xu Wang
> ---
> drivers/net/wireless/realtek/rtlwifi/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --gi
On Thu, 2020-07-23 at 17:32 +0100, Colin King wrote:
> From: Colin Ian King
>
> The variables ant_num and single_ant_path are being initialized with a
> value that is never read and are being updated later with a new value.
> The initializations are redundant and can be removed.
>
> Addresses-Co
On Mon, 2020-06-29 at 11:12 +0800, Pkshih wrote:
> On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote:
> > On 2020-06-28 19:09, Pkshih wrote:
> > > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
> > >
> > > Use 'rtlwifi:' as subject titl
On Sun, 2020-06-28 at 19:51 -0700, j...@perches.com wrote:
> On 2020-06-28 19:09, Pkshih wrote:
> > On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
> >
> > Use 'rtlwifi:' as subject title prefix is enough, likes
> > rtlwifi: Use const in swing_table
On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
Use 'rtlwifi:' as subject title prefix is enough, likes
rtlwifi: Use const in swing_table declarations
> Reduce data usage about 1KB by using const.
>
> Signed-off-by: Joe Perches
> ---
> .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c
On Thu, 2020-05-14 at 18:13 +, Colin King wrote:
> From: Colin Ian King
>
> Currently ldo_pwr has the LDO25 voltage bits set to zero and then
> it is overwritten with the new voltage setting. The assignment
> looks incorrect, it should be bit-wise or'ing in the new voltage
> setting rather th
On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
> +cc netdev@vger.kernel.org
>
> On 2019/1/29 13:57, YueHaibing wrote:
> > ping...
> >
> > On 2018/9/11 20:12, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/net/wireless/realtek/rtlwifi/base.c: In funct
On Fri, 2019-01-18 at 11:32 +0800, YueHaibing wrote:
> remove unneeded semicolon
>
> Signed-off-by: YueHaibing
> ---
> drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
> drivers/net/wireless/ath/ath6kl/init.c| 2 +-
> drivers/net/wireless/broadcom/brcm80211/b
On Thu, 2018-12-13 at 13:36 +0800, Kai Heng Feng wrote:
> > On Dec 13, 2018, at 08:35, Pkshih wrote:
> >
> > On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote:
> >> Once BSS STA mode gets started, it can be scanned by other clients but
> &g
On Wed, 2018-12-12 at 13:13 +0800, Kai-Heng Feng wrote:
> Once BSS STA mode gets started, it can be scanned by other clients but
> cannot entablish a connection.
^^^ typo: establish
>
> Turns out the set_bcn_reg() and its *_set_beacon_related_registers()
> callbacks never get called so it
On Wed, 2018-05-09 at 13:33 -0700, João Paulo Rechi Vita wrote:
> On Tue, May 8, 2018 at 1:37 AM, Pkshih wrote:
> > On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote:
> >> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote:
> >> > On Wed, 2018-05-0
On Mon, 2018-05-07 at 14:49 -0700, João Paulo Rechi Vita wrote:
> On Tue, May 1, 2018 at 10:58 PM, Pkshih wrote:
> > On Wed, 2018-05-02 at 05:44 +0000, Pkshih wrote:
> >>
> >> > -Original Message-
> >> > From: João Paulo Rechi Vita [mailto:jprv...
On Wed, 2018-05-02 at 05:44 +, Pkshih wrote:
>
> > -Original Message-
> > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com]
> > Sent: Wednesday, May 02, 2018 6:41 AM
> > To: Larry Finger
> > Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shao
> -Original Message-
> From: João Paulo Rechi Vita [mailto:jprv...@gmail.com]
> Sent: Wednesday, May 02, 2018 6:41 AM
> To: Larry Finger
> Cc: Steve deRosier; 莊彥宣; Pkshih; Birming Chiu; Shaofu; Steven Ting;
> Chaoming_Li; Kalle Valo;
> linux-wireless; Network Deve
On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote:
> Hi all,
>
> While doing some static analysis I came across the following piece of code at
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581:
>
> 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_
On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote:
> Use the new ether_broadcast_addr global instead to save some object code.
>
> Signed-off-by: Joe Perches
> ---
> drivers/net/wireless/admtek/adm8211.c | 3 +--
> drivers/net/wireless/ath/carl9170/mac.c | 4 +---
> drivers/
On Wed, 2018-02-07 at 12:51 -0800, Matthias Kaehlcke wrote:
> El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit:
>
> > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote:
> > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal
> > > is assigned to itself in an if ... el
From: Ping-Ke Shih
Since mac80211 maintains the sequence number for each STA/TID,
driver doesn't need to maintain a copy.
Signed-off-by: Ping-Ke Shih
---
drivers/net/wireless/realtek/rtlwifi/base.c | 6 ++
drivers/net/wireless/realtek/rtlwifi/pci.c | 17 -
drivers/net/wir
44 matches
Mail list logo
