Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-08 Thread Piotr Sawicki
On 1/8/19 12:14 PM, Eric Dumazet wrote: > On Tue, Jan 8, 2019 at 3:08 AM Piotr Sawicki > wrote: > >> Yes I know. It looks like the Smack's security rule was changed during this >> process. >> >> Firstly the packet was allowed to be received and it was put

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-08 Thread Piotr Sawicki
On 1/8/19 11:48 AM, Eric Dumazet wrote: > On Tue, Jan 8, 2019 at 2:36 AM Piotr Sawicki > wrote: >> >> On 1/8/19 11:06 AM, Eric Dumazet wrote: >>> On Tue, Jan 8, 2019 at 1:47 AM Piotr Sawicki >>> wrote: >>>> On 1/8/19 10:21 AM, Eric Dumazet wr

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-08 Thread Piotr Sawicki
On 1/8/19 11:06 AM, Eric Dumazet wrote: > On Tue, Jan 8, 2019 at 1:47 AM Piotr Sawicki > wrote: >> >> On 1/8/19 10:21 AM, Eric Dumazet wrote: >>> On Tue, Jan 8, 2019 at 12:57 AM Piotr Sawicki >>> wrote: >>>> dccp_v6_rcv() calls _

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-08 Thread Piotr Sawicki
On 1/8/19 10:21 AM, Eric Dumazet wrote: > On Tue, Jan 8, 2019 at 12:57 AM Piotr Sawicki > wrote: >> dccp_v6_rcv() calls __sk_receive_skb() which calls sk_filter_trim_cap(). >> >> sk_filter_trim_cap() should return a value not equal to 0 and cause the skb >> to

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-08 Thread Piotr Sawicki
instead of infering it. > > Fixes: d66a8acbda92 ("Smack: Inform peer that IPv6 traffic has been blocked") > Signed-off-by: Eric Dumazet > Cc: Piotr Sawicki > Cc: Casey Schaufler > Reported-by: syzbot > --- > net/ipv6/icmp.c |