Re: [PATCH] NET:AX25:ROSE NULL ax25_cb kernel panic

2019-01-24 Thread Bernard Pidoux
kb->data[1] << 0) & 0x0FF); if (frametype == ROSE_CALL_REQUEST && Reported-by:syzbot+1a2c456a1ea08fa5b...@syzkaller.appspotmail.com Signed-off-by: Bernard Pidoux, f6bvp

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Bernard Pidoux F6BVP
ROSE driver nor application. I will try your new patch version 2 and report any possible change. Regards, Bernard Pidoux, F6BVP Jarek Poplawski wrote: On Sat, Feb 09, 2008 at 07:44:50PM +0100, Bernard Pidoux F6BVP wrote: Hi, With AX25 patches applied I still get this possible circular

[PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Bernard Pidoux F6BVP
Hi, With AX25 patches applied I still get this possible circular locking message. Regards, Bernard P. === [ INFO: possible circular locking dependency detected ] 2.6.24 #3 --- swapper/

[PATCH 1/4] [ROSE] simplified rose_get_route()

2008-01-15 Thread Bernard Pidoux
Hi, This patch is send to replace preceding commit : From fd66cc115e058b2fc63a0e26aa73f1d27113105a Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:10:44 +0100 Subject: [PATCH 1/4] [ROSE] new rose_get_route() function I removed unnecessary li

Re: [PATCH 2/4] [ROSE] rose_get_route() template

2008-01-15 Thread Bernard Pidoux
to reexamine my code. Regards, Bernard P. Bernard Pidoux wrote: Eric Dumazet wrote: Bernard Pidoux a écrit : From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:01:46 +0100 Subject: [PATCH

Re: [PATCH 2/4] [ROSE] rose_get_route() template

2008-01-12 Thread Bernard Pidoux
Eric Dumazet wrote: Bernard Pidoux a écrit : From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:01:46 +0100 Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route() Signed-off-by: B

[PATCH 4/4] [ROSE] ENETUNREACH held rose_connect()

2008-01-12 Thread Bernard Pidoux
From 5c50971c6088f380eafdb1a6a7de5a5d3686c8c7 Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Sat, 12 Jan 2008 20:19:34 +0100 Subject: [PATCH 4/4] [ROSE] ENETUNREACH held rose_connect() Initial connection to rose neighbour nodes was unusually, t0 timer was block

[PATCH 3/4] [ROSE] return with lock held

2008-01-12 Thread Bernard Pidoux
From bc108e5ee0b0353c3707df25e12e40038da0160a Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Fri, 11 Jan 2008 10:23:55 +0100 Subject: [PATCH 3/4] [ROSE] return with lock held Signed-off-by: Bernard Pidoux <[EMAIL

[PATCH 2/4] [ROSE] rose_get_route() template

2008-01-12 Thread Bernard Pidoux
From 46bccce1e660a39bcc8f8cf87d4c17de33f4ba48 Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:01:46 +0100 Subject: [PATCH 2/4] [ROSE] template declaration for rose_get_route() Signed-off-by: Bernard Pidoux <[EMAIL PROTECTED]> --- includ

Re: [PATCH] [ROSE] finding a connected ROSE neighbor node

2008-01-12 Thread Bernard Pidoux
2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:10:44 +0100 Subject: [PATCH 1/4] [ROSE] new rose_get_route() function rose_get_neigh() was called by two different functions. Firstly, by rose_connect() in order to establish connections to adjacent rose nodes. This

Re: [PATCH][ROSE][AX25] af_ax25: possible circular locking

2008-01-12 Thread Bernard Pidoux F6BVP
pful and probably safe for after killing kissattach we don't want to use attached ax25 devices. Regards, Bernard Pidoux -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [ROSE] two extra tab characters removed

2008-01-11 Thread Bernard Pidoux F6BVP
Signed-off-by: Bernard Pidoux <[EMAIL PROTECTED]> --- include/net/rose.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/rose.h b/include/net/rose.h index d3ab453..0cfdc0e 100644 --- a/include/net/rose.h +++ b/include/net/rose.h @@ -86,7 +86,7 @@

Re: [ROSE] [AX25] possible circular locking

2007-12-28 Thread Pidoux
Jarek Poplawski wrote : On Mon, Dec 17, 2007 at 11:06:04AM +0100, Bernard Pidoux F6BVP wrote: Hi, When I killall kissattach I can see the following message. This happens on kernel 2.6.24-rc5 already patched with the 6 previously patches I sent recently

Re: [PATCH] sysctl: Fix ax25 checks

2007-12-17 Thread Bernard Pidoux
Eric, I applied your patch and now I have all /proc/sys/net/ax25 created and initialized as before. Thanks. Bernard Pidoux Eric W. Biederman wrote: Bernard Pidoux <[EMAIL PROTECTED]> writes: With 2.6.24-rc5 there is no /proc/net/ax25 /proc/sys/net/ax25? Here is an extract from

[BUG] [ROSE] [AX25] system impossible to reboot with linux-2.6.24-rc5

2007-12-17 Thread Bernard Pidoux F6BVP
/0xa7 do_exit+0x205/0x674 error_code+0x6a/0x70 sys_exit_group+0x0/0xd sysenter_past_esp+0x5f/0x9a == Bernard Pidoux -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[ROSE] [AX25] possible circular locking

2007-12-17 Thread Bernard Pidoux F6BVP
ep+0x49/0x59 [] work_notifysig+0x13/0x26 === Bernard Pidoux -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[BUG] lack of /proc/net/ax25 with 2.6.24-rc5

2007-12-16 Thread Bernard Pidoux
/ax25/ax0/connect_mode .3.9.1.4 Unknown sysctl binary path (...) === sysctl table check failed: /net/ax25/ax0/standard_window_size .3.9.1.5 Unknown sysctl binary path === (...) and so on ... Bernard Pidoux [EMAIL PROTECTED] -- To unsubscribe from

[PATCH] [ROSE] ax25_send_frame() called with a constant paclen = 260

2007-12-14 Thread Bernard Pidoux
size, which in turn induced significant results on the AX25 frame fragmentation and removed some garbage trailing characters in AX25 frames sent. signed off by Bernard Pidoux, [EMAIL PROTECTED] --- linux-2.6.24-rc5/net/rose/rose_link.c 2007-12-11 04:48:43.0 +0100 +++ b/net/rose

[PATCH] [ROSE] reverts commits d85838c55d836c33077344fab424f200f2827d84

2007-12-14 Thread Bernard Pidoux
Pidoux, [EMAIL PROTECTED] --- linux-2.6.24-rc5/net/rose/af_rose.c 2007-12-11 04:48:43.0 +0100 +++ b/net/rose/af_rose.c2007-12-14 14:09:40.0 +0100 @@ -782,7 +782,6 @@ rose_insert_socket(sk); /* Finish the bind */ } -rose_try_next_neigh

[PATCH] [ROSE] ROSE_PACLEN definition used a number constant value

2007-12-14 Thread Bernard Pidoux
Hi, ROSE_PACLEN was defined by a substraction using a fixed constant value of 256 in af_rose.c #define ROSE_PACLEN (256-ROSE_MIN_LEN) For more convenience 256 is replaced by AX25_DEF_PACLEN default size declared in ax25.h which is the actual AX25 MTU. signed off by Bernard Pidoux, [EMAIL

[PATCH] [ROSE] static const struct proto_ops in af_rose.c

2007-12-14 Thread Bernard Pidoux
This patch corrects the declaration of struct proto_ops as static const like in struct socket signed off by Bernard Pidoux, [EMAIL PROTECTED] --- linux-2.6.24-rc5/net/rose/af_rose.c 2007-12-11 04:48:43.0 +0100 +++ b/net/rose/af_rose.c2007-12-14 14:32:06.0 +0100 @@ -63,7

[PATCH] [ROSE] finding a connected ROSE neighbor node

2007-12-14 Thread Bernard Pidoux
not performed on the whole node list. A new function __rose_get_neigh() is introduced to cure a spin lock conflict related to rose_node_list_lock. signed off by Alexey Dobriyan,[EMAIL PROTECTED] signed off by Bernard Pidoux, f6bvp @ amsat.org --- linux-2.6.24-rc5/include/net/rose.h 2007-12-11 04

[PATCH] [AX25] circular locking with AX25 connection timeout

2007-12-14 Thread Bernard Pidoux
Hi, This patch cancels a circular locking conflict that appeared with a timeout of an AX25 connection. signed off by Jarek Poplawski --- linux-2.6.24-rc5/net/ax25/ax25_subr.c 2007-12-11 04:48:43.0 +0100 +++ b/net/ax25/ax25_subr.c 2007-12-14 14:30:02.0 +0100 @@ -279,

Re: Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

2007-12-04 Thread Bernard Pidoux
Jarek Poplawski wrote: Bernard Pidoux wrote, On 12/02/2007 06:37 PM: Hi, Many thanks for your patch for ~/net/ax25/ax25_subr.c Introduction of local_bh_disable() ... local_bh_enable() cured the inconsistent lock state related to AX25 connect timeout. I have now a stable monoprocessor

Re: Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

2007-12-02 Thread Bernard Pidoux
st regards, Bernard Pidoux F6BVP rose-patch-2.6.23.9.tgz Description: application/compressed-tar

Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

2007-11-21 Thread Bernard Pidoux
is the inconsistent lock state could be observed with ax25_call, flexd, fpac ax25 application programms. Please find attached a few reports captured from dmesg after each event. Could someone look at the listing and identify the origin of the problem ,if unique ? Thanks. Bernard Pidoux

Re: [PATCH 2/3] Eleminate HZ from NET/ROM kernel interfaces

2006-04-30 Thread Bernard Pidoux
Ralf Baechle wrote : Convert all NET/ROM sysctl time values from jiffies to ms as units. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> With such extensive patches for netrom and rose modules that will go into a future 2.6.x kernel, I think it would be justified to update the following ba

Re: [PATCH 3/3] Eleminate HZ from ROSE kernel interfaces

2006-04-30 Thread Bernard Pidoux
Ralf Baechle wrote : Index: linux-net.git/net/rose/af_rose.c === --- linux-net.git.orig/net/rose/af_rose.c 2006-04-29 01:54:21.0 +0100 +++ linux-net.git/net/rose/af_rose.c2006-04-29 11:37:34.0 +0100 Whi

Re: [ROSE] Fix routing table locking in rose_remove_neigh.

2006-04-29 Thread Bernard Pidoux
Ralf Baechle wrote: The locking rule for rose_remove_neigh() are that the called needs to hold rose_neigh_list_lock, so we better don't take it yet again in rose_neigh_list_lock. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> All ROSE and HZ patches applied to kernel 2.6.16 Many thanks Ralf

undefined symbol "has_bridge_parent"

2006-02-12 Thread Bernard Pidoux
Hi, I would like to report that when compiling 2.6.15.4 kernel there is an error with undefined symbol 'has_bridge_parent' in compilation of bridge/br_netfilter.c due to CONFIG_NETFILTER_DEBUG 1 option. Regards, Bernard Pidoux - To unsubscribe from this list: send the line "uns