Re: [PATCH] mt76: mt7915: fix misplaced #ifdef

2021-01-06 Thread Petr Štetiar
Arnd Bergmann [2021-01-03 14:57:55]: Hi, just a small nitpick, > From: Arnd Bergmann > > The lone '|' at the end of a line causes a build failure: > > drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error: expected > expression before '}' token > > Replace the #ifdef with an equival

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-28 Thread Petr Štetiar
Octavio Alvarez [2019-05-28 22:59:24]: Hi, > On 5/18/19 8:22 PM, Octavio Alvarez wrote: > > Hi, Petr, > > > > > I'm just shooting out of the blue, as I don't have currently any rational > > > explanation for that now, but could you please change the line above to > > > following: > > > > > >

Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

2019-05-18 Thread Petr Štetiar
Hi Octavio, > PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working I'm sorry, that I've ruined your day. > Linux version 5.1.0-12511-g72cf0b07418a (alvarezp@alvarezp-samsung) What do I need to do/apply in order to get the same source tree with 72cf0b07418a hash? I'm not able to find that commi

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-14 Thread Petr Štetiar
Srinivas Kandagatla [2019-05-14 16:13:22]: > On 13/05/2019 12:16, Petr Štetiar wrote: > > Srinivas Kandagatla [2019-05-13 11:06:48]: > > > > > On 13/05/2019 10:07, Petr Štetiar wrote: > > > > Srinivas Kandagatla [2019-05-13 > > > > 09:25:55

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-13 Thread Petr Štetiar
Srinivas Kandagatla [2019-05-13 11:06:48]: > On 13/05/2019 10:07, Petr Štetiar wrote: > > Srinivas Kandagatla [2019-05-13 09:25:55]: > > > > > My initial idea was to add compatible strings to the cell so that most of > > > the encoding information can be de

[PATCH] of_net: Fix missing of_find_device_by_node ref count drop

2019-05-13 Thread Petr Štetiar
of_find_device_by_node takes a reference to the embedded struct device which needs to be dropped after use. Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") Reported-by: kbuild test robot Reported-by: Julia Lawall Signed-off-by: Petr Štetiar --- drivers/of/of

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-13 Thread Petr Štetiar
Maxime Ripard [2019-05-12 14:19:10]: > > @@ -29,6 +31,19 @@ Optional properties: > > bits: Is pair of bit location and number of bits, which specifies offset > > in bit and number of bits within the address range specified by reg > > property. > > Offset takes values from 0-7.

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-13 Thread Petr Štetiar
Srinivas Kandagatla [2019-05-13 09:25:55]: Hi, > My initial idea was to add compatible strings to the cell so that most of > the encoding information can be derived from it. For example if the encoding > representing in your example is pretty standard or vendor specific we could > just do with a

Re: [EXT] Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for of_get_mac_addr()

2019-05-13 Thread Petr Štetiar
Andy Duan [2019-05-13 03:31:59]: > From: Andrew Lunn Sent: Saturday, May 11, 2019 2:18 AM > > On Fri, May 10, 2019 at 08:24:03AM +, Andy Duan wrote: > > > If MAC address read from nvmem cell and it is valid mac address, > > > .of_get_mac_addr_nvmem() add new property "nvmem-mac-address" in >

NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-11 Thread Petr Štetiar
Maxime Ripard [2019-05-10 13:31:55]: Hi, > > This reverse byte order format/layout is one of a few other storage formats > > currently used by vendors, some other (creative) vendors are currently > > providing MAC addresses in NVMEMs as ASCII text in following two formats > > (hexdump -C /dev/mt

Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order

2019-05-10 Thread Petr Štetiar
Andy Duan [2019-05-10 08:23:58]: Hi Andy, you've probably forget to Cc some maintainers and mailing lists, so I'm adding them now to the Cc loop. This patch series should be posted against net-next tree as per netdev FAQ[0], but you've to wait little bit as net-next is currently closed for the n

[PATCH net 1/5] of_net: remove nvmem-mac-address property

2019-05-10 Thread Petr Štetiar
driver unbinds, the buffer is freed, but DT code would be still referencing that memory. I'm removing this property completely instead of fixing it, as it's not needed to have it. Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") Suggested-by: Rob Herring S

[PATCH net 0/5] of_get_mac_address fixes

2019-05-10 Thread Petr Štetiar
thus kbuild test robot happy. Cheers, Petr Petr Štetiar (5): of_net: remove nvmem-mac-address property dt-bindings: doc: net: remove Linux API references powerpc: tsi108: fix similar warning reported by kbuild test robot net: ethernet: fix similar warning reported by kbuild test robot

[PATCH net-next v2 1/4] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-06 Thread Petr Štetiar
always valid and checked by is_valid_ether_addr anyway. Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") Signed-off-by: Petr Štetiar --- This is defacto v5 of the previous 05/10 patch in the series, but since the v4 of this 05/10 patch wasn't picked up by th

Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-06 Thread Petr Štetiar
Maxime Chevallier [2019-05-06 16:41:32]: Hi Maxime, > On Mon, 6 May 2019 10:32:07 +0200 > Petr Štetiar wrote: > > >David Miller [2019-05-05 21:47:27]: > > > >Hi David, > > > >> Series applied, thank you. > > > >I did probably som

[PATCH RESEND net-next 1/3] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-06 Thread Petr Štetiar
always valid and checked by is_valid_ether_addr anyway. Signed-off-by: Petr Štetiar --- This is defacto v5 of the previous 05/10 patch in the series, but since the v4 of this 05/10 patch wasn't picked up by the patchwork for some unknown reason, this patch wasn't applied with the other 9

Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-06 Thread Petr Štetiar
David Miller [2019-05-05 21:47:27]: Hi David, > Series applied, thank you. I did probably something terribly wrong, but patch "[PATCH v4 05/10] net: ethernet: support of_get_mac_address new ERR_PTR error" has not reached the patchwork, but I'm sure, that it was sent out as Hauke Mehrtens (maint

[PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-03 Thread Petr Štetiar
uot;; }; &wmac { nvmem-cells = <&wmac_addr>; nvmem-cell-names = "mac-address"; }; 1. https://patchwork.ozlabs.org/patch/1086628/ 2. https://patchwork.ozlabs.org/patch/890738/ -- ynezz Petr Štetiar (10): of_net: add NVMEM support to of_get_mac_address d

[PATCH v3 01/10] of_net: add NVMEM support to of_get_mac_address

2019-05-03 Thread Petr Štetiar
about 497 use cases in 357 device tree files. Cc: Alban Bedel Signed-off-by: Felix Fietkau Signed-off-by: John Crispin Signed-off-by: Petr Štetiar --- Changes since v1: * moved handling of nvmem after mac-address and local-mac-address properties Changes since v2: * moved

[PATCH v3 04/10] net: davinci: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added directly to of_get_mac_address, and it uses nvmem_get_mac_address under the hood, so we can remove it. As of_get_mac_address can now return NULL and ERR_PTR encoded error values, adjust to that as well. Signed-off-by: Petr Štetiar --- Changes since v2: * ERR_PTR

[PATCH v3 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-03 Thread Petr Štetiar
= <ð0_addr>; nvmem-cell-names = "mac-address"; }; ð1 { nvmem-cells = <ð1_addr>; nvmem-cell-names = "mac-address"; }; &wmac { nvmem-cells = <&wmac_addr>; nvmem-cell-names = "mac-address"; };

Reading MAC addresses with NVMEM under MTD partition [Was: Re: [PATCH v3 1/3] nvmem: Update the OF binding to use a subnode for the cells list]

2019-04-18 Thread Petr Štetiar
Hi, I'm wondering what is the status of this patch? I'm currently trying to do following with modified of_get_mac_address[1] which uses nvmem_get_mac_address under the hood: flash@0 { partitions { compatible = "fixed-partitions"; art: partition@fe {

[PATCH] of_net: Fix residues after of_get_nvmem_mac_address removal

2019-04-17 Thread Petr Štetiar
kill of_get_nvmem_mac_address()") Signed-off-by: Petr Štetiar --- Documentation/devicetree/bindings/net/davinci_emac.txt | 2 ++ Documentation/devicetree/bindings/net/ethernet.txt | 2 -- Documentation/devicetree/bindings/net/macb.txt | 4 drivers/of/of_net.c

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 10:06:14]: > NVMEM is supported by of_net already Well, not anymore: commit afa64a72b862a7a9d04f8d07fba632eaf06b23f8 Author: Bartosz Golaszewski Date: Fri Nov 30 09:20:59 2018 +0100 of: net: kill of_get_nvmem_mac_address() Now, I'm really confused. Documen

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 12:15:57]: > https://elixir.bootlin.com/linux/latest/source/net/ethernet/eth.c#L564 Thanks, so if I parse those 2 use cases of nvmem_get_mac_address correctly: drivers/net/ethernet/cadence/macb_main.c: err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr); dri

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-17 Thread Petr Štetiar
Maxime Ripard [2019-04-17 10:06:14]: Hi Maxime, > On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote: > > From: John Crispin > > > > Many embedded devices have information such as MAC addresses stored > > inside MTD devices. This patch allows us to a

[PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Petr Štetiar
device tree files * mtd-mac-address-increment-byte used 1 time in 1 device tree file Signed-off-by: John Crispin Signed-off-by: Felix Fietkau [cleanup of the patch for upstream submission] Signed-off-by: Petr Štetiar --- Documentation/devicetree/bindings/net/ethernet.txt | 5 ++ drivers/of

[PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Petr Štetiar
bmAttributes 0xa0 (Bus Powered) Remote Wakeup MaxPower 500mA Signed-off-by: Petr Štetiar --- Changes since v1: * make quectel_ec20_detected return bool (Bjørn) drivers/net/usb/qmi_wwan.c | 21 + 1 file changed, 21