[iproute PATCH] utils.h: provide fallback CLOCK_TAI definition

2018-10-27 Thread Peter Korsgaard
q_{etf,taprio}.c uses CLOCK_TAI, which isn't exposed by glibc < 2.21 or uClibc, breaking the build. Provide a fallback definition like it is done for IPPROTO_MPLS and others. Signed-off-by: Peter Korsgaard --- include/utils.h | 4 1 file changed, 4 insertions(+) diff --git a

Re: [linux-sunxi] [PATCH 03/21] net-next: stmmac: add optional setup function

2017-02-16 Thread Peter Korsgaard
>>>>> "Corentin" == Corentin Labbe writes: > Instead of ading more ifthen login for adding a new mac_device_info s/login/logic/ -- Bye, Peter Korsgaard

Re: am335x: no multicast reception over VLAN

2016-03-30 Thread Peter Korsgaard
>>>>> "Mugunthan" == Mugunthan V N writes: Hi, > You had received these packets as tcpdump will enable promiscuous mode > so that you receive all the packets from the wire. FYI, you can use the -p option to tcpdump to not put the interface into promiscuous mode. -- Bye, Peter Korsgaard

Re: [PATCH 1/3] dm9601: enable EP3 interrupt

2016-03-10 Thread Peter Korsgaard
terrupt-interval */ > +dm_write_reg(dev, DM_USB_CTRL, USB_CTRL_EP3ACK); Why would we want to do that instead of the current setup that afaik only returns data when the link status changes? -- Bye, Peter Korsgaard

Re: [PATCH 2/3] dm9601: manage eeprom to assure the chip for correct operation

2016-03-10 Thread Peter Korsgaard
. How common are these adapters without valid eeprom? What happens if the eeprom content isn't fixed? Do we need to reset the device once the eeprom is updated? -- Bye, Peter Korsgaard

Re: [PATCH 1/1] dm9601: enable EP3 interrupt and enhance eeprom functions

2016-03-09 Thread Peter Korsgaard
t_eeprom which tested good with ethtool > utility. Thanks for the patch. This sounds like 3 seperate changes, could you please restructure it as 3 patches each doing one of the changes? -- Bye, Peter Korsgaard

Re: [PATCH] usbnet: New driver for QinHeng CH9200 devices

2015-09-21 Thread Peter Korsgaard
it seems to be based on sr9700.c (which in term is largely derrived from dm9601.c) ;) But that's fine. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: DSA: phy polling

2015-09-14 Thread Peter Korsgaard
ave conflated that with what Broadcom switches support. It's been some years, but I think the PPU was just to automatically configure the switch MACs to to match the phy autonegotiation results. I also don't see any summery register though. -- Bye, Peter Korsgaard -- To uns

Re: [PATCH] New device for DM9601 usb net driver

2008-02-17 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard <[EMAIL PROTECTED]> writes: >>>>> "Robert" == Robert Brockway <[EMAIL PROTECTED]> writes: Robert> Hi Peter. I've verified that the Hirose USB-100 (0x0a47, Robert> 0x9601) is a clone of the

Re: [PATCH] New device for DM9601 usb net driver

2008-02-10 Thread Peter Korsgaard
in production. Robert> Unified diff against 2.6.24 attached. Thanks! Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> Robert> Cheers, Robert> Rob Robert> -- Robert> "With sufficient thrust, pigs fly just fine..." Robert>-- RFC 1925 "The Twelve

Re: [PATCH] SMC911X: Fix using of dereferenced skb after netif_rx

2007-12-04 Thread Peter Korsgaard
aybe Wang> changed in netif_rx. But fortunately dev->stats isn't changed in Wang> netif_rx. Wang> So, I agree. Wang> Here is the new patch. Thanks. Wang> Signed-off-by: Wang Chen <[EMAIL PROTECTED]> Acked-by: Peter Korsgaard <[EMAIL PROTECTED]> -- Bye, Peter

Re: [PATCH] SMC911X: Fix using of dereferenced skb after netif_rx

2007-12-03 Thread Peter Korsgaard
es += len; Why not simply update the stats before calling netif_rx as the return value isn't checked anyway? -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] smc911x: Fix multicast handling

2007-11-22 Thread Peter Korsgaard
ff-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/smc911x.c | 17 - 1 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index dd18af0..b6c6c99 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c

[PATCH] smc911x: Fix unused variable warning.

2007-11-21 Thread Peter Korsgaard
The smc911x_local pointer in smc911x_rcv is only used in the SMC_USE_DMA case. Move it under the #ifdef so GCC doesn't generate a warning in the non-DMA case. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |2 +- 1 files changed, 1 insertions(+),

[PATCH] smc911x: Fix undefined CONFIG_ symbol warning

2007-11-21 Thread Peter Korsgaard
elif defined(CONFIG_*) should be used instead of elif CONFIG_* so GCC doesn't give warnings about undefined symbols when the config option is disabled. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- Sigh, forgot --signoff :/ drivers/net/smc911x.h |2 +- 1 files changed, 1

[PATCH] smc911x: Fix undefined CONFIG_ symbol warning

2007-11-21 Thread Peter Korsgaard
elif defined(CONFIG_*) should be used instead of elif CONFIG_* so GCC doesn't give warnings about undefined symbols when the config option is disabled. --- drivers/net/smc911x.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h

[PATCH] smc911x: Fix unused variable warning.

2007-11-21 Thread Peter Korsgaard
The smc911x_local pointer in smc911x_rcv is only used in the SMC_USE_DMA case. Move it under the #ifdef so GCC doesn't generate a warning in the non-DMA case. --- drivers/net/smc911x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc

[PATCH] dm9601: Consolidate common parts of dm_write_*_async

2007-11-19 Thread Peter Korsgaard
dm_write_async and dm_write_reg_async are almost identical. Move common functionality to dm_write_async_helper (saves ~256b). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c | 53 +++-- 1 files changed, 13 inse

[PATCH] dm9601: Fix printk

2007-11-19 Thread Peter Korsgaard
A printk in the error handling code of dm9601.c was missing a newline. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 2

[PATCH] DM9601: Support for ADMtek ADM8515 NIC

2007-10-30 Thread Peter Korsgaard
Add device ID for the ADMtek ADM8515 USB NIC to the DM9601 driver. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index a2de32f..2c68573 100644 --- a/drivers/net/usb/dm9601.c +++ b/drivers/net/usb/dm9601.c @@ -586,6 +

Re: [patch] dm9601: Fix receive MTU

2007-10-02 Thread Peter Korsgaard
e apply to 2.6.23" should go AFTER Jeff> the patch description and "---" separator. Sorry about that - And thanks! -- Bye, Peter Korsgaard - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch] dm9601: Fix receive MTU

2007-10-01 Thread Peter Korsgaard
Please apply to 2.6.23. --- dm9601 didn't take the ethernet header into account when calculating RX MTU, causing packets bigger than 1486 to fail. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c |2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-08-07 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard <[EMAIL PROTECTED]> writes: Hi, Peter> I'll give your driver a try and report back. Ok, the driver seems to be working (after fixing up the accessor routines for my hw setup) and performance is comparable to Dustin&#x

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-08-01 Thread Peter Korsgaard
p, so I need special access routines (enable the big endian mode, not byteswap on normal registar access and byteswap on fifo access). I'll give your driver a try and report back. -- Bye, Peter Korsgaard - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-07-29 Thread Peter Korsgaard
ended to Steve> replace it. Dustin McIntire (the author of the smc911x driver) has Steve> expressed his support for switching to this driver. What's the problem with Dustin's driver? It seems to work fine here with a lan9117. Why not just add lan921x support to the existing drive

Re: [PATCH] Cleanup usbnet_probe() return value handling

2007-07-02 Thread Peter Korsgaard
l problem in my dm9601 driver. usbnet_probe() handles a positive return value from the driver bind() function as success, but will later only setup the status handler if the return value was zero, leading to confusion. Patch adjusts this to accept positive values as success in both checks.

[PATCH] Cleanup usbnet_probe() return value handling

2007-07-02 Thread Peter Korsgaard
usbnet_probe() handles a positive return value from the driver bind() function as success, but will later only setup the status handler if the return value was zero, leading to confusion. Patch adjusts this to only accept 0 as success in both checks. Signed-off-by: Peter Korsgaard <[EM

[PATCH] dm9601: Return 0 from bind() on success

2007-06-30 Thread Peter Korsgaard
Fixup dm9601_bind() so it returns 0 on success rather than just a positive number, as otherwise usbnet doesn't init the status handler. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) I

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
the networking list unless no Greg> one minds that I never see any queries about it :) Ok, here's an updated patch: Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECT

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
hange: http://thread.gmane.org/gmane.linux.usb.devel/55377/focus=55382 -- Bye, Peter Korsgaard - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Peter Korsgaard
Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.22-rc6/MAINT

[PATCH] usbnet: Zero padding byte if there is tail room in skb

2007-06-26 Thread Peter Korsgaard
Usbnet adds a padding byte if a 0 byte USB packet would be sent. Zero padding byte if there is tail room in skb. Signed-of-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- drivers/net/usb/usbnet.c |9 ++--- 1 file changed, 6 inse

[PATCH] dm9601: HW header size shouldn't be included in packet length

2007-06-26 Thread Peter Korsgaard
The dm9601 driver was including the 2 byte hardware header in the packet length, causing the HW to send 2 extra bytes of garbage on tx. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

[PATCH] net/smc911x: Match up spin lock/unlock

2007-02-01 Thread Peter Korsgaard
smc911x_phy_configure's error handling unconditionally unlocks the spinlock even if it wasn't locked. Patch fixes it. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/smc911x.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: linux-t

[PATCH] Fix up smc911x after work_struct changes

2006-12-22 Thread Peter Korsgaard
Fix up the smc911x driver after the work_struct changes. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> diff -urpN linux-2.6.20-rc1/drivers/net/smc911x.c linux-2.6.20-rc1.new/drivers/net/smc911x.c --- linux-2.6.20-rc1/drivers/net/smc911x.c 2006-11-29 22:57:37.0 +0100 +++

Re: [PATCH] smc911x: Re-release spinlock on spurious interrupt

2006-07-20 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard <[EMAIL PROTECTED]> writes: Peter> Hi, Peter> The smc911x driver forgets to release the spinlock on spurious Peter> interrupts. This little patch fixes it. Crap - forgot to sign off :/ Signed-off-by: Peter Korsgaa

[PATCH] smc911x: Re-release spinlock on spurious interrupt

2006-07-20 Thread Peter Korsgaard
_EN_)) { + spin_unlock_irqrestore(&lp->lock, flags); return IRQ_NONE; } -- Bye, Peter Korsgaard - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html